143855 2015-04-16 16:23:26 -0700 Expose JavaScriptMarkupEnabled preference for WebKit1 2015-04-16 17:29:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sam sam oldest_to_newest 1086149 0 sam 2015-04-16 16:23:26 -0700 Expose JavaScriptMarkupEnabled preference for WebKit1 1086152 1 250974 sam 2015-04-16 16:25:46 -0700 Created attachment 250974 Patch 1086158 2 250974 mitz 2015-04-16 16:31:48 -0700 Comment on attachment 250974 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250974&action=review > Source/WebKit/mac/WebView/WebPreferences.mm:2498 > +- (BOOL)isJavaScriptMarkupEnabled The getter should just be javaScriptMarkupEnabled (see other recent examples in this class). > Source/WebKit/mac/WebView/WebPreferencesPrivate.h:442 > +@property (nonatomic, getter=isJavaScriptMarkupEnabled) BOOL javaScriptMarkupEnabled; So you don’t need a custom getter= here. 1086189 3 sam 2015-04-16 17:29:20 -0700 Committed r182928: <http://trac.webkit.org/changeset/182928> 250974 2015-04-16 16:25:46 -0700 2015-04-16 16:31:48 -0700 Patch bug-143855-20150416162447.patch text/plain 4859 sam SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MjkyMCkKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBACisyMDE1LTA0LTE2 ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRXhwb3NlIEphdmFTY3Jp cHRNYXJrdXBFbmFibGVkIHByZWZlcmVuY2UgZm9yIFdlYktpdDEKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzE5OTM5NDUwPgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTQzODU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBXZWJWaWV3L1dlYlByZWZlcmVuY2VLZXlzUHJpdmF0ZS5oOgorICAgICAgICBB ZGQgbmV3IGtleSwgV2ViS2l0SmF2YVNjcmlwdE1hcmt1cEVuYWJsZWRQcmVmZXJlbmNlS2V5CisK KyAgICAgICAgKiBXZWJWaWV3L1dlYlByZWZlcmVuY2VzLm1tOgorICAgICAgICAoK1tXZWJQcmVm ZXJlbmNlcyBpbml0aWFsaXplXSk6CisgICAgICAgIEluaXRpYWxpemUgV2ViS2l0SmF2YVNjcmlw dE1hcmt1cEVuYWJsZWRQcmVmZXJlbmNlS2V5IHRvIFlFUy4KKworICAgICAgICAoLVtXZWJQcmVm ZXJlbmNlcyBpc0phdmFTY3JpcHRNYXJrdXBFbmFibGVkXSk6CisgICAgICAgICgtW1dlYlByZWZl cmVuY2VzIHNldEphdmFTY3JpcHRNYXJrdXBFbmFibGVkOl0pOgorICAgICAgICBJbXBsZW1lbnQg Z2V0dGVyL3NldHRlci4KKworICAgICAgICAqIFdlYlZpZXcvV2ViUHJlZmVyZW5jZXNQcml2YXRl Lmg6CisgICAgICAgIEFkZCBuZXcgcHJvcGVydHksIGphdmFTY3JpcHRNYXJrdXBFbmFibGVkLgor CisgICAgICAgICogV2ViVmlldy9XZWJWaWV3Lm1tOgorICAgICAgICAoLVtXZWJWaWV3IF9wcmVm ZXJlbmNlc0NoYW5nZWQ6XSk6CisgICAgICAgIE1hcCB0aGUgbmV3IHByZWZlcmVuY2UgdG8gV2Vi Q29yZSdzIHNjcmlwdE1hcmt1cEVuYWJsZWQgc2V0dGluZy4KKwogMjAxNS0wNC0xNSAgQnJlbnQg RnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBbTWFjXSBEaXNhYmxlICJT YXZlIHRvIERvd25sb2FkcyIgb3B0aW9uIGZvciBsb2NhbCBmaWxlcwpJbmRleDogU291cmNlL1dl YktpdC9tYWMvV2ViVmlldy9XZWJQcmVmZXJlbmNlS2V5c1ByaXZhdGUuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlByZWZlcmVuY2VLZXlzUHJpdmF0ZS5oCShy ZXZpc2lvbiAxODI5MTgpCisrKyBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlByZWZlcmVu Y2VLZXlzUHJpdmF0ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC01MSw2ICs1MSw3IEBACiAjZGVmaW5l IFdlYktpdFNocmlua3NTdGFuZGFsb25lSW1hZ2VzVG9GaXRQcmVmZXJlbmNlS2V5IEAiV2ViS2l0 U2hyaW5rc1N0YW5kYWxvbmVJbWFnZXNUb0ZpdCIKICNkZWZpbmUgV2ViS2l0SmF2YUVuYWJsZWRQ cmVmZXJlbmNlS2V5IEAiV2ViS2l0SmF2YUVuYWJsZWQiCiAjZGVmaW5lIFdlYktpdEphdmFTY3Jp cHRFbmFibGVkUHJlZmVyZW5jZUtleSBAIldlYktpdEphdmFTY3JpcHRFbmFibGVkIgorI2RlZmlu ZSBXZWJLaXRKYXZhU2NyaXB0TWFya3VwRW5hYmxlZFByZWZlcmVuY2VLZXkgQCJXZWJLaXRKYXZh U2NyaXB0TWFya3VwRW5hYmxlZCIKICNkZWZpbmUgV2ViS2l0V2ViU2VjdXJpdHlFbmFibGVkUHJl ZmVyZW5jZUtleSBAIldlYktpdFdlYlNlY3VyaXR5RW5hYmxlZCIKICNkZWZpbmUgV2ViS2l0QWxs b3dVbml2ZXJzYWxBY2Nlc3NGcm9tRmlsZVVSTHNQcmVmZXJlbmNlS2V5IEAiV2ViS2l0QWxsb3dV bml2ZXJzYWxBY2Nlc3NGcm9tRmlsZVVSTHMiCiAjZGVmaW5lIFdlYktpdEFsbG93RmlsZUFjY2Vz c0Zyb21GaWxlVVJMc1ByZWZlcmVuY2VLZXkgQCJXZWJLaXRBbGxvd0ZpbGVBY2Nlc3NGcm9tRmls ZVVSTHMiCkluZGV4OiBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlByZWZlcmVuY2VzLm1t Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViUHJlZmVyZW5jZXMu bW0JKHJldmlzaW9uIDE4MjkxOCkKKysrIFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViUHJl ZmVyZW5jZXMubW0JKHdvcmtpbmcgY29weSkKQEAgLTQzMiw2ICs0MzIsNyBAQCArICh2b2lkKWlu aXRpYWxpemUKICAgICAgICAgW05TTnVtYmVyIG51bWJlcldpdGhCb29sOllFU10sICBXZWJLaXRK YXZhRW5hYmxlZFByZWZlcmVuY2VLZXksCiAjZW5kaWYKICAgICAgICAgW05TTnVtYmVyIG51bWJl cldpdGhCb29sOllFU10sICBXZWJLaXRKYXZhU2NyaXB0RW5hYmxlZFByZWZlcmVuY2VLZXksCisg ICAgICAgIFtOU051bWJlciBudW1iZXJXaXRoQm9vbDpZRVNdLCAgV2ViS2l0SmF2YVNjcmlwdE1h cmt1cEVuYWJsZWRQcmVmZXJlbmNlS2V5LAogICAgICAgICBbTlNOdW1iZXIgbnVtYmVyV2l0aEJv b2w6WUVTXSwgIFdlYktpdFdlYlNlY3VyaXR5RW5hYmxlZFByZWZlcmVuY2VLZXksCiAgICAgICAg IFtOU051bWJlciBudW1iZXJXaXRoQm9vbDpZRVNdLCAgV2ViS2l0QWxsb3dVbml2ZXJzYWxBY2Nl c3NGcm9tRmlsZVVSTHNQcmVmZXJlbmNlS2V5LAogICAgICAgICBbTlNOdW1iZXIgbnVtYmVyV2l0 aEJvb2w6WUVTXSwgIFdlYktpdEFsbG93RmlsZUFjY2Vzc0Zyb21GaWxlVVJMc1ByZWZlcmVuY2VL ZXksCkBAIC0yNDk0LDYgKzI0OTUsMTYgQEAgLSAoQk9PTClhbnRpYWxpYXNlZEZvbnREaWxhdGlv bkVuYWJsZWQKICAgICByZXR1cm4gW3NlbGYgX2Jvb2xWYWx1ZUZvcktleTpXZWJLaXRBbnRpYWxp YXNlZEZvbnREaWxhdGlvbkVuYWJsZWRLZXldOwogfQogCistIChCT09MKWlzSmF2YVNjcmlwdE1h cmt1cEVuYWJsZWQKK3sKKyAgICByZXR1cm4gW3NlbGYgX2Jvb2xWYWx1ZUZvcktleTpXZWJLaXRK YXZhU2NyaXB0TWFya3VwRW5hYmxlZFByZWZlcmVuY2VLZXldOworfQorCistICh2b2lkKXNldEph dmFTY3JpcHRNYXJrdXBFbmFibGVkOihCT09MKWZsYWcKK3sKKyAgICBbc2VsZiBfc2V0Qm9vbFZh bHVlOmZsYWcgZm9yS2V5OldlYktpdEphdmFTY3JpcHRNYXJrdXBFbmFibGVkUHJlZmVyZW5jZUtl eV07Cit9CisKIEBlbmQKIAogQGltcGxlbWVudGF0aW9uIFdlYlByZWZlcmVuY2VzIChXZWJJbnRl cm5hbCkKSW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViUHJlZmVyZW5jZXNQcml2 YXRlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJQcmVmZXJl bmNlc1ByaXZhdGUuaAkocmV2aXNpb24gMTgyOTE4KQorKysgU291cmNlL1dlYktpdC9tYWMvV2Vi Vmlldy9XZWJQcmVmZXJlbmNlc1ByaXZhdGUuaAkod29ya2luZyBjb3B5KQpAQCAtNDM5LDYgKzQz OSw4IEBAIEBpbnRlcmZhY2UgV2ViUHJlZmVyZW5jZXMgKFdlYlByaXZhdGUpCiAtICh2b2lkKXNl dEFudGlhbGlhc2VkRm9udERpbGF0aW9uRW5hYmxlZDooQk9PTClmbGFnOwogLSAoQk9PTClhbnRp YWxpYXNlZEZvbnREaWxhdGlvbkVuYWJsZWQ7CiAKK0Bwcm9wZXJ0eSAobm9uYXRvbWljLCBnZXR0 ZXI9aXNKYXZhU2NyaXB0TWFya3VwRW5hYmxlZCkgQk9PTCBqYXZhU2NyaXB0TWFya3VwRW5hYmxl ZDsKKwogI2lmIFRBUkdFVF9PU19JUEhPTkUgJiYgX19JUEhPTkVfT1NfVkVSU0lPTl9NSU5fUkVR VUlSRUQgPCA4MDAwMAogLSAodm9pZClfc2V0QWxsb3dDb21wb3NpdGluZ0xheWVyVmlzdWFsRGVn cmFkYXRpb246KEJPT0wpZmxhZzsKICNlbmRpZgpJbmRleDogU291cmNlL1dlYktpdC9tYWMvV2Vi Vmlldy9XZWJWaWV3Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcv V2ViVmlldy5tbQkocmV2aXNpb24gMTgyOTE4KQorKysgU291cmNlL1dlYktpdC9tYWMvV2ViVmll dy9XZWJWaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yMjE4LDYgKzIyMTgsNyBAQCAtICh2b2lk KV9wcmVmZXJlbmNlc0NoYW5nZWQ6KFdlYlByZWZlcmVuCiAgICAgc2V0dGluZ3Muc2V0TG9jYWxT dG9yYWdlRGF0YWJhc2VQYXRoKFtwcmVmZXJlbmNlcyBfbG9jYWxTdG9yYWdlRGF0YWJhc2VQYXRo XSk7CiAgICAgc2V0dGluZ3Muc2V0SmF2YUVuYWJsZWQoW3ByZWZlcmVuY2VzIGlzSmF2YUVuYWJs ZWRdKTsKICAgICBzZXR0aW5ncy5zZXRTY3JpcHRFbmFibGVkKFtwcmVmZXJlbmNlcyBpc0phdmFT Y3JpcHRFbmFibGVkXSk7CisgICAgc2V0dGluZ3Muc2V0U2NyaXB0TWFya3VwRW5hYmxlZChbcHJl ZmVyZW5jZXMgaXNKYXZhU2NyaXB0TWFya3VwRW5hYmxlZF0pOwogICAgIHNldHRpbmdzLnNldFdl YlNlY3VyaXR5RW5hYmxlZChbcHJlZmVyZW5jZXMgaXNXZWJTZWN1cml0eUVuYWJsZWRdKTsKICAg ICBzZXR0aW5ncy5zZXRBbGxvd1VuaXZlcnNhbEFjY2Vzc0Zyb21GaWxlVVJMcyhbcHJlZmVyZW5j ZXMgYWxsb3dVbml2ZXJzYWxBY2Nlc3NGcm9tRmlsZVVSTHNdKTsKICAgICBzZXR0aW5ncy5zZXRB bGxvd0ZpbGVBY2Nlc3NGcm9tRmlsZVVSTHMoW3ByZWZlcmVuY2VzIGFsbG93RmlsZUFjY2Vzc0Zy b21GaWxlVVJMc10pOwo=