143850 2015-04-16 15:40:15 -0700 Add assertions to make sure ActiveDOMObject::suspend() / resume() / stop() overrides don't fire events 2015-04-16 16:42:48 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez ap barraclough commit-queue kling oldest_to_newest 1086100 0 cdumez 2015-04-16 15:40:15 -0700 Add assertions to make sure ActiveDOMObject::suspend() / resume() / stop() overrides don't fire events as this is not allowed. This would cause arbitrary JS execution which would be very dangerous in these stages. 1086102 1 250957 cdumez 2015-04-16 15:43:03 -0700 Created attachment 250957 Patch 1086111 2 cdumez 2015-04-16 15:48:31 -0700 I verified locally these assertions are not hit by the current layout tests. 1086118 3 250957 ap 2015-04-16 15:53:02 -0700 Comment on attachment 250957 Patch Seems reasonable. 1086165 4 250957 commit-queue 2015-04-16 16:42:43 -0700 Comment on attachment 250957 Patch Clearing flags on attachment: 250957 Committed r182923: <http://trac.webkit.org/changeset/182923> 1086166 5 commit-queue 2015-04-16 16:42:48 -0700 All reviewed patches have been landed. Closing bug. 250957 2015-04-16 15:43:03 -0700 2015-04-16 16:42:43 -0700 Patch bug-143850-20150416154208.patch text/plain 5299 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyOTA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTQxZDdiYzJmNDVkMThh OTRiZjIyZTNkNGU4YjM3ZGEyZTBlMjM2Yy4uZTAwOGE1ZmU5YzZmZGY4NjIwYzU4ZDUwNGEwNGIz MmI5OTg0OGJhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMwIEBACiAyMDE1LTA0LTE2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgQWRkIGFzc2VydGlvbnMgdG8g bWFrZSBzdXJlIEFjdGl2ZURPTU9iamVjdDo6c3VzcGVuZCgpIC8gcmVzdW1lKCkgLyBzdG9wKCkg b3ZlcnJpZGVzIGRvbid0IGZpcmUgZXZlbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNDM4NTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGQgYXNzZXJ0aW9ucyB0byBtYWtlIHN1cmUgQWN0aXZlRE9N T2JqZWN0OjpzdXNwZW5kKCkgLyByZXN1bWUoKSAvIHN0b3AoKQorICAgICAgICBvdmVycmlkZXMg ZG9uJ3QgZmlyZSBldmVudHMgYXMgdGhpcyBpcyBub3QgYWxsb3dlZC4gVGhpcyB3b3VsZCBjYXVz ZQorICAgICAgICBhcmJpdHJhcnkgSlMgZXhlY3V0aW9uIHdoaWNoIHdvdWxkIGJlIHZlcnkgZGFu Z2Vyb3VzIGluIHRoZXNlIHN0YWdlcy4KKworICAgICAgICBGaXJpbmcgSlMgZXZlbnRzIGZyb20g dGhlc2UgZnVuY3Rpb25zIGlzIGEgY29tbW9uIHNvdXJjZSBvZiBjcmFzaGVzLgorCisgICAgICAg ICogTW9kdWxlcy93ZWJzb2NrZXRzL1dlYlNvY2tldC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpX ZWJTb2NrZXQ6OnN1c3BlbmQpOgorICAgICAgICAoV2ViQ29yZTo6V2ViU29ja2V0OjpyZXN1bWUp OgorICAgICAgICAqIGRvbS9TY3JpcHRFeGVjdXRpb25Db250ZXh0LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ6OnN1c3BlbmRBY3RpdmVET01PYmplY3RzKToK KyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ6OnJlc3VtZUFjdGl2ZURP TU9iamVjdHMpOgorICAgICAgICAoV2ViQ29yZTo6U2NyaXB0RXhlY3V0aW9uQ29udGV4dDo6c3Rv cEFjdGl2ZURPTU9iamVjdHMpOgorICAgICAgICAqIHhtbC9YTUxIdHRwUmVxdWVzdC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpYTUxIdHRwUmVxdWVzdDo6c3VzcGVuZCk6CisgICAgICAgIChXZWJD b3JlOjpYTUxIdHRwUmVxdWVzdDo6cmVzdW1lKToKKyAgICAgICAgKFdlYkNvcmU6OlhNTEh0dHBS ZXF1ZXN0OjpzdG9wKToKKworMjAxNS0wNC0xNiAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUu Y29tPgorCiAgICAgICAgIFJlZ3Jlc3Npb24ocjE4MjUxNyk6IFdlYlNvY2tldDo6c3VzcGVuZCgp IGNhdXNlcyBlcnJvciBldmVudCB0byBiZSBmaXJlZAogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzODA2CiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8y MDU1OTgxMj4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2Vic29ja2V0cy9X ZWJTb2NrZXQuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJzb2NrZXRzL1dlYlNvY2tl dC5jcHAKaW5kZXggOTRhMDNlZWVlMGZjZDQyNWVhYzc2YTA3YTUxZDcxNjc1ZmM0NDdjZC4uMDkw ZDk1NDEzMDU5MjJkNjY5YzIyYTRlMTA4YTU4MWUyNDNjNTdiZSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvTW9kdWxlcy93ZWJzb2NrZXRzL1dlYlNvY2tldC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvTW9kdWxlcy93ZWJzb2NrZXRzL1dlYlNvY2tldC5jcHAKQEAgLTQ2OCw4ICs0NjgsNiBA QCBib29sIFdlYlNvY2tldDo6Y2FuU3VzcGVuZEZvclBhZ2VDYWNoZSgpIGNvbnN0CiAKIHZvaWQg V2ViU29ja2V0OjpzdXNwZW5kKFJlYXNvbkZvclN1c3BlbnNpb24gcmVhc29uKQogewotICAgIE5v RXZlbnREaXNwYXRjaEFzc2VydGlvbiBhc3NlcnROb0V2ZW50RGlzcGF0Y2g7Ci0KICAgICBpZiAo bV9yZXN1bWVUaW1lci5pc0FjdGl2ZSgpKQogICAgICAgICBtX3Jlc3VtZVRpbWVyLnN0b3AoKTsK IApAQCAtNDg2LDggKzQ4NCw2IEBAIHZvaWQgV2ViU29ja2V0OjpzdXNwZW5kKFJlYXNvbkZvclN1 c3BlbnNpb24gcmVhc29uKQogCiB2b2lkIFdlYlNvY2tldDo6cmVzdW1lKCkKIHsKLSAgICBOb0V2 ZW50RGlzcGF0Y2hBc3NlcnRpb24gYXNzZXJ0Tm9FdmVudERpc3BhdGNoOwotCiAgICAgaWYgKG1f Y2hhbm5lbCkKICAgICAgICAgbV9jaGFubmVsLT5yZXN1bWUoKTsKICAgICBlbHNlIGlmICghbV9w ZW5kaW5nRXZlbnRzLmlzRW1wdHkoKSAmJiAhbV9yZXN1bWVUaW1lci5pc0FjdGl2ZSgpKSB7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vU2NyaXB0RXhlY3V0aW9uQ29udGV4dC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9kb20vU2NyaXB0RXhlY3V0aW9uQ29udGV4dC5jcHAKaW5kZXggNzM2 YjA0YWRkMjNlOGJmNDZjMzUyNTQwZGRmMjljYTg4ZTM0N2I2MS4uYzlkYmQ4YTkwOWEyMGM2OWI1 YjFjZDhjY2QxZmE4MDQwNzQ5ZDJlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1Nj cmlwdEV4ZWN1dGlvbkNvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TY3JpcHRF eGVjdXRpb25Db250ZXh0LmNwcApAQCAtMjI3LDYgKzIyNyw3IEBAIHZvaWQgU2NyaXB0RXhlY3V0 aW9uQ29udGV4dDo6c3VzcGVuZEFjdGl2ZURPTU9iamVjdHMoQWN0aXZlRE9NT2JqZWN0OjpSZWFz b25Gb3JTCiAgICAgLy8gZnVuY3Rpb25zIHNob3VsZCBub3QgYWRkIG5ldyBhY3RpdmUgRE9NIG9i amVjdHMsIG5vciBleGVjdXRlIGFyYml0cmFyeSBKYXZhU2NyaXB0LgogICAgIC8vIEFuIEFTU0VS VCBvciBSRUxFQVNFX0FTU0VSVCB3aWxsIGZpcmUgaWYgdGhpcyBoYXBwZW5zLCBidXQgaXQncyBp bXBvcnRhbnQgdG8gY29kZQogICAgIC8vIHN1c3BlbmQgZnVuY3Rpb25zIHNvIGl0IHdpbGwgbm90 IGhhcHBlbiEKKyAgICBOb0V2ZW50RGlzcGF0Y2hBc3NlcnRpb24gYXNzZXJ0Tm9FdmVudERpc3Bh dGNoOwogICAgIGZvciAoYXV0byogYWN0aXZlRE9NT2JqZWN0IDogbV9hY3RpdmVET01PYmplY3Rz KQogICAgICAgICBhY3RpdmVET01PYmplY3QtPnN1c3BlbmQod2h5KTsKIApAQCAtMjU2LDYgKzI1 Nyw3IEBAIHZvaWQgU2NyaXB0RXhlY3V0aW9uQ29udGV4dDo6cmVzdW1lQWN0aXZlRE9NT2JqZWN0 cyhBY3RpdmVET01PYmplY3Q6OlJlYXNvbkZvclN1CiAgICAgLy8gZnVuY3Rpb25zIHNob3VsZCBu b3QgYWRkIG5ldyBhY3RpdmUgRE9NIG9iamVjdHMsIG5vciBleGVjdXRlIGFyYml0cmFyeSBKYXZh U2NyaXB0LgogICAgIC8vIEFuIEFTU0VSVCBvciBSRUxFQVNFX0FTU0VSVCB3aWxsIGZpcmUgaWYg dGhpcyBoYXBwZW5zLCBidXQgaXQncyBpbXBvcnRhbnQgdG8gY29kZQogICAgIC8vIHJlc3VtZSBm dW5jdGlvbnMgc28gaXQgd2lsbCBub3QgaGFwcGVuIQorICAgIE5vRXZlbnREaXNwYXRjaEFzc2Vy dGlvbiBhc3NlcnROb0V2ZW50RGlzcGF0Y2g7CiAgICAgZm9yIChhdXRvKiBhY3RpdmVET01PYmpl Y3QgOiBtX2FjdGl2ZURPTU9iamVjdHMpCiAgICAgICAgIGFjdGl2ZURPTU9iamVjdC0+cmVzdW1l KCk7CiAKQEAgLTI4Myw2ICsyODUsNyBAQCB2b2lkIFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ6OnN0 b3BBY3RpdmVET01PYmplY3RzKCkKICAgICAvLyBzdG9wIGZ1bmN0aW9ucyBzaG91bGQgbm90IGFk ZCBuZXcgYWN0aXZlIERPTSBvYmplY3RzLCBub3IgZXhlY3V0ZSBhcmJpdHJhcnkgSmF2YVNjcmlw dC4KICAgICAvLyBBIFJFTEVBU0VfQVNTRVJUIHdpbGwgZmlyZSBpZiB0aGlzIGhhcHBlbnMsIGJ1 dCBpdCdzIGltcG9ydGFudCB0byBjb2RlIHN0b3AgZnVuY3Rpb25zCiAgICAgLy8gc28gaXQgd2ls bCBub3QgaGFwcGVuIQorICAgIE5vRXZlbnREaXNwYXRjaEFzc2VydGlvbiBhc3NlcnROb0V2ZW50 RGlzcGF0Y2g7CiAgICAgZm9yIChhdXRvKiBhY3RpdmVET01PYmplY3QgOiBwb3NzaWJsZUFjdGl2 ZURPTU9iamVjdHMpIHsKICAgICAgICAgLy8gQ2hlY2sgaWYgdGhpcyBvYmplY3Qgd2FzIGRlbGV0 ZWQgYWxyZWFkeS4gSWYgc28sIGp1c3Qgc2tpcCBpdC4KICAgICAgICAgLy8gQ2FsbGluZyBjb250 YWlucyBvbiBhIHBvc3NpYmx5LWFscmVhZHktZGVsZXRlZCBvYmplY3QgaXMgT0sgYmVjYXVzZSB3 ZSBndWFyYW50ZWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVz dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuY3BwCmluZGV4IGViMDUz YmMzNzRjN2RmMzFjYTc5ZDQ3ZjcwODA3OGNhYjQwNTY3OWYuLmJhNDUwY2VhNTUyZWUxNWUzMTg4 ZjZmODU1MTQxYjZiZTc2NWUzNDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxI dHRwUmVxdWVzdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmNw cApAQCAtMTI2NSw4ICsxMjY1LDYgQEAgY29uc3QgY2hhciogWE1MSHR0cFJlcXVlc3Q6OmFjdGl2 ZURPTU9iamVjdE5hbWUoKSBjb25zdAogCiB2b2lkIFhNTEh0dHBSZXF1ZXN0OjpzdXNwZW5kKFJl YXNvbkZvclN1c3BlbnNpb24gcmVhc29uKQogewotICAgIE5vRXZlbnREaXNwYXRjaEFzc2VydGlv biBhc3NlcnROb0V2ZW50RGlzcGF0Y2g7Ci0KICAgICBtX3Byb2dyZXNzRXZlbnRUaHJvdHRsZS5z dXNwZW5kKCk7CiAKICAgICBpZiAobV9yZXN1bWVUaW1lci5pc0FjdGl2ZSgpKSB7CkBAIC0xMjg3 LDggKzEyODUsNiBAQCB2b2lkIFhNTEh0dHBSZXF1ZXN0OjpzdXNwZW5kKFJlYXNvbkZvclN1c3Bl bnNpb24gcmVhc29uKQogCiB2b2lkIFhNTEh0dHBSZXF1ZXN0OjpyZXN1bWUoKQogewotICAgIE5v RXZlbnREaXNwYXRjaEFzc2VydGlvbiBhc3NlcnROb0V2ZW50RGlzcGF0Y2g7Ci0KICAgICBtX3By b2dyZXNzRXZlbnRUaHJvdHRsZS5yZXN1bWUoKTsKIAogICAgIC8vIFdlIGFyZSBub3QgYWxsb3dl ZCB0byBleGVjdXRlIGFyYml0cmFyeSBKUyBpbiByZXN1bWUoKSBzbyBkaXNwYXRjaApAQCAtMTMw Niw3ICsxMzAyLDYgQEAgdm9pZCBYTUxIdHRwUmVxdWVzdDo6cmVzdW1lVGltZXJGaXJlZCgpCiAK IHZvaWQgWE1MSHR0cFJlcXVlc3Q6OnN0b3AoKQogewotICAgIE5vRXZlbnREaXNwYXRjaEFzc2Vy dGlvbiBhc3NlcnROb0V2ZW50RGlzcGF0Y2g7CiAgICAgaW50ZXJuYWxBYm9ydCgpOwogfQogCg==