143845 2015-04-16 14:14:23 -0700 Web Inspector: Should include "Log Value" context menu item in Preview and Collapsed ObjectTree 2015-04-20 14:24:37 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1086065 0 joepeck 2015-04-16 14:14:23 -0700 * SUMMARY Should include "Log Value" context menu item in Preview and Collapsed ObjectTree. For instance, if I console.log("onclick", event) and I see an event I am interested in, I want to just be able to right click it and "Log Value" to get a $n reference to poke around the object. Currently "Log Value" only happens for the properties inside the expanded event. 1086066 1 webkit-bug-importer 2015-04-16 14:14:49 -0700 <rdar://problem/20576655> 1086154 2 250975 joepeck 2015-04-16 16:28:30 -0700 Created attachment 250975 [PATCH] Proposed Fix NOTE: The previews inside of ObjectTreePropertyTreeElement don't get originating information because the TreeElement already handles context menus. 1086163 3 250975 timothy 2015-04-16 16:34:23 -0700 Comment on attachment 250975 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=250975&action=review > Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.js:57 > + this._previewView.setOriginatingObjectInfo(this._object, providedPropertyPath ? propertyPath : null); Is providedPropertyPath just to avoid maybe passing a non-WebInspector.PropertyPath? The assert at the top should be enough. Why not this._propertyPath? 1086198 4 joepeck 2015-04-16 17:45:37 -0700 (In reply to comment #3) > Comment on attachment 250975 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=250975&action=review > > > Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.js:57 > > + this._previewView.setOriginatingObjectInfo(this._object, providedPropertyPath ? propertyPath : null); > > Is providedPropertyPath just to avoid maybe passing a > non-WebInspector.PropertyPath? The assert at the top should be enough. > > Why not this._propertyPath? If a property path was not provided, we provide a default root path of "this" and in that case I do not want to pass the property path along, because it won't be accurate. Only in the case where the ObjectTree was initialized with a property path will I pass it on. I could have written "var providedPropertyPath = !!propertyPath;" but chose the more explicit route. 1086202 5 250975 joepeck 2015-04-16 17:46:51 -0700 Comment on attachment 250975 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=250975&action=review > Source/WebInspectorUI/UserInterface/Views/ObjectPreviewView.js:254 > + > + contextMenu.appendSeparator(); I have a feeling this separator is not actually needed and can be removed. I'll test. 1086209 6 joepeck 2015-04-16 18:01:43 -0700 http://trac.webkit.org/changeset/182933 250975 2015-04-16 16:28:30 -0700 2015-04-20 14:24:37 -0700 [PATCH] Proposed Fix log-value-preview.patch text/plain 7022 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDc5Nzk2NjUuLjNmOTUyOTMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDM1IEBACiAyMDE1LTA0LTE2ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogU2hvdWxk IGluY2x1ZGUgIkxvZyBWYWx1ZSIgY29udGV4dCBtZW51IGl0ZW0gaW4gUHJldmlldyBhbmQgQ29s bGFwc2VkIE9iamVjdFRyZWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE0Mzg0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEdpdmUgcHJldmlld3MgdGhlIHNhbWUgIkxvZyBWYWx1ZSIgY29udGV4dCBtZW51 IHNvIHRoYXQgaWYgeW91IGp1c3QgbG9nCisgICAgICAgIGEgYnVuY2ggb2Ygb2JqZWN0cyB0byB0 aGUgY29uc29sZSB5b3UgY2FuIHF1aWNrbHkgdHVybiB0aGF0IGVudGlyZSBvYmplY3QKKyAgICAg ICAgaW50byBhICRuIHJlZmVyZW5jZSBpbiB0aGUgY29uc29sZSB0byBpbnRlcmFjdCB3aXRoLgor CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9PYmplY3RQcmV2aWV3Vmlldy5qczoKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5PYmplY3RQcmV2aWV3Vmlldy5wcm90b3R5cGUuc2V0T3JpZ2lu YXRpbmdPYmplY3RJbmZvKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5PYmplY3RQcmV2aWV3Vmll dy5wcm90b3R5cGUuX2NvbnRleHRNZW51SGFuZGxlcik6CisgICAgICAgIFByb3ZpZGUgQVBJIHRv IHJlZmVyIHRvIGEgUmVtb3RlT2JqZWN0IGFuZCBvcHRpb25hbCBQcm9wZXJ0eVBhdGgKKyAgICAg ICAgdGhhdCBjYW4gYmUgdXNlZCB0byBnaXZlIHRoZSBwcmV2aWV3IGEgIkxvZyBWYWx1ZSIgY29u dGV4dCBtZW51LgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9Db25zb2xlTWVzc2Fn ZVZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ29uc29sZU1lc3NhZ2VWaWV3LnByb3Rv dHlwZS5fYXBwZW5kRm9ybWF0dGVkQXJndW1lbnRzKToKKyAgICAgICAgSW5jbHVkZSB0aGUgUmVt b3RlT2JqZWN0IHdpdGhvdXQgYSBwYXRoIGZvciBhIHByZXZpZXcgY29udGV4dCBtZW51LgorCisg ICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9PYmplY3RUcmVlVmlldy5qczoKKyAgICAgICAg KFdlYkluc3BlY3Rvci5PYmplY3RUcmVlVmlldyk6CisgICAgICAgIEluY2x1ZGUgdGhlIFJlbW90 ZU9iamVjdCB3aXRoIGEgcGF0aCBpZiB3ZSBrbmV3IGl0IGZvciBhIHByZXZpZXcgY29udGV4dCBt ZW51LgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9PYmplY3RUcmVlQmFzZVRyZWVF bGVtZW50LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk9iamVjdFRyZWVCYXNlVHJlZUVsZW1l bnQucHJvdG90eXBlLmNyZWF0ZUdldHRlckVsZW1lbnQpOgorICAgICAgICBUaGUgY29udGV4dCBt ZW51IGNhbiBuZXZlciBiZSBlbXB0eSwgc2luY2Ugd2UgYWx3YXlzIGFkZGVkIGF0IGxlYXN0IG9u ZSBpdGVtIGFib3ZlLgorCisKKzIwMTUtMDQtMTYgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJv QGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiAiTG9nIFZhbHVlIiBvZiBhIHZh bHVlIGluc2lkZSBvZiBhbiBhcnJheSwgZG9lcyBub3QgbG9nIHRoZSBpbm5lcm1vc3QgdmFsdWUK ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0Mzc5Mwog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9D b25zb2xlTWVzc2FnZVZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9Db25zb2xlTWVzc2FnZVZpZXcuanMKaW5kZXggMDU3ZTFlMi4uMjAxNzkwNCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29uc29s ZU1lc3NhZ2VWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL0NvbnNvbGVNZXNzYWdlVmlldy5qcwpAQCAtMzkwLDYgKzM5MCwxMCBAQCBXZWJJbnNw ZWN0b3IuQ29uc29sZU1lc3NhZ2VWaWV3ID0gY2xhc3MgQ29uc29sZU1lc3NhZ2VWaWV3IGV4dGVu ZHMgV2ViSW5zcGVjdG9yLgogICAgICAgICAgICAgICAgIHZhciBwYXJhbWV0ZXIgPSBwYXJhbWV0 ZXJzWzBdOwogICAgICAgICAgICAgICAgIHZhciBwcmV2aWV3ID0gV2ViSW5zcGVjdG9yLkZvcm1h dHRlZFZhbHVlLmNyZWF0ZU9iamVjdFByZXZpZXdPckZvcm1hdHRlZFZhbHVlRm9yUmVtb3RlT2Jq ZWN0KHBhcmFtZXRlciwgV2ViSW5zcGVjdG9yLk9iamVjdFByZXZpZXdWaWV3Lk1vZGUuQnJpZWYp OwogICAgICAgICAgICAgICAgIHZhciBpc1ByZXZpZXdWaWV3ID0gcHJldmlldyBpbnN0YW5jZW9m IFdlYkluc3BlY3Rvci5PYmplY3RQcmV2aWV3VmlldzsKKworICAgICAgICAgICAgICAgIGlmIChp c1ByZXZpZXdWaWV3KQorICAgICAgICAgICAgICAgICAgICBwcmV2aWV3LnNldE9yaWdpbmF0aW5n T2JqZWN0SW5mbyhwYXJhbWV0ZXIsIG51bGwpOworCiAgICAgICAgICAgICAgICAgdmFyIHByZXZp ZXdFbGVtZW50ID0gaXNQcmV2aWV3VmlldyA/IHByZXZpZXcuZWxlbWVudCA6IHByZXZpZXc7CiAg ICAgICAgICAgICAgICAgcHJldmlld0NvbnRhaW5lci5hcHBlbmRDaGlsZChwcmV2aWV3RWxlbWVu dCk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL09iamVjdFByZXZpZXdWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvT2JqZWN0UHJldmlld1ZpZXcuanMKaW5kZXggZTgxMjI5ZC4uMjJlNTIxOSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT2Jq ZWN0UHJldmlld1ZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvT2JqZWN0UHJldmlld1ZpZXcuanMKQEAgLTkwLDYgKzkwLDE4IEBAIFdlYkluc3Bl Y3Rvci5PYmplY3RQcmV2aWV3VmlldyA9IGNsYXNzIE9iamVjdFByZXZpZXdWaWV3IGV4dGVuZHMg V2ViSW5zcGVjdG9yLk9iCiAgICAgICAgIHRoaXMuX3ByZXZpZXdFbGVtZW50LmhpZGRlbiA9IGZh bHNlOwogICAgIH0KIAorICAgIHNldE9yaWdpbmF0aW5nT2JqZWN0SW5mbyhyZW1vdGVPYmplY3Qs IHByb3BlcnR5UGF0aCkKKyAgICB7CisgICAgICAgIGNvbnNvbGUuYXNzZXJ0KCF0aGlzLl9yZW1v dGVPYmplY3QpOworICAgICAgICBjb25zb2xlLmFzc2VydChyZW1vdGVPYmplY3QgaW5zdGFuY2Vv ZiBXZWJJbnNwZWN0b3IuUmVtb3RlT2JqZWN0KTsKKyAgICAgICAgY29uc29sZS5hc3NlcnQoIXBy b3BlcnR5UGF0aCB8fCBwcm9wZXJ0eVBhdGggaW5zdGFuY2VvZiBXZWJJbnNwZWN0b3IuUHJvcGVy dHlQYXRoKTsKKworICAgICAgICB0aGlzLl9yZW1vdGVPYmplY3QgPSByZW1vdGVPYmplY3Q7Cisg ICAgICAgIHRoaXMuX3Byb3BlcnR5UGF0aCA9IHByb3BlcnR5UGF0aCB8fCBudWxsOworCisgICAg ICAgIHRoaXMuZWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJjb250ZXh0bWVudSIsIHRoaXMuX2Nv bnRleHRNZW51SGFuZGxlci5iaW5kKHRoaXMpKTsKKyAgICB9CisKICAgICAvLyBQcml2YXRlCiAK ICAgICBfaW5pdFRpdGxlRWxlbWVudCgpCkBAIC0yMjMsNiArMjM1LDI2IEBAIFdlYkluc3BlY3Rv ci5PYmplY3RQcmV2aWV3VmlldyA9IGNsYXNzIE9iamVjdFByZXZpZXdWaWV3IGV4dGVuZHMgV2Vi SW5zcGVjdG9yLk9iCiAgICAgICAgIGVsZW1lbnQuYXBwZW5kQ2hpbGQoV2ViSW5zcGVjdG9yLkZv cm1hdHRlZFZhbHVlLmNyZWF0ZUVsZW1lbnRGb3JPYmplY3RQcmV2aWV3KHByZXZpZXcpKTsKICAg ICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQorCisgICAgX2NvbnRleHRNZW51SGFuZGxlcihldmVu dCkKKyAgICB7CisgICAgICAgIHZhciBjb250ZXh0TWVudSA9IG5ldyBXZWJJbnNwZWN0b3IuQ29u dGV4dE1lbnUoZXZlbnQpOworCisgICAgICAgIGNvbnRleHRNZW51LmFwcGVuZEl0ZW0oV2ViSW5z cGVjdG9yLlVJU3RyaW5nKCJMb2cgVmFsdWUiKSwgZnVuY3Rpb24oKSB7CisgICAgICAgICAgICB2 YXIgcmVtb3RlT2JqZWN0ID0gdGhpcy5fcmVtb3RlT2JqZWN0OworICAgICAgICAgICAgdmFyIGlz SW1wb3NzaWJsZSA9ICF0aGlzLl9wcm9wZXJ0eVBhdGggfHwgdGhpcy5fcHJvcGVydHlQYXRoLmlz RnVsbFBhdGhJbXBvc3NpYmxlKCk7CisgICAgICAgICAgICB2YXIgdGV4dCA9IGlzSW1wb3NzaWJs ZSA/IFdlYkluc3BlY3Rvci5VSVN0cmluZygiU2VsZWN0ZWQgVmFsdWUiKSA6IHRoaXMuX3Byb3Bl cnR5UGF0aC5kaXNwbGF5UGF0aChXZWJJbnNwZWN0b3IuUHJvcGVydHlQYXRoLlR5cGUuVmFsdWUp OworCisgICAgICAgICAgICBpZiAoIWlzSW1wb3NzaWJsZSkKKyAgICAgICAgICAgICAgICBXZWJJ bnNwZWN0b3IucXVpY2tDb25zb2xlLnByb21wdC5wdXNoSGlzdG9yeUl0ZW0odGV4dCk7CisKKyAg ICAgICAgICAgIFdlYkluc3BlY3Rvci5jb25zb2xlTG9nVmlld0NvbnRyb2xsZXIuYXBwZW5kSW1t ZWRpYXRlRXhlY3V0aW9uV2l0aFJlc3VsdCh0ZXh0LCB0aGlzLl9yZW1vdGVPYmplY3QpOworICAg ICAgICB9LmJpbmQodGhpcykpOworCisgICAgICAgIGNvbnRleHRNZW51LmFwcGVuZFNlcGFyYXRv cigpOworCisgICAgICAgIGNvbnRleHRNZW51LnNob3coKTsgICAgICAgIAorICAgIH0KIH07CiAK IFdlYkluc3BlY3Rvci5PYmplY3RQcmV2aWV3Vmlldy5Nb2RlID0gewpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT2JqZWN0VHJlZUJhc2VUcmVl RWxlbWVudC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL09i amVjdFRyZWVCYXNlVHJlZUVsZW1lbnQuanMKaW5kZXggZjQ5NGFhYS4uOGFlMWI3NyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT2JqZWN0VHJl ZUJhc2VUcmVlRWxlbWVudC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9PYmplY3RUcmVlQmFzZVRyZWVFbGVtZW50LmpzCkBAIC0yMDQsOCArMjA0LDcg QEAgV2ViSW5zcGVjdG9yLk9iamVjdFRyZWVCYXNlVHJlZUVsZW1lbnQgPSBjbGFzcyBPYmplY3RU cmVlQmFzZVRyZWVFbGVtZW50IGV4dGVuZHMKIAogICAgICAgICB0aGlzLl9hcHBlbmRNZW51c0l0 ZW1zRm9yT2JqZWN0KGNvbnRleHRNZW51LCByZXNvbHZlZFZhbHVlKTsKIAotICAgICAgICBpZiAo IWNvbnRleHRNZW51LmlzRW1wdHkoKSkKLSAgICAgICAgICAgIGNvbnRleHRNZW51LnNob3coKTsK KyAgICAgICAgY29udGV4dE1lbnUuc2hvdygpOwogICAgIH0KIAogICAgIF9hcHBlbmRNZW51c0l0 ZW1zRm9yT2JqZWN0KGNvbnRleHRNZW51LCByZXNvbHZlZFZhbHVlKQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT2JqZWN0VHJlZVZpZXcuanMg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9PYmplY3RUcmVlVmll dy5qcwppbmRleCBjZGEyYmQ0Li5kMjZhNzZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9PYmplY3RUcmVlVmlldy5qcworKysgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9PYmplY3RUcmVlVmlldy5qcwpAQCAt MzIsNiArMzIsOCBAQCBXZWJJbnNwZWN0b3IuT2JqZWN0VHJlZVZpZXcgPSBjbGFzcyBPYmplY3RU cmVlVmlldyBleHRlbmRzIFdlYkluc3BlY3Rvci5PYmplY3QKICAgICAgICAgY29uc29sZS5hc3Nl cnQob2JqZWN0IGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLlJlbW90ZU9iamVjdCk7CiAgICAgICAg IGNvbnNvbGUuYXNzZXJ0KCFwcm9wZXJ0eVBhdGggfHwgcHJvcGVydHlQYXRoIGluc3RhbmNlb2Yg V2ViSW5zcGVjdG9yLlByb3BlcnR5UGF0aCk7CiAKKyAgICAgICAgdmFyIHByb3ZpZGVkUHJvcGVy dHlQYXRoID0gcHJvcGVydHlQYXRoIGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLlByb3BlcnR5UGF0 aDsKKwogICAgICAgICB0aGlzLl9vYmplY3QgPSBvYmplY3Q7CiAgICAgICAgIHRoaXMuX21vZGUg PSBtb2RlIHx8IFdlYkluc3BlY3Rvci5PYmplY3RUcmVlVmlldy5kZWZhdWx0TW9kZUZvck9iamVj dChvYmplY3QpOwogICAgICAgICB0aGlzLl9wcm9wZXJ0eVBhdGggPSBwcm9wZXJ0eVBhdGggfHwg bmV3IFdlYkluc3BlY3Rvci5Qcm9wZXJ0eVBhdGgodGhpcy5fb2JqZWN0LCAidGhpcyIpOwpAQCAt NTIsNiArNTQsNyBAQCBXZWJJbnNwZWN0b3IuT2JqZWN0VHJlZVZpZXcgPSBjbGFzcyBPYmplY3RU cmVlVmlldyBleHRlbmRzIFdlYkluc3BlY3Rvci5PYmplY3QKIAogICAgICAgICBpZiAodGhpcy5f b2JqZWN0LnByZXZpZXcpIHsKICAgICAgICAgICAgIHRoaXMuX3ByZXZpZXdWaWV3ID0gbmV3IFdl Ykluc3BlY3Rvci5PYmplY3RQcmV2aWV3Vmlldyh0aGlzLl9vYmplY3QucHJldmlldyk7CisgICAg ICAgICAgICB0aGlzLl9wcmV2aWV3Vmlldy5zZXRPcmlnaW5hdGluZ09iamVjdEluZm8odGhpcy5f b2JqZWN0LCBwcm92aWRlZFByb3BlcnR5UGF0aCA/IHByb3BlcnR5UGF0aCA6IG51bGwpOwogICAg ICAgICAgICAgdGhpcy5fcHJldmlld1ZpZXcuZWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJjbGlj ayIsIHRoaXMuX2hhbmRsZVByZXZpZXdPclRpdGxlRWxlbWVudENsaWNrLmJpbmQodGhpcykpOwog ICAgICAgICAgICAgdGhpcy5fZWxlbWVudC5hcHBlbmRDaGlsZCh0aGlzLl9wcmV2aWV3Vmlldy5l bGVtZW50KTsKIAo=