143837 2015-04-16 12:10:35 -0700 It is very hard to attach a debugger to WebProcess to debug tests 2015-04-16 15:56:12 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap cdumez commit-queue glenn ossy rniwa thorton oldest_to_newest 1086008 0 ap 2015-04-16 12:10:35 -0700 When attaching a debugger to WebContent, one would normally hit a 5-second IPC timeout that WebKitTestRunner has. To safely debug, tests need to be run with something like: run-webkit-tests --additional-drt-flag="--no-timeout-at-all" --time-out-ms=100000000 This is despite having a nice --no-timeout option in run-webkit-tests. This is because --no-timeout only affects waitUntilDone timeout, and not IPC timeout or run-webkit-tests timeout. There is a claim (in <http://trac.webkit.org/changeset/123464>) that --no-timeout-at-all and --no-timeout needs to be different because of performance tests, but I don't see any evidence supporting that. I want to make "run-webkit-tests --no-timeout" disable all timeouts, as best for debugging. 1086012 1 250937 ap 2015-04-16 12:21:51 -0700 Created attachment 250937 proposed fix 1086013 2 commit-queue 2015-04-16 12:24:55 -0700 Attachment 250937 did not pass style-queue: ERROR: Tools/Scripts/webkitpy/port/driver.py:190: at least two spaces before inline comment [pep8/E261] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1086069 3 250937 cdumez 2015-04-16 14:28:50 -0700 Comment on attachment 250937 proposed fix r=me 1086085 4 250937 ggaren 2015-04-16 15:11:28 -0700 Comment on attachment 250937 proposed fix Maybe we should add a --debugger option, which auto-attaches a debugger after launching the Web Process, and also enables --no-timeout? 90% of the time, I would use that every time. 1086090 5 cdumez 2015-04-16 15:18:11 -0700 (In reply to comment #4) > Comment on attachment 250937 [details] > proposed fix > > Maybe we should add a --debugger option, which auto-attaches a debugger > after launching the Web Process, and also enables --no-timeout? > > 90% of the time, I would use that every time. FYI, back when I was working on the EFL port I added a specific run-webkit-test parameter exactly for this purpose: --webprocess-cmd-prefix It is still in but the implementation probably needs to be adapted for Mac. On EFL port it is used like so: ./Tools/Scripts/run-webkit-tests --efl --webprocess-cmd-prefix="DISPLAY=:0 xterm -title WebProcess -e gdb --eval-command=run --args" LayoutTests/fast/forms/plaintext-mode-1.html 1086114 6 ap 2015-04-16 15:51:01 -0700 > Maybe we should add a --debugger option, which auto-attaches a debugger after launching the Web Process, and also enables --no-timeout? The --debugger option wouldn't know if I want to debug WebKitTestRunner, WebContent or Networking. And adding an option for each... I don't know, I just want to attach to the process in Xcode as it launches. 1086120 7 ap 2015-04-16 15:56:03 -0700 Committed r182916. 250937 2015-04-16 12:21:51 -0700 2015-04-16 15:56:12 -0700 proposed fix NoTimeout.txt text/plain 3337 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4Mjg5OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIxIEBACisyMDE1LTA0LTE2ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIEl0IGlzIHZlcnkgaGFyZCB0byBhdHRhY2ggYSBkZWJ1Z2dlciB0byBXZWJQ cm9jZXNzIHRvIGRlYnVnIHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDM4MzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAtLW5vLXRpbWVvdXQgdXNlZCB0byBvbmx5IGFmZmVjdCB3YWl0VW50aWxE b25lIHRpbWVvdXQsIGJ1dCBub3QgSVBDIHRpbWVvdXQgaW4KKyAgICAgICAgV2ViS2l0VGVzdFJ1 bm5lciwgYW5kIG5vdCBwaXBlIHJlYWRpbmcgdGltZW91dCBpbiBydW4td2Via2l0LXRlc3RzLgor CisgICAgICAgIE5vdyBpdCBkaXNhYmxlcyBhbGwgdGltZW91dHMgaW4gdG9vbHMsIGFzIGlzIGJl c3QgZm9yIGRlYnVnZ2luZyB0ZXN0cy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9y dC9kcml2ZXIucHk6IChEcml2ZXIucnVuX3Rlc3QpOiBSZXNwZWN0IC0tbm8tdGltZW91dCwgc28K KyAgICAgICAgdGhhdCB0aGUgc2NyaXB0IGRvZXNuJ3QgdGVybWluYXRlIERSVC9XS1RSIHdoZW4g dGhlcmUgaXMgbm8gb3V0cHV0IGZvciBhIGxvbmcgdGltZS4KKworICAgICAgICAqIFdlYktpdFRl c3RSdW5uZXIvT3B0aW9ucy5jcHA6IFJlbW92ZWQgLS1uby10aW1lb3V0LWF0LWFsbCwgYXMgLS1u by10aW1lb3V0CisgICAgICAgIG5vdyBoYXMgdGhlIHNhbWUgZnVuY3Rpb25hbGl0eS4KKwogMjAx NS0wNC0xNiAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAg IFtFRkxdIEJ1bXAgTExWTSB0byB2ZXJzaW9uIDMuNi4wIG9uIFg4Nl82NApJbmRleDogVG9vbHMv U2NyaXB0cy93ZWJraXRweS9wb3J0L2RyaXZlci5weQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3Jp cHRzL3dlYmtpdHB5L3BvcnQvZHJpdmVyLnB5CShyZXZpc2lvbiAxODI4NTEpCisrKyBUb29scy9T Y3JpcHRzL3dlYmtpdHB5L3BvcnQvZHJpdmVyLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xODYsNyAr MTg2LDEwIEBAIGNsYXNzIERyaXZlcihvYmplY3QpOgogICAgICAgICAjIGJ5IDUgc2Vjb25kcyB0 byBhdm9pZCByYWNpbmcgZm9yIHdoaWNoIHRpbWVvdXQgaXMgZGV0ZWN0ZWQgZmlyc3QuCiAgICAg ICAgICMgRklYTUU6IEl0J3Mgbm90IHRoZSBqb2Igb2YgdGhlIGRyaXZlciB0byBkZWNpZGUgd2hh dCB0aGUgdGltZW91dHMgc2hvdWxkIGJlLgogICAgICAgICAjIE1vdmUgdGhlIGFkZGl0aW9uYWwg dGltZW91dCB0byBkcml2ZXJfaW5wdXQuCi0gICAgICAgIGRlYWRsaW5lID0gdGVzdF9iZWdpbl90 aW1lICsgaW50KGRyaXZlcl9pbnB1dC50aW1lb3V0KSAvIDEwMDAuMCArIDUKKyAgICAgICAgaWYg c2VsZi5fbm9fdGltZW91dDoKKyAgICAgICAgICAgIGRlYWRsaW5lID0gdGVzdF9iZWdpbl90aW1l ICsgNjAgKiA2MCAqIDI0ICogNyAjIDcgZGF5cy4gVXNpbmcgc3lzLm1heGludCBjYXVzZXMgYSBo YW5nLgorICAgICAgICBlbHNlOgorICAgICAgICAgICAgZGVhZGxpbmUgPSB0ZXN0X2JlZ2luX3Rp bWUgKyBpbnQoZHJpdmVyX2lucHV0LnRpbWVvdXQpIC8gMTAwMC4wICsgNQogCiAgICAgICAgIHNl bGYuX3NlcnZlcl9wcm9jZXNzLndyaXRlKGNvbW1hbmQpCiAgICAgICAgIHRleHQsIGF1ZGlvID0g c2VsZi5fcmVhZF9maXJzdF9ibG9jayhkZWFkbGluZSkgICMgRmlyc3QgYmxvY2sgaXMgZWl0aGVy IHRleHQgb3IgYXVkaW8KSW5kZXg6IFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvT3B0aW9ucy5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9PcHRpb25zLmNwcAkocmV2aXNp b24gMTgyODUxKQorKysgVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9PcHRpb25zLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNDcsMTIgKzQ3LDYgQEAgT3B0aW9uczo6T3B0aW9ucygpCiBib29sIGhhbmRs ZU9wdGlvbk5vVGltZW91dChPcHRpb25zJiBvcHRpb25zLCBjb25zdCBjaGFyKiwgY29uc3QgY2hh ciopCiB7CiAgICAgb3B0aW9ucy51c2VXYWl0VG9EdW1wV2F0Y2hkb2dUaW1lciA9IGZhbHNlOwot ICAgIHJldHVybiB0cnVlOwotfQotCi1ib29sIGhhbmRsZU9wdGlvbk5vVGltZW91dEF0QWxsKE9w dGlvbnMmIG9wdGlvbnMsIGNvbnN0IGNoYXIqLCBjb25zdCBjaGFyKikKLXsKLSAgICBvcHRpb25z LnVzZVdhaXRUb0R1bXBXYXRjaGRvZ1RpbWVyID0gZmFsc2U7CiAgICAgb3B0aW9ucy5mb3JjZU5v VGltZW91dCA9IHRydWU7CiAgICAgcmV0dXJuIHRydWU7CiB9CkBAIC0xMTYsOCArMTEwLDcgQEAg Ym9vbCBoYW5kbGVPcHRpb25Vbm1hdGNoZWQoT3B0aW9ucyYgb3B0aQogT3B0aW9uc0hhbmRsZXI6 Ok9wdGlvbnNIYW5kbGVyKE9wdGlvbnMmIG8pCiAgICAgOiBvcHRpb25zKG8pCiB7Ci0gICAgb3B0 aW9uTGlzdC5hcHBlbmQoT3B0aW9uKCItLW5vLXRpbWVvdXQiLCAiRGlzYWJsZXMgd2FpdFVudGls RG9uZSB0aW1lb3V0LiIsIGhhbmRsZU9wdGlvbk5vVGltZW91dCkpOwotICAgIG9wdGlvbkxpc3Qu YXBwZW5kKE9wdGlvbigiLS1uby10aW1lb3V0LWF0LWFsbCIsICJEaXNhYmxlcyBhbGwgdGltZW91 dHMuIiwgaGFuZGxlT3B0aW9uTm9UaW1lb3V0QXRBbGwpKTsKKyAgICBvcHRpb25MaXN0LmFwcGVu ZChPcHRpb24oIi0tbm8tdGltZW91dCIsICJEaXNhYmxlcyBhbGwgdGltZW91dHMuIiwgaGFuZGxl T3B0aW9uTm9UaW1lb3V0KSk7CiAgICAgb3B0aW9uTGlzdC5hcHBlbmQoT3B0aW9uKCItLXZlcmJv c2UiLCAiVHVybnMgb24gbWVzc2FnZXMuIiwgaGFuZGxlT3B0aW9uVmVyYm9zZSkpOwogICAgIG9w dGlvbkxpc3QuYXBwZW5kKE9wdGlvbigiLS1nYy1iZXR3ZWVuLXRlc3RzIiwgIkdhcmJhZ2UgY29s bGVjdGlvbiBiZXR3ZWVuIHRlc3RzLiIsIGhhbmRsZU9wdGlvbkdjQmV0d2VlblRlc3RzKSk7CiAg ICAgb3B0aW9uTGlzdC5hcHBlbmQoT3B0aW9uKCItLXBpeGVsLXRlc3RzIiwgIkNoZWNrIHBpeGVs cy4iLCBoYW5kbGVPcHRpb25QaXhlbFRlc3RzKSk7Cg==