143830 2015-04-16 08:30:39 -0700 Remove PluginController::isPluginVisible() 2015-04-16 10:29:42 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sungmann.cho webkit-unassigned andersca commit-queue darin kling ossy sam oldest_to_newest 1085926 0 sungmann.cho 2015-04-16 08:30:39 -0700 PluginController::isPluginVisible() was introduced by http://webkit.org/b/60285. This method had been used only for WebKit2 on Windows, and no one uses it now. So we can remove it. 1085927 1 250925 sungmann.cho 2015-04-16 08:33:37 -0700 Created attachment 250925 Patch 1085947 2 ossy 2015-04-16 09:37:47 -0700 LGTM, but I let WK2 owners to do the final review. 1085961 3 250925 commit-queue 2015-04-16 10:29:37 -0700 Comment on attachment 250925 Patch Clearing flags on attachment: 250925 Committed r182892: <http://trac.webkit.org/changeset/182892> 1085962 4 commit-queue 2015-04-16 10:29:42 -0700 All reviewed patches have been landed. Closing bug. 250925 2015-04-16 08:33:37 -0700 2015-04-16 10:29:37 -0700 Patch bug-143830-20150417003239.patch text/plain 4796 sungmann.cho U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyODMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggN2Q4ZmRmYTc0MzhhZmQ0 ZGI5ZmE0ODQ3NWNkN2QxYTEzNDAxNzg1OS4uMWRlMzAyNzVlOTViMmQyYWEzOTg3YTUzMGM2N2Q4 NDJjZmNhNmUxZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE1LTA0LTE2ICBTdW5n bWFubiBDaG8gIDxzdW5nbWFubi5jaG9AbmF2ZXJjb3JwLmNvbT4KKworICAgICAgICBSZW1vdmUg UGx1Z2luQ29udHJvbGxlcjo6aXNQbHVnaW5WaXNpYmxlKCkuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDM4MzAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQbHVnaW5Db250cm9sbGVyOjppc1BsdWdpblZp c2libGUoKSB3YXMgaW50cm9kdWNlZCBieSBodHRwOi8vd2Via2l0Lm9yZy9iLzYwMjg1LgorICAg ICAgICBUaGlzIG1ldGhvZCBoYWQgYmVlbiB1c2VkIG9ubHkgZm9yIFdlYktpdDIgb24gV2luZG93 cywgYW5kIG5vIG9uZSB1c2VzIGl0IG5vdy4KKyAgICAgICAgU28gd2UgY2FuIHJlbW92ZSBpdC4K KworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAq IFBsdWdpblByb2Nlc3MvUGx1Z2luQ29udHJvbGxlclByb3h5LmNwcDoKKyAgICAgICAgKFdlYktp dDo6UGx1Z2luQ29udHJvbGxlclByb3h5Ojppc1BsdWdpblZpc2libGUpOiBEZWxldGVkLgorICAg ICAgICAqIFBsdWdpblByb2Nlc3MvUGx1Z2luQ29udHJvbGxlclByb3h5Lmg6CisgICAgICAgICog V2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpbkNvbnRyb2xsZXIuaDoKKyAgICAgICAgKiBXZWJQcm9j ZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5jcHA6CisgICAgICAgIChXZWJLaXQ6OlBsdWdpblZpZXc6 OmlzUGx1Z2luVmlzaWJsZSk6IERlbGV0ZWQuCisgICAgICAgICogV2ViUHJvY2Vzcy9QbHVnaW5z L1BsdWdpblZpZXcuaDoKKwogMjAxNS0wNC0xNCAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9u QGFwcGxlLmNvbT4KIAogICAgICAgICBVcGRhdGUgZ2VzdHVyZSBzd2lwZSBzaGFkb3cgc3R5bGUK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsdWdpblByb2Nlc3MvUGx1Z2luQ29udHJvbGxl clByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1BsdWdpblByb2Nlc3MvUGx1Z2luQ29udHJvbGxl clByb3h5LmNwcAppbmRleCBkOWE4ZjYwZjEzZmZhNDEwNDM2YmQ5N2UyMWFlM2E2YzI0YTJhZjg1 Li43OTcwMTllYzdjMGYyOGNlMDE0MzAzOGE5MzJiYzBmZTc4NjUxZDg1IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9QbHVnaW5Qcm9jZXNzL1BsdWdpbkNvbnRyb2xsZXJQcm94eS5jcHAKKysr IGIvU291cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy9QbHVnaW5Db250cm9sbGVyUHJveHkuY3Bw CkBAIC0yMjAsMTMgKzIyMCw2IEBAIHZvaWQgUGx1Z2luQ29udHJvbGxlclByb3h5OjpzdGFydFBh aW50VGltZXIoKQogICAgIG1fd2FpdGluZ0ZvckRpZFVwZGF0ZSA9IHRydWU7CiB9CiAKLWJvb2wg UGx1Z2luQ29udHJvbGxlclByb3h5Ojppc1BsdWdpblZpc2libGUoKQotewotICAgIC8vIEZJWE1F OiBJbXBsZW1lbnQgdGhpcy4KLSAgICBub3RJbXBsZW1lbnRlZCgpOwotICAgIHJldHVybiBmYWxz ZTsKLX0KLQogdm9pZCBQbHVnaW5Db250cm9sbGVyUHJveHk6OmludmFsaWRhdGUoY29uc3QgSW50 UmVjdCYgcmVjdCkKIHsKICAgICBJbnRSZWN0IGRpcnR5UmVjdCA9IHJlY3Q7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9QbHVnaW5Qcm9jZXNzL1BsdWdpbkNvbnRyb2xsZXJQcm94eS5oIGIv U291cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy9QbHVnaW5Db250cm9sbGVyUHJveHkuaAppbmRl eCAwMjNmZjA3MmE4MmMxYjgyYWQxMmQ4ODgwZWQyZGE4MmIzZjM0YmU1Li4yNzc1Y2JhYzBlZTQ0 MmE4NDJmNmU4OWJiZDg2Y2JiOWJhYmMyYjM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9Q bHVnaW5Qcm9jZXNzL1BsdWdpbkNvbnRyb2xsZXJQcm94eS5oCisrKyBiL1NvdXJjZS9XZWJLaXQy L1BsdWdpblByb2Nlc3MvUGx1Z2luQ29udHJvbGxlclByb3h5LmgKQEAgLTgzLDcgKzgzLDYgQEAg cHJpdmF0ZToKICAgICB2b2lkIHBhaW50KCk7CiAKICAgICAvLyBQbHVnaW5Db250cm9sbGVyCi0g ICAgdmlydHVhbCBib29sIGlzUGx1Z2luVmlzaWJsZSgpIG92ZXJyaWRlOwogICAgIHZpcnR1YWwg dm9pZCBpbnZhbGlkYXRlKGNvbnN0IFdlYkNvcmU6OkludFJlY3QmKSBvdmVycmlkZTsKICAgICB2 aXJ0dWFsIFN0cmluZyB1c2VyQWdlbnQoKSBvdmVycmlkZTsKICAgICB2aXJ0dWFsIHZvaWQgbG9h ZFVSTCh1aW50NjRfdCByZXF1ZXN0SUQsIGNvbnN0IFN0cmluZyYgbWV0aG9kLCBjb25zdCBTdHJp bmcmIHVybFN0cmluZywgY29uc3QgU3RyaW5nJiB0YXJnZXQsIGNvbnN0IFdlYkNvcmU6OkhUVFBI ZWFkZXJNYXAmIGhlYWRlckZpZWxkcywgY29uc3QgVmVjdG9yPHVpbnQ4X3Q+JiBodHRwQm9keSwg Ym9vbCBhbGxvd1BvcHVwcykgb3ZlcnJpZGU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luQ29udHJvbGxlci5oIGIvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9QbHVnaW5zL1BsdWdpbkNvbnRyb2xsZXIuaAppbmRleCBlNGNlNzgyNzQzMWE2MjE2 ZTAwOGIwMjA4ZWM2MDgwNzRmNjY5MDcxLi44YjA2ZjQxNjk1NjRmYjZlM2Q3ZDQxOWUyMDYxYTdl N2Q3ZTM2YWMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMv UGx1Z2luQ29udHJvbGxlci5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lu cy9QbHVnaW5Db250cm9sbGVyLmgKQEAgLTQ4LDkgKzQ4LDYgQEAgbmFtZXNwYWNlIFdlYktpdCB7 CiAKIGNsYXNzIFBsdWdpbkNvbnRyb2xsZXIgewogcHVibGljOgotICAgIC8vIFJldHVybnMgZmFs c2UgaWYgdGhlIHBsdWdpbiBoYXMgZXhwbGljaXRseSBiZWVuIGhpZGRlbi4gUmV0dXJucyB0cnVl IG90aGVyd2lzZSAoZXZlbiBpZiB0aGUgcGx1Z2luIGlzIGN1cnJlbnRseSBvYnNjdXJlZCBmcm9t IHZpZXcgb24gc2NyZWVuLikKLSAgICB2aXJ0dWFsIGJvb2wgaXNQbHVnaW5WaXNpYmxlKCkgPSAw OwotCiAgICAgLy8gVGVsbHMgdGhlIGNvbnRyb2xsZXIgdGhhdCB0aGUgcGx1Zy1pbiB3YW50cyB0 aGUgZ2l2ZW4gcmVjdCB0byBiZSByZXBhaW50ZWQuIFRoZSByZWN0IGlzIGluIHRoZSBwbHVnLWlu J3MgY29vcmRpbmF0ZSBzeXN0ZW0uCiAgICAgdmlydHVhbCB2b2lkIGludmFsaWRhdGUoY29uc3Qg V2ViQ29yZTo6SW50UmVjdCYpID0gMDsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9QbHVnaW5zL1BsdWdpblZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9QbHVnaW5zL1BsdWdpblZpZXcuY3BwCmluZGV4IDQzYTA1YTczMDI1YmNlZDYzOWU0NWY2OWRh N2U1NzU4Yjk0OTYxMmMuLjJjZTNlZWIxZGMxMGFmY2MxNDg5YTk2NDAxODU4NDBjNWVhMTY5NzYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5WaWV3 LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5j cHAKQEAgLTEzNDAsMTEgKzEzNDAsNiBAQCB2b2lkIFBsdWdpblZpZXc6OnBhZ2VNdXRlZFN0YXRl RGlkQ2hhbmdlKCkKICNlbmRpZgogfQogCi1ib29sIFBsdWdpblZpZXc6OmlzUGx1Z2luVmlzaWJs ZSgpCi17Ci0gICAgcmV0dXJuIGlzVmlzaWJsZSgpOwotfQotCiB2b2lkIFBsdWdpblZpZXc6Omlu dmFsaWRhdGUoY29uc3QgSW50UmVjdCYgZGlydHlSZWN0KQogewogICAgIGludmFsaWRhdGVSZWN0 KGRpcnR5UmVjdCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdp bnMvUGx1Z2luVmlldy5oIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdp blZpZXcuaAppbmRleCAwODdiZjc2OWNiYWQxZjM5NDBlYzI5YWUxY2I4MmYxZWMwYzlkZjkxLi43 MTliN2Y2ZjU2MzA3MjE3ODQwOThlN2M2M2M4MGIyOWUwZDQ1Yzc0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5oCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5WaWV3LmgKQEAgLTE4Niw3ICsxODYsNiBA QCBwcml2YXRlOgogICAgIHZpcnR1YWwgdm9pZCBwYWdlTXV0ZWRTdGF0ZURpZENoYW5nZSgpIG92 ZXJyaWRlOwogCiAgICAgLy8gUGx1Z2luQ29udHJvbGxlcgotICAgIHZpcnR1YWwgYm9vbCBpc1Bs dWdpblZpc2libGUoKSBvdmVycmlkZTsKICAgICB2aXJ0dWFsIHZvaWQgaW52YWxpZGF0ZShjb25z dCBXZWJDb3JlOjpJbnRSZWN0Jikgb3ZlcnJpZGU7CiAgICAgdmlydHVhbCBTdHJpbmcgdXNlckFn ZW50KCkgb3ZlcnJpZGU7CiAgICAgdmlydHVhbCB2b2lkIGxvYWRVUkwodWludDY0X3QgcmVxdWVz dElELCBjb25zdCBTdHJpbmcmIG1ldGhvZCwgY29uc3QgU3RyaW5nJiB1cmxTdHJpbmcsIGNvbnN0 IFN0cmluZyYgdGFyZ2V0LCBjb25zdCBXZWJDb3JlOjpIVFRQSGVhZGVyTWFwJiBoZWFkZXJGaWVs ZHMsIGNvbnN0IFZlY3Rvcjx1aW50OF90PiYgaHR0cEJvZHksIGJvb2wgYWxsb3dQb3B1cHMpIG92 ZXJyaWRlOwo=