143819 2015-04-16 03:04:42 -0700 [GTK] Run forwarding headers generator unconditionally 2015-04-17 04:19:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=137394 P2 Normal --- 1 ossy ossy calvaris cgarcia clopez commit-queue mrobinson ossy oldest_to_newest 1085869 0 ossy 2015-04-16 03:04:42 -0700 bug137394 made it run depends on source code changes, but renaming headers caused incremental build issues. The runtime is quite short, approximately only 1 second, so let's run it unconditionally again. I already have a patch for it, I run the final test now and will upload if everything is good. 1085871 1 250909 ossy 2015-04-16 03:17:59 -0700 Created attachment 250909 Patch 1085875 2 250909 cgarcia 2015-04-16 04:26:45 -0700 Comment on attachment 250909 Patch Thanks! 1085877 3 250909 ossy 2015-04-16 04:47:33 -0700 Comment on attachment 250909 Patch Clearing flags on attachment: 250909 Committed r182882: <http://trac.webkit.org/changeset/182882> 1085878 4 ossy 2015-04-16 04:47:41 -0700 All reviewed patches have been landed. Closing bug. 1086285 5 ossy 2015-04-17 03:21:13 -0700 and a speculative fix landed in http://trac.webkit.org/changeset/182945 1086293 6 ossy 2015-04-17 04:19:50 -0700 I managed to reproduce the failure (with adding a long sleep into the WK2's fw header generator rule). We really need the dependency, because TestWebKitAPI contains zillion <WebKit/foo.h> Mac style framework include. I added it back in http://trac.webkit.org/changeset/182948 EFL didn't have this problem, because it generates fw-ing headers for WebKit2 too in TestWebKitAPI. It's so ugly, EFL should use the same solution, I'm going to change it. 250909 2015-04-16 03:17:59 -0700 2015-04-16 04:47:33 -0700 Patch bug-143819-20150416031701.patch text/plain 5903 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyODgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTllNTdhYWI2MmIyZjcw MWFhMTY2MGM3ZWJiMTRjM2M0YTZiNDcxOS4uZDhmNWI2NGNhZjIzMDIzODhiM2VmZTkzMzZkYmNj ZmY2MWM2Y2I3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1LTA0LTE2ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0dUS10gUnVuIGZv cndhcmRpbmcgaGVhZGVycyBnZW5lcmF0b3IgdW5jb25kaXRpb25hbGx5CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDM4MTkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFBsYXRmb3JtR1RLLmNtYWtlOgor CiAyMDE1LTA0LTE1ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAg ICAgIFtNYWNdIERpc2FibGUgIlNhdmUgdG8gRG93bmxvYWRzIiBvcHRpb24gZm9yIGxvY2FsIGZp bGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybUdUSy5jbWFrZSBiL1NvdXJj ZS9XZWJLaXQyL1BsYXRmb3JtR1RLLmNtYWtlCmluZGV4IGUwZWY3MWZiNGFmZDg1N2ViNWEwNDA4 ZTFlNTkxZjAxNjVmMDkxZDkuLmIwMmU5NDdiNTA5ZDYxNmZlOGI5MzFiODA0MmRkNTRmYTljZWIw NWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtR1RLLmNtYWtlCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1BsYXRmb3JtR1RLLmNtYWtlCkBAIC05NjYsMjUgKzk2Niw4IEBAIGZpbGUo V1JJVEUgJHtDTUFLRV9CSU5BUllfRElSfS9ndGtkb2Mtd2Via2l0Mmd0ay5jZmcKICAgICAibWFp bl9zZ21sX2ZpbGU9d2Via2l0Mmd0ay1kb2NzLnNnbWxcbiIKICkKIAotZmlsZShHTE9CX1JFQ1VS U0UgV2ViS2l0Ml9IRUFERVJTCi0gICAgKi5oCi0pCi0KLWFkZF9jdXN0b21fY29tbWFuZCgKLSAg ICBPVVRQVVQgJHtDTUFLRV9CSU5BUllfRElSfS9XZWJLaXQyLWZvcndhcmRpbmctaGVhZGVycy5z dGFtcAotICAgIERFUEVORFMgJHtXRUJLSVQyX0RJUn0vU2NyaXB0cy9nZW5lcmF0ZS1mb3J3YXJk aW5nLWhlYWRlcnMucGwKLSAgICAgICAgICAgICR7V2ViS2l0Ml9TT1VSQ0VTfQotICAgICAgICAg ICAgJHtXZWJQcm9jZXNzX1NPVVJDRVN9Ci0gICAgICAgICAgICAke05ldHdvcmtQcm9jZXNzX1NP VVJDRVN9Ci0gICAgICAgICAgICAke0RhdGFiYXNlUHJvY2Vzc19TT1VSQ0VTfQotICAgICAgICAg ICAgJHtQbHVnaW5Qcm9jZXNzR1RLMl9TT1VSQ0VTfQotICAgICAgICAgICAgJHtQbHVnaW5Qcm9j ZXNzX1NPVVJDRVN9Ci0gICAgICAgICAgICAke1dlYktpdDJfSEVBREVSU30KLSAgICBDT01NQU5E ICR7UEVSTF9FWEVDVVRBQkxFfSAke1dFQktJVDJfRElSfS9TY3JpcHRzL2dlbmVyYXRlLWZvcndh cmRpbmctaGVhZGVycy5wbCAtLWluY2x1ZGUtcGF0aCAke1dFQktJVDJfRElSfSAtLW91dHB1dCAk e0ZPUldBUkRJTkdfSEVBREVSU19ESVJ9IC0tcGxhdGZvcm0gZ3RrIC0tcGxhdGZvcm0gc291cAot ICAgIENPTU1BTkQgdG91Y2ggJHtDTUFLRV9CSU5BUllfRElSfS9XZWJLaXQyLWZvcndhcmRpbmct aGVhZGVycy5zdGFtcAotKQogYWRkX2N1c3RvbV90YXJnZXQoV2ViS2l0Mi1mb3J3YXJkaW5nLWhl YWRlcnMKLSAgICBERVBFTkRTICR7Q01BS0VfQklOQVJZX0RJUn0vV2ViS2l0Mi1mb3J3YXJkaW5n LWhlYWRlcnMuc3RhbXAKKyAgICBDT01NQU5EICR7UEVSTF9FWEVDVVRBQkxFfSAke1dFQktJVDJf RElSfS9TY3JpcHRzL2dlbmVyYXRlLWZvcndhcmRpbmctaGVhZGVycy5wbCAtLWluY2x1ZGUtcGF0 aCAke1dFQktJVDJfRElSfSAtLW91dHB1dCAke0ZPUldBUkRJTkdfSEVBREVSU19ESVJ9IC0tcGxh dGZvcm0gZ3RrIC0tcGxhdGZvcm0gc291cAogKQogCiAjIFRoZXNlIHN5bWJvbGljIGxpbmsgYWxs b3dzIGluY2x1ZGVzIGxpa2UgI2luY2x1ZGUgPHdlYmtpdDIvV2Via2l0V2ViVmlldy5oPiB3aGlj aCBzaW11bGF0ZXMgaW5zdGFsbGVkIGhlYWRlcnMuCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VM b2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTlhZWFjMTIzNTkxY2Q1MGZjNDljZTg2YjUwNmQz NWY4YTE3MmM0Ny4uNTM0OTQzMDkxNGZkYzZkY2Y1NTk3OGQzMTFjZmZlNDMxNTA3Nzc2MCAxMDA2 NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsx LDEzIEBACisyMDE1LTA0LTE2ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+ CisKKyAgICAgICAgW0dUS10gUnVuIGZvcndhcmRpbmcgaGVhZGVycyBnZW5lcmF0b3IgdW5jb25k aXRpb25hbGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNDM4MTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFRlc3RXZWJLaXRBUEkvUGxhdGZvcm1HVEsuY21ha2U6CisgICAgICAgICogV2ViS2l0VGVz dFJ1bm5lci9QbGF0Zm9ybUdUSy5jbWFrZToKKwogMjAxNS0wNC0xNSAgR3l1eW91bmcgS2ltICA8 Z3l1eW91bmcua2ltQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW0VGTF0gQWRkIGdudXRscyB0byBq aGJ1aWxkLm1vZHVsZQpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9QbGF0Zm9ybUdU Sy5jbWFrZSBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggZWQ5 ZTZhZGQ1YmZhMGU2ZGU5NmY0MjA3NTk5MTY4MmQzNTYzN2QxMy4uOTUxYWJmZTIxNDhmYjcwYjQ5 NjJhZGRiZjI3Mjk4ZjdkZmQ4ZWU0YSAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9Q bGF0Zm9ybUdUSy5jbWFrZQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1BsYXRmb3JtR1RLLmNt YWtlCkBAIC0yLDYgKzIsMTAgQEAKICMgZGlzYWJsZWQgYW5kIHRoaXMgdHJpZ2dlcnMgdGhlIGlu Y2x1c2lvbiBvZiB0aGUgV2ViS2l0MiBoZWFkZXJzLgogYWRkX2RlZmluaXRpb25zKC1EQlVJTERJ TkdfV0VCS0lUMl9fKQogCithZGRfY3VzdG9tX3RhcmdldChUZXN0V2ViS2l0QVBJLWZvcndhcmRp bmctaGVhZGVycworICAgIENPTU1BTkQgJHtQRVJMX0VYRUNVVEFCTEV9ICR7V0VCS0lUMl9ESVJ9 L1NjcmlwdHMvZ2VuZXJhdGUtZm9yd2FyZGluZy1oZWFkZXJzLnBsIC0taW5jbHVkZS1wYXRoICR7 VEVTVFdFQktJVEFQSV9ESVJ9IC0tb3V0cHV0ICR7Rk9SV0FSRElOR19IRUFERVJTX0RJUn0gLS1w bGF0Zm9ybSBndGsKKykKKwogc2V0KEZvcndhcmRpbmdIZWFkZXJzRm9yVGVzdFdlYktpdEFQSV9O QU1FIFRlc3RXZWJLaXRBUEktZm9yd2FyZGluZy1oZWFkZXJzKQogCiBpbmNsdWRlX2RpcmVjdG9y aWVzKApAQCAtMTMwLDIwICsxMzQsMyBAQCBsaXN0KEFQUEVORCBUZXN0V1RGX1NPVVJDRVMKICAg ICAke1RFU1RXRUJLSVRBUElfRElSfS9UZXN0cy9XVEYvZ29iamVjdC9HTWFpbkxvb3BTb3VyY2Uu Y3BwCiAgICAgJHtURVNUV0VCS0lUQVBJX0RJUn0vVGVzdHMvV1RGL2dvYmplY3QvR1VuaXF1ZVB0 ci5jcHAKICkKLQotZmlsZShHTE9CX1JFQ1VSU0UgVGVzdFdlYktpdEFQSV9TT1VSQ0VTCi0gICAg Ki5jcHAKLSAgICAqLmgKLSkKLQotYWRkX2N1c3RvbV9jb21tYW5kKAotICAgIE9VVFBVVCAke0NN QUtFX0JJTkFSWV9ESVJ9L1Rlc3RXZWJLaXRBUEktZm9yd2FyZGluZy1oZWFkZXJzLnN0YW1wCi0g ICAgREVQRU5EUyAke1dFQktJVDJfRElSfS9TY3JpcHRzL2dlbmVyYXRlLWZvcndhcmRpbmctaGVh ZGVycy5wbAotICAgICAgICAgICAgJHtUZXN0V2ViS2l0QVBJX1NPVVJDRVN9Ci0gICAgQ09NTUFO RCAke1BFUkxfRVhFQ1VUQUJMRX0gJHtXRUJLSVQyX0RJUn0vU2NyaXB0cy9nZW5lcmF0ZS1mb3J3 YXJkaW5nLWhlYWRlcnMucGwgLS1pbmNsdWRlLXBhdGggJHtURVNUV0VCS0lUQVBJX0RJUn0gLS1v dXRwdXQgJHtGT1JXQVJESU5HX0hFQURFUlNfRElSfSAtLXBsYXRmb3JtIGd0awotICAgIENPTU1B TkQgdG91Y2ggJHtDTUFLRV9CSU5BUllfRElSfS9UZXN0V2ViS2l0QVBJLWZvcndhcmRpbmctaGVh ZGVycy5zdGFtcAotKQotYWRkX2N1c3RvbV90YXJnZXQoVGVzdFdlYktpdEFQSS1mb3J3YXJkaW5n LWhlYWRlcnMKLSAgICBERVBFTkRTIFdlYktpdDItZm9yd2FyZGluZy1oZWFkZXJzCi0gICAgREVQ RU5EUyAke0NNQUtFX0JJTkFSWV9ESVJ9L1Rlc3RXZWJLaXRBUEktZm9yd2FyZGluZy1oZWFkZXJz LnN0YW1wCi0pCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1BsYXRmb3JtR1RL LmNtYWtlIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9QbGF0Zm9ybUdUSy5jbWFrZQppbmRleCBj OGEwMTYwYjZjMDViODEyOTJmYTBhYWUwY2FiMWQ1ZGUzYTk1MjY3Li4zYzczNmVhNjM5OWQ3NDcx OTNjODYwYjJmMDg3ZTExNjZlNzNlYTFiIDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVu bmVyL1BsYXRmb3JtR1RLLmNtYWtlCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvUGxhdGZv cm1HVEsuY21ha2UKQEAgLTEsMyArMSw3IEBACithZGRfY3VzdG9tX3RhcmdldChXZWJLaXRUZXN0 UnVubmVyLWZvcndhcmRpbmctaGVhZGVycworICAgIENPTU1BTkQgJHtQRVJMX0VYRUNVVEFCTEV9 ICR7V0VCS0lUMl9ESVJ9L1NjcmlwdHMvZ2VuZXJhdGUtZm9yd2FyZGluZy1oZWFkZXJzLnBsIC0t aW5jbHVkZS1wYXRoICR7V0VCS0lUX1RFU1RSVU5ORVJfRElSfSAtLW91dHB1dCAke0ZPUldBUkRJ TkdfSEVBREVSU19ESVJ9IC0tcGxhdGZvcm0gZ3RrCispCisKIHNldChGb3J3YXJkaW5nSGVhZGVy c0ZvcldlYktpdFRlc3RSdW5uZXJfTkFNRSBXZWJLaXRUZXN0UnVubmVyLWZvcndhcmRpbmctaGVh ZGVycykKIAogbGlzdChBUFBFTkQgV2ViS2l0VGVzdFJ1bm5lcl9TT1VSQ0VTCkBAIC01NSwyMCAr NTksMyBAQCBhZGRfZGVmaW5pdGlvbnMoCiAgICAgLURGT05UU19DT05GX0RJUj0iJHtUT09MU19E SVJ9L1dlYktpdFRlc3RSdW5uZXIvZ3RrL2ZvbnRzIgogICAgIC1EVE9QX0xFVkVMX0RJUj0iJHtD TUFLRV9TT1VSQ0VfRElSfSIKICkKLQotZmlsZShHTE9CX1JFQ1VSU0UgV2ViS2l0VGVzdFJ1bm5l cl9IRUFERVJTCi0gICAgKi5oCi0pCi0KLWFkZF9jdXN0b21fY29tbWFuZCgKLSAgICBPVVRQVVQg JHtDTUFLRV9CSU5BUllfRElSfS9XZWJLaXRUZXN0UnVubmVyLWZvcndhcmRpbmctaGVhZGVycy5z dGFtcAotICAgIERFUEVORFMgJHtXRUJLSVQyX0RJUn0vU2NyaXB0cy9nZW5lcmF0ZS1mb3J3YXJk aW5nLWhlYWRlcnMucGwKLSAgICAgICAgICAgICR7V2ViS2l0VGVzdFJ1bm5lcl9TT1VSQ0VTfQot ICAgICAgICAgICAgJHtXZWJLaXRUZXN0UnVubmVyX0hFQURFUlN9Ci0gICAgICAgICAgICAke1dl YktpdFRlc3RSdW5uZXJJbmplY3RlZEJ1bmRsZV9TT1VSQ0VTfQotICAgIENPTU1BTkQgJHtQRVJM X0VYRUNVVEFCTEV9ICR7V0VCS0lUMl9ESVJ9L1NjcmlwdHMvZ2VuZXJhdGUtZm9yd2FyZGluZy1o ZWFkZXJzLnBsIC0taW5jbHVkZS1wYXRoICR7V0VCS0lUX1RFU1RSVU5ORVJfRElSfSAtLW91dHB1 dCAke0ZPUldBUkRJTkdfSEVBREVSU19ESVJ9IC0tcGxhdGZvcm0gZ3RrCi0gICAgQ09NTUFORCB0 b3VjaCAke0NNQUtFX0JJTkFSWV9ESVJ9L1dlYktpdFRlc3RSdW5uZXItZm9yd2FyZGluZy1oZWFk ZXJzLnN0YW1wCi0pCi1hZGRfY3VzdG9tX3RhcmdldChXZWJLaXRUZXN0UnVubmVyLWZvcndhcmRp bmctaGVhZGVycwotICAgIERFUEVORFMgJHtDTUFLRV9CSU5BUllfRElSfS9XZWJLaXRUZXN0UnVu bmVyLWZvcndhcmRpbmctaGVhZGVycy5zdGFtcAotKQo=