143813 2015-04-15 21:12:25 -0700 Web Inspector: Give DOM Nodes a Context Menu to Log Element to the console 2015-04-16 12:50:51 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck burg graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1085822 0 joepeck 2015-04-15 21:12:25 -0700 * SUMMARY Give DOM Nodes a Context Menu to Log Element to the console. Anywhere we show a DOMTreeOutline we should be able to log to the console. This will give a $n value, so the $1-$9 case is conveniently replaceable by this. 1085823 1 webkit-bug-importer 2015-04-15 21:12:46 -0700 <rdar://problem/20565622> 1085824 2 250895 joepeck 2015-04-15 21:14:55 -0700 Created attachment 250895 [PATCH] Proposed Fix 1085919 3 250895 burg 2015-04-16 08:05:18 -0700 Comment on attachment 250895 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=250895&action=review r=me Nice! Great to see a simple added use case to the console API. This change will be helpful reference. > Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:59 > + this._domTreeOutline = new WebInspector.DOMTreeOutline(true, true, true); In a separate patch, we should convert these boolean arguments into setters. There's no reason they need to be constructor arguments. 1085954 4 250895 timothy 2015-04-16 10:13:59 -0700 Comment on attachment 250895 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=250895&action=review > Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js:496 > + var text = WebInspector.UIString("Selected Element"); The more we do this the more I think the text needs a special formatting. Italics? Tokenized? 1086028 5 joepeck 2015-04-16 12:50:51 -0700 http://trac.webkit.org/changeset/182902 250895 2015-04-15 21:14:55 -0700 2015-04-16 08:05:18 -0700 [PATCH] Proposed Fix log-element.patch text/plain 6977 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDQzNjg1MTkuLjNkNDQ1MTkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDM2IEBACiAyMDE1LTA0LTE1ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogR2l2ZSBE T00gTm9kZXMgYSBDb250ZXh0IE1lbnUgdG8gTG9nIEVsZW1lbnQgdG8gdGhlIGNvbnNvbGUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MzgxMworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFsd2F5cyBnaXZl IERPTSBOb2RlcyBhICJMb2cgRWxlbWVudCIgY29udGV4dCBtZW51IHRvIGxvZyBpdCB0byB0aGUg Y29uc29sZS4KKyAgICAgICAgVGhpcyB3aWxsIGdpdmUgYSAkbiByZWZlcmVuY2UsIGFuZCBpcyBh IGNvbnZlbmllbnQgYWx0ZXJuYXRpdmUgdG8gJDAgb3IKKyAgICAgICAgdGhlIG5vdyByZW1vdmVk ICQxLSQ5LgorCisgICAgICAgICogTG9jYWxpemF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJp bmdzLmpzOgorICAgICAgICBOZXcgIkxvZyBFbGVtZW50IiBhbmQgIlNlbGVjdGVkIEVsZW1lbnQi IHN0cmluZ3MuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVPdXRsaW5l LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRPTVRyZWVPdXRsaW5lKToKKyAgICAgICAgKFdl Ykluc3BlY3Rvci5ET01UcmVlT3V0bGluZS5wcm90b3R5cGUuX2NvbnRleHRNZW51RXZlbnRGaXJl ZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRE9NVHJlZU91dGxpbmUucHJvdG90eXBlLl91cGRh dGVNb2RpZmllZE5vZGVzKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5ET01UcmVlT3V0bGluZS5w cm90b3R5cGUuX3BvcHVsYXRlQ29udGV4dE1lbnUucmV2ZWFsRWxlbWVudCk6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuRE9NVHJlZU91dGxpbmUucHJvdG90eXBlLl9wb3B1bGF0ZUNvbnRleHRNZW51 LmxvZ0VsZW1lbnQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRPTVRyZWVPdXRsaW5lLnByb3Rv dHlwZS5fcG9wdWxhdGVDb250ZXh0TWVudSk6CisgICAgICAgIEFsd2F5cyBpbmNsdWRlIHRoZSAi TG9nIEVsZW1lbnQiIGNvbnRleHQgbWVudS8KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmll d3MvRm9ybWF0dGVkVmFsdWUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRm9ybWF0dGVkVmFs dWUuY3JlYXRlRWxlbWVudEZvck5vZGUpOgorICAgICAgICBUaGlzIHVzZXMgYWxsIHRoZSBkZWZh dWx0cy4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZUNvbnRlbnRWaWV3 LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRPTVRyZWVDb250ZW50Vmlldyk6CisgICAgICAg IFRoaXMgZW5hYmxlcyBhbGwgdGhlIGV4dHJhIGJlaGF2aW9yLgorCisyMDE1LTA0LTE1ICBKb3Nl cGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3Rv cjogUmVtb3ZlIHVubmVjZXNzYXJ5IGludGVybWVkaWF0ZSBvYmplY3QgZnJvbSBET01UcmVlT3V0 bGluZQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQz ODExCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2Vu Lmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvTG9jYWxp emF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzCmluZGV4IDQ2ZjIwYzAxOWYzODJl NWYxNTIwMTM5MWM3NjI1Y2FmYWViMmJhOTMuLjkwYWYwZDkwM2RmNTBhZTY5NTUwZTZmYmEyMWNk ODIwMzE1NWQ4ODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRp b25zL2VuLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0xvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcwpAQCAtMjk1LDYg KzI5NSw3IEBAIGxvY2FsaXplZFN0cmluZ3NbIkxvY2FsIFN0b3JhZ2UiXSA9ICJMb2NhbCBTdG9y YWdlIjsKIGxvY2FsaXplZFN0cmluZ3NbIkxvY2FsIFZhcmlhYmxlcyJdID0gIkxvY2FsIFZhcmlh YmxlcyI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJMb2NhdGVkIGF0ICVzIl0gPSAiTG9jYXRlZCBhdCAl cyI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJMb2NhdGlvbiJdID0gIkxvY2F0aW9uIjsKK2xvY2FsaXpl ZFN0cmluZ3NbIkxvZyBFbGVtZW50Il0gPSAiTG9nIEVsZW1lbnQiOwogbG9jYWxpemVkU3RyaW5n c1siTG9nIE1lc3NhZ2UiXSA9ICJMb2cgTWVzc2FnZSI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJMb2cg U3ltYm9sIl0gPSAiTG9nIFN5bWJvbCI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJMb2cgVmFsdWUiXSA9 ICJMb2cgVmFsdWUiOwpAQCAtNDE0LDYgKzQxNSw3IEBAIGxvY2FsaXplZFN0cmluZ3NbIlNlYXJj aCBSZXNvdXJjZSBDb250ZW50Il0gPSAiU2VhcmNoIFJlc291cmNlIENvbnRlbnQiOwogbG9jYWxp emVkU3RyaW5nc1siU2VjdXJlIl0gPSAiU2VjdXJlIjsKIGxvY2FsaXplZFN0cmluZ3NbIlNlY3Vy aXR5IElzc3VlIl0gPSAiU2VjdXJpdHkgSXNzdWUiOwogbG9jYWxpemVkU3RyaW5nc1siU2VsZWN0 ZWQiXSA9ICJTZWxlY3RlZCI7Citsb2NhbGl6ZWRTdHJpbmdzWyJTZWxlY3RlZCBFbGVtZW50Il0g PSAiU2VsZWN0ZWQgRWxlbWVudCI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJTZWxlY3RlZCBJdGVtIl0g PSAiU2VsZWN0ZWQgSXRlbSI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJTZWxlY3RlZCBJdGVtcyJdID0g IlNlbGVjdGVkIEl0ZW1zIjsKIGxvY2FsaXplZFN0cmluZ3NbIlNlbGVjdGVkIFJhbmdlIl0gPSAi U2VsZWN0ZWQgUmFuZ2UiOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvRE9NVHJlZUNvbnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZUNvbnRlbnRWaWV3LmpzCmluZGV4IDUxYzY2 NzYuLjM4NWRlMDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL0RPTVRyZWVDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVlQ29udGVudFZpZXcuanMKQEAgLTU2LDcgKzU2 LDcgQEAgV2ViSW5zcGVjdG9yLkRPTVRyZWVDb250ZW50VmlldyA9IGZ1bmN0aW9uKHJlcHJlc2Vu dGVkT2JqZWN0KQogICAgIHRoaXMuZWxlbWVudC5jbGFzc0xpc3QuYWRkKFdlYkluc3BlY3Rvci5E T01UcmVlQ29udGVudFZpZXcuU3R5bGVDbGFzc05hbWUpOwogICAgIHRoaXMuZWxlbWVudC5hZGRF dmVudExpc3RlbmVyKCJjbGljayIsIHRoaXMuX21vdXNlV2FzQ2xpY2tlZC5iaW5kKHRoaXMpLCBm YWxzZSk7CiAKLSAgICB0aGlzLl9kb21UcmVlT3V0bGluZSA9IG5ldyBXZWJJbnNwZWN0b3IuRE9N VHJlZU91dGxpbmUodHJ1ZSwgdHJ1ZSwgZmFsc2UpOworICAgIHRoaXMuX2RvbVRyZWVPdXRsaW5l ID0gbmV3IFdlYkluc3BlY3Rvci5ET01UcmVlT3V0bGluZSh0cnVlLCB0cnVlLCB0cnVlKTsKICAg ICB0aGlzLl9kb21UcmVlT3V0bGluZS5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5ET01U cmVlT3V0bGluZS5FdmVudC5TZWxlY3RlZE5vZGVDaGFuZ2VkLCB0aGlzLl9zZWxlY3RlZE5vZGVE aWRDaGFuZ2UsIHRoaXMpOwogICAgIHRoaXMuX2RvbVRyZWVPdXRsaW5lLndpcmVUb0RvbUFnZW50 KCk7CiAgICAgdGhpcy5lbGVtZW50LmFwcGVuZENoaWxkKHRoaXMuX2RvbVRyZWVPdXRsaW5lLmVs ZW1lbnQpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvRE9NVHJlZU91dGxpbmUuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9ET01UcmVlT3V0bGluZS5qcwppbmRleCAxNWZkYmNhLi42NTJkNTk2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVl T3V0bGluZS5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9ET01UcmVlT3V0bGluZS5qcwpAQCAtMzAsNyArMzAsNyBAQAogCiBXZWJJbnNwZWN0b3IuRE9N VHJlZU91dGxpbmUgPSBjbGFzcyBET01UcmVlT3V0bGluZSBleHRlbmRzIFdlYkluc3BlY3Rvci5U cmVlT3V0bGluZQogewotICAgIGNvbnN0cnVjdG9yKG9taXRSb290RE9NTm9kZSwgc2VsZWN0RW5h YmxlZCwgc2hvd0luRWxlbWVudHNQYW5lbEVuYWJsZWQpCisgICAgY29uc3RydWN0b3Iob21pdFJv b3RET01Ob2RlLCBzZWxlY3RFbmFibGVkLCBleGNsdWRlUmV2ZWFsRWxlbWVudENvbnRleHRNZW51 KQogICAgIHsKICAgICAgICAgdmFyIGVsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJv bCIpOwogCkBAIC01MCw3ICs1MCw3IEBAIFdlYkluc3BlY3Rvci5ET01UcmVlT3V0bGluZSA9IGNs YXNzIERPTVRyZWVPdXRsaW5lIGV4dGVuZHMgV2ViSW5zcGVjdG9yLlRyZWVPdXRsCiAKICAgICAg ICAgdGhpcy5faW5jbHVkZVJvb3RET01Ob2RlID0gIW9taXRSb290RE9NTm9kZTsKICAgICAgICAg dGhpcy5fc2VsZWN0RW5hYmxlZCA9IHNlbGVjdEVuYWJsZWQ7Ci0gICAgICAgIHRoaXMuX3Nob3dJ bkVsZW1lbnRzUGFuZWxFbmFibGVkID0gc2hvd0luRWxlbWVudHNQYW5lbEVuYWJsZWQ7CisgICAg ICAgIHRoaXMuX2V4Y2x1ZGVSZXZlYWxFbGVtZW50Q29udGV4dE1lbnUgPSBleGNsdWRlUmV2ZWFs RWxlbWVudENvbnRleHRNZW51OwogICAgICAgICB0aGlzLl9yb290RE9NTm9kZSA9IG51bGw7CiAg ICAgICAgIHRoaXMuX3NlbGVjdGVkRE9NTm9kZSA9IG51bGw7CiAKQEAgLTQ4MywxNiArNDgzLDI3 IEBAIFdlYkluc3BlY3Rvci5ET01UcmVlT3V0bGluZSA9IGNsYXNzIERPTVRyZWVPdXRsaW5lIGV4 dGVuZHMgV2ViSW5zcGVjdG9yLlRyZWVPdXRsCiAKICAgICBfcG9wdWxhdGVDb250ZXh0TWVudShj b250ZXh0TWVudSwgZG9tTm9kZSkKICAgICB7Ci0gICAgICAgIGlmICghdGhpcy5fc2hvd0luRWxl bWVudHNQYW5lbEVuYWJsZWQpCi0gICAgICAgICAgICByZXR1cm47Ci0KICAgICAgICAgZnVuY3Rp b24gcmV2ZWFsRWxlbWVudCgpCiAgICAgICAgIHsKICAgICAgICAgICAgIFdlYkluc3BlY3Rvci5k b21UcmVlTWFuYWdlci5pbnNwZWN0RWxlbWVudChkb21Ob2RlLmlkKTsKICAgICAgICAgfQogCisg ICAgICAgIGZ1bmN0aW9uIGxvZ0VsZW1lbnQoKQorICAgICAgICB7CisgICAgICAgICAgICBXZWJJ bnNwZWN0b3IuUmVtb3RlT2JqZWN0LnJlc29sdmVOb2RlKGRvbU5vZGUsICJjb25zb2xlIiwgZnVu Y3Rpb24ocmVtb3RlT2JqZWN0KSB7CisgICAgICAgICAgICAgICAgaWYgKCFyZW1vdGVPYmplY3Qp CisgICAgICAgICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAgICAgICB2YXIgdGV4dCA9 IFdlYkluc3BlY3Rvci5VSVN0cmluZygiU2VsZWN0ZWQgRWxlbWVudCIpOworICAgICAgICAgICAg ICAgIFdlYkluc3BlY3Rvci5jb25zb2xlTG9nVmlld0NvbnRyb2xsZXIuYXBwZW5kSW1tZWRpYXRl RXhlY3V0aW9uV2l0aFJlc3VsdCh0ZXh0LCByZW1vdGVPYmplY3QpOworICAgICAgICAgICAgfSk7 CisgICAgICAgIH0KKwogICAgICAgICBjb250ZXh0TWVudS5hcHBlbmRTZXBhcmF0b3IoKTsKLSAg ICAgICAgY29udGV4dE1lbnUuYXBwZW5kSXRlbShXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlJldmVh bCBpbiBET00gVHJlZSIpLCByZXZlYWxFbGVtZW50KTsKKworICAgICAgICBpZiAoIXRoaXMuX2V4 Y2x1ZGVSZXZlYWxFbGVtZW50Q29udGV4dE1lbnUpCisgICAgICAgICAgICBjb250ZXh0TWVudS5h cHBlbmRJdGVtKFdlYkluc3BlY3Rvci5VSVN0cmluZygiUmV2ZWFsIGluIERPTSBUcmVlIiksIHJl dmVhbEVsZW1lbnQpOworCisgICAgICAgIGNvbnRleHRNZW51LmFwcGVuZEl0ZW0oV2ViSW5zcGVj dG9yLlVJU3RyaW5nKCJMb2cgRWxlbWVudCIpLCBsb2dFbGVtZW50KTsKICAgICB9CiAKICAgICBf c2hvd1NoYWRvd0RPTVNldHRpbmdDaGFuZ2VkKGV2ZW50KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRm9ybWF0dGVkVmFsdWUuanMgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Gb3JtYXR0ZWRWYWx1ZS5qcwpp bmRleCBlNzAwMmJlLi5kNjM1NzFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9Gb3JtYXR0ZWRWYWx1ZS5qcworKysgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Gb3JtYXR0ZWRWYWx1ZS5qcwpAQCAtNTYsNyAr NTYsNyBAQCBXZWJJbnNwZWN0b3IuRm9ybWF0dGVkVmFsdWUuY3JlYXRlRWxlbWVudEZvck5vZGUg PSBmdW5jdGlvbihvYmplY3QpCiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KIAotICAg ICAgICB2YXIgdHJlZU91dGxpbmUgPSBuZXcgV2ViSW5zcGVjdG9yLkRPTVRyZWVPdXRsaW5lKGZh bHNlLCBmYWxzZSwgdHJ1ZSk7CisgICAgICAgIHZhciB0cmVlT3V0bGluZSA9IG5ldyBXZWJJbnNw ZWN0b3IuRE9NVHJlZU91dGxpbmU7CiAgICAgICAgIHRyZWVPdXRsaW5lLnNldFZpc2libGUodHJ1 ZSk7CiAgICAgICAgIHRyZWVPdXRsaW5lLnJvb3RET01Ob2RlID0gV2ViSW5zcGVjdG9yLmRvbVRy ZWVNYW5hZ2VyLm5vZGVGb3JJZChub2RlSWQpOwogICAgICAgICBpZiAoIXRyZWVPdXRsaW5lLmNo aWxkcmVuWzBdLmhhc0NoaWxkcmVuKQo=