143811 2015-04-15 20:12:00 -0700 Web Inspector: Remove unnecessary intermediate object from DOMTreeOutline 2015-04-16 10:33:08 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck burg commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1085811 0 joepeck 2015-04-15 20:12:00 -0700 * SUMMARY Remove unnecessary intermediate object from DOMTreeOutline. this._eventSupport does nothing, since a TreeOutline is already a WebInspector.Object. 1085812 1 250893 joepeck 2015-04-15 20:13:50 -0700 Created attachment 250893 [PATCH] Proposed Fix 1085918 2 250893 burg 2015-04-16 07:58:30 -0700 Comment on attachment 250893 [PATCH] Proposed Fix r=me After working with this code in the past week, I'm convinced the tree outlines have a lot more cleanup potential. It would be great to split them into views and data sources, for example. 1085931 3 250893 commit-queue 2015-04-16 08:44:33 -0700 Comment on attachment 250893 [PATCH] Proposed Fix Clearing flags on attachment: 250893 Committed r182888: <http://trac.webkit.org/changeset/182888> 1085932 4 commit-queue 2015-04-16 08:44:38 -0700 All reviewed patches have been landed. Closing bug. 1085967 5 timothy 2015-04-16 10:33:08 -0700 (In reply to comment #2) > Comment on attachment 250893 [details] > [PATCH] Proposed Fix > > r=me > > After working with this code in the past week, I'm convinced the tree > outlines have a lot more cleanup potential. It would be great to split them > into views and data sources, for example. As our oldest file, dating back to 2007, I'd say so! I'd like to combine DataGrid and TreeOutline. They both do very similar things. 250893 2015-04-15 20:13:50 -0700 2015-04-16 08:44:33 -0700 [PATCH] Proposed Fix event.patch text/plain 2831 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGVmNGFhNzAuLjQzNjg1MTkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE1LTA0LTE1ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVtb3Zl IHVubmVjZXNzYXJ5IGludGVybWVkaWF0ZSBvYmplY3QgZnJvbSBET01UcmVlT3V0bGluZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzODExCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJm YWNlL1ZpZXdzL0RPTVRyZWVPdXRsaW5lLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRPTVRy ZWVPdXRsaW5lKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5ET01UcmVlT3V0bGluZS5wcm90b3R5 cGUuX3NlbGVjdGVkTm9kZUNoYW5nZWQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRPTVRyZWVP dXRsaW5lLnByb3RvdHlwZS5hZGRFdmVudExpc3RlbmVyKTogRGVsZXRlZC4KKyAgICAgICAgKFdl Ykluc3BlY3Rvci5ET01UcmVlT3V0bGluZS5wcm90b3R5cGUucmVtb3ZlRXZlbnRMaXN0ZW5lcik6 IERlbGV0ZWQuCisgICAgICAgIFRoaXMgb2JqZWN0IHVzZWQgdG8gYmUgdXNlZCB0byBoYW5kbGUg ZXZlbnQgZGlzcGF0Y2hpbmcsIGJ1dAorICAgICAgICBUcmVlT3V0bGluZXMgdGhlbXNlbHZlcyBh cmUgbm93IFdlYkluc3BlY3Rvci5PYmplY3RzIHNvIHdlCisgICAgICAgIGNhbiByZW1vdmUgdGhl IGludGVybWVkaWFyeS4KKworMjAxNS0wNC0xNSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9A YXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEhhbmRsZSBhbGwgcG9zc2libGUg Q29uc29sZSBtZXNzYWdlIFNvdXJjZSB0eXBlcyBpbiBJc3N1ZU1lc3NhZ2UKICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MzgwMwogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVlT3V0bGlu ZS5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVP dXRsaW5lLmpzCmluZGV4IDVhNTk2YjIuLjE1ZmRiY2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVPdXRsaW5lLmpzCisrKyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVPdXRsaW5lLmpz CkBAIC01Myw5ICs1Myw4IEBAIFdlYkluc3BlY3Rvci5ET01UcmVlT3V0bGluZSA9IGNsYXNzIERP TVRyZWVPdXRsaW5lIGV4dGVuZHMgV2ViSW5zcGVjdG9yLlRyZWVPdXRsCiAgICAgICAgIHRoaXMu X3Nob3dJbkVsZW1lbnRzUGFuZWxFbmFibGVkID0gc2hvd0luRWxlbWVudHNQYW5lbEVuYWJsZWQ7 CiAgICAgICAgIHRoaXMuX3Jvb3RET01Ob2RlID0gbnVsbDsKICAgICAgICAgdGhpcy5fc2VsZWN0 ZWRET01Ob2RlID0gbnVsbDsKLSAgICAgICAgdGhpcy5fZXZlbnRTdXBwb3J0ID0gbmV3IFdlYklu c3BlY3Rvci5PYmplY3QoKTsKKwogICAgICAgICB0aGlzLl9lZGl0aW5nID0gZmFsc2U7Ci0KICAg ICAgICAgdGhpcy5fdmlzaWJsZSA9IGZhbHNlOwogCiAgICAgICAgIHRoaXMuZWxlbWVudC5hZGRF dmVudExpc3RlbmVyKCJjb250ZXh0bWVudSIsIHRoaXMuX2NvbnRleHRNZW51RXZlbnRGaXJlZC5i aW5kKHRoaXMpLCB0cnVlKTsKQEAgLTkyLDE2ICs5MSw2IEBAIFdlYkluc3BlY3Rvci5ET01UcmVl T3V0bGluZSA9IGNsYXNzIERPTVRyZWVPdXRsaW5lIGV4dGVuZHMgV2ViSW5zcGVjdG9yLlRyZWVP dXRsCiAgICAgICAgICAgICB0aGlzLl9yZXZlYWxBbmRTZWxlY3ROb2RlKHRoaXMuX3NlbGVjdGVk RE9NTm9kZSwgb21pdEZvY3VzKTsKICAgICB9CiAKLSAgICBhZGRFdmVudExpc3RlbmVyKGV2ZW50 VHlwZSwgbGlzdGVuZXIsIHRoaXNPYmplY3QpCi0gICAgewotICAgICAgICB0aGlzLl9ldmVudFN1 cHBvcnQuYWRkRXZlbnRMaXN0ZW5lcihldmVudFR5cGUsIGxpc3RlbmVyLCB0aGlzT2JqZWN0KTsK LSAgICB9Ci0KLSAgICByZW1vdmVFdmVudExpc3RlbmVyKGV2ZW50VHlwZSwgbGlzdGVuZXIsIHRo aXNPYmplY3QpCi0gICAgewotICAgICAgICB0aGlzLl9ldmVudFN1cHBvcnQucmVtb3ZlRXZlbnRM aXN0ZW5lcihldmVudFR5cGUsIGxpc3RlbmVyLCB0aGlzT2JqZWN0KTsKLSAgICB9Ci0KICAgICBn ZXQgcm9vdERPTU5vZGUoKQogICAgIHsKICAgICAgICAgcmV0dXJuIHRoaXMuX3Jvb3RET01Ob2Rl OwpAQCAtMTkyLDcgKzE4MSw3IEBAIFdlYkluc3BlY3Rvci5ET01UcmVlT3V0bGluZSA9IGNsYXNz IERPTVRyZWVPdXRsaW5lIGV4dGVuZHMgV2ViSW5zcGVjdG9yLlRyZWVPdXRsCiAKICAgICBfc2Vs ZWN0ZWROb2RlQ2hhbmdlZCgpCiAgICAgewotICAgICAgICB0aGlzLl9ldmVudFN1cHBvcnQuZGlz cGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdlYkluc3BlY3Rvci5ET01UcmVlT3V0bGluZS5FdmVudC5T ZWxlY3RlZE5vZGVDaGFuZ2VkKTsKKyAgICAgICAgdGhpcy5kaXNwYXRjaEV2ZW50VG9MaXN0ZW5l cnMoV2ViSW5zcGVjdG9yLkRPTVRyZWVPdXRsaW5lLkV2ZW50LlNlbGVjdGVkTm9kZUNoYW5nZWQp OwogICAgIH0KIAogICAgIGZpbmRUcmVlRWxlbWVudChub2RlKQo=