<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>143803</bug_id>
          
          <creation_ts>2015-04-15 15:18:32 -0700</creation_ts>
          <short_desc>Web Inspector: Handle all possible Console message Source types in IssueMessage</short_desc>
          <delta_ts>2015-04-15 16:10:35 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Inspector</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>DoNotImportToRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Joseph Pecoraro">joepeck</reporter>
          <assigned_to name="Joseph Pecoraro">joepeck</assigned_to>
          <cc>bburg</cc>
    
    <cc>burg</cc>
    
    <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>graouts</cc>
    
    <cc>joepeck</cc>
    
    <cc>jonowells</cc>
    
    <cc>mattbaker</cc>
    
    <cc>nvasilyev</cc>
    
    <cc>timothy</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1085715</commentid>
    <comment_count>0</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2015-04-15 15:18:32 -0700</bug_when>
    <thetext>* SUMMARY
Handle all possible Console message Source types in IssueMessage. Our switch statement misses many possible sources.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1085717</commentid>
    <comment_count>1</comment_count>
      <attachid>250872</attachid>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2015-04-15 15:19:44 -0700</bug_when>
    <thetext>Created attachment 250872
[PATCH] Proposed Fix</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1085721</commentid>
    <comment_count>2</comment_count>
      <attachid>250872</attachid>
    <who name="Brian Burg">burg</who>
    <bug_when>2015-04-15 15:23:45 -0700</bug_when>
    <thetext>Comment on attachment 250872
[PATCH] Proposed Fix

r=me

I remember filing a bug about this error message.. must have lost it!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1085727</commentid>
    <comment_count>3</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2015-04-15 15:26:49 -0700</bug_when>
    <thetext>*** Bug 129950 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1085748</commentid>
    <comment_count>4</comment_count>
      <attachid>250872</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-04-15 16:10:30 -0700</bug_when>
    <thetext>Comment on attachment 250872
[PATCH] Proposed Fix

Clearing flags on attachment: 250872

Committed r182867: &lt;http://trac.webkit.org/changeset/182867&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1085749</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-04-15 16:10:35 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>250872</attachid>
            <date>2015-04-15 15:19:44 -0700</date>
            <delta_ts>2015-04-15 16:10:30 -0700</delta_ts>
            <desc>[PATCH] Proposed Fix</desc>
            <filename>dos</filename>
            <type>text/plain</type>
            <size>2095</size>
            <attacher name="Joseph Pecoraro">joepeck</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi
SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGU4NGZmNjAuLmVmNGFhNzAgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv
clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE1LTA0LTE1ICBKb3NlcGggUGVjb3Jh
cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogSGFuZGxl
IGFsbCBwb3NzaWJsZSBDb25zb2xlIG1lc3NhZ2UgU291cmNlIHR5cGVzIGluIElzc3VlTWVzc2Fn
ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzODAz
CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2Vy
SW50ZXJmYWNlL01vZGVscy9Jc3N1ZU1lc3NhZ2UuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu
SXNzdWVNZXNzYWdlKToKKyAgICAgICAgVXBkYXRlIHRoZSBzd2l0Y2ggdG8gaGFuZGxlIGFsbCBw
b3NzaWJsZSBjb25zb2xlIG1lc3NhZ2Ugc291cmNlcy4KKyAgICAgICAgIndtbCIgd2FzIGxlZ2Fj
eSBhbmQgbm8gbG9uZ2VyIHN1cHBvcnRlZC4KKworMjAxNS0wNC0xNSAgSm9zZXBoIFBlY29yYXJv
ICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEluc3BlY3Rv
clRlc3QgZnJvbnRlbmQgY29uc29sZSBtZXRob2RzIHJlZGlyZWN0ZWQgdG8gdGhlIGZyb250ZW5k
IGFyZSB3cm9uZwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9MTQzODAxCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm
YWNlL01vZGVscy9Jc3N1ZU1lc3NhZ2UuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu
dGVyZmFjZS9Nb2RlbHMvSXNzdWVNZXNzYWdlLmpzCmluZGV4IGZmNmM0YjcuLjRhZTRhMDggMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9Jc3N1
ZU1lc3NhZ2UuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9k
ZWxzL0lzc3VlTWVzc2FnZS5qcwpAQCAtNzUsOSArNzUsOCBAQCBXZWJJbnNwZWN0b3IuSXNzdWVN
ZXNzYWdlID0gY2xhc3MgSXNzdWVNZXNzYWdlIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVjdAog
ICAgICAgICAgICAgICAgIHRoaXMuX3R5cGUgPSBXZWJJbnNwZWN0b3IuSXNzdWVNZXNzYWdlLlR5
cGUuT3RoZXJJc3N1ZTsKICAgICAgICAgICAgIGJyZWFrOwogCi0gICAgICAgIGNhc2UgImh0bWwi
OgorICAgICAgICBjYXNlICJodG1sIjogLy8gQ09NUEFUSUJJTElUWSAoaU9TIDYpLgogICAgICAg
ICBjYXNlICJjc3MiOgotICAgICAgICBjYXNlICJ3bWwiOgogICAgICAgICBjYXNlICJ4bWwiOgog
ICAgICAgICAgICAgdGhpcy5fdHlwZSA9IFdlYkluc3BlY3Rvci5Jc3N1ZU1lc3NhZ2UuVHlwZS5Q
YWdlSXNzdWU7CiAgICAgICAgICAgICBicmVhazsKQEAgLTg2LDcgKzg1LDE0IEBAIFdlYkluc3Bl
Y3Rvci5Jc3N1ZU1lc3NhZ2UgPSBjbGFzcyBJc3N1ZU1lc3NhZ2UgZXh0ZW5kcyBXZWJJbnNwZWN0
b3IuT2JqZWN0CiAgICAgICAgICAgICB0aGlzLl90eXBlID0gV2ViSW5zcGVjdG9yLklzc3VlTWVz
c2FnZS5UeXBlLk5ldHdvcmtJc3N1ZTsKICAgICAgICAgICAgIGJyZWFrOwogCisgICAgICAgIGNh
c2UgInNlY3VyaXR5IjoKKyAgICAgICAgICAgIHRoaXMuX3R5cGUgPSBXZWJJbnNwZWN0b3IuSXNz
dWVNZXNzYWdlLlR5cGUuU2VjdXJpdHlJc3N1ZTsKKyAgICAgICAgICAgIGJyZWFrOworCiAgICAg
ICAgIGNhc2UgImNvbnNvbGUtYXBpIjoKKyAgICAgICAgY2FzZSAic3RvcmFnZSI6CisgICAgICAg
IGNhc2UgImFwcGNhY2hlIjoKKyAgICAgICAgY2FzZSAicmVuZGVyaW5nIjoKICAgICAgICAgY2Fz
ZSAib3RoZXIiOgogICAgICAgICAgICAgdGhpcy5fdHlwZSA9IFdlYkluc3BlY3Rvci5Jc3N1ZU1l
c3NhZ2UuVHlwZS5PdGhlcklzc3VlOwogICAgICAgICAgICAgYnJlYWs7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>