143801 2015-04-15 15:15:54 -0700 Web Inspector: InspectorTest frontend console methods redirected to the frontend are wrong 2015-04-15 16:23:07 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck burg cdumez commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1085711 0 joepeck 2015-04-15 15:15:54 -0700 * SUMMARY InspectorTest frontend console methods redirected to the frontend are wrong. Test.js tries to redirect console.log/error/info as "LOG: args" etc, but they all end up as "INFO: " and have an extra comma in the arguments stringification. 1085713 1 250870 joepeck 2015-04-15 15:17:30 -0700 Created attachment 250870 [PATCH] Proposed Fix 1085720 2 250870 burg 2015-04-15 15:22:51 -0700 Comment on attachment 250870 [PATCH] Proposed Fix r=me (Ouch, that is a dumb bug.) I would have expected this to require test rebaselines..? 1085760 3 250870 commit-queue 2015-04-15 16:23:03 -0700 Comment on attachment 250870 [PATCH] Proposed Fix Clearing flags on attachment: 250870 Committed r182870: <http://trac.webkit.org/changeset/182870> 1085761 4 commit-queue 2015-04-15 16:23:07 -0700 All reviewed patches have been landed. Closing bug. 250870 2015-04-15 15:17:30 -0700 2015-04-15 16:23:03 -0700 [PATCH] Proposed Fix uno.patch text/plain 2659 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDk5NmVhNjguLmU4NGZmNjAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTA0LTE1ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogSW5zcGVj dG9yVGVzdCBmcm9udGVuZCBjb25zb2xlIG1ldGhvZHMgcmVkaXJlY3RlZCB0byB0aGUgZnJvbnRl bmQgYXJlIHdyb25nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNDM4MDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFVzZXJJbnRlcmZhY2UvQmFzZS9UZXN0LmpzOgorICAgICAgICAoSW5zcGVjdG9yVGVz dC5ldmFsdWF0ZUluUGFnZSk6CisgICAgICAgIFByb3Blcmx5IGlmIGNoZWNrIGZvciB0aGUgZXhp c3RlbmNlIG9mIGFuIGFnZW50LgorCisgICAgICAgIChnbG9iYWwpOgorICAgICAgICBQcm9wZXJs eSBob29rIHVwIGNvbnNvbGUgcmVkaXJlY3QgaGFuZGxlcnMgc28gdGhleQorICAgICAgICB3aWxs IG91dHB1dCB0aGUgcmlnaHQgdHlwZSBhbmQgYXJndW1lbnRzIHN0cmluZ3MuCisKIDIwMTUtMDQt MTQgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIg SW5zcGVjdG9yOiBVbmNhdWdodCBleGNlcHRpb24gaW4gSlNDb250ZXh0IGluc3BlY3RvciB3aGVu IG9wZW5pbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L0Jhc2UvVGVzdC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2Uv VGVzdC5qcwppbmRleCA0ZjVjZGE2Li5hNzZiZjk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL1Rlc3QuanMKKysrIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9UZXN0LmpzCkBAIC0xODUsNyArMTg1LDcgQEAgSW5z cGVjdG9yVGVzdC5ldmFsdWF0ZUluUGFnZSA9IGZ1bmN0aW9uKGNvZGVTdHJpbmcsIGNhbGxiYWNr KQogewogICAgIC8vIElmIHdlIGxvYWQgdGhpcyBwYWdlIG91dHNpZGUgb2YgdGhlIGluc3BlY3Rv ciwgb3IgaGl0IGFuIGVhcmx5IGVycm9yIHdoZW4gbG9hZGluZwogICAgIC8vIHRoZSB0ZXN0IGZy b250ZW5kLCB0aGVuIGRlZmVyIGV2YWx1YXRpbmcgdGhlIGNvbW1hbmRzIChpbmRlZmluaXRlbHkg aW4gdGhlIGZvcm1lciBjYXNlKS4KLSAgICBpZiAoIVJ1bnRpbWVBZ2VudCkgeworICAgIGlmICgh d2luZG93LlJ1bnRpbWVBZ2VudCkgewogICAgICAgICB0aGlzLl9vcmlnaW5hbENvbnNvbGVNZXRo b2RzWyJlcnJvciJdKCJUcmllZCB0byBldmFsdWF0ZSBpbiB0ZXN0IHBhZ2UsIGJ1dCBjb25uZWN0 aW9uIG5vdCB5ZXQgZXN0YWJsaXNoZWQ6IiwgY29kZVN0cmluZyk7CiAgICAgICAgIHJldHVybjsK ICAgICB9CkBAIC0yNjUsMTAgKzI2NSwxNiBAQCBJbnNwZWN0b3JUZXN0Ll9vcmlnaW5hbENvbnNv bGVNZXRob2RzID0ge307CiAvLyBDYXRjaCBzeW50YXggZXJyb3JzLCB0eXBlIGVycm9ycywgYW5k IG90aGVyIGV4Y2VwdGlvbnMuCiB3aW5kb3cub25lcnJvciA9IEluc3BlY3RvclRlc3QucmVwb3J0 VW5jYXVnaHRFeGNlcHRpb24uYmluZChJbnNwZWN0b3JUZXN0KTsKIAotZm9yICh2YXIgbG9nVHlw ZSBvZiBbImxvZyIsICJlcnJvciIsICJpbmZvIl0pIHsKLSAgICAvLyBSZWRpcmVjdCBjb25zb2xl IG1ldGhvZHMgdG8gbG9nIG1lc3NhZ2VzIGludG8gdGhlIHRlc3QgcGFnZSdzIERPTS4KLSAgICBJ bnNwZWN0b3JUZXN0Ll9vcmlnaW5hbENvbnNvbGVNZXRob2RzW2xvZ1R5cGVdID0gY29uc29sZVts b2dUeXBlXS5iaW5kKGNvbnNvbGUpOwotICAgIGNvbnNvbGVbbG9nVHlwZV0gPSBmdW5jdGlvbigp IHsKLSAgICAgICAgSW5zcGVjdG9yVGVzdC5hZGRSZXN1bHQobG9nVHlwZS50b1VwcGVyQ2FzZSgp ICsgIjogIiArIEFycmF5LmZyb20oYXJndW1lbnRzKS50b1N0cmluZygpKTsKLSAgICB9OwotfQor Ly8gUmVkaXJlY3QgZnJvbnRlbmQgY29uc29sZSBtZXRob2RzIHRvIGxvZyBtZXNzYWdlcyBpbnRv IHRoZSB0ZXN0IHJlc3VsdC4KKyhmdW5jdGlvbigpIHsKKyAgICBmdW5jdGlvbiBjcmVhdGVQcm94 eUNvbnNvbGVIYW5kbGVyKHR5cGUpIHsKKyAgICAgICAgcmV0dXJuIGZ1bmN0aW9uKCkgeworICAg ICAgICAgICAgSW5zcGVjdG9yVGVzdC5hZGRSZXN1bHQodHlwZSArICI6ICIgKyBBcnJheS5mcm9t KGFyZ3VtZW50cykuam9pbigiICIpKTsKKyAgICAgICAgfTsKKyAgICB9CisKKyAgICBmb3IgKHZh ciB0eXBlIG9mIFsibG9nIiwgImVycm9yIiwgImluZm8iXSkgeworICAgICAgICBJbnNwZWN0b3JU ZXN0Ll9vcmlnaW5hbENvbnNvbGVNZXRob2RzW3R5cGVdID0gY29uc29sZVt0eXBlXS5iaW5kKGNv bnNvbGUpOworICAgICAgICBjb25zb2xlW3R5cGVdID0gY3JlYXRlUHJveHlDb25zb2xlSGFuZGxl cih0eXBlLnRvVXBwZXJDYXNlKCkpOworICAgIH0KK30pKCk7Cg==