143795 2015-04-15 13:56:32 -0700 Sites with both width=device-width and height=device-height load zoomed out 2016-04-12 09:29:45 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 156504 1 thorton thorton benjamin dbates sam simon.fraser oldest_to_newest 1085673 0 thorton 2015-04-15 13:56:32 -0700 Sites with both width=device-width and height=device-height load zoomed out 1085674 1 250855 thorton 2015-04-15 13:56:50 -0700 Created attachment 250855 Patch 1085730 2 250855 benjamin 2015-04-15 15:36:41 -0700 Comment on attachment 250855 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250855&action=review > Source/WebCore/page/ViewportConfiguration.cpp:122 > + if (m_viewportArguments.height == ViewportArguments::ValueDeviceHeight && m_viewportArguments.width != ViewportArguments::ValueDeviceWidth) We should be even more aggressive. Where are the tests? ;) 1085765 3 250883 thorton 2015-04-15 17:05:14 -0700 Created attachment 250883 Patch 1086055 4 thorton 2015-04-16 13:38:11 -0700 (In reply to comment #2) > Comment on attachment 250855 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=250855&action=review > > > Source/WebCore/page/ViewportConfiguration.cpp:122 > > + if (m_viewportArguments.height == ViewportArguments::ValueDeviceHeight && m_viewportArguments.width != ViewportArguments::ValueDeviceWidth) > > We should be even more aggressive. OK! Done. > Where are the tests? ;) Hopefully we can have tests soon, after WKTR uses WKWebView always. 1086067 5 thorton 2015-04-16 14:25:42 -0700 http://trac.webkit.org/changeset/182910 1086068 6 dbates 2015-04-16 14:28:18 -0700 <rdar://problem/20369671> 250855 2015-04-15 13:56:50 -0700 2015-04-15 17:05:11 -0700 Patch bug-143795-20150415135553.patch text/plain 2278 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyODUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzQ4OTQzYWRjZTNlMjY2 N2Q3YmIyZmU1NTM0ODhhYmQ3YzNlZDBjMi4uZjY5ZTVjZjQ0MTFhNjIwYjJlNTBhZmFjMzZmMTE5 YTc0MmU0NTA2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE1LTA0LTE1ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFNpdGVzIHdpdGgg Ym90aCB3aWR0aD1kZXZpY2Utd2lkdGggYW5kIGhlaWdodD1kZXZpY2UtaGVpZ2h0IGxvYWQgem9v bWVkIG91dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTQzNzk1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yMDM2OTY3MT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBhZ2UvVmlld3BvcnRDb25maWd1 cmF0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlZpZXdwb3J0Q29uZmlndXJhdGlvbjo6c2hv dWxkSWdub3JlVmVydGljYWxTY2FsaW5nQ29uc3RyYWludHMpOgorICAgICAgICBTb21lIHNpdGVz IHNwZWNpZnkgYm90aCB3aWR0aD1kZXZpY2Utd2lkdGggYW5kIGhlaWdodD1kZXZpY2UtaGVpZ2h0 LCBhbmQKKyAgICAgICAgdGhlbiBsYXkgb3V0IHRvIGRldmljZSB3aWR0aCBidXQgd2l0aCBhIGxh cmdlIGFtb3VudCBvZiB2ZXJ0aWNhbGx5IHNjcm9sbGFibGUgY29udGVudAorICAgICAgICAoc28s IGhlaWdodD1kZXZpY2UtaGVpZ2h0IHdhcyBhIGxpZSkuCisKKyAgICAgICAgSW4gYWxsIG90aGVy IGNhc2VzIHdoZXJlIHdlIHVzZSBkZXZpY2Utd2lkdGggYW5kIGRldmljZS1oZWlnaHQsIHdlIHBy ZWZlcgorICAgICAgICB3aWR0aD1kZXZpY2Utd2lkdGggb3ZlciBoZWlnaHQ9ZGV2aWNlLWhlaWdo dCwgYnV0IGluIHRoZSBjb2RlIHRvIGlnbm9yZSBzY2FsaW5nIGNvbnN0cmFpbnRzLAorICAgICAg ICB0aGUgdHdvIHBhdGhzIHdlcmUgY29tcGxldGVseSBzZXBhcmF0ZS4gT24gc2l0ZXMgdGhhdCBz cGVjaWZ5IGJvdGgsIHRoaXMKKyAgICAgICAgcmVzdWx0ZWQgaW4gdXMgYXR0ZW1wdGluZyB0byB6 b29tIG91dCB0byBmaXQgdGhlIGVudGlyZSBoZWlnaHQgb2YgdGhlIHZlcnkgdGFsbCBwYWdlLAor ICAgICAgICB3aGljaCBpc24ndCBhdCBhbGwgd2hhdCB3ZSB3YW50ZWQuIFNvLCBpZ25vcmUgaGVp Z2h0PWRldmljZS1oZWlnaHQgaWYgd2lkdGg9ZGV2aWNlLXdpZHRoIGlzIHNwZWNpZmllZC4KKwog MjAxNS0wNC0xNCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAg ICAgIE1ha2UgY3JlYXRpbmcgc2VuZCByaWdodHMgZnJvbSBzaGFyZWQgbWVtb3J5IG1vcmUgcm9i dXN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1ZpZXdwb3J0Q29uZmlndXJhdGlv bi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1ZpZXdwb3J0Q29uZmlndXJhdGlvbi5jcHAKaW5k ZXggYWYxNDJjMDNjNDg0MzdlZmJmZjkzMmJiOGRhNTMwOTQwOTFhYzYxNS4uM2FmNmE4MWQ1YTMw MmE2NGY5YjIwNzQ3MWI0Yjc5MzE4OWM4NDYxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGFnZS9WaWV3cG9ydENvbmZpZ3VyYXRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv Vmlld3BvcnRDb25maWd1cmF0aW9uLmNwcApAQCAtMTE5LDcgKzExOSw3IEBAIGJvb2wgVmlld3Bv cnRDb25maWd1cmF0aW9uOjpzaG91bGRJZ25vcmVWZXJ0aWNhbFNjYWxpbmdDb25zdHJhaW50cygp IGNvbnN0CiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIGJvb2wgbGFpZE91dFRhbGxlclRo YW5WaWV3cG9ydCA9IG1fY29udGVudFNpemUuaGVpZ2h0KCkgPiBsYXlvdXRIZWlnaHQoKTsKLSAg ICBpZiAobV92aWV3cG9ydEFyZ3VtZW50cy5oZWlnaHQgPT0gVmlld3BvcnRBcmd1bWVudHM6OlZh bHVlRGV2aWNlSGVpZ2h0KQorICAgIGlmIChtX3ZpZXdwb3J0QXJndW1lbnRzLmhlaWdodCA9PSBW aWV3cG9ydEFyZ3VtZW50czo6VmFsdWVEZXZpY2VIZWlnaHQgJiYgbV92aWV3cG9ydEFyZ3VtZW50 cy53aWR0aCAhPSBWaWV3cG9ydEFyZ3VtZW50czo6VmFsdWVEZXZpY2VXaWR0aCkKICAgICAgICAg cmV0dXJuIGxhaWRPdXRUYWxsZXJUaGFuVmlld3BvcnQ7CiAKICAgICByZXR1cm4gZmFsc2U7Cg== 250883 2015-04-15 17:05:14 -0700 2015-04-16 14:09:20 -0700 Patch bug-143795-20150415170417.patch text/plain 2279 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyODY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2Q1ZjM0NTQzY2RjNDgy MjEyOWI1ZTMzZDczZDg0MDg2ZmZkNjJiYy4uOWI4YzQ1ZTQxOGRhZjYyOTcwZTkxODZmODNiZDNm ZThhZTEwMTkwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE1LTA0LTE1ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFNpdGVzIHdpdGgg Ym90aCB3aWR0aD1kZXZpY2Utd2lkdGggYW5kIGhlaWdodD1kZXZpY2UtaGVpZ2h0IGxvYWQgem9v bWVkIG91dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTQzNzk1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yMDM2OTY3MT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBhZ2UvVmlld3BvcnRDb25maWd1 cmF0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlZpZXdwb3J0Q29uZmlndXJhdGlvbjo6c2hv dWxkSWdub3JlVmVydGljYWxTY2FsaW5nQ29uc3RyYWludHMpOgorICAgICAgICBTb21lIHNpdGVz IHNwZWNpZnkgYm90aCB3aWR0aD1kZXZpY2Utd2lkdGggYW5kIGhlaWdodD1kZXZpY2UtaGVpZ2h0 LCBhbmQKKyAgICAgICAgdGhlbiBsYXkgb3V0IHRvIGRldmljZSB3aWR0aCBidXQgd2l0aCBhIGxh cmdlIGFtb3VudCBvZiB2ZXJ0aWNhbGx5IHNjcm9sbGFibGUgY29udGVudAorICAgICAgICAoc28s IGhlaWdodD1kZXZpY2UtaGVpZ2h0IHdhcyBhIGxpZSkuCisKKyAgICAgICAgSW4gYWxsIG90aGVy IGNhc2VzIHdoZXJlIHdlIHVzZSBkZXZpY2Utd2lkdGggYW5kIGRldmljZS1oZWlnaHQsIHdlIHBy ZWZlcgorICAgICAgICB3aWR0aD1kZXZpY2Utd2lkdGggb3ZlciBoZWlnaHQ9ZGV2aWNlLWhlaWdo dCwgYnV0IGluIHRoZSBjb2RlIHRvIGlnbm9yZSBzY2FsaW5nIGNvbnN0cmFpbnRzLAorICAgICAg ICB0aGUgdHdvIHBhdGhzIHdlcmUgY29tcGxldGVseSBzZXBhcmF0ZS4gT24gc2l0ZXMgdGhhdCBz cGVjaWZ5IGJvdGgsIHRoaXMKKyAgICAgICAgcmVzdWx0ZWQgaW4gdXMgYXR0ZW1wdGluZyB0byB6 b29tIG91dCB0byBmaXQgdGhlIGVudGlyZSBoZWlnaHQgb2YgdGhlIHZlcnkgdGFsbCBwYWdlLAor ICAgICAgICB3aGljaCBpc24ndCBhdCBhbGwgd2hhdCB3ZSB3YW50ZWQuIFNvLCBpZ25vcmUgaGVp Z2h0PWRldmljZS1oZWlnaHQgaWYgYSB3aWR0aCBpcyBzcGVjaWZpZWQuCisKIDIwMTUtMDQtMTUg IERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIENsZWFuIHVwOiBI YXZlIFNWR1RleHRMYXlvdXRFbmdpbmU6OmJlZ2luVGV4dFBhdGhMYXlvdXQoKSB0YWtlIGEgcmVm ZXJlbmNlIHRvIGEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvVmlld3BvcnRDb25m aWd1cmF0aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvVmlld3BvcnRDb25maWd1cmF0aW9u LmNwcAppbmRleCBhZjE0MmMwM2M0ODQzN2VmYmZmOTMyYmI4ZGE1MzA5NDA5MWFjNjE1Li4wYTMz ZGQ4YjA2YjZlMDJhMDkzZDA2Njg3ZjdkMTRjOTUzZDQ0ZWE1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL1ZpZXdwb3J0Q29uZmlndXJhdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGFnZS9WaWV3cG9ydENvbmZpZ3VyYXRpb24uY3BwCkBAIC0xMTksNyArMTE5LDcgQEAgYm9v bCBWaWV3cG9ydENvbmZpZ3VyYXRpb246OnNob3VsZElnbm9yZVZlcnRpY2FsU2NhbGluZ0NvbnN0 cmFpbnRzKCkgY29uc3QKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgYm9vbCBsYWlkT3V0 VGFsbGVyVGhhblZpZXdwb3J0ID0gbV9jb250ZW50U2l6ZS5oZWlnaHQoKSA+IGxheW91dEhlaWdo dCgpOwotICAgIGlmIChtX3ZpZXdwb3J0QXJndW1lbnRzLmhlaWdodCA9PSBWaWV3cG9ydEFyZ3Vt ZW50czo6VmFsdWVEZXZpY2VIZWlnaHQpCisgICAgaWYgKG1fdmlld3BvcnRBcmd1bWVudHMuaGVp Z2h0ID09IFZpZXdwb3J0QXJndW1lbnRzOjpWYWx1ZURldmljZUhlaWdodCAmJiBtX3ZpZXdwb3J0 QXJndW1lbnRzLndpZHRoID09IFZpZXdwb3J0QXJndW1lbnRzOjpWYWx1ZUF1dG8pCiAgICAgICAg IHJldHVybiBsYWlkT3V0VGFsbGVyVGhhblZpZXdwb3J0OwogCiAgICAgcmV0dXJuIGZhbHNlOwo=