143793 2015-04-15 13:06:08 -0700 Web Inspector: "Log Value" of a value inside of an array, does not log the innermost value 2015-04-16 13:55:55 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned burg graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1085640 0 joepeck 2015-04-15 13:06:08 -0700 * SUMMARY "Log Value" of a value inside of an array, does not log the innermost value. * STEPS TO REPRODUCE 1. js> myObject = { array: [1, {name:"Joe", age:123}] }; dir(myObject) 2. Expand all the way to the inner object 3. Right click "name" and choose "Log Value" => Expected "Joe", but got the containing object {name: "Joe", age: 123} 1085642 1 webkit-bug-importer 2015-04-15 13:06:45 -0700 <rdar://problem/20558139> 1085648 2 joepeck 2015-04-15 13:18:51 -0700 This happens because the GeneralTreeElement event handlers are "useCapture" and thus capture top down. Removing capture mode things work as expected. 1085821 3 joepeck 2015-04-15 21:08:13 -0700 Reusing this to improve context menus in the console in general. 1085830 4 250898 joepeck 2015-04-15 21:32:29 -0700 Created attachment 250898 [PATCH] Proposed Fix 1085922 5 250898 burg 2015-04-16 08:08:31 -0700 Comment on attachment 250898 [PATCH] Proposed Fix r=me Any intuition for why this used to be a capturing handler? 1085955 6 timothy 2015-04-16 10:18:04 -0700 (In reply to comment #5) > Comment on attachment 250898 [details] > [PATCH] Proposed Fix > > r=me > > Any intuition for why this used to be a capturing handler? Joe asked me about it before posting this and I had no clue. Likely legacy and a mistake. 1086062 7 joepeck 2015-04-16 13:55:55 -0700 http://trac.webkit.org/changeset/182909 250898 2015-04-15 21:32:29 -0700 2015-04-16 08:08:31 -0700 [PATCH] Proposed Fix log-value-inner.patch text/plain 5563 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGU0NzIyZjIuLmZhOGRjMWEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDM0IEBACiAyMDE1LTA0LTE1ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogIkxvZyBW YWx1ZSIgb2YgYSB2YWx1ZSBpbnNpZGUgb2YgYW4gYXJyYXksIGRvZXMgbm90IGxvZyB0aGUgaW5u ZXJtb3N0IHZhbHVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNDM3OTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBDb250ZXh0IG1lbnUgaGFuZGxlcnMgd2VyZSBiZWluZyBoYW5kbGVkIGluIHRoZSBjYXB0 dXJpbmcgZXZlbnQgcGhhc2UsIHNvCisgICAgICAgIHRoZSBvdXRlciBtb3N0IGhhbmRsZXIsIGlu c3RlYWQgb2YgdGhlIGlubmVyIG1vc3QgaGFuZGxlciwgd2FzIGdldHRpbmcKKyAgICAgICAgZmly c3QgYWNjZXNzLiBDaGFuZ2UgdGhpcyBzbyB0aGUgZXZlbnRzIGhhcHBlbiBpbiB0aGUgYnViYmxp bmcgcGhhc2UuCisKKyAgICAgICAgRE9NIE5vZGVzIG1heSBhcHBlYXIgaW5zaWRlIG9mIE9iamVj dCBUcmVlcywgZm9yIGluc3RhbmNlIHdoZW4gc2hvd24KKyAgICAgICAgaW4gYSBjb2xsZWN0aW9u IGxpa2UgYW4gYXJyYXkgb3Igc2V0LiBJbiBhbiBlZmZvcnQgdG8gc3RhbmRhcmRpemUgb24KKyAg ICAgICAgImlubmVyIG1vc3QiIGJlaGF2aW9yLCBjaGFuZ2UgdGhlIERPTVRyZWVPdXRsaW5lIGNv bnRleHQgaGFuZGxlcgorICAgICAgICB0byBhbHNvIGJlIGluIGJ1YmJsaW5nLgorCisgICAgICAg IEluIHRoZSByYXJlIGluc3RhbmNlcyB3aGVyZSBhIG5vZGUgb2JqZWN0IGlzIGluIHRoZSBjb25z b2xlIGJ1dAorICAgICAgICBub3QgZGlzcGxheWVkIGluIGFuIG91dGxpbmUgKGNvbnNvbGUuZGly KG5vZGUpKSwgdGhlbiBpbmNsdWRlIGEKKyAgICAgICAgQ29weSBhcyBIVE1MIGNvbnRleHQgbWVu dSBsaWtlIHlvdSB3b3VsZCBleHBlY3QgaW4gYSBET00gdHJlZS4KKworICAgICAgICAqIFVzZXJJ bnRlcmZhY2UvVmlld3MvRE9NVHJlZU91dGxpbmUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu RE9NVHJlZU91dGxpbmUpOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvR2VuZXJhbFRy ZWVFbGVtZW50LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkdlbmVyYWxUcmVlRWxlbWVudC5w cm90b3R5cGUub25hdHRhY2gpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkdlbmVyYWxUcmVlRWxl bWVudC5wcm90b3R5cGUub25kZXRhY2gpOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3Mv T2JqZWN0VHJlZUJhc2VUcmVlRWxlbWVudC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5PYmpl Y3RUcmVlQmFzZVRyZWVFbGVtZW50LnByb3RvdHlwZS5fYXBwZW5kTWVudXNJdGVtc0Zvck9iamVj dCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuT2JqZWN0VHJlZUJhc2VUcmVlRWxlbWVudCk6CisK KzIwMTUtMDQtMTUgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAg ICAgICBXZWIgSW5zcGVjdG9yOiBBbGxvdyB0b2dnbGluZyB0aGUgZWRpYmlsaXR5IG9mIGEgRE9N VHJlZU91dGxpbmUKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE0MzgxNAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9ET01UcmVlT3V0bGluZS5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVPdXRsaW5lLmpzCmluZGV4IDI5YmM3MTcuLmYxNjZjMmEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RP TVRyZWVPdXRsaW5lLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL0RPTVRyZWVPdXRsaW5lLmpzCkBAIC01OCw3ICs1OCw3IEBAIFdlYkluc3BlY3Rvci5E T01UcmVlT3V0bGluZSA9IGNsYXNzIERPTVRyZWVPdXRsaW5lIGV4dGVuZHMgV2ViSW5zcGVjdG9y LlRyZWVPdXRsCiAgICAgICAgIHRoaXMuX2VkaXRpbmcgPSBmYWxzZTsKICAgICAgICAgdGhpcy5f dmlzaWJsZSA9IGZhbHNlOwogCi0gICAgICAgIHRoaXMuZWxlbWVudC5hZGRFdmVudExpc3RlbmVy KCJjb250ZXh0bWVudSIsIHRoaXMuX2NvbnRleHRNZW51RXZlbnRGaXJlZC5iaW5kKHRoaXMpLCB0 cnVlKTsKKyAgICAgICAgdGhpcy5lbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoImNvbnRleHRtZW51 IiwgdGhpcy5fY29udGV4dE1lbnVFdmVudEZpcmVkLmJpbmQodGhpcykpOwogCiAgICAgICAgIHRo aXMuX2hpZGVFbGVtZW50S2V5Ym9hcmRTaG9ydGN1dCA9IG5ldyBXZWJJbnNwZWN0b3IuS2V5Ym9h cmRTaG9ydGN1dChudWxsLCAiSCIsIHRoaXMuX2hpZGVFbGVtZW50LmJpbmQodGhpcyksIHRoaXMu ZWxlbWVudCk7CiAgICAgICAgIHRoaXMuX2hpZGVFbGVtZW50S2V5Ym9hcmRTaG9ydGN1dC5pbXBs aWNpdGx5UHJldmVudHNEZWZhdWx0ID0gZmFsc2U7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9HZW5lcmFsVHJlZUVsZW1lbnQuanMgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9HZW5lcmFsVHJlZUVsZW1lbnQu anMKaW5kZXggYzM4NjQxMS4uN2ExNWY2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvR2VuZXJhbFRyZWVFbGVtZW50LmpzCisrKyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0dlbmVyYWxUcmVlRWxlbWVudC5q cwpAQCAtMjM4LDEyICsyMzgsMTIgQEAgV2ViSW5zcGVjdG9yLkdlbmVyYWxUcmVlRWxlbWVudCA9 IGNsYXNzIEdlbmVyYWxUcmVlRWxlbWVudCBleHRlbmRzIFdlYkluc3BlY3Rvci4KIAogICAgICAg ICBpZiAodGhpcy5vbmNvbnRleHRtZW51ICYmIHR5cGVvZiB0aGlzLm9uY29udGV4dG1lbnUgPT09 ICJmdW5jdGlvbiIpIHsKICAgICAgICAgICAgIHRoaXMuX2JvdW5kQ29udGV4dE1lbnVFdmVudEhh bmRsZXIgPSB0aGlzLm9uY29udGV4dG1lbnUuYmluZCh0aGlzKTsKLSAgICAgICAgICAgIHRoaXMu X2xpc3RJdGVtTm9kZS5hZGRFdmVudExpc3RlbmVyKCJjb250ZXh0bWVudSIsIHRoaXMuX2JvdW5k Q29udGV4dE1lbnVFdmVudEhhbmRsZXIsIHRydWUpOworICAgICAgICAgICAgdGhpcy5fbGlzdEl0 ZW1Ob2RlLmFkZEV2ZW50TGlzdGVuZXIoImNvbnRleHRtZW51IiwgdGhpcy5fYm91bmRDb250ZXh0 TWVudUV2ZW50SGFuZGxlcik7CiAgICAgICAgIH0KIAogICAgICAgICBpZiAoIXRoaXMuX2JvdW5k Q29udGV4dE1lbnVFdmVudEhhbmRsZXIgJiYgdGhpcy50cmVlT3V0bGluZS5vbmNvbnRleHRtZW51 ICYmIHR5cGVvZiB0aGlzLnRyZWVPdXRsaW5lLm9uY29udGV4dG1lbnUgPT09ICJmdW5jdGlvbiIp IHsKICAgICAgICAgICAgIHRoaXMuX2JvdW5kQ29udGV4dE1lbnVFdmVudEhhbmRsZXIgPSBmdW5j dGlvbihldmVudCkgeyB0aGlzLnRyZWVPdXRsaW5lLm9uY29udGV4dG1lbnUoZXZlbnQsIHRoaXMp OyB9LmJpbmQodGhpcyk7Ci0gICAgICAgICAgICB0aGlzLl9saXN0SXRlbU5vZGUuYWRkRXZlbnRM aXN0ZW5lcigiY29udGV4dG1lbnUiLCB0aGlzLl9ib3VuZENvbnRleHRNZW51RXZlbnRIYW5kbGVy LCB0cnVlKTsKKyAgICAgICAgICAgIHRoaXMuX2xpc3RJdGVtTm9kZS5hZGRFdmVudExpc3RlbmVy KCJjb250ZXh0bWVudSIsIHRoaXMuX2JvdW5kQ29udGV4dE1lbnVFdmVudEhhbmRsZXIpOwogICAg ICAgICB9CiAKICAgICAgICAgdGhpcy5fdXBkYXRlU3RhdHVzRWxlbWVudCgpOwpAQCAtMjUyLDcg KzI1Miw3IEBAIFdlYkluc3BlY3Rvci5HZW5lcmFsVHJlZUVsZW1lbnQgPSBjbGFzcyBHZW5lcmFs VHJlZUVsZW1lbnQgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuCiAgICAgb25kZXRhY2goKQogICAgIHsK ICAgICAgICAgaWYgKHRoaXMuX2JvdW5kQ29udGV4dE1lbnVFdmVudEhhbmRsZXIpIHsKLSAgICAg ICAgICAgIHRoaXMuX2xpc3RJdGVtTm9kZS5yZW1vdmVFdmVudExpc3RlbmVyKCJjb250ZXh0bWVu dSIsIHRoaXMuX2JvdW5kQ29udGV4dE1lbnVFdmVudEhhbmRsZXIsIHRydWUpOworICAgICAgICAg ICAgdGhpcy5fbGlzdEl0ZW1Ob2RlLnJlbW92ZUV2ZW50TGlzdGVuZXIoImNvbnRleHRtZW51Iiwg dGhpcy5fYm91bmRDb250ZXh0TWVudUV2ZW50SGFuZGxlcik7CiAgICAgICAgICAgICBkZWxldGUg dGhpcy5fYm91bmRDb250ZXh0TWVudUV2ZW50SGFuZGxlcjsKICAgICAgICAgfQogICAgIH0KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL09iamVj dFRyZWVCYXNlVHJlZUVsZW1lbnQuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9PYmplY3RUcmVlQmFzZVRyZWVFbGVtZW50LmpzCmluZGV4IDdkMTE4MjUuLmY0 OTRhYWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL09iamVjdFRyZWVCYXNlVHJlZUVsZW1lbnQuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT2JqZWN0VHJlZUJhc2VUcmVlRWxlbWVudC5qcwpAQCAt MjMyLDYgKzIzMiwxNCBAQCBXZWJJbnNwZWN0b3IuT2JqZWN0VHJlZUJhc2VUcmVlRWxlbWVudCA9 IGNsYXNzIE9iamVjdFRyZWVCYXNlVHJlZUVsZW1lbnQgZXh0ZW5kcwogICAgICAgICB9CiAKICAg ICAgICAgaWYgKHJlc29sdmVkVmFsdWUuc3VidHlwZSA9PT0gIm5vZGUiKSB7CisgICAgICAgICAg ICBjb250ZXh0TWVudS5hcHBlbmRJdGVtKFdlYkluc3BlY3Rvci5VSVN0cmluZygiQ29weSBhcyBI VE1MIiksIGZ1bmN0aW9uKCkgeworICAgICAgICAgICAgICAgIHJlc29sdmVkVmFsdWUucHVzaE5v ZGVUb0Zyb250ZW5kKGZ1bmN0aW9uKG5vZGVJZCkgeworICAgICAgICAgICAgICAgICAgICBXZWJJ bnNwZWN0b3IuZG9tVHJlZU1hbmFnZXIubm9kZUZvcklkKG5vZGVJZCkuY29weU5vZGUoKTsKKyAg ICAgICAgICAgICAgICB9KTsKKyAgICAgICAgICAgIH0pOworCisgICAgICAgICAgICBjb250ZXh0 TWVudS5hcHBlbmRTZXBhcmF0b3IoKTsKKwogICAgICAgICAgICAgY29udGV4dE1lbnUuYXBwZW5k SXRlbShXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlJldmVhbCBpbiBET00gVHJlZSIpLCBmdW5jdGlv bigpIHsKICAgICAgICAgICAgICAgICByZXNvbHZlZFZhbHVlLnB1c2hOb2RlVG9Gcm9udGVuZChm dW5jdGlvbihub2RlSWQpIHsKICAgICAgICAgICAgICAgICAgICAgV2ViSW5zcGVjdG9yLmRvbVRy ZWVNYW5hZ2VyLmluc3BlY3RFbGVtZW50KG5vZGVJZCk7Cg==