143792 2015-04-15 12:10:19 -0700 Harden DFGForAllKills 2015-04-15 13:34:05 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 143734 1 fpizlo fpizlo barraclough benjamin ggaren mark.lam mhahnenb mmirman msaboff nrotem oliver saam sam oldest_to_newest 1085623 0 fpizlo 2015-04-15 12:10:19 -0700 Currently it appears to have issues with: - Bytecode instructions that don't have an origin in DFG IR because the operations were killed off. - MovHint doing a kill because the local is always live. 1085625 1 250833 fpizlo 2015-04-15 12:15:36 -0700 Created attachment 250833 the patch 1085645 2 250833 ggaren 2015-04-15 13:09:50 -0700 Comment on attachment 250833 the patch r=me 1085657 3 fpizlo 2015-04-15 13:34:05 -0700 Landed in http://trac.webkit.org/changeset/182857 250833 2015-04-15 12:15:36 -0700 2015-04-15 13:09:50 -0700 the patch blah.patch text/plain 6936 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTgyODQ5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM2IEBA CisyMDE1LTA0LTE1ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg SGFyZGVuIERGR0ZvckFsbEtpbGxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDM3OTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKyAgICAgICAgCisgICAgICAgIFVuZm9ydHVuYXRlbHksIHdlIGRvbid0IGhhdmUgYSBnb29k IHdheSB0byB0ZXN0IHRoaXMgeWV0IC0gYnV0IGl0IHdpbGwgYmUgbmVlZGVkIHRvIHByZXZlbnQK KyAgICAgICAgYnVncyBpbiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTQzNzM0LgorICAgICAgICAKKyAgICAgICAgUHJldmlvdXNseSBGb3JBbGxLaWxscyB1c2VkIHRo ZSBieXRlY29kZSBraWxsIGFuYWx5c2lzLiBUaGF0IHNlZW1lZCBsaWtlIGEgZ29vZCBpZGVhIGJl Y2F1c2UKKyAgICAgICAgdGhhdCBhbmFseXNpcyBpcyBjaGVhcGVyIHRoYW4gdGhlIGZ1bGwgbGl2 ZW5lc3MgYW5hbHlzaXMuIFVuZm9ydHVuYXRlbHksIGl0J3MgcHJvYmFibHkgd3Jvbmc6CisgICAg ICAgIAorICAgICAgICAtIEl0IGxvb2tzIGZvciBraWxsIHNpdGVzIGF0IGZvckV4aXQgb3JpZ2lu IGJvdW5kYXJpZXMuIEJ1dCwgc29tZXRoaW5nIG1pZ2h0IGhhdmUgYmVlbiBraWxsZWQKKyAgICAg ICAgICBieSBhbiBvcGVyYXRpb24gdGhhdCB3YXMgbG9naWNhbGx5IGluIGJldHdlZW4gdGhlIGZv ckV4aXQgb3JpZ2lucyBhdCB0aGUgYm91bmRhcnksIGJ1dCB3YXMKKyAgICAgICAgICByZW1vdmVk IGZyb20gdGhlIERGRyBmb3Igd2hhdGV2ZXIgcmVhc29uLiBUaGUgREZHIGlzIGFsbG93ZWQgdG8g aGF2ZSBieXRlY29kZSBpbnN0cnVjdGlvbgorICAgICAgICAgIGdhcHMuCisgICAgICAgIAorICAg ICAgICAtIEl0IG92ZXJsb29rZWQgdGhlIGZhY3QgdGhhdCBhIE1vdkhpbnQgdGhhdCBhZGRyZXNz ZXMgYSBsb2NhbCB0aGF0IGlzIGFsd2F5cyBsaXZlIGtpbGxzIHRoYXQKKyAgICAgICAgICBsb2Nh bC4gRm9yIGV4YW1wbGUsIHN0b3JpbmcgdG8gYW4gYXJndW1lbnQgbWVhbnMgdGhhdCB0aGUgcHJp b3IgdmFsdWUgb2YgdGhlIGFyZ3VtZW50IGlzCisgICAgICAgICAga2lsbGVkLgorICAgICAgICAK KyAgICAgICAgVGhpcyBmaXhlcyB0aGUgYW5hbHlzaXMgYnkgbWFraW5nIGl0IGhhbmRsZSBNb3ZI aW50cyBkaXJlY3RseSwgYW5kIG1ha2luZyBpdCBkZWZpbmUga2lsbHMgaW4KKyAgICAgICAgdGhl IG1vc3QgY29uc2VydmF0aXZlIHdheSBwb3NzaWJsZTogaXQgYXNrcyBpZiB5b3Ugd2VyZSBsaXZl IGJlZm9yZSBidXQgZGVhZCBhZnRlci4gSWYgd2UKKyAgICAgICAgaGF2ZSB0aGUgY29tcGlsZSB0 aW1lIGJ1ZGdldCB0byBhZmZvcmQgdGhpcyBtb3JlIGRpcmVjdCBhcHByb2FjaCwgdGhlbiBpdCdz IGRlZmluaXRlbCBhIGdvb2QKKyAgICAgICAgaWRlYSBzaW5jZSBpdCdzIHNvIGZvb2wtcHJvb2Yu CisKKyAgICAgICAgKiBkZmcvREZHQXJndW1lbnRzRWxpbWluYXRpb25QaGFzZS5jcHA6CisgICAg ICAgICogZGZnL0RGR0ZvckFsbEtpbGxzLmg6CisgICAgICAgIChKU0M6OkRGRzo6Zm9yQWxsS2ls bGVkT3BlcmFuZHMpOgorICAgICAgICAoSlNDOjpERkc6OmZvckFsbEtpbGxlZE5vZGVzQXROb2Rl SW5kZXgpOgorICAgICAgICAoSlNDOjpERkc6OmZvckFsbERpcmVjdGx5S2lsbGVkT3BlcmFuZHMp OiBEZWxldGVkLgorCiAyMDE1LTA0LTE1ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBs ZS5jb20+CiAKICAgICAgICAgUHJvdmlkZSBTUEkgdG8gYWxsb3cgY2hhbmdpbmcgd2hldGhlciBK U0NvbnRleHRzIGFyZSByZW1vdGUgZGVidWdnYWJsZSBieSBkZWZhdWx0CkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR0FyZ3VtZW50c0VsaW1pbmF0aW9uUGhhc2UuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQXJndW1lbnRzRWxpbWluYXRp b25QaGFzZS5jcHAJKHJldmlzaW9uIDE4MjgwNikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHQXJndW1lbnRzRWxpbWluYXRpb25QaGFzZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI5 Myw2ICsyOTMsNyBAQCBwcml2YXRlOgogICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuOwog ICAgICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgICAgIAorICAgICAgICAgICAg ICAgICAgICAvLyBUaGlzIGxvb3AgY29uc2lkZXJzIGFsbCBub2RlcyB1cCB0byB0aGUgbm9kZUlu ZGV4LCBleGNsdWRpbmcgdGhlIG5vZGVJbmRleC4KICAgICAgICAgICAgICAgICAgICAgd2hpbGUg KG5vZGVJbmRleC0tKSB7CiAgICAgICAgICAgICAgICAgICAgICAgICBOb2RlKiBub2RlID0gYmxv Y2stPmF0KG5vZGVJbmRleCk7CiAgICAgICAgICAgICAgICAgICAgICAgICBpZiAobm9kZSA9PSBj YW5kaWRhdGUpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0ZvckFsbEtpbGxz LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdGb3JBbGxLaWxs cy5oCShyZXZpc2lvbiAxODI4MDYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Zv ckFsbEtpbGxzLmgJKHdvcmtpbmcgY29weSkKQEAgLTcyLDE4ICs3Miw5IEBAIHZvaWQgZm9yQWxs TGl2ZU5vZGVzQXRUYWlsKEdyYXBoJiBncmFwaCwKIH0KIAogdGVtcGxhdGU8dHlwZW5hbWUgRnVu Y3Rvcj4KLXZvaWQgZm9yQWxsRGlyZWN0bHlLaWxsZWRPcGVyYW5kcyhHcmFwaCYgZ3JhcGgsIENv ZGVPcmlnaW4gb3JpZ2luLCBjb25zdCBGdW5jdG9yJiBmdW5jdG9yKQordm9pZCBmb3JBbGxLaWxs ZWRPcGVyYW5kcyhHcmFwaCYgZ3JhcGgsIENvZGVPcmlnaW4gYmVmb3JlLCBOb2RlKiBub2RlQWZ0 ZXIsIGNvbnN0IEZ1bmN0b3ImIGZ1bmN0b3IpCiB7Ci0gICAgZ3JhcGgua2lsbHNGb3Iob3JpZ2lu LmlubGluZUNhbGxGcmFtZSkuZm9yRWFjaE9wZXJhbmRLaWxsZWRBdChvcmlnaW4uYnl0ZWNvZGVJ bmRleCwgZnVuY3Rvcik7Ci19Ci0KLXRlbXBsYXRlPHR5cGVuYW1lIEZ1bmN0b3I+Ci12b2lkIGZv ckFsbEtpbGxlZE9wZXJhbmRzKEdyYXBoJiBncmFwaCwgQ29kZU9yaWdpbiBiZWZvcmUsIENvZGVP cmlnaW4gYWZ0ZXIsIGNvbnN0IEZ1bmN0b3ImIGZ1bmN0b3IpCi17Ci0gICAgLy8gVGhlIHBoaWxv c29waHkgaGVyZSBpcyB0aGF0IGlmIHdlJ3JlIG9uIHRoZSBib3VuZGFyeSBiZXR3ZWVuIGV4aXRp bmcgdG8gb3JpZ2luIEEgYW5kIGV4aXRpbmcKLSAgICAvLyB0byBvcmlnaW4gQiwgdGhlbiB3ZSBu b3RlIHRoZSBraWxscyBmb3IgQS4gS2lsbHMgZm9yIEEgYXJlIHRoZSBieXRlY29kZSBraWxscyBw bHVzIHRoZSB0aGluZ3MKLSAgICAvLyB0aGF0IHdlcmUgbGl2ZSBhdCB3aGF0ZXZlciBjYWxsc2l0 ZXMgYXJlIHBvcHBlZCBiZXR3ZWVuIEEgYW5kIEIuIEl0J3MgbGVnYWwgdG8gY29uc2VydmF0aXZl bHkKLSAgICAvLyBqdXN0IGNvbnNpZGVyIGV2ZXJ5dGhpbmcgbGl2ZSBhdCBBLgorICAgIENvZGVP cmlnaW4gYWZ0ZXIgPSBub2RlQWZ0ZXItPm9yaWdpbi5mb3JFeGl0OwogICAgIAogICAgIGlmICgh YmVmb3JlKSB7CiAgICAgICAgIGlmICghYWZ0ZXIpCkBAIC05OSw0MyArOTAsMzAgQEAgdm9pZCBm b3JBbGxLaWxsZWRPcGVyYW5kcyhHcmFwaCYgZ3JhcGgsIAogICAgICAgICByZXR1cm47CiAgICAg fQogICAgIAorICAgIC8vIElmIHdlIE1vdkhpbnQgc29tZXRoaW5nIHRoYXQgaXMgbGl2ZSBhdCB0 aGUgdGltZSwgdGhlbiB3ZSBraWxsIHRoZSBvbGQgdmFsdWUuCisgICAgVmlydHVhbFJlZ2lzdGVy IGFscmVhZHlOb3RlZDsKKyAgICBpZiAobm9kZUFmdGVyLT5jb250YWluc01vdkhpbnQoKSkgewor ICAgICAgICBWaXJ0dWFsUmVnaXN0ZXIgcmVnID0gbm9kZUFmdGVyLT51bmxpbmtlZExvY2FsKCk7 CisgICAgICAgIGlmIChncmFwaC5pc0xpdmVJbkJ5dGVjb2RlKHJlZywgYWZ0ZXIpKSB7CisgICAg ICAgICAgICBmdW5jdG9yKHJlZyk7CisgICAgICAgICAgICBhbHJlYWR5Tm90ZWQgPSByZWc7Cisg ICAgICAgIH0KKyAgICB9CisgICAgCiAgICAgaWYgKGJlZm9yZSA9PSBhZnRlcikKICAgICAgICAg cmV0dXJuOwogICAgIAogICAgIC8vIGJlZm9yZSBjb3VsZCBiZSB1bnNldCBldmVuIGlmIGFmdGVy IGlzLCBidXQgdGhlIG9wcG9zaXRlIGNhbm5vdCBoYXBwZW4uCiAgICAgQVNTRVJUKCEhYWZ0ZXIp OwogICAgIAotICAgIGlmIChiZWZvcmUuaW5saW5lQ2FsbEZyYW1lICE9IGFmdGVyLmlubGluZUNh bGxGcmFtZSkgewotICAgICAgICAvLyBJcyBiZWZvcmUgZGVlcGVyIHRoYW4gYWZ0ZXI/Ci0gICAg ICAgIGJvb2wgYmVmb3JlSXNEZWVwZXI7Ci0gICAgICAgIGlmICghYWZ0ZXIuaW5saW5lQ2FsbEZy YW1lKQotICAgICAgICAgICAgYmVmb3JlSXNEZWVwZXIgPSB0cnVlOwotICAgICAgICBlbHNlIHsK LSAgICAgICAgICAgIGJlZm9yZUlzRGVlcGVyID0gZmFsc2U7Ci0gICAgICAgICAgICBmb3IgKElu bGluZUNhbGxGcmFtZSogY3VycmVudCA9IGJlZm9yZS5pbmxpbmVDYWxsRnJhbWU7IGN1cnJlbnQ7 IGN1cnJlbnQgPSBjdXJyZW50LT5jYWxsZXIuaW5saW5lQ2FsbEZyYW1lKSB7Ci0gICAgICAgICAg ICAgICAgaWYgKGN1cnJlbnQgPT0gYWZ0ZXIuaW5saW5lQ2FsbEZyYW1lKSB7Ci0gICAgICAgICAg ICAgICAgICAgIGJlZm9yZUlzRGVlcGVyID0gdHJ1ZTsKLSAgICAgICAgICAgICAgICAgICAgYnJl YWs7Ci0gICAgICAgICAgICAgICAgfQotICAgICAgICAgICAgfQotICAgICAgICB9Ci0gICAgICAg IGlmIChiZWZvcmVJc0RlZXBlcikgewotICAgICAgICAgICAgQVNTRVJUKGJlZm9yZS5pbmxpbmVD YWxsRnJhbWUpOwotICAgICAgICAgICAgZm9yIChDb2RlT3JpZ2luIGN1cnJlbnQgPSBiZWZvcmU7 IGN1cnJlbnQuaW5saW5lQ2FsbEZyYW1lICE9IGFmdGVyLmlubGluZUNhbGxGcmFtZTsgY3VycmVu dCA9IGN1cnJlbnQuaW5saW5lQ2FsbEZyYW1lLT5jYWxsZXIpIHsKLSAgICAgICAgICAgICAgICBB U1NFUlQoY3VycmVudC5pbmxpbmVDYWxsRnJhbWUpOwotICAgICAgICAgICAgICAgIENvZGVCbG9j ayogY29kZUJsb2NrID0gZ3JhcGguYmFzZWxpbmVDb2RlQmxvY2tGb3IoY3VycmVudC5pbmxpbmVD YWxsRnJhbWUpOwotICAgICAgICAgICAgICAgIEZ1bGxCeXRlY29kZUxpdmVuZXNzJiBsaXZlbmVz cyA9IGdyYXBoLmxpdmVuZXNzRm9yKGNvZGVCbG9jayk7Ci0gICAgICAgICAgICAgICAgZm9yICh1 bnNpZ25lZCBpID0gY29kZUJsb2NrLT5tX251bUNhbGxlZVJlZ2lzdGVyczsgaS0tOykgewotICAg ICAgICAgICAgICAgICAgICBWaXJ0dWFsUmVnaXN0ZXIgcmVnID0gdmlydHVhbFJlZ2lzdGVyRm9y TG9jYWwoaSk7Ci0gICAgICAgICAgICAgICAgICAgIGlmIChsaXZlbmVzcy5vcGVyYW5kSXNMaXZl KHJlZy5vZmZzZXQoKSwgY3VycmVudC5ieXRlY29kZUluZGV4KSkKLSAgICAgICAgICAgICAgICAg ICAgICAgIGZ1bmN0b3IocmVnICsgY3VycmVudC5pbmxpbmVDYWxsRnJhbWUtPnN0YWNrT2Zmc2V0 KTsKLSAgICAgICAgICAgICAgICB9Ci0gICAgICAgICAgICAgICAgZm9yQWxsRGlyZWN0bHlLaWxs ZWRPcGVyYW5kcyhncmFwaCwgY3VycmVudC5pbmxpbmVDYWxsRnJhbWUtPmNhbGxlciwgZnVuY3Rv cik7Ci0gICAgICAgICAgICB9Ci0gICAgICAgIH0KKyAgICAvLyBEZXRlY3Qga2lsbHMgdGhlIHN1 cGVyIGNvbnNlcnZhdGl2ZSB3YXk6IGl0IGlzIGtpbGxlZCBpZiBpdCB3YXMgbGl2ZSBiZWZvcmUg YW5kIGRlYWQgYWZ0ZXIuCisgICAgZm9yICh1bnNpZ25lZCBpID0gZ3JhcGguYmxvY2soMCktPnZh cmlhYmxlc0F0SGVhZC5udW1iZXJPZkxvY2FscygpOyBpLS07KSB7CisgICAgICAgIFZpcnR1YWxS ZWdpc3RlciByZWcgPSB2aXJ0dWFsUmVnaXN0ZXJGb3JMb2NhbChpKTsKKyAgICAgICAgaWYgKHJl ZyA9PSBhbHJlYWR5Tm90ZWQpCisgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgaWYgKGdy YXBoLmlzTGl2ZUluQnl0ZWNvZGUocmVnLCBiZWZvcmUpICYmICFncmFwaC5pc0xpdmVJbkJ5dGVj b2RlKHJlZywgYWZ0ZXIpKQorICAgICAgICAgICAgZnVuY3RvcihyZWcpOwogICAgIH0KLSAgICAK LSAgICBmb3JBbGxEaXJlY3RseUtpbGxlZE9wZXJhbmRzKGdyYXBoLCBiZWZvcmUsIGZ1bmN0b3Ip OwogfQogICAgIAogLy8gVGVsbHMgeW91IGFsbCBvZiB0aGUgbm9kZXMgdGhhdCB3b3VsZCBubyBs b25nZXIgYmUgbGl2ZSBhY3Jvc3MgdGhlIG5vZGUgYXQgdGhpcyBub2RlSW5kZXguCkBAIC0xNjcs NyArMTQ1LDcgQEAgdm9pZCBmb3JBbGxLaWxsZWROb2Rlc0F0Tm9kZUluZGV4KAogICAgICAgICBi ZWZvcmUgPSBibG9jay0+YXQobm9kZUluZGV4IC0gMSktPm9yaWdpbi5mb3JFeGl0OwogCiAgICAg Zm9yQWxsS2lsbGVkT3BlcmFuZHMoCi0gICAgICAgIGdyYXBoLCBiZWZvcmUsIG5vZGUtPm9yaWdp bi5mb3JFeGl0LAorICAgICAgICBncmFwaCwgYmVmb3JlLCBub2RlLAogICAgICAgICBbJl0gKFZp cnR1YWxSZWdpc3RlciByZWcpIHsKICAgICAgICAgICAgIGF2YWlsYWJpbGl0eU1hcC5jbG9zZVN0 YXJ0aW5nV2l0aExvY2FsKAogICAgICAgICAgICAgICAgIHJlZywK