143787 2015-04-15 11:04:34 -0700 Clean up: Have SVGTextLayoutEngine::beginTextPathLayout() take a reference to a RenderSVGTextPath instead of a pointer 2015-04-15 15:36:48 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dbates dbates ap darin sabouhallawa zimmermann oldest_to_newest 1085593 0 dbates 2015-04-15 11:04:34 -0700 Currently SVGTextLayoutEngine::beginTextPathLayout() takes a pointer to a RenderObject and run-time asserts that its non-null and assumes that it can be safely downcast to a reference to RenderSVGTextPath object. Instead we should have SVGTextLayoutEngine::beginTextPathLayout() take a reference to a RenderSVGTextPath to better catch at compile time and document the preconditions of this function. 1085600 1 250826 dbates 2015-04-15 11:14:31 -0700 Created attachment 250826 Patch 1085712 2 250826 kling 2015-04-15 15:16:24 -0700 Comment on attachment 250826 Patch r=me 1085731 3 250826 dbates 2015-04-15 15:36:42 -0700 Comment on attachment 250826 Patch Clearing flags on attachment: 250826 Committed r182864: <http://trac.webkit.org/changeset/182864> 1085732 4 dbates 2015-04-15 15:36:48 -0700 All reviewed patches have been landed. Closing bug. 250826 2015-04-15 11:14:31 -0700 2015-04-15 15:36:42 -0700 Patch bug-143787-20150415111334.patch text/plain 4800 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyODQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2Y0NWNjYjEzZDhiZmY5 MjMwZGRmNWFkYmJmNTJiMjBlZmFjNzk1MS4uMGE4ZGY1MTM2ZTI0MWUzODVjMjE1Mzk1MzdhYmM0 M2IxNzdmYTFlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE1LTA0LTE1ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBDbGVhbiB1cDogSGF2ZSBT VkdUZXh0TGF5b3V0RW5naW5lOjpiZWdpblRleHRQYXRoTGF5b3V0KCkgdGFrZSBhIHJlZmVyZW5j ZSB0byBhCisgICAgICAgIFJlbmRlclNWR1RleHRQYXRoIGluc3RlYWQgb2YgYSBwb2ludGVyCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDM3ODcKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTVkdUZXh0TGF5 b3V0RW5naW5lOjpiZWdpblRleHRQYXRoTGF5b3V0KCkgYXNzdW1lcyB0aGF0IHRoZSBwYXNzZWQg UmVuZGVyT2JqZWN0IGlzIGEKKyAgICAgICAgbm9uLW51bGwgcG9pbnRlciB0byBhIFJlbmRlclNW R1RleHRQYXRoIG9iamVjdC4gSW5zdGVhZCB3ZSBzaG91bGQgaGF2ZSB0aGlzIGZ1bmN0aW9uIHRh a2UgYQorICAgICAgICByZWZlcmVuY2UgdG8gYSBSZW5kZXJTVkdUZXh0UGF0aCBvYmplY3QgdG8g aGVscCBjYWxsZXJzIGNhdGNoIGJhZCB1c2FnZSBhbmQgYmV0dGVyIGRvY3VtZW50CisgICAgICAg IHRoZSBleHBlY3RhdGlvbiBvZiBhIHZhbGlkIFJlbmRlclNWR1RleHRQYXRoIG9iamVjdC4KKwor ICAgICAgICAqIHJlbmRlcmluZy9zdmcvU1ZHUm9vdElubGluZUJveC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpTVkdSb290SW5saW5lQm94OjpsYXlvdXRDaGFyYWN0ZXJzSW5UZXh0Qm94ZXMpOiBE b3duY2FzdCB0aGUgcmVuZGVyZXIgb2YgdGhlCisgICAgICAgIGlubGluZSBib3ggdG8gYSBSZW5k ZXJTVkdUZXh0UGF0aCBvYmplY3QgYW5kIHBhc3MgaXQgdG8gU1ZHVGV4dExheW91dEVuZ2luZTo6 YmVnaW5UZXh0UGF0aExheW91dCgpLgorICAgICAgICBXZSBlbnN1cmVkIHRoYXQgdGhpcyBjYXN0 IGlzIHNhZmUgZWFybGllciBpbiB0aGlzIGZ1bmN0aW9uLgorICAgICAgICBTVkdUZXh0TGF5b3V0 RW5naW5lOjpiZWdpblRleHRQYXRoTGF5b3V0KCkuCisgICAgICAgICogcmVuZGVyaW5nL3N2Zy9T VkdUZXh0TGF5b3V0RW5naW5lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNWR1RleHRMYXlvdXRF bmdpbmU6OmJlZ2luVGV4dFBhdGhMYXlvdXQpOiBDaGFuZ2UgdHlwZSBvZiBmaXJzdCBwYXJhbWV0 ZXIgZnJvbQorICAgICAgICBSZW5kZXJPYmplY3QqIHRvIFJlbmRlclNWR1RleHRQYXRoLiBSZW1v dmUgQVNTRVJUKCkgdGhhdCB3YXMgY2hlY2tpbmcgZm9yIGEgbm9uLW51bGwKKyAgICAgICAgUmVu ZGVyT2JqZWN0IHBvaW50ZXIgc2luY2Ugd2UgYXJlIHBhc3NpbmcgdGhlIHJlbmRlcmVyIGJ5IHJl ZmVyZW5jZSBhbmQgYSB3ZWxsLWZvcm1lZAorICAgICAgICByZWZlcmVuY2UgbXVzdCByZWZlciB0 byBhIHZhbGlkIG9iamVjdC4KKyAgICAgICAgKiByZW5kZXJpbmcvc3ZnL1NWR1RleHRMYXlvdXRF bmdpbmUuaDogU3Vic3RpdHV0ZSBSZW5kZXJTVkdUZXh0UGF0aCYgZm9yIFJlbmRlck9iamVjdCou CisKIDIwMTUtMDQtMTUgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAK ICAgICAgICAgR2VuZXJhbGl6ZSAiaXNQbGF5aW5nQXVkaW8iIHRvIGluY2x1ZGUgb3RoZXIgbWVk aWEgY2hhcmFjdGVyaXN0aWNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv c3ZnL1NWR1Jvb3RJbmxpbmVCb3guY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9T VkdSb290SW5saW5lQm94LmNwcAppbmRleCA3YmViNTFkZmQ5YzA5NzZmMGE3YTc1NmE4MzU5NjI1 YTdlMTg1ZmNhLi4wNGQ1ODRkZWU4ZmU3OGJkMWE2ZGM4NzAwMGI5M2Y5ODVmY2Q4YWI4IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1NWR1Jvb3RJbmxpbmVCb3guY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvU1ZHUm9vdElubGluZUJveC5jcHAK QEAgLTI2LDYgKzI2LDcgQEAKIAogI2luY2x1ZGUgIkdyYXBoaWNzQ29udGV4dC5oIgogI2luY2x1 ZGUgIlJlbmRlclNWR1RleHQuaCIKKyNpbmNsdWRlICJSZW5kZXJTVkdUZXh0UGF0aC5oIgogI2lu Y2x1ZGUgIlNWR0lubGluZUZsb3dCb3guaCIKICNpbmNsdWRlICJTVkdJbmxpbmVUZXh0Qm94Lmgi CiAjaW5jbHVkZSAiU1ZHTmFtZXMuaCIKQEAgLTExOSw3ICsxMjAsNyBAQCB2b2lkIFNWR1Jvb3RJ bmxpbmVCb3g6OmxheW91dENoYXJhY3RlcnNJblRleHRCb3hlcyhJbmxpbmVGbG93Qm94KiBzdGFy dCwgU1ZHVGV4dAogICAgICAgICAgICAgICAgIFNWR1RleHRMYXlvdXRFbmdpbmUgbGluZUxheW91 dChjaGFyYWN0ZXJMYXlvdXQubGF5b3V0QXR0cmlidXRlcygpKTsKICAgICAgICAgICAgICAgICBs YXlvdXRDaGFyYWN0ZXJzSW5UZXh0Qm94ZXMoJmZsb3dCb3gsIGxpbmVMYXlvdXQpOwogCi0gICAg ICAgICAgICAgICAgY2hhcmFjdGVyTGF5b3V0LmJlZ2luVGV4dFBhdGhMYXlvdXQoJmNoaWxkLT5y ZW5kZXJlcigpLCBsaW5lTGF5b3V0KTsKKyAgICAgICAgICAgICAgICBjaGFyYWN0ZXJMYXlvdXQu YmVnaW5UZXh0UGF0aExheW91dChkb3duY2FzdDxSZW5kZXJTVkdUZXh0UGF0aD4oY2hpbGQtPnJl bmRlcmVyKCkpLCBsaW5lTGF5b3V0KTsKICAgICAgICAgICAgIH0KIAogICAgICAgICAgICAgbGF5 b3V0Q2hhcmFjdGVyc0luVGV4dEJveGVzKCZmbG93Qm94LCBjaGFyYWN0ZXJMYXlvdXQpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9TVkdUZXh0TGF5b3V0RW5naW5l LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvU1ZHVGV4dExheW91dEVuZ2luZS5j cHAKaW5kZXggZTljNTM1MDhlNWRkYjg0ZTU1ODQ3NmRlNWJkZTRkYmJlM2YzMjY1OC4uZDc3ZjI2 ZDY1NDU3NTZlYzU5OTcxYjA3MWZiNDA4YTczYjgyODdjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL3N2Zy9TVkdUZXh0TGF5b3V0RW5naW5lLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1NWR1RleHRMYXlvdXRFbmdpbmUuY3BwCkBAIC0xNjEsMTIg KzE2MSw5IEBAIGJvb2wgU1ZHVGV4dExheW91dEVuZ2luZTo6cGFyZW50RGVmaW5lc1RleHRMZW5n dGgoUmVuZGVyT2JqZWN0KiBwYXJlbnQpIGNvbnN0CiAgICAgcmV0dXJuIGZhbHNlOwogfQogCi12 b2lkIFNWR1RleHRMYXlvdXRFbmdpbmU6OmJlZ2luVGV4dFBhdGhMYXlvdXQoUmVuZGVyT2JqZWN0 KiBvYmplY3QsIFNWR1RleHRMYXlvdXRFbmdpbmUmIGxpbmVMYXlvdXQpCit2b2lkIFNWR1RleHRM YXlvdXRFbmdpbmU6OmJlZ2luVGV4dFBhdGhMYXlvdXQoUmVuZGVyU1ZHVGV4dFBhdGgmIHRleHRQ YXRoLCBTVkdUZXh0TGF5b3V0RW5naW5lJiBsaW5lTGF5b3V0KQogewotICAgIEFTU0VSVChvYmpl Y3QpOwotCiAgICAgbV9pblBhdGhMYXlvdXQgPSB0cnVlOwotICAgIFJlbmRlclNWR1RleHRQYXRo JiB0ZXh0UGF0aCA9IGRvd25jYXN0PFJlbmRlclNWR1RleHRQYXRoPigqb2JqZWN0KTsKIAogICAg IG1fdGV4dFBhdGggPSB0ZXh0UGF0aC5sYXlvdXRQYXRoKCk7CiAgICAgaWYgKG1fdGV4dFBhdGgu aXNFbXB0eSgpKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9TVkdU ZXh0TGF5b3V0RW5naW5lLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1NWR1RleHRM YXlvdXRFbmdpbmUuaAppbmRleCA0Yjg3OTNhY2M4Nzg3Mjc2OTY3MzE0NDM2MzI0ODIwN2UxOTg1 YTdkLi4zODJkMzllZmEwNDJlOTgwMTk3ZTZlZmEzMjhiMmY2Nzc5NDVmYTY3IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1NWR1RleHRMYXlvdXRFbmdpbmUuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1NWR1RleHRMYXlvdXRFbmdpbmUuaApAQCAt MzAsNiArMzAsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiBjbGFzcyBSZW5kZXJPYmplY3Q7CiBj bGFzcyBSZW5kZXJTdHlsZTsKIGNsYXNzIFJlbmRlclNWR0lubGluZVRleHQ7CitjbGFzcyBSZW5k ZXJTVkdUZXh0UGF0aDsKIGNsYXNzIFNWR0VsZW1lbnQ7CiBjbGFzcyBTVkdJbmxpbmVUZXh0Qm94 OwogY2xhc3MgU1ZHUmVuZGVyU3R5bGU7CkBAIC01MCw3ICs1MSw3IEBAIHB1YmxpYzoKICAgICBW ZWN0b3I8U1ZHVGV4dExheW91dEF0dHJpYnV0ZXMqPiYgbGF5b3V0QXR0cmlidXRlcygpIHsgcmV0 dXJuIG1fbGF5b3V0QXR0cmlidXRlczsgfQogICAgIFNWR1RleHRDaHVua0J1aWxkZXImIGNodW5r TGF5b3V0QnVpbGRlcigpIHsgcmV0dXJuIG1fY2h1bmtMYXlvdXRCdWlsZGVyOyB9CiAKLSAgICB2 b2lkIGJlZ2luVGV4dFBhdGhMYXlvdXQoUmVuZGVyT2JqZWN0KiwgU1ZHVGV4dExheW91dEVuZ2lu ZSYgbGluZUxheW91dCk7CisgICAgdm9pZCBiZWdpblRleHRQYXRoTGF5b3V0KFJlbmRlclNWR1Rl eHRQYXRoJiwgU1ZHVGV4dExheW91dEVuZ2luZSYgbGluZUxheW91dCk7CiAgICAgdm9pZCBlbmRU ZXh0UGF0aExheW91dCgpOwogCiAgICAgdm9pZCBsYXlvdXRJbmxpbmVUZXh0Qm94KFNWR0lubGlu ZVRleHRCb3gqKTsK