143779 2015-04-15 09:42:40 -0700 [Win] DRT does not seem to reset the 'UsesPageCache' setting between tests 2015-04-15 17:27:18 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 143463 1 cdumez cdumez ap bfulgham oldest_to_newest 1085514 0 cdumez 2015-04-15 09:42:40 -0700 DRT does not seem to reset the 'UsesPageCache' settings between tests on Windows. This should be done in resetWebPreferencesToConsistentValues() in DumpRenderTree.cpp, similarly to what is done in DumpRenderTree.mm on Mac / WK1. Without test, PageCache could stay enabled after page cache tests (They enable PageCache explicitly via 'testRunner.overridePreference("WebKitUsesPageCachePreferenceKey", 1)') and cause weird behaviors. 1085519 1 250800 cdumez 2015-04-15 09:45:06 -0700 Created attachment 250800 Patch 1085521 2 250801 cdumez 2015-04-15 09:47:07 -0700 Created attachment 250801 Patch 1085528 3 250801 bfulgham 2015-04-15 09:50:34 -0700 Comment on attachment 250801 Patch r=me. 1085536 4 250801 cdumez 2015-04-15 09:54:59 -0700 Comment on attachment 250801 Patch Clearing flags on attachment: 250801 Committed r182844: <http://trac.webkit.org/changeset/182844> 1085537 5 cdumez 2015-04-15 09:55:03 -0700 All reviewed patches have been landed. Closing bug. 1085776 6 cdumez 2015-04-15 17:26:13 -0700 FYI, after this change. The number of new passes went from 28 to 32 on the Windows Debug bot. Also, the flakes went down from 9 to 1. Similar results on the Windows Release bot. So it looks like the change was indeed useful :) 1085778 7 bfulgham 2015-04-15 17:27:18 -0700 I'm also wondering if (In reply to comment #6) > FYI, after this change. The number of new passes went from 28 to 32 on the > Windows Debug bot. Also, the flakes went down from 9 to 1. Similar results > on the Windows Release bot. > > So it looks like the change was indeed useful :) That's wonderful news! I wonder if I can re-enable a few of the tests I identified as messing up the page cache previously. All of those symptoms might have been caused by this bug you found. 250800 2015-04-15 09:45:06 -0700 2015-04-15 09:47:03 -0700 Patch bug-143779-20150415094409.patch text/plain 1613 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyODQxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzM5ZTYyODEzMzRhMWM0ZGQ4OTI3ZWRlYmRmNjhkMmFj OWRmMTljYi4uNzVmNzBkYzI0NDBmYzAyN2Y5NGViOTIwOThkYWEwZWY3NTMyZDA3OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE1LTA0LTE1ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAg ICAgW1dpbl0gRFJUIGRvZXMgbm90IHNlZW0gdG8gcmVzZXQgdGhlICdVc2VzUGFnZUNhY2hlJyBz ZXR0aW5ncyBiZXR3ZWVuIHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDM3NzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBSZXNldCB0aGUgJ1VzZXNQYWdlQ2FjaGUnIHNldHRpbmcgdG8gRkFMU0Ug YmV0d2VlbiB0ZXN0cyBvbiBXaW5kb3dzLAorICAgICAgICBzaW1pbGFybHkgdG8gd2hhdCBpcyBk b25lIG9uIE1hYyAvIFdLMS4gV2l0aG91dCB0aGlzLCBQYWdlQ2FjaGUgY291bGQKKyAgICAgICAg c3RheSBlbmFibGVkIGFmdGVyIHBhZ2UgY2FjaGUgdGVzdHMgYW5kIGNhdXNlIHdlaXJkIGJlaGF2 aW9ycy4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL3dpbi9EdW1wUmVuZGVyVHJlZS5jcHA6 CisgICAgICAgIChyZXNldFdlYlByZWZlcmVuY2VzVG9Db25zaXN0ZW50VmFsdWVzKToKKwogMjAx NS0wNC0xNCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZS1lbmFibGUgY3VzdG9tIGRpbGF0aW9uIGZvciBhbnRpYWxpYXNlZCBmb250cwpkaWZmIC0t Z2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvd2luL0R1bXBSZW5kZXJUcmVlLmNwcCBiL1Rvb2xz L0R1bXBSZW5kZXJUcmVlL3dpbi9EdW1wUmVuZGVyVHJlZS5jcHAKaW5kZXggZmRiNmJmOWMzOGNj YWE3M2VhM2M2YzA4YzM4ZjlkMWY0MjIzOTBjNS4uMzI5MjkyZjFkMzg0MmMyNjk5YzY1NzUxYTdj NTFmOTIyMzM2ZTQyMSAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvd2luL0R1bXBS ZW5kZXJUcmVlLmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS93aW4vRHVtcFJlbmRlclRy ZWUuY3BwCkBAIC04MDgsNiArODA4LDcgQEAgc3RhdGljIHZvaWQgcmVzZXRXZWJQcmVmZXJlbmNl c1RvQ29uc2lzdGVudFZhbHVlcyhJV2ViUHJlZmVyZW5jZXMqIHByZWZlcmVuY2VzKQogICAgIHBy ZWZzUHJpdmF0ZS0+c2V0RXhwZXJpbWVudGFsTm90aWZpY2F0aW9uc0VuYWJsZWQoRkFMU0UpOwog ICAgIHByZWZlcmVuY2VzLT5zZXRQbHVnSW5zRW5hYmxlZChUUlVFKTsKICAgICBwcmVmZXJlbmNl cy0+c2V0VGV4dEFyZWFzQXJlUmVzaXphYmxlKFRSVUUpOworICAgIHByZWZlcmVuY2VzLT5zZXRV c2VzUGFnZUNhY2hlKEZBTFNFKTsKIAogICAgIHByZWZlcmVuY2VzLT5zZXRQcml2YXRlQnJvd3Np bmdFbmFibGVkKEZBTFNFKTsKICAgICBwcmVmc1ByaXZhdGUtPnNldEF1dGhvckFuZFVzZXJTdHls ZXNFbmFibGVkKFRSVUUpOwo= 250801 2015-04-15 09:47:07 -0700 2015-04-15 09:54:59 -0700 Patch bug-143779-20150415094610.patch text/plain 1612 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyODQxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzM5ZTYyODEzMzRhMWM0ZGQ4OTI3ZWRlYmRmNjhkMmFj OWRmMTljYi4uYWJjZjFjOWJiMjk5MzZkMGJkYTA1ODUwOWQzNTBkNzM3NjMzOGMxYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE1LTA0LTE1ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAg ICAgW1dpbl0gRFJUIGRvZXMgbm90IHNlZW0gdG8gcmVzZXQgdGhlICdVc2VzUGFnZUNhY2hlJyBz ZXR0aW5nIGJldHdlZW4gdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE0Mzc3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFJlc2V0IHRoZSAnVXNlc1BhZ2VDYWNoZScgc2V0dGluZyB0byBGQUxTRSBi ZXR3ZWVuIHRlc3RzIG9uIFdpbmRvd3MsCisgICAgICAgIHNpbWlsYXJseSB0byB3aGF0IGlzIGRv bmUgb24gTWFjIC8gV0sxLiBXaXRob3V0IHRoaXMsIFBhZ2VDYWNoZSBjb3VsZAorICAgICAgICBz dGF5IGVuYWJsZWQgYWZ0ZXIgcGFnZSBjYWNoZSB0ZXN0cyBhbmQgY2F1c2Ugd2VpcmQgYmVoYXZp b3JzLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvd2luL0R1bXBSZW5kZXJUcmVlLmNwcDoK KyAgICAgICAgKHJlc2V0V2ViUHJlZmVyZW5jZXNUb0NvbnNpc3RlbnRWYWx1ZXMpOgorCiAyMDE1 LTA0LTE0ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAg IFJlLWVuYWJsZSBjdXN0b20gZGlsYXRpb24gZm9yIGFudGlhbGlhc2VkIGZvbnRzCmRpZmYgLS1n aXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS93aW4vRHVtcFJlbmRlclRyZWUuY3BwIGIvVG9vbHMv RHVtcFJlbmRlclRyZWUvd2luL0R1bXBSZW5kZXJUcmVlLmNwcAppbmRleCBmZGI2YmY5YzM4Y2Nh YTczZWEzYzZjMDhjMzhmOWQxZjQyMjM5MGM1Li4zMjkyOTJmMWQzODQyYzI2OTljNjU3NTFhN2M1 MWY5MjIzMzZlNDIxIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS93aW4vRHVtcFJl bmRlclRyZWUuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9EdW1wUmVuZGVyVHJl ZS5jcHAKQEAgLTgwOCw2ICs4MDgsNyBAQCBzdGF0aWMgdm9pZCByZXNldFdlYlByZWZlcmVuY2Vz VG9Db25zaXN0ZW50VmFsdWVzKElXZWJQcmVmZXJlbmNlcyogcHJlZmVyZW5jZXMpCiAgICAgcHJl ZnNQcml2YXRlLT5zZXRFeHBlcmltZW50YWxOb3RpZmljYXRpb25zRW5hYmxlZChGQUxTRSk7CiAg ICAgcHJlZmVyZW5jZXMtPnNldFBsdWdJbnNFbmFibGVkKFRSVUUpOwogICAgIHByZWZlcmVuY2Vz LT5zZXRUZXh0QXJlYXNBcmVSZXNpemFibGUoVFJVRSk7CisgICAgcHJlZmVyZW5jZXMtPnNldFVz ZXNQYWdlQ2FjaGUoRkFMU0UpOwogCiAgICAgcHJlZmVyZW5jZXMtPnNldFByaXZhdGVCcm93c2lu Z0VuYWJsZWQoRkFMU0UpOwogICAgIHByZWZzUHJpdmF0ZS0+c2V0QXV0aG9yQW5kVXNlclN0eWxl c0VuYWJsZWQoVFJVRSk7Cg==