143753 2015-04-15 06:11:13 -0700 [GTK][W32] WTF tries to include non-existent WTFHeaderDetection.h 2017-03-11 10:59:41 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 lrn1986 webkit-unassigned benjamin bfulgham bugs-noreply cgarcia cmarcelo commit-queue lrn1986 peavo roger_fong oldest_to_newest 1085448 0 lrn1986 2015-04-15 06:11:13 -0700 WTF/WTFHeaderDetection.h seems to be from some other universe, there are no rules to generate it in webkit-2.4, except for MSVS projects. 1085472 1 250788 lrn1986 2015-04-15 07:33:34 -0700 Created attachment 250788 [GTK][W32] Don't include non-existing WTF/WTFHeaderDetection.h in 2.4.x WTF/WTFHeaderDetection.h seems to be from some other universe, there are no rules to generate it in webkit-2.4, except for MSVS projects. 1085475 2 250788 ossy 2015-04-15 08:10:51 -0700 Comment on attachment 250788 [GTK][W32] Don't include non-existing WTF/WTFHeaderDetection.h in 2.4.x View in context: https://bugs.webkit.org/attachment.cgi?id=250788&action=review > Source/WTF/ChangeLog:15 > + [W32] Change printf format attribute to gnu_printf, MinGW compatibility > + > + "printf" means "gnu_printf" when compiling for non-Windows and means > + "ms_printf" when compiling for Windows. The code, however, does seems to be > + assuming gnu_printf (judging by the use of %z and %l). > + > + Fix this by explicitly specifying gnu_printf format style. > + To ensure that gnu-compatible printf implementation is used, compile > + with -D__USE_MINGW_ANSI_STDIO=1, it will automagically turn all *printf() > + invocations into __mingw_*printf(), which are gnu-compatible. > + > + Only one function that won't be turned is _vsnprintf(). Ifdef its use and > + call vsnprintf() instead when __USE_MINGW_ANSI_STDIO != 0. It seems it is unrelated to this change. > Source/WTF/ChangeLog:23 > + * wtf/Assertions.cpp: > + * wtf/Assertions.h: ditto > Source/WTF/wtf/Platform.h:616 > +#ifdef _MSC_VER > #include <WTF/WTFHeaderDetection.h> > +#endif It is a generated header (see WTFGenerated.make) which is used by Apple Windows port. 1085510 3 250796 lrn1986 2015-04-15 09:38:07 -0700 Created attachment 250796 Don't include non-existing WTF/WTFHeaderDetection.h in 2.4.x WTF/WTFHeaderDetection.h seems to be from some other universe, there are no rules to generate it in webkit-2.4, except for MSVS projects. 1085516 4 ossy 2015-04-15 09:44:42 -0700 (In reply to comment #3) > Created attachment 250796 [details] > Don't include non-existing WTF/WTFHeaderDetection.h in 2.4.x > > WTF/WTFHeaderDetection.h seems to be from some other universe, > there are no rules to generate it in webkit-2.4, except for MSVS projects. Ah, so don't you want to land this change in WebKit trunk, but only the WebKitGTK 2.4 release branch? 1085525 5 250796 bfulgham 2015-04-15 09:49:01 -0700 Comment on attachment 250796 Don't include non-existing WTF/WTFHeaderDetection.h in 2.4.x View in context: https://bugs.webkit.org/attachment.cgi?id=250796&action=review I don't think this is quite right. I think it would be better to have the GTK Win32 build simply generate a "false" case WTFHeaderDetection.h file. That will work with all compiler combinations. I know there are some people using MingW32 to build the WinCairo port, and others working with the Intel compiler. Now that Clang is somewhat usable on Windows, I expect that to be an issue as well. > Source/WTF/ChangeLog:1 > +2015-04-15 Руслан Ижбулатов <lrn1986@gmail.com> The string encoding here seems wrong! > Source/WTF/wtf/Platform.h:614 > +#ifdef _MSC_VER This change breaks the build for people using MingW32 (or other compilers) to build WebKit on Windows. 1085568 6 lrn1986 2015-04-15 10:29:08 -0700 (In reply to comment #5) > Comment on attachment 250796 [details] > Don't include non-existing WTF/WTFHeaderDetection.h in 2.4.x > > View in context: > https://bugs.webkit.org/attachment.cgi?id=250796&action=review > > I don't think this is quite right. I think it would be better to have the > GTK Win32 build simply generate a "false" case WTFHeaderDetection.h file. > That will work with all compiler combinations. I know there are some people > using MingW32 to build the WinCairo port, and others working with the Intel > compiler. Now that Clang is somewhat usable on Windows, I expect that to be > an issue as well. I went for the simplest fix possible that does not immediately break anything else. Considering the fact that building webkit takes a few hours, i'm not very well-motivated to try anything fancier, unless i absolutely have to. > > > Source/WTF/ChangeLog:1 > > +2015-04-15 Руслан Ижбулатов <lrn1986@gmail.com> > > The string encoding here seems wrong! Poor UTF-8 support in the review module. The text is in UTF-8 in the attachment itself. > > > Source/WTF/wtf/Platform.h:614 > > +#ifdef _MSC_VER > > This change breaks the build for people using MingW32 (or other compilers) > to build WebKit on Windows. What about #ifdef HAVE_WTFHEADERDETECTION_H and modifying these mysterious other-ports-with-buildsystems-that-use-gnu-toolchain-but-refuse-to-use-gnu-autotools-which-do-not-generate-this-header? Well, i guess they'd tell me to fix the autotools-based buildsystem used to build webkitgtk instead, which would be fair enough. Thing is, 2.4.x is the last version to have autotools, newer webkitgtk uses cmake, and we'll go back to square one. 250788 2015-04-15 07:33:34 -0700 2015-04-15 09:38:07 -0700 [GTK][W32] Don't include non-existing WTF/WTFHeaderDetection.h in 2.4.x GTKW32-Dont-include-non-existing-WTFWTFHeaderDetec.patch text/plain 2320 lrn1986 RnJvbSBhMmY3ZWE3MTlkYTFiMGMzMTliMjRhOGY2ODg3NDQwYzI3YjhlZjkwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/PUQwPUEwPUQxPTgzPUQxPTgxPUQwPUJCPUQw PUIwPUQwPUJEPTIwPUQwPTk4PUQwPUI2PUQwPUIxPz0KID0/VVRGLTg/cT89RDE9ODM9RDA9QkI9 RDA9QjA9RDE9ODI9RDA9QkU9RDA9QjI/PSA8bHJuMTk4NkBnbWFpbC5jb20+CkRhdGU6IE1vbiwg MTMgQXByIDIwMTUgMDA6Mjk6MjEgKzAwMDAKU3ViamVjdDogW1BBVENIXSBbR1RLXVtXMzJdIERv bid0IGluY2x1ZGUgbm9uLWV4aXN0aW5nCiBXVEYvV1RGSGVhZGVyRGV0ZWN0aW9uLmggaW4gMi40 LngKCldURi9XVEZIZWFkZXJEZXRlY3Rpb24uaCBzZWVtcyB0byBiZSBmcm9tIHNvbWUgb3RoZXIg dW5pdmVyc2UsCnRoZXJlIGFyZSBubyBydWxlcyB0byBnZW5lcmF0ZSBpdCBpbiB3ZWJraXQtMi40 LCBleGNlcHQgZm9yIE1TVlMgcHJvamVjdHMuCgpodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQzNzUzCi0tLQogU291cmNlL1dURi9DaGFuZ2VMb2cgICAgICB8IDI0ICsr KysrKysrKysrKysrKysrKysrKysrKwogU291cmNlL1dURi93dGYvUGxhdGZvcm0uaCB8ICAyICsr CiAyIGZpbGVzIGNoYW5nZWQsIDI2IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V1RGL0NoYW5nZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDhmMDNhNTguLjZjOGMw N2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjcgQEAKKzIwMTUtMDQtMTUgINCg0YPRgdC70LDQvSDQmNC20LHR g9C70LDRgtC+0LIgIDxscm4xOTg2QGdtYWlsLmNvbT4KKworICAgICAgICBbVzMyXSBDaGFuZ2Ug cHJpbnRmIGZvcm1hdCBhdHRyaWJ1dGUgdG8gZ251X3ByaW50ZiwgTWluR1cgY29tcGF0aWJpbGl0 eQorCisgICAgICAgICJwcmludGYiIG1lYW5zICJnbnVfcHJpbnRmIiB3aGVuIGNvbXBpbGluZyBm b3Igbm9uLVdpbmRvd3MgYW5kIG1lYW5zCisgICAgICAgICJtc19wcmludGYiIHdoZW4gY29tcGls aW5nIGZvciBXaW5kb3dzLiBUaGUgY29kZSwgaG93ZXZlciwgZG9lcyBzZWVtcyB0byBiZQorICAg ICAgICBhc3N1bWluZyBnbnVfcHJpbnRmIChqdWRnaW5nIGJ5IHRoZSB1c2Ugb2YgJXogYW5kICVs KS4KKworICAgICAgICBGaXggdGhpcyBieSBleHBsaWNpdGx5IHNwZWNpZnlpbmcgZ251X3ByaW50 ZiBmb3JtYXQgc3R5bGUuCisgICAgICAgIFRvIGVuc3VyZSB0aGF0IGdudS1jb21wYXRpYmxlIHBy aW50ZiBpbXBsZW1lbnRhdGlvbiBpcyB1c2VkLCBjb21waWxlCisgICAgICAgIHdpdGggLURfX1VT RV9NSU5HV19BTlNJX1NURElPPTEsIGl0IHdpbGwgYXV0b21hZ2ljYWxseSB0dXJuIGFsbCAqcHJp bnRmKCkKKyAgICAgICAgaW52b2NhdGlvbnMgaW50byBfX21pbmd3XypwcmludGYoKSwgd2hpY2gg YXJlIGdudS1jb21wYXRpYmxlLgorCisgICAgICAgIE9ubHkgb25lIGZ1bmN0aW9uIHRoYXQgd29u J3QgYmUgdHVybmVkIGlzIF92c25wcmludGYoKS4gSWZkZWYgaXRzIHVzZSBhbmQKKyAgICAgICAg Y2FsbCB2c25wcmludGYoKSBpbnN0ZWFkIHdoZW4gX19VU0VfTUlOR1dfQU5TSV9TVERJTyAhPSAw LgorCisgICAgICAgIFtHVEtdW1czMl0gV1RGIHRyaWVzIHRvIGluY2x1ZGUgbm9uLWV4aXN0ZW50 IFdURkhlYWRlckRldGVjdGlvbi5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDM3NTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIHd0Zi9Bc3NlcnRpb25zLmNwcDoKKyAgICAgICAgKiB3dGYvQXNzZXJ0 aW9ucy5oOgorCiAyMDE1LTAxLTIwICBZdW5RaWFuZyBTdSAgPHd6c3N5cWFAZ21haWwuY29tPgog CiAgICAgICAgIEZpeCBmYWlsZWQgdG8gYnVpbGQgZm9yIExpbnV4L01JUFM2NEVMCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0u aAppbmRleCBkOTE4YjQzLi4yZWJkZWVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0 Zm9ybS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKQEAgLTYxMSw3ICs2MTEsOSBA QAogI2RlZmluZSBIQVZFX0FMSUdORURfTUFMTE9DIDEKICNkZWZpbmUgSEFWRV9JU0RFQlVHR0VS UFJFU0VOVCAxCiAKKyNpZmRlZiBfTVNDX1ZFUgogI2luY2x1ZGUgPFdURi9XVEZIZWFkZXJEZXRl Y3Rpb24uaD4KKyNlbmRpZgogCiAjZW5kaWYKIAotLSAKMS44LjUuMw== 250796 2015-04-15 09:38:07 -0700 2015-04-15 09:49:01 -0700 Don't include non-existing WTF/WTFHeaderDetection.h in 2.4.x Dont-include-non-existing-WTFWTFHeaderDetectionh-i.patch text/plain 1728 lrn1986 RnJvbSBkOTEwYWUzYzc5NWFlZDM0ZTNhMWM1MzhiNGRiNzJkZDliM2JmNmE3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/PUQwPUEwPUQxPTgzPUQxPTgxPUQwPUJCPUQw PUIwPUQwPUJEPTIwPUQwPTk4PUQwPUI2PUQwPUIxPz0KID0/VVRGLTg/cT89RDE9ODM9RDA9QkI9 RDA9QjA9RDE9ODI9RDA9QkU9RDA9QjI/PSA8bHJuMTk4NkBnbWFpbC5jb20+CkRhdGU6IE1vbiwg MTMgQXByIDIwMTUgMDA6Mjk6MjEgKzAwMDAKU3ViamVjdDogW1BBVENIXSBEb24ndCBpbmNsdWRl IG5vbi1leGlzdGluZyBXVEYvV1RGSGVhZGVyRGV0ZWN0aW9uLmggaW4gMi40LngKCldURi9XVEZI ZWFkZXJEZXRlY3Rpb24uaCBzZWVtcyB0byBiZSBmcm9tIHNvbWUgb3RoZXIgdW5pdmVyc2UsCnRo ZXJlIGFyZSBubyBydWxlcyB0byBnZW5lcmF0ZSBpdCBpbiB3ZWJraXQtMi40LCBleGNlcHQgZm9y IE1TVlMgcHJvamVjdHMuCgpodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTQzNzUzCi0tLQogU291cmNlL1dURi9DaGFuZ2VMb2cgICAgICB8IDE0ICsrKysrKysrKysrKysr CiBTb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oIHwgIDIgKysKIDIgZmlsZXMgY2hhbmdlZCwgMTYg aW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNl L1dURi9DaGFuZ2VMb2cKaW5kZXggOGYwM2E1OC4uNjM2YThkNCAxMDA2NDQKLS0tIGEvU291cmNl L1dURi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBA QAorMjAxNS0wNC0xNSAg0KDRg9GB0LvQsNC9INCY0LbQsdGD0LvQsNGC0L7QsiAgPGxybjE5ODZA Z21haWwuY29tPgorCisgICAgICAgIERvbid0IGluY2x1ZGUgbm9uLWV4aXN0aW5nIFdURi9XVEZI ZWFkZXJEZXRlY3Rpb24uaCBpbiAyLjQueAorCisgICAgICAgIFdURi9XVEZIZWFkZXJEZXRlY3Rp b24uaCBzZWVtcyB0byBiZSBmcm9tIHNvbWUgb3RoZXIgdW5pdmVyc2UsCisgICAgICAgIHRoZXJl IGFyZSBubyBydWxlcyB0byBnZW5lcmF0ZSBpdCBpbiB3ZWJraXQtMi40LCBleGNlcHQgZm9yIE1T VlMgcHJvamVjdHMuCisKKyAgICAgICAgW0dUS11bVzMyXSBXVEYgdHJpZXMgdG8gaW5jbHVkZSBu b24tZXhpc3RlbnQgV1RGSGVhZGVyRGV0ZWN0aW9uLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0Mzc1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6CisKIDIwMTUtMDEtMjAg IFl1blFpYW5nIFN1ICA8d3pzc3lxYUBnbWFpbC5jb20+CiAKICAgICAgICAgRml4IGZhaWxlZCB0 byBidWlsZCBmb3IgTGludXgvTUlQUzY0RUwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1Bs YXRmb3JtLmggYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCmluZGV4IGQ5MThiNDMuLjJlYmRl ZWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKKysrIGIvU291cmNlL1dU Ri93dGYvUGxhdGZvcm0uaApAQCAtNjExLDcgKzYxMSw5IEBACiAjZGVmaW5lIEhBVkVfQUxJR05F RF9NQUxMT0MgMQogI2RlZmluZSBIQVZFX0lTREVCVUdHRVJQUkVTRU5UIDEKIAorI2lmZGVmIF9N U0NfVkVSCiAjaW5jbHVkZSA8V1RGL1dURkhlYWRlckRldGVjdGlvbi5oPgorI2VuZGlmCiAKICNl bmRpZgogCi0tIAoxLjguNS4z