143750 2015-04-15 01:44:47 -0700 Use UNUSED_PARAM instead of the void casting to suppress unused parameter warnings 2015-04-16 18:26:16 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sungmann.cho webkit-unassigned commit-queue darin gyuyoung.kim ossy oldest_to_newest 1085426 0 sungmann.cho 2015-04-15 01:44:47 -0700 Use UNUSED_PARAM instead of the void casting. 1085427 1 250780 sungmann.cho 2015-04-15 01:45:47 -0700 Created attachment 250780 Patch 1085429 2 250781 sungmann.cho 2015-04-15 01:56:57 -0700 Created attachment 250781 Patch 1085473 3 250781 ossy 2015-04-15 08:04:16 -0700 Comment on attachment 250781 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250781&action=review > Source/WebKit2/WebProcess/Notifications/NotificationPermissionRequestManager.cpp:65 > + UNUSED_PARAM(page); Using UNUSED_PARAM(page) unconditionally is incorrect, it should be in the #else case of ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS) 1085485 4 250791 sungmann.cho 2015-04-15 08:44:00 -0700 Created attachment 250791 Patch 1085489 5 sungmann.cho 2015-04-15 08:54:08 -0700 Thank you for pointing that out. I updated the patch. Please take a look. Thanks! 1085490 6 250791 gyuyoung.kim 2015-04-15 08:59:10 -0700 Comment on attachment 250791 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250791&action=review > Source/WebKit2/WebProcess/Notifications/NotificationPermissionRequestManager.cpp:65 > +#if !ENABLE(NOTIFICATIONS) && !ENABLE(LEGACY_NOTIFICATIONS) I don't like to use unnecessary macro. Probably it looks Ossy wants to use a thing similar to below style. NotificationPermissionRequestManager::NotificationPermissionRequestManager(WebPage* page) { #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS) m_page = page; #else UNUSED_PARAM(page); #endif } 1085491 7 250791 ossy 2015-04-15 09:00:11 -0700 Comment on attachment 250791 Patch Ouch, it's so ugly. :-/ Unfortunately we can't put UNUSED_PARAM to the same place as init list. I think this one would be the least ugly solution NotificationPermissionRequestManager::NotificationPermissionRequestManager(WebPage* page) { #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS) m_page = page #else UNUSED_PARAM(page); #endif } 1085492 8 ossy 2015-04-15 09:01:38 -0700 (In reply to comment #6) > Comment on attachment 250791 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=250791&action=review > > > Source/WebKit2/WebProcess/Notifications/NotificationPermissionRequestManager.cpp:65 > > +#if !ENABLE(NOTIFICATIONS) && !ENABLE(LEGACY_NOTIFICATIONS) > > I don't like to use unnecessary macro. Probably it looks Ossy wants to use a > thing similar to below style. > > NotificationPermissionRequestManager:: > NotificationPermissionRequestManager(WebPage* page) > { > #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS) > m_page = page; > #else > UNUSED_PARAM(page); > #endif > } haha, you must be a thought-reader :) 1085493 9 gyuyoung.kim 2015-04-15 09:03:26 -0700 (In reply to comment #8) > (In reply to comment #6) > > Comment on attachment 250791 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=250791&action=review > > > > > Source/WebKit2/WebProcess/Notifications/NotificationPermissionRequestManager.cpp:65 > > > +#if !ENABLE(NOTIFICATIONS) && !ENABLE(LEGACY_NOTIFICATIONS) > > > > I don't like to use unnecessary macro. Probably it looks Ossy wants to use a > > thing similar to below style. > > > > NotificationPermissionRequestManager:: > > NotificationPermissionRequestManager(WebPage* page) > > { > > #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS) > > m_page = page; > > #else > > UNUSED_PARAM(page); > > #endif > > } > > haha, you must be a thought-reader :) Because you and I have dealt with similar issues many times. :) 1085501 10 sungmann.cho 2015-04-15 09:22:57 -0700 (In reply to comment #7) > Comment on attachment 250791 [details] > Patch > > Ouch, it's so ugly. :-/ Unfortunately we can't put UNUSED_PARAM to the same > place as init list. > > I think this one would be the least ugly solution > > NotificationPermissionRequestManager:: > NotificationPermissionRequestManager(WebPage* page) > { > #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS) > m_page = page > #else > UNUSED_PARAM(page); > #endif > } Agreed. But the member initialization is slightly different from the assignment. Any thoughts on this? 1085508 11 250795 sungmann.cho 2015-04-15 09:34:32 -0700 Created attachment 250795 Patch 1085540 12 gyuyoung.kim 2015-04-15 09:56:31 -0700 (In reply to comment #10) > (In reply to comment #7) > > Comment on attachment 250791 [details] > > Patch > > > > Ouch, it's so ugly. :-/ Unfortunately we can't put UNUSED_PARAM to the same > > place as init list. > > > > I think this one would be the least ugly solution > > > > NotificationPermissionRequestManager:: > > NotificationPermissionRequestManager(WebPage* page) > > { > > #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS) > > m_page = page > > #else > > UNUSED_PARAM(page); > > #endif > > } > > Agreed. But the member initialization is slightly different from the > assignment. > Any thoughts on this? I think biggest difference is generally that copy constructor of *WebPage* class is called or not. In this case, however, m_page is a pointer type of *WebPage*. Thus it seems to me that there is no big difference between both. 1085608 13 sungmann.cho 2015-04-15 11:36:11 -0700 Addressed your comments.(In reply to comment #12) > (In reply to comment #10) > > (In reply to comment #7) > > > Comment on attachment 250791 [details] > > > Patch > > > > > > Ouch, it's so ugly. :-/ Unfortunately we can't put UNUSED_PARAM to the same > > > place as init list. > > > > > > I think this one would be the least ugly solution > > > > > > NotificationPermissionRequestManager:: > > > NotificationPermissionRequestManager(WebPage* page) > > > { > > > #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS) > > > m_page = page > > > #else > > > UNUSED_PARAM(page); > > > #endif > > > } > > > > Agreed. But the member initialization is slightly different from the > > assignment. > > Any thoughts on this? > > I think biggest difference is generally that copy constructor of *WebPage* > class is called or not. In this case, however, m_page is a pointer type of > *WebPage*. Thus it seems to me that there is no big difference between both. (In reply to comment #12) > (In reply to comment #10) > > (In reply to comment #7) > > > Comment on attachment 250791 [details] > > > Patch > > > > > > Ouch, it's so ugly. :-/ Unfortunately we can't put UNUSED_PARAM to the same > > > place as init list. > > > > > > I think this one would be the least ugly solution > > > > > > NotificationPermissionRequestManager:: > > > NotificationPermissionRequestManager(WebPage* page) > > > { > > > #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS) > > > m_page = page > > > #else > > > UNUSED_PARAM(page); > > > #endif > > > } > > > > Agreed. But the member initialization is slightly different from the > > assignment. > > Any thoughts on this? > > I think biggest difference is generally that copy constructor of *WebPage* > class is called or not. In this case, however, m_page is a pointer type of > *WebPage*. Thus it seems to me that there is no big difference between both. I addressed your comments. Thanks! 1085948 14 250795 darin 2015-04-16 09:41:11 -0700 Comment on attachment 250795 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250795&action=review I’m OK with this as is, but it doesn’t really seem like much of an improvement. > Source/WebKit2/WebProcess/Notifications/NotificationPermissionRequestManager.cpp:67 > NotificationPermissionRequestManager::NotificationPermissionRequestManager(WebPage* page) > +{ > #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS) > - : m_page(page) > + m_page = page; > +#else > + UNUSED_PARAM(page); > #endif > -{ > - (void)page; > } I don’t really like the way this changes from initialization syntax to assignment syntax. I’d prefer to avoid both UNUSED_PARAM and (void) myself by just repeating the function twice: #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS) NotificationPermissionRequestManager::NotificationPermissionRequestManager(WebPage* page) : m_page(page) { } #else NotificationPermissionRequestManager::NotificationPermissionRequestManager(WebPage*) { } #endif One nice thing about that is that it clears the way for further refinement, for example, we could make the empty constructor inline by putting it in the header and marking it inline without making the non-empty constructor be inlined. 1086190 15 250982 sungmann.cho 2015-04-16 17:30:33 -0700 Created attachment 250982 Patch 1086193 16 250982 sungmann.cho 2015-04-16 17:34:46 -0700 Comment on attachment 250982 Patch Address Darin's comments 1086212 17 250982 commit-queue 2015-04-16 18:26:11 -0700 Comment on attachment 250982 Patch Clearing flags on attachment: 250982 Committed r182936: <http://trac.webkit.org/changeset/182936> 1086213 18 commit-queue 2015-04-16 18:26:16 -0700 All reviewed patches have been landed. Closing bug. 250780 2015-04-15 01:45:47 -0700 2015-04-15 01:56:51 -0700 Patch bug-143750-20150415174450.patch text/plain 1445 sungmann.cho U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyODMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggN2Q4ZmRmYTc0MzhhZmQ0 ZGI5ZmE0ODQ3NWNkN2QxYTEzNDAxNzg1OS4uOWFiZjcwMzcwNjgyYzFkMDM0YWU4NWExYWM3ZWNh OWFhM2I3MDcyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA0LTE1ICBTdW5n bWFubiBDaG8gIDxzdW5nbWFubi5jaG9AbmF2ZXJjb3JwLmNvbT4KKworICAgICAgICBVc2UgVU5V U0VEX1BBUkFNIGluc3RlYWQgb2YgdGhlIHZvaWQgY2FzdGluZworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzNzUwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBj aGFuZ2UuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL05vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9u UGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Tm90aWZpY2F0 aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyOjpOb3RpZmljYXRpb25QZXJtaXNzaW9uUmVxdWVz dE1hbmFnZXIpOgorCiAyMDE1LTA0LTE0ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBw bGUuY29tPgogCiAgICAgICAgIFVwZGF0ZSBnZXN0dXJlIHN3aXBlIHNoYWRvdyBzdHlsZQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Ob3RpZmljYXRpb25zL05vdGlmaWNh dGlvblBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL05vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyLmNw cAppbmRleCAyYWIyZmZhN2Q1YzMxOGQ3MzE2Nzk3YWQxYmMyNTBhYzQ2ODEzNzk2Li43NDZhNDJk OTc0OTU0Y2YwZDU0MjEzZjZjMjMwOTQzZDUxODY1YWZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL05vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVl c3RNYW5hZ2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05vdGlmaWNhdGlv bnMvTm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyLmNwcApAQCAtNjIsNyArNjIs NyBAQCBOb3RpZmljYXRpb25QZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXI6Ok5vdGlmaWNhdGlvblBl cm1pc3Npb25SZXF1ZXN0TWFuYWdlcihXZWJQYQogICAgIDogbV9wYWdlKHBhZ2UpCiAjZW5kaWYK IHsKLSAgICAodm9pZClwYWdlOworICAgIFVOVVNFRF9QQVJBTShwYWdlKTsKIH0KIAogI2lmIEVO QUJMRShOT1RJRklDQVRJT05TKQo= 250781 2015-04-15 01:56:57 -0700 2015-04-15 08:43:44 -0700 Patch bug-143750-20150415175600.patch text/plain 1484 sungmann.cho U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyODMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggN2Q4ZmRmYTc0MzhhZmQ0 ZGI5ZmE0ODQ3NWNkN2QxYTEzNDAxNzg1OS4uYTM2N2FkYjA3MjNhZWY5YTY4ZWJmNzc3ZjMzMDZk MmRhNTRjZWI5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA0LTE1ICBTdW5n bWFubiBDaG8gIDxzdW5nbWFubi5jaG9AbmF2ZXJjb3JwLmNvbT4KKworICAgICAgICBVc2UgVU5V U0VEX1BBUkFNIGluc3RlYWQgb2YgdGhlIHZvaWQgY2FzdGluZyB0byBzdXBwcmVzcyB1bnVzZWQg cGFyYW1ldGVyIHdhcm5pbmdzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQzNzUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAg KiBXZWJQcm9jZXNzL05vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RN YW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Tm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVl c3RNYW5hZ2VyOjpOb3RpZmljYXRpb25QZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXIpOgorCiAyMDE1 LTA0LTE0ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAg IFVwZGF0ZSBnZXN0dXJlIHN3aXBlIHNoYWRvdyBzdHlsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9Ob3RpZmljYXRpb25zL05vdGlmaWNhdGlvblBlcm1pc3Npb25SZXF1 ZXN0TWFuYWdlci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05vdGlmaWNhdGlvbnMv Tm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyLmNwcAppbmRleCAyYWIyZmZhN2Q1 YzMxOGQ3MzE2Nzk3YWQxYmMyNTBhYzQ2ODEzNzk2Li43NDZhNDJkOTc0OTU0Y2YwZDU0MjEzZjZj MjMwOTQzZDUxODY1YWZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05v dGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uUGVy bWlzc2lvblJlcXVlc3RNYW5hZ2VyLmNwcApAQCAtNjIsNyArNjIsNyBAQCBOb3RpZmljYXRpb25Q ZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXI6Ok5vdGlmaWNhdGlvblBlcm1pc3Npb25SZXF1ZXN0TWFu YWdlcihXZWJQYQogICAgIDogbV9wYWdlKHBhZ2UpCiAjZW5kaWYKIHsKLSAgICAodm9pZClwYWdl OworICAgIFVOVVNFRF9QQVJBTShwYWdlKTsKIH0KIAogI2lmIEVOQUJMRShOT1RJRklDQVRJT05T KQo= 250791 2015-04-15 08:44:00 -0700 2015-04-15 09:34:24 -0700 Patch bug-143750-20150416004304.patch text/plain 1553 sungmann.cho U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyODMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggN2Q4ZmRmYTc0MzhhZmQ0 ZGI5ZmE0ODQ3NWNkN2QxYTEzNDAxNzg1OS4uYTM2N2FkYjA3MjNhZWY5YTY4ZWJmNzc3ZjMzMDZk MmRhNTRjZWI5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA0LTE1ICBTdW5n bWFubiBDaG8gIDxzdW5nbWFubi5jaG9AbmF2ZXJjb3JwLmNvbT4KKworICAgICAgICBVc2UgVU5V U0VEX1BBUkFNIGluc3RlYWQgb2YgdGhlIHZvaWQgY2FzdGluZyB0byBzdXBwcmVzcyB1bnVzZWQg cGFyYW1ldGVyIHdhcm5pbmdzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQzNzUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAg KiBXZWJQcm9jZXNzL05vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RN YW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Tm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVl c3RNYW5hZ2VyOjpOb3RpZmljYXRpb25QZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXIpOgorCiAyMDE1 LTA0LTE0ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAg IFVwZGF0ZSBnZXN0dXJlIHN3aXBlIHNoYWRvdyBzdHlsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9Ob3RpZmljYXRpb25zL05vdGlmaWNhdGlvblBlcm1pc3Npb25SZXF1 ZXN0TWFuYWdlci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05vdGlmaWNhdGlvbnMv Tm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyLmNwcAppbmRleCAyYWIyZmZhN2Q1 YzMxOGQ3MzE2Nzk3YWQxYmMyNTBhYzQ2ODEzNzk2Li5kMWFlNzU1MGQ3MmFiMTI2OGU0NDgyNGFj OWZiZGZhZGJlZWRjODY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05v dGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uUGVy bWlzc2lvblJlcXVlc3RNYW5hZ2VyLmNwcApAQCAtNjIsNyArNjIsOSBAQCBOb3RpZmljYXRpb25Q ZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXI6Ok5vdGlmaWNhdGlvblBlcm1pc3Npb25SZXF1ZXN0TWFu YWdlcihXZWJQYQogICAgIDogbV9wYWdlKHBhZ2UpCiAjZW5kaWYKIHsKLSAgICAodm9pZClwYWdl OworI2lmICFFTkFCTEUoTk9USUZJQ0FUSU9OUykgJiYgIUVOQUJMRShMRUdBQ1lfTk9USUZJQ0FU SU9OUykKKyAgICBVTlVTRURfUEFSQU0ocGFnZSk7CisjZW5kaWYKIH0KIAogI2lmIEVOQUJMRShO T1RJRklDQVRJT05TKQo= 250795 2015-04-15 09:34:32 -0700 2015-04-16 17:30:24 -0700 Patch bug-143750-20150416013334.patch text/plain 1671 sungmann.cho U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyODMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggN2Q4ZmRmYTc0MzhhZmQ0 ZGI5ZmE0ODQ3NWNkN2QxYTEzNDAxNzg1OS4uYTM2N2FkYjA3MjNhZWY5YTY4ZWJmNzc3ZjMzMDZk MmRhNTRjZWI5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA0LTE1ICBTdW5n bWFubiBDaG8gIDxzdW5nbWFubi5jaG9AbmF2ZXJjb3JwLmNvbT4KKworICAgICAgICBVc2UgVU5V U0VEX1BBUkFNIGluc3RlYWQgb2YgdGhlIHZvaWQgY2FzdGluZyB0byBzdXBwcmVzcyB1bnVzZWQg cGFyYW1ldGVyIHdhcm5pbmdzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQzNzUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAg KiBXZWJQcm9jZXNzL05vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RN YW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Tm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVl c3RNYW5hZ2VyOjpOb3RpZmljYXRpb25QZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXIpOgorCiAyMDE1 LTA0LTE0ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAg IFVwZGF0ZSBnZXN0dXJlIHN3aXBlIHNoYWRvdyBzdHlsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9Ob3RpZmljYXRpb25zL05vdGlmaWNhdGlvblBlcm1pc3Npb25SZXF1 ZXN0TWFuYWdlci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05vdGlmaWNhdGlvbnMv Tm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyLmNwcAppbmRleCAyYWIyZmZhN2Q1 YzMxOGQ3MzE2Nzk3YWQxYmMyNTBhYzQ2ODEzNzk2Li5mMmE1MGE4MzBiYjQ3NWRhNGRhM2YyYWQx MmFjZjVmYjBmNDA1MTY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05v dGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uUGVy bWlzc2lvblJlcXVlc3RNYW5hZ2VyLmNwcApAQCAtNTgsMTEgKzU4LDEyIEBAIFBhc3NSZWZQdHI8 Tm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyPiBOb3RpZmljYXRpb25QZXJtaXNz aW9uUmVxdWVzdE1hCiB9CiAKIE5vdGlmaWNhdGlvblBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlcjo6 Tm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyKFdlYlBhZ2UqIHBhZ2UpCit7CiAj aWYgRU5BQkxFKE5PVElGSUNBVElPTlMpIHx8IEVOQUJMRShMRUdBQ1lfTk9USUZJQ0FUSU9OUykK LSAgICA6IG1fcGFnZShwYWdlKQorICAgIG1fcGFnZSA9IHBhZ2U7CisjZWxzZQorICAgIFVOVVNF RF9QQVJBTShwYWdlKTsKICNlbmRpZgotewotICAgICh2b2lkKXBhZ2U7CiB9CiAKICNpZiBFTkFC TEUoTk9USUZJQ0FUSU9OUykK 250982 2015-04-16 17:30:33 -0700 2015-04-16 18:26:11 -0700 Patch bug-143750-20150417092935.patch text/plain 2018 sungmann.cho U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyODMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggN2Q4ZmRmYTc0MzhhZmQ0 ZGI5ZmE0ODQ3NWNkN2QxYTEzNDAxNzg1OS4uYmVjM2FiZGExYWZhNTdjOTUyOGI5ZDc1ZmIwMWU5 N2Q2MWQwMjUxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA0LTE2ICBTdW5n bWFubiBDaG8gIDxzdW5nbWFubi5jaG9AbmF2ZXJjb3JwLmNvbT4KKworICAgICAgICBVc2UgVU5V U0VEX1BBUkFNIGluc3RlYWQgb2YgdGhlIHZvaWQgY2FzdGluZyB0byBzdXBwcmVzcyB1bnVzZWQg cGFyYW1ldGVyIHdhcm5pbmdzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQzNzUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAg KiBXZWJQcm9jZXNzL05vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RN YW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Tm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVl c3RNYW5hZ2VyOjpOb3RpZmljYXRpb25QZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXIpOgorCiAyMDE1 LTA0LTE0ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAg IFVwZGF0ZSBnZXN0dXJlIHN3aXBlIHNoYWRvdyBzdHlsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9Ob3RpZmljYXRpb25zL05vdGlmaWNhdGlvblBlcm1pc3Npb25SZXF1 ZXN0TWFuYWdlci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05vdGlmaWNhdGlvbnMv Tm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyLmNwcAppbmRleCAyYWIyZmZhN2Q1 YzMxOGQ3MzE2Nzk3YWQxYmMyNTBhYzQ2ODEzNzk2Li5jNDc5NTAyNmYyZmIyNTMzMTNmOGMyZjYx YTk0ZDhkYzBhMzQyY2E4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05v dGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uUGVy bWlzc2lvblJlcXVlc3RNYW5hZ2VyLmNwcApAQCAtNTcsMTMgKzU3LDE2IEBAIFBhc3NSZWZQdHI8 Tm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyPiBOb3RpZmljYXRpb25QZXJtaXNz aW9uUmVxdWVzdE1hCiAgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBOb3RpZmljYXRpb25QZXJtaXNz aW9uUmVxdWVzdE1hbmFnZXIocGFnZSkpOwogfQogCi1Ob3RpZmljYXRpb25QZXJtaXNzaW9uUmVx dWVzdE1hbmFnZXI6Ok5vdGlmaWNhdGlvblBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlcihXZWJQYWdl KiBwYWdlKQogI2lmIEVOQUJMRShOT1RJRklDQVRJT05TKSB8fCBFTkFCTEUoTEVHQUNZX05PVElG SUNBVElPTlMpCitOb3RpZmljYXRpb25QZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXI6Ok5vdGlmaWNh dGlvblBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlcihXZWJQYWdlKiBwYWdlKQogICAgIDogbV9wYWdl KHBhZ2UpCi0jZW5kaWYKIHsKLSAgICAodm9pZClwYWdlOwogfQorI2Vsc2UKK05vdGlmaWNhdGlv blBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlcjo6Tm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RN YW5hZ2VyKFdlYlBhZ2UqKQoreworfQorI2VuZGlmCiAKICNpZiBFTkFCTEUoTk9USUZJQ0FUSU9O UykKIHZvaWQgTm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyOjpzdGFydFJlcXVl c3QoU2VjdXJpdHlPcmlnaW4qIG9yaWdpbiwgUGFzc1JlZlB0cjxOb3RpZmljYXRpb25QZXJtaXNz aW9uQ2FsbGJhY2s+IGNhbGxiYWNrKQo=