143747 2015-04-14 18:25:07 -0700 JavaScriptCore: Use kCFAllocatorDefault where possible 2015-04-15 10:56:52 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck ap commit-queue ggaren joepeck mitz oldest_to_newest 1085373 0 joepeck 2015-04-14 18:25:07 -0700 * SUMMARY Use kCFAllocatorDefault instead of NULL/0/nullptr where possible. This came up as a review comment for one of my changes. There are only a few in JSC, the other frameworks can be addressed separately later. 1085374 1 250771 joepeck 2015-04-14 18:26:27 -0700 Created attachment 250771 [PATCH] Proposed Fix 1085379 2 ap 2015-04-14 18:42:25 -0700 I'm curious what the rationale is. Isn't 0 slightly faster? 1085380 3 joepeck 2015-04-14 18:50:18 -0700 (In reply to comment #2) > I'm curious what the rationale is. Isn't 0 slightly faster? My rationale was "consistency and readability". In cases where the first parameter is an allocator, then specifying kCFAllocatorDefault removes any ambiguity that may exist if "0" or "nullptr" was used for the first argument. That said, I don't really have strong opinions on this. It was brought up in a review on one of my patches. 1085550 4 250771 darin 2015-04-15 10:08:11 -0700 Comment on attachment 250771 [PATCH] Proposed Fix This is the clearest and most correct way to write it, but oh so wordy. In my non-WebKit code I almost always used NULL for this. 1085588 5 250771 commit-queue 2015-04-15 10:56:49 -0700 Comment on attachment 250771 [PATCH] Proposed Fix Clearing flags on attachment: 250771 Committed r182847: <http://trac.webkit.org/changeset/182847> 1085589 6 commit-queue 2015-04-15 10:56:52 -0700 All reviewed patches have been landed. Closing bug. 250771 2015-04-14 18:26:27 -0700 2015-04-15 10:56:49 -0700 [PATCH] Proposed Fix allocator.patch text/plain 3486 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGExNjA5NDguLjg0MWEyOWYzIDEwMDY0NAotLS0g YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMCBAQAogMjAxNS0wNC0xNCAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCisgICAgICAgIEphdmFTY3JpcHRDb3JlOiBVc2Ug a0NGQWxsb2NhdG9yRGVmYXVsdCB3aGVyZSBwb3NzaWJsZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzNzQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBoZWFwL0hlYXBUaW1lci5jcHA6CisgICAgICAg IChKU0M6OkhlYXBUaW1lcjo6SGVhcFRpbWVyKToKKyAgICAgICAgKiBpbnNwZWN0b3IvcmVtb3Rl L1JlbW90ZUluc3BlY3RvckRlYnVnZ2FibGVDb25uZWN0aW9uLm1tOgorICAgICAgICAoSW5zcGVj dG9yOjpSZW1vdGVJbnNwZWN0b3JJbml0aWFsaXplR2xvYmFsUXVldWUpOgorICAgICAgICAoSW5z cGVjdG9yOjpSZW1vdGVJbnNwZWN0b3JEZWJ1Z2dhYmxlQ29ubmVjdGlvbjo6c2V0dXBSdW5Mb29w KToKKyAgICAgICAgRm9yIGNvbnNpc3RlbmN5IGFuZCByZWFkYWJpbGl0eSB1c2UgdGhlIGNvbnN0 YW50IGluc3RlYWQgb2YKKyAgICAgICAgZGlmZmVyZW50IHJlcHJlc2VudGF0aW9ucyBvZiBudWxs LgorCisyMDE1LTA0LTE0ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisK ICAgICAgICAgUHJvdmlkZSBTUEkgdG8gYWxsb3cgY2hhbmdpbmcgd2hldGhlciBKU0NvbnRleHRz IGFyZSByZW1vdGUgZGVidWdnYWJsZSBieSBkZWZhdWx0CiAgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDM2ODEKIApkaWZmIC0tZ2l0IGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2hlYXAvSGVhcFRpbWVyLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9o ZWFwL0hlYXBUaW1lci5jcHAKaW5kZXggNWFhMzM5OS4uMTVlNTQ4NCAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcFRpbWVyLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvaGVhcC9IZWFwVGltZXIuY3BwCkBAIC02Myw3ICs2Myw3IEBAIEhlYXBUaW1lcjo6 SGVhcFRpbWVyKFZNKiB2bSwgQ0ZSdW5Mb29wUmVmIHJ1bkxvb3ApCiAgICAgbV9jb250ZXh0Lmlu Zm8gPSAmdm0tPmFwaUxvY2soKTsKICAgICBtX2NvbnRleHQucmV0YWluID0gcmV0YWluQVBJTG9j azsKICAgICBtX2NvbnRleHQucmVsZWFzZSA9IHJlbGVhc2VBUElMb2NrOwotICAgIG1fdGltZXIg PSBhZG9wdENGKENGUnVuTG9vcFRpbWVyQ3JlYXRlKDAsIHNfZGVjYWRlLCBzX2RlY2FkZSwgMCwg MCwgSGVhcFRpbWVyOjp0aW1lckRpZEZpcmUsICZtX2NvbnRleHQpKTsKKyAgICBtX3RpbWVyID0g YWRvcHRDRihDRlJ1bkxvb3BUaW1lckNyZWF0ZShrQ0ZBbGxvY2F0b3JEZWZhdWx0LCBzX2RlY2Fk ZSwgc19kZWNhZGUsIDAsIDAsIEhlYXBUaW1lcjo6dGltZXJEaWRGaXJlLCAmbV9jb250ZXh0KSk7 CiAgICAgQ0ZSdW5Mb29wQWRkVGltZXIobV9ydW5Mb29wLmdldCgpLCBtX3RpbWVyLmdldCgpLCBr Q0ZSdW5Mb29wQ29tbW9uTW9kZXMpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvaW5zcGVjdG9yL3JlbW90ZS9SZW1vdGVJbnNwZWN0b3JEZWJ1Z2dhYmxlQ29ubmVjdGlv bi5tbSBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL1JlbW90ZUluc3Bl Y3RvckRlYnVnZ2FibGVDb25uZWN0aW9uLm1tCmluZGV4IDVjMzZjOTAuLmEyNGQ1NGQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL1JlbW90ZUluc3Bl Y3RvckRlYnVnZ2FibGVDb25uZWN0aW9uLm1tCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9p bnNwZWN0b3IvcmVtb3RlL1JlbW90ZUluc3BlY3RvckRlYnVnZ2FibGVDb25uZWN0aW9uLm1tCkBA IC04NCw3ICs4NCw3IEBAIHN0YXRpYyB2b2lkIFJlbW90ZUluc3BlY3RvckluaXRpYWxpemVHbG9i YWxRdWV1ZSgpCiAgICAgICAgIHJ3aVF1ZXVlTXV0ZXggPSBzdGQ6Om1ha2VfdW5pcXVlPHN0ZDo6 bXV0ZXg+KCkucmVsZWFzZSgpOwogCiAgICAgICAgIENGUnVuTG9vcFNvdXJjZUNvbnRleHQgcnVu TG9vcFNvdXJjZUNvbnRleHQgPSB7MCwgbnVsbHB0ciwgbnVsbHB0ciwgbnVsbHB0ciwgbnVsbHB0 ciwgbnVsbHB0ciwgbnVsbHB0ciwgbnVsbHB0ciwgbnVsbHB0ciwgUmVtb3RlSW5zcGVjdG9ySGFu ZGxlUnVuU291cmNlR2xvYmFsfTsKLSAgICAgICAgcndpUnVuTG9vcFNvdXJjZSA9IENGUnVuTG9v cFNvdXJjZUNyZWF0ZShudWxscHRyLCAxLCAmcnVuTG9vcFNvdXJjZUNvbnRleHQpOworICAgICAg ICByd2lSdW5Mb29wU291cmNlID0gQ0ZSdW5Mb29wU291cmNlQ3JlYXRlKGtDRkFsbG9jYXRvckRl ZmF1bHQsIDEsICZydW5Mb29wU291cmNlQ29udGV4dCk7CiAKICAgICAgICAgLy8gQWRkIHRvIHRo ZSBkZWZhdWx0IHJ1biBsb29wIG1vZGUgZm9yIGRlZmF1bHQgaGFuZGxpbmcsIGFuZCB0aGUgSlND b250ZXh0IHJlbW90ZSBpbnNwZWN0b3IgcnVuIGxvb3AgbW9kZSB3aGVuIHBhdXNlZC4KICAgICAg ICAgQ0ZSdW5Mb29wQWRkU291cmNlKENGUnVuTG9vcEdldE1haW4oKSwgcndpUnVuTG9vcFNvdXJj ZSwga0NGUnVuTG9vcERlZmF1bHRNb2RlKTsKQEAgLTIzNyw3ICsyMzcsNyBAQCB2b2lkIFJlbW90 ZUluc3BlY3RvckRlYnVnZ2FibGVDb25uZWN0aW9uOjpzZXR1cFJ1bkxvb3AoKQogICAgIG1fcnVu TG9vcCA9IGRlYnVnZ2VyUnVuTG9vcDsKIAogICAgIENGUnVuTG9vcFNvdXJjZUNvbnRleHQgcnVu TG9vcFNvdXJjZUNvbnRleHQgPSB7MCwgdGhpcywgbnVsbHB0ciwgbnVsbHB0ciwgbnVsbHB0ciwg bnVsbHB0ciwgbnVsbHB0ciwgbnVsbHB0ciwgbnVsbHB0ciwgUmVtb3RlSW5zcGVjdG9ySGFuZGxl UnVuU291cmNlV2l0aEluZm99OwotICAgIG1fcnVuTG9vcFNvdXJjZSA9IGFkb3B0Q0YoQ0ZSdW5M b29wU291cmNlQ3JlYXRlKG51bGxwdHIsIDEsICZydW5Mb29wU291cmNlQ29udGV4dCkpOworICAg IG1fcnVuTG9vcFNvdXJjZSA9IGFkb3B0Q0YoQ0ZSdW5Mb29wU291cmNlQ3JlYXRlKGtDRkFsbG9j YXRvckRlZmF1bHQsIDEsICZydW5Mb29wU291cmNlQ29udGV4dCkpOwogCiAgICAgQ0ZSdW5Mb29w QWRkU291cmNlKG1fcnVuTG9vcC5nZXQoKSwgbV9ydW5Mb29wU291cmNlLmdldCgpLCBrQ0ZSdW5M b29wRGVmYXVsdE1vZGUpOwogICAgIENGUnVuTG9vcEFkZFNvdXJjZShtX3J1bkxvb3AuZ2V0KCks IG1fcnVuTG9vcFNvdXJjZS5nZXQoKSwgRXZlbnRMb29wOjpyZW1vdGVJbnNwZWN0b3JSdW5Mb29w TW9kZSgpKTsK