143732 2015-04-14 15:19:40 -0700 Correct layering violation in DumpRenderTree Build 2015-04-14 16:48:58 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 143684 1 bfulgham bfulgham bfulgham simon.fraser oldest_to_newest 1085287 0 bfulgham 2015-04-14 15:19:40 -0700 In Bug 143286, I introduced a layering violation between DumpRenderTree and WebCore. Instead of accessing WebCore types directly, DRT needs to pass through the WebCoreTestSupport library to manipulate WebCore state. 1085303 1 250750 bfulgham 2015-04-14 16:02:24 -0700 Created attachment 250750 Patch 1085329 2 bfulgham 2015-04-14 16:48:58 -0700 Committed r182821: <http://trac.webkit.org/changeset/182821> 250750 2015-04-14 16:02:24 -0700 2015-04-14 16:22:55 -0700 Patch bug-143732-20150414160128.patch text/plain 5867 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MjgxNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA0LTE0ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIENvcnJlY3QgbGF5ZXJpbmcg dmlvbGF0aW9uIGluIER1bXBSZW5kZXJUcmVlIEJ1aWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDM3MzIKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHRlc3RpbmcvanMvV2ViQ29yZVRlc3RTdXBwb3J0 LmNwcDoKKyAgICAgICAgKFdlYkNvcmVUZXN0U3VwcG9ydDo6bW9uaXRvcldoZWVsRXZlbnRzKTog QWRkZWQuIFByb3ZpZGVzIGEgd3JhcHBlciBhcm91bmQKKyAgICAgICAgdGhlIGludGVybmFsIFdl YkNvcmUgb2JqZWN0cyBuZWVkZWQgdG8gaW1wbGVtZW50IHRoaXMgZnVuY3Rpb24uCisgICAgICAg IChXZWJDb3JlVGVzdFN1cHBvcnQ6OnNldFRlc3RDYWxsYmFja0FuZFN0YXJ0Tm90aWZpY2F0aW9u VGltZXIpOiBEaXR0by4KKyAgICAgICAgKiB0ZXN0aW5nL2pzL1dlYkNvcmVUZXN0U3VwcG9ydC5o OgorCiAyMDE1LTA0LTE0ICBCcmlhbiBXZWluc3RlaW4gIDxid2VpbnN0ZWluQGFwcGxlLmNvbT4K IAogICAgICAgICBBZGQgU1BJIHRvIGNsZWFyIEhTVFMgaG9zdHMgYWRkZWQgc2luY2UgYSBkYXRl LgpJbmRleDogU291cmNlL1dlYkNvcmUvdGVzdGluZy9qcy9XZWJDb3JlVGVzdFN1cHBvcnQuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvanMvV2ViQ29yZVRlc3RTdXBw b3J0LmNwcAkocmV2aXNpb24gMTgyNzk4KQorKysgU291cmNlL1dlYkNvcmUvdGVzdGluZy9qcy9X ZWJDb3JlVGVzdFN1cHBvcnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMSw3ICszMSwxMCBAQAog I2luY2x1ZGUgIkludGVybmFscy5oIgogI2luY2x1ZGUgIkpTRG9jdW1lbnQuaCIKICNpbmNsdWRl ICJKU0ludGVybmFscy5oIgorI2luY2x1ZGUgIk1haW5GcmFtZS5oIgorI2luY2x1ZGUgIldoZWVs RXZlbnRUZXN0VHJpZ2dlci5oIgogI2luY2x1ZGUgPEphdmFTY3JpcHRDb3JlL0FQSUNhc3QuaD4K KyNpbmNsdWRlIDxKYXZhU2NyaXB0Q29yZS9KU1ZhbHVlUmVmLmg+CiAjaW5jbHVkZSA8SmF2YVNj cmlwdENvcmUvUHJvZmlsZS5oPgogI2luY2x1ZGUgPGludGVycHJldGVyL0NhbGxGcmFtZS5oPgog I2luY2x1ZGUgPHJ1bnRpbWUvSWRlbnRpZmllcklubGluZXMuaD4KQEAgLTYyLDQgKzY1LDIwIEBA IHZvaWQgcmVzZXRJbnRlcm5hbHNPYmplY3QoSlNDb250ZXh0UmVmIGMKICAgICBJbnRlcm5hbFNl dHRpbmdzOjpmcm9tKHBhZ2UpLT5yZXNldFRvQ29uc2lzdGVudFN0YXRlKCk7CiB9CiAKK3ZvaWQg bW9uaXRvcldoZWVsRXZlbnRzKFdlYkNvcmU6OkZyYW1lJiBmcmFtZSkKK3sKKyAgICBmcmFtZS5t YWluRnJhbWUoKS5lbnN1cmVUZXN0VHJpZ2dlcigpOworfQorCit2b2lkIHNldFRlc3RDYWxsYmFj a0FuZFN0YXJ0Tm90aWZpY2F0aW9uVGltZXIoV2ViQ29yZTo6RnJhbWUmIGZyYW1lLCBKU0NvbnRl eHRSZWYgY29udGV4dCwgSlNPYmplY3RSZWYganNDYWxsYmFja0Z1bmN0aW9uKQoreworICAgIFdo ZWVsRXZlbnRUZXN0VHJpZ2dlciogdHJpZ2dlciA9IGZyYW1lLm1haW5GcmFtZSgpLmVuc3VyZVRl c3RUcmlnZ2VyKCk7CisgICAgSlNWYWx1ZVByb3RlY3QoY29udGV4dCwganNDYWxsYmFja0Z1bmN0 aW9uKTsKKyAgICAKKyAgICB0cmlnZ2VyLT5zZXRUZXN0Q2FsbGJhY2tBbmRTdGFydE5vdGlmaWNh dGlvblRpbWVyKFs9XSh2b2lkKSB7CisgICAgICAgIEpTT2JqZWN0Q2FsbEFzRnVuY3Rpb24oY29u dGV4dCwganNDYWxsYmFja0Z1bmN0aW9uLCBudWxscHRyLCAwLCBudWxscHRyLCBudWxscHRyKTsK KyAgICAgICAgSlNWYWx1ZVVucHJvdGVjdChjb250ZXh0LCBqc0NhbGxiYWNrRnVuY3Rpb24pOwor ICAgIH0pOworfQorCiB9CkluZGV4OiBTb3VyY2UvV2ViQ29yZS90ZXN0aW5nL2pzL1dlYkNvcmVU ZXN0U3VwcG9ydC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvanMvV2Vi Q29yZVRlc3RTdXBwb3J0LmgJKHJldmlzaW9uIDE4Mjc5OCkKKysrIFNvdXJjZS9XZWJDb3JlL3Rl c3RpbmcvanMvV2ViQ29yZVRlc3RTdXBwb3J0LmgJKHdvcmtpbmcgY29weSkKQEAgLTI3LDYgKzI3 LDcgQEAKICNkZWZpbmUgV2ViQ29yZVRlc3RTdXBwb3J0X2gKIAogdHlwZWRlZiBjb25zdCBzdHJ1 Y3QgT3BhcXVlSlNDb250ZXh0KiBKU0NvbnRleHRSZWY7Cit0eXBlZGVmIHN0cnVjdCBPcGFxdWVK U1ZhbHVlKiBKU09iamVjdFJlZjsKIAogI2lmIFBMQVRGT1JNKENPQ09BKQogI2RlZmluZSBURVNU X1NVUFBPUlRfRVhQT1JUIFdURl9FWFBPUlRfUFJJVkFURQpAQCAtMzQsMTAgKzM1LDE2IEBAIHR5 cGVkZWYgY29uc3Qgc3RydWN0IE9wYXF1ZUpTQ29udGV4dCogSlMKICNkZWZpbmUgVEVTVF9TVVBQ T1JUX0VYUE9SVAogI2VuZGlmCiAKK25hbWVzcGFjZSBXZWJDb3JlIHsKK2NsYXNzIEZyYW1lOwor fQorCiBuYW1lc3BhY2UgV2ViQ29yZVRlc3RTdXBwb3J0IHsKIAogdm9pZCBpbmplY3RJbnRlcm5h bHNPYmplY3QoSlNDb250ZXh0UmVmKSBURVNUX1NVUFBPUlRfRVhQT1JUOwogdm9pZCByZXNldElu dGVybmFsc09iamVjdChKU0NvbnRleHRSZWYpIFRFU1RfU1VQUE9SVF9FWFBPUlQ7Cit2b2lkIG1v bml0b3JXaGVlbEV2ZW50cyhXZWJDb3JlOjpGcmFtZSYpIFRFU1RfU1VQUE9SVF9FWFBPUlQ7Cit2 b2lkIHNldFRlc3RDYWxsYmFja0FuZFN0YXJ0Tm90aWZpY2F0aW9uVGltZXIoV2ViQ29yZTo6RnJh bWUmLCBKU0NvbnRleHRSZWYsIEpTT2JqZWN0UmVmKSBURVNUX1NVUFBPUlRfRVhQT1JUOwogCiB9 IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAKSW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MjgxNSkKKysrIFRvb2xzL0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE1LTA0LTE0ICBCcmVudCBGdWxn aGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIENvcnJlY3QgbGF5ZXJpbmcgdmlv bGF0aW9uIGluIER1bXBSZW5kZXJUcmVlIEJ1aWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDM3MzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBDb3JyZWN0IGEgbGF5ZXJpbmcgdmlvbGF0aW9uIGluIER1 bXBSZW5kZXJUcmVlIGJ5IGNhbGxpbmcgZnVuY3Rpb25zIG9uIHRoZQorICAgICAgICBXZWJDb3Jl VGVzdFN1cHBvcnQgbGlicmFyeSwgcmF0aGVyIHRoYW4gYXR0ZW1wdGluZyB0byB3b3JrIHdpdGgg V2ViQ29yZQorICAgICAgICB0eXBlcyBkaXJlY3RseS4KKworICAgICAgICAqIER1bXBSZW5kZXJU cmVlL21hYy9FdmVudFNlbmRpbmdDb250cm9sbGVyLm1tOgorICAgICAgICAoLVtFdmVudFNlbmRp bmdDb250cm9sbGVyIG1vbml0b3JXaGVlbEV2ZW50c10pOiBDYWxsIG1ldGhvZHMgb24gV2ViQ29y ZVRlc3RTdXBwb3J0LCByYXRoZXIKKyAgICAgICAgdGhhbiBXZWJDb3JlIGl0c2VsZi4sCisgICAg ICAgICgtW0V2ZW50U2VuZGluZ0NvbnRyb2xsZXIgY2FsbEFmdGVyU2Nyb2xsaW5nQ29tcGxldGVz Ol0pOiBEaXR0by4KKwogMjAxNS0wNC0xNCAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdl YmtpdC5vcmc+CiAKICAgICAgICAgQWRkIGEgY29uc2VydmF0aXZlIERGQSBtaW5pbWl6ZXIgZm9y IHRoZSBjb250ZW50IGV4dGVuc2lvbiBtYXRjaGVyCkluZGV4OiBUb29scy9EdW1wUmVuZGVyVHJl ZS9tYWMvRXZlbnRTZW5kaW5nQ29udHJvbGxlci5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9EdW1w UmVuZGVyVHJlZS9tYWMvRXZlbnRTZW5kaW5nQ29udHJvbGxlci5tbQkocmV2aXNpb24gMTgyNzk4 KQorKysgVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0V2ZW50U2VuZGluZ0NvbnRyb2xsZXIubW0J KHdvcmtpbmcgY29weSkKQEAgLTM1LDYgKzM1LDcgQEAKICNpbXBvcnQgIkR1bXBSZW5kZXJUcmVl LmgiCiAjaW1wb3J0ICJEdW1wUmVuZGVyVHJlZURyYWdnaW5nSW5mby5oIgogI2ltcG9ydCAiRHVt cFJlbmRlclRyZWVGaWxlRHJhZ2dpbmdTb3VyY2UuaCIKKyNpbXBvcnQgIldlYkNvcmVUZXN0U3Vw cG9ydC5oIgogI2ltcG9ydCA8V2ViS2l0L0RPTVByaXZhdGUuaD4KICNpbXBvcnQgPFdlYktpdC9X ZWJLaXQuaD4KICNpbXBvcnQgPFdlYktpdC9XZWJWaWV3UHJpdmF0ZS5oPgpAQCAtNDIsMTAgKzQz LDYgQEAKIAogI2lmICFQTEFURk9STShJT1MpCiAjaW1wb3J0IDxDYXJib24vQ2FyYm9uLmg+IC8v IGZvciBHZXRDdXJyZW50RXZlbnRUaW1lKCkKLSNpbXBvcnQgPEphdmFTY3JpcHRDb3JlL0pTUmV0 YWluUHRyLmg+Ci0jaW1wb3J0IDxXZWJDb3JlL01haW5GcmFtZS5oPgotI2ltcG9ydCA8V2ViQ29y ZS9QYWdlLmg+Ci0jaW1wb3J0IDxXZWJDb3JlL1doZWVsRXZlbnRUZXN0VHJpZ2dlci5oPgogI2Vu ZGlmCiAKICNpZiBQTEFURk9STShJT1MpCkBAIC0xMjY3LDggKzEyNjQsOCBAQCAtICh2b2lkKW1v bml0b3JXaGVlbEV2ZW50cwogICAgIFdlYkNvcmU6OkZyYW1lKiBmcmFtZSA9IFtbbWFpbkZyYW1l IHdlYlZpZXddIF9tYWluQ29yZUZyYW1lXTsKICAgICBpZiAoIWZyYW1lKQogICAgICAgICByZXR1 cm47Ci0gICAgCi0gICAgZnJhbWUtPm1haW5GcmFtZSgpLmVuc3VyZVRlc3RUcmlnZ2VyKCk7CisK KyAgICBXZWJDb3JlVGVzdFN1cHBvcnQ6Om1vbml0b3JXaGVlbEV2ZW50cygqZnJhbWUpOwogI2Vu ZGlmCiB9CiAKQEAgLTEyODMsMTQgKzEyODAsOCBAQCAtICh2b2lkKWNhbGxBZnRlclNjcm9sbGlu Z0NvbXBsZXRlczooV2ViCiAgICAgaWYgKCFmcmFtZSkKICAgICAgICAgcmV0dXJuOwogCi0gICAg V2ViQ29yZTo6V2hlZWxFdmVudFRlc3RUcmlnZ2VyKiB0cmlnZ2VyID0gZnJhbWUtPm1haW5GcmFt ZSgpLmVuc3VyZVRlc3RUcmlnZ2VyKCk7CiAgICAgSlNHbG9iYWxDb250ZXh0UmVmIGdsb2JhbENv bnRleHQgPSBbbWFpbkZyYW1lIGdsb2JhbENvbnRleHRdOwotICAgIEpTVmFsdWVQcm90ZWN0KGds b2JhbENvbnRleHQsIGpzQ2FsbGJhY2tGdW5jdGlvbik7Ci0KLSAgICB0cmlnZ2VyLT5zZXRUZXN0 Q2FsbGJhY2tBbmRTdGFydE5vdGlmaWNhdGlvblRpbWVyKFs9XSh2b2lkKSB7Ci0gICAgICAgIEpT T2JqZWN0Q2FsbEFzRnVuY3Rpb24oZ2xvYmFsQ29udGV4dCwganNDYWxsYmFja0Z1bmN0aW9uLCBu dWxscHRyLCAwLCBudWxscHRyLCBudWxscHRyKTsKLSAgICAgICAgSlNWYWx1ZVVucHJvdGVjdChn bG9iYWxDb250ZXh0LCBqc0NhbGxiYWNrRnVuY3Rpb24pOwotICAgIH0pOworICAgIFdlYkNvcmVU ZXN0U3VwcG9ydDo6c2V0VGVzdENhbGxiYWNrQW5kU3RhcnROb3RpZmljYXRpb25UaW1lcigqZnJh bWUsIGdsb2JhbENvbnRleHQsIGpzQ2FsbGJhY2tGdW5jdGlvbik7CiAjZW5kaWYKIH0KIAo=