143723 2015-04-14 13:24:41 -0700 ASSERT(frame().view() == this) assertion hit in FrameView::windowClipRect() on Windows bots 2015-04-14 15:49:32 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez ap bfulgham commit-queue simon.fraser oldest_to_newest 1085237 0 cdumez 2015-04-14 13:24:41 -0700 ASSERT(frame().view() == this) assertion hit in FrameView::windowClipRect() on Windows bots: 0018eee8 05ff4290 064f14f7 0018ef44 00000001 WTF!WTFCrash+0x21 0018ef4c 05ff4952 0018ef58 00000001 0018ef9c WebKit!WebCore::FrameView::windowClipRect+0x40 0018ef90 05ff490f 0ebc3ea8 0018efbc 05ffa4ff WebKit!WebCore::FrameView::resumeVisibleImageAnimationsIncludingSubframes+0x32 0018ef9c 05ffa4ff 0ebc3ea8 0060aa90 006060c0 WebKit!WebCore::FrameView::viewportContentsChanged+0xf 0018efbc 05ff56bf 0ebc3ea8 0018efd4 06911367 WebKit!WebCore::FrameView::performPostLayoutTasks+0x12f 0018efc8 06911367 0d18bc60 0018efe4 067e0259 WebKit!WebCore::FrameView::postLayoutTimerFired+0xf 0018efd4 067e0259 0ebc3ea8 0d18bc60 0018effc WebKit!std::_Pmf_wrap<void (__thiscall WebCore::WebSocket::*)(void),void,WebCore::WebSocket>::operator()+0x17 0018efe4 067e00f5 00000000 00000000 0d18bc60 WebKit!std::_Bind<1,void,std::_Pmf_wrap<void (__thiscall WebCore::XMLHttpRequest::*)(void),void,WebCore::XMLHttpRequest>,WebCore::XMLHttpRequest *>::_Do_call<,0>+0x39 0018effc 067e0116 0d18bc60 0018f014 067e0a72 WebKit!std::_Bind<1,void,std::_Pmf_wrap<void (__thiscall WebCore::XMLHttpRequest::*)(void),void,WebCore::XMLHttpRequest>,WebCore::XMLHttpRequest *>::operator()<>+0x25 0018f008 067e0a72 0d18bc58 0018f020 05cd5f78 WebKit!std::_Callable_obj<std::_Bind<1,void,std::_Pmf_wrap<void (__thiscall WebCore::XMLHttpRequest::*)(void),void,WebCore::XMLHttpRequest>,WebCore::XMLHttpRequest *>,0>::_ApplyX<void>+0x16 0018f014 05cd5f78 0ebc4050 0018f02c 05cd6f32 WebKit!std::_Func_impl<std::_Callable_obj<std::_Bind<1,void,std::_Pmf_wrap<void (__thiscall WebCore::XMLHttpRequest::*)(void),void,WebCore::XMLHttpRequest>,WebCore::XMLHttpRequest *>,0>,std::allocator<std::_Func_class<void> >,void>::_Do_call+0x12 0018f020 05cd6f32 0ebc4018 0018f05c 066d341c WebKit!std::_Func_class<void>::operator()+0x28 0018f02c 066d341c d3d79865 41d54b72 00000000 WebKit!WebCore::Timer::fired+0x12 0018f05c 066d32f6 0018f06c 06ad16bf 0018f098 WebKit!WebCore::ThreadTimers::sharedTimerFiredInternal+0x11c 0018f064 06ad16bf 0018f098 76f862fa 003d074e WebKit!WebCore::ThreadTimers::sharedTimerFired+0x16 0018f06c 76f862fa 003d074e 0000c126 00000000 WebKit!WebCore::TimerWindowWndProc+0x7f It started happening after <http://trac.webkit.org/changeset/182773> but it is likely timing related rather than an actual regression. 1085239 1 250733 cdumez 2015-04-14 13:33:45 -0700 Created attachment 250733 Patch 1085242 2 250733 bfulgham 2015-04-14 13:37:09 -0700 Comment on attachment 250733 Patch Looks good. If it doesn't break any tests, please land it! 1085248 3 250733 cdumez 2015-04-14 13:55:36 -0700 Comment on attachment 250733 Patch Clearing flags on attachment: 250733 Committed r182807: <http://trac.webkit.org/changeset/182807> 1085249 4 cdumez 2015-04-14 13:55:40 -0700 All reviewed patches have been landed. Closing bug. 1085293 5 cdumez 2015-04-14 15:49:32 -0700 The Windows bot has recovered after this fix: https://build.webkit.org/builders/Apple%20Win%207%20Debug%20%28Tests%29/builds/65702 250733 2015-04-14 13:33:45 -0700 2015-04-14 13:55:36 -0700 Patch bug-143723-20150414133249.patch text/plain 2116 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyODA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjlhNWJiNTUzMDgxMjUz Y2FjMTUwZTFkNWJmY2VmMzhjMThkMjFiYy4uYWRmZjE1ZmM1N2ZhODU5ZmVmZjU4M2Y0MDgyMjdm Y2E4YjQ4YjhmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMxIEBACiAyMDE1LTA0LTE0ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgQVNTRVJUKGZyYW1lKCkudmll dygpID09IHRoaXMpIGFzc2VydGlvbiBoaXQgaW4gRnJhbWVWaWV3Ojp3aW5kb3dDbGlwUmVjdCgp IG9uIFdpbmRvd3MgYm90cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTQzNzIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQVNTRVJUKGZyYW1lKCkudmlldygpID09IHRoaXMpIGluIEZyYW1lVmlldzo6d2lu ZG93Q2xpcFJlY3QoKSBjYW4gYmUgaGl0CisgICAgICAgIGlmIHRoZSBwb3N0IGxheW91dCB0aW1l ciB0aW1lciBmaXJlcyBhZnRlciB0aGUgcGFnZSBoYXMgZW50ZXJlZCBwYWdlCisgICAgICAgIGNh Y2hlLiBVcG9uIGVudGVyaW5nIHBhZ2UgY2FjaGUsIHdlIGNhbGwgRnJhbWVWaWV3Ojp1bnNjaGVk dWxlUmVsYXlvdXQoKQorICAgICAgICB0byBzdG9wIHRoZSBsYXlvdXQgdGltZXIgaWYgaXQgaXMg YWN0aXZlLCBob3dldmVyLCB3ZSBkb24ndCBzdG9wIHRoZQorICAgICAgICBwb3N0LWxheW91dCB0 aW1lci4gVGhlcmVmb3JlLCB0aGVyZSB3YXMgbm90aGluZyBwcmV2ZW50aW5nIHRoZQorICAgICAg ICBwb3N0LWxheW91dCB0aW1lciBmcm9tIGZpcmluZyBhZnRlciBlbnRlcmluZyBwYWdlIGNhY2hl LgorCisgICAgICAgIEluIHRoaXMgcGF0Y2gsIHdlIHVuc2NoZWR1bGUgdGhlIHBvc3QtbGF5b3V0 IHRpbWVyIGluCisgICAgICAgIEZyYW1lVmlldzo6dW5zY2hlZHVsZVJlbGF5b3V0KCkgdG8gcHJv dGVjdCBvdXJzZWx2ZXMgYWdhaW5zdCB0aGlzLgorCisgICAgICAgIEkgdGhpbmsgd2Ugd2VyZSBv bmx5IHNlZWluZyB0aGUgYXNzZXJ0aW9uIGhpdCBvbiBXaW5kb3dzIGJlY2F1c2UgdGhpcworICAg ICAgICB0aW1lciBwcm9iYWJseSBnZXRzIHNjaGVkdWxlZCBtb3JlIGZyZXF1ZW50bHkgb24gV2lu ZG93cy4gT24gTWFjLCBJCisgICAgICAgIHJhcmVseSBzZWUgaXQgZ2V0dGluZyBzY2hlZHVsZWQu CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBzaG91bGQgZml4IGNyYXNoaW5nIHRlc3RzIG9uIHRo ZSBib3RzLgorCisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6RnJhbWVWaWV3Ojp1bnNjaGVkdWxlUmVsYXlvdXQpOgorCisyMDE1LTA0LTE0ICBDaHJpcyBE dW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKICAgICAgICAgRnJhbWVWaWV3OjptX2ZyYW1lIHNo b3VsZCBiZSBhIFJlZjxGcmFtZT4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE0MzcxNgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0Zy YW1lVmlldy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKaW5kZXggZGIy NTM5ODM3MmIxNTNmNzM5MWVhZTNmYTA0ZWZjNGM4ZWMzOThiYS4uOGQzZTU3NWZiMWI4NTk5ZWRj MzJjYzEzM2M0ZGY4MGI4OWZkN2M0OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9G cmFtZVZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcApAQCAt MjYyMCw2ICsyNjIwLDkgQEAgdm9pZCBGcmFtZVZpZXc6OnNldE5lZWRzTGF5b3V0KCkKIAogdm9p ZCBGcmFtZVZpZXc6OnVuc2NoZWR1bGVSZWxheW91dCgpCiB7CisgICAgaWYgKG1fcG9zdExheW91 dFRhc2tzVGltZXIuaXNBY3RpdmUoKSkKKyAgICAgICAgbV9wb3N0TGF5b3V0VGFza3NUaW1lci5z dG9wKCk7CisKICAgICBpZiAoIW1fbGF5b3V0VGltZXIuaXNBY3RpdmUoKSkKICAgICAgICAgcmV0 dXJuOwogCg==