143721 2015-04-14 12:55:24 -0700 Insert volume control in correct place after exiting wireless play 2015-04-14 15:39:27 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 roger_fong webkit-unassigned darin eric.carlson roger_fong oldest_to_newest 1085221 0 roger_fong 2015-04-14 12:55:24 -0700 rdar://problem/20526106 1085223 1 250728 roger_fong 2015-04-14 12:57:47 -0700 Created attachment 250728 patch 1085234 2 250728 darin 2015-04-14 13:19:41 -0700 Comment on attachment 250728 patch Maybe we should use "display: none" styling to hide and show rather than DOM manipulation. That’s usually better if you want to preserve a certain ordering of the nodes. 1085270 3 roger_fong 2015-04-14 14:36:47 -0700 Roger that. Didn't realize that display: none actually removes things from the DOM. http://trac.webkit.org/changeset/182812 1085292 4 darin 2015-04-14 15:39:27 -0700 (In reply to comment #3) > Roger that. Didn't realize that display: none actually removes things from > the DOM. It doesn’t remove things from the DOM. It removes them from the render tree, though, which usually accomplishes the same thing. 250728 2015-04-14 12:57:47 -0700 2015-04-14 13:19:41 -0700 patch patch.patch text/plain 1711 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MjgwNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA0LTE0ICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgSW5zZXJ0IHZvbHVtZSBjb250 cm9sIGluIGNvcnJlY3QgcGxhY2UgYWZ0ZXIgZXhpdGluZyB3aXJlbGVzcyBwbGF5LgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzNzIxLgorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMjA1MjYxMDY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkKKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xz QXBwbGUuanM6CisgICAgICAgIChDb250cm9sbGVyLnByb3RvdHlwZS51cGRhdGVXaXJlbGVzc1Bs YXliYWNrU3RhdHVzKToKKwogMjAxNS0wNC0xNCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUu Y29tPgogCiAgICAgICAgIEZyYW1lVmlldzo6bV9mcmFtZSBzaG91bGQgYmUgYSBSZWY8RnJhbWU+ CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9s c0FwcGxlLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250 cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUuanMJKHJldmlzaW9uIDE4Mjc3MSkKKysrIFNvdXJjZS9X ZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUuanMJKHdvcmtp bmcgY29weSkKQEAgLTE3NzUsMTAgKzE3NzUsMTAgQEAgQ29udHJvbGxlci5wcm90b3R5cGUgPSB7 CiAgICAgICAgICAgICB0aGlzLmNvbnRyb2xzLndpcmVsZXNzVGFyZ2V0UGlja2VyLmNsYXNzTGlz dC5yZW1vdmUodGhpcy5DbGFzc05hbWVzLnBsYXlpbmcpOwogICAgICAgICAgICAgaWYgKHRoaXMu aXNGdWxsU2NyZWVuKCkpIHsKICAgICAgICAgICAgICAgICBpZiAoIXRoaXMuY29udHJvbHMudm9s dW1lQm94LnBhcmVudE5vZGUpCi0gICAgICAgICAgICAgICAgICAgIHRoaXMuY29udHJvbHMucGFu ZWwuYXBwZW5kQ2hpbGQodGhpcy5jb250cm9scy52b2x1bWVCb3gpOworICAgICAgICAgICAgICAg ICAgICB0aGlzLmNvbnRyb2xzLnBhbmVsLmluc2VydEJlZm9yZSh0aGlzLmNvbnRyb2xzLnZvbHVt ZUJveCwgdGhpcy5jb250cm9scy5zZWVrQmFja0J1dHRvbik7CiAgICAgICAgICAgICB9IGVsc2Ug ewogICAgICAgICAgICAgICAgIGlmICghdGhpcy5jb250cm9scy5tdXRlQm94LnBhcmVudE5vZGUp Ci0gICAgICAgICAgICAgICAgICAgIHRoaXMuY29udHJvbHMucGFuZWwuYXBwZW5kQ2hpbGQodGhp cy5jb250cm9scy5tdXRlQm94KTsKKyAgICAgICAgICAgICAgICAgICAgdGhpcy5jb250cm9scy5w YW5lbC5pbnNlcnRCZWZvcmUodGhpcy5jb250cm9scy5tdXRlQm94LCB0aGlzLmNvbnRyb2xzLnRp bWVsaW5lQm94Lm5leHRTaWJsaW5nKTsKICAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgIH0s Cg==