143720 2015-04-14 12:51:19 -0700 Media elements not in a page shouldn't load 2015-04-14 14:25:50 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 beidson beidson commit-queue jer.noble oldest_to_newest 1085218 0 beidson 2015-04-14 12:51:19 -0700 Media elements not in a page shouldn't load 1085220 1 beidson 2015-04-14 12:51:36 -0700 Noticed while working on an unrelated patch. Have no test to reproduce. 1085222 2 250727 beidson 2015-04-14 12:56:30 -0700 Created attachment 250727 Patch v1 1085224 3 250727 jer.noble 2015-04-14 12:58:19 -0700 Comment on attachment 250727 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=250727&action=review > Source/WebCore/html/HTMLMediaSession.cpp:146 > - if (m_restrictions & RequirePageConsentToLoadMedia && page && !page->canStartMedia()) { > + if (!page || !page->canStartMedia() || m_restrictions & RequirePageConsentToLoadMedia) { This should be: if (m_restrictions & RequirePageConsentToLoadMedia && (!page || !page->canStartMedia())) 1085225 4 beidson 2015-04-14 12:59:50 -0700 (In reply to comment #3) > Comment on attachment 250727 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=250727&action=review > > > Source/WebCore/html/HTMLMediaSession.cpp:146 > > - if (m_restrictions & RequirePageConsentToLoadMedia && page && !page->canStartMedia()) { > > + if (!page || !page->canStartMedia() || m_restrictions & RequirePageConsentToLoadMedia) { > > This should be: if (m_restrictions & RequirePageConsentToLoadMedia && (!page > || !page->canStartMedia())) Kinda. The page checks should be first. But the joining clause after them *should* be an or. Thanks! 1085226 5 beidson 2015-04-14 13:00:19 -0700 (In reply to comment #4) > Kinda. > > The page checks should be first. > > But the joining clause after them *should* be an or. > I meant it should be an and. *sigh* 1085227 6 beidson 2015-04-14 13:03:14 -0700 We found another one we discussed on IRC. 1085228 7 250729 beidson 2015-04-14 13:03:32 -0700 Created attachment 250729 Patch for landing 1085229 8 commit-queue 2015-04-14 13:04:39 -0700 Attachment 250729 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1085232 9 250731 beidson 2015-04-14 13:15:07 -0700 Created attachment 250731 Real patch for landing. Disagreement on the media session parts - landing only the loadResource part. 1085235 10 250727 darin 2015-04-14 13:21:28 -0700 Comment on attachment 250727 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=250727&action=review > Source/WebCore/html/HTMLMediaElement.cpp:1093 > + if (!frame->mainFrame().page()) { Should just be frame->page(). 1085238 11 beidson 2015-04-14 13:33:33 -0700 (In reply to comment #10) > Comment on attachment 250727 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=250727&action=review > > > Source/WebCore/html/HTMLMediaElement.cpp:1093 > > + if (!frame->mainFrame().page()) { > > Should just be frame->page(). Yup, you're definitely correct. Brain dead copy mistake. 1085241 12 250734 beidson 2015-04-14 13:35:13 -0700 Created attachment 250734 Land it 1085263 13 250734 commit-queue 2015-04-14 14:25:47 -0700 Comment on attachment 250734 Land it Clearing flags on attachment: 250734 Committed r182810: <http://trac.webkit.org/changeset/182810> 1085264 14 commit-queue 2015-04-14 14:25:50 -0700 All reviewed patches have been landed. Closing bug. 250727 2015-04-14 12:56:30 -0700 2015-04-14 13:03:32 -0700 Patch v1 patch text/plain 2283 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3NGNjMDY2Li4zNjhhYTFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTUtMDQtMTQgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIE1lZGlhIGVsZW1lbnRzIG5vdCBpbiBhIHBhZ2Ugc2hvdWxkbid0IGxvYWQuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDM3MjAKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKFRo ZW9yZXRpY2FsIHByb2JsZW0gbm90aWNlZCBpbiBjb2RlIHJldmlldykuCisKKyAgICAgICAgKiBo dG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxl bWVudDo6bG9hZFJlc291cmNlKTogTWFrZSBzdXJlIHRoZSBmcmFtZSBpcyBpbiBhIHBhZ2UuCisK KyAgICAgICAgKiBodG1sL0hUTUxNZWRpYVNlc3Npb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6 SFRNTE1lZGlhU2Vzc2lvbjo6cGFnZUFsbG93c0RhdGFMb2FkaW5nKTogTWFrZSBzdXJlIHRoZSBw YWdlIG51bGwgY2hlY2sgYWx3YXlzIGhhcHBlbnMuCisKIDIwMTUtMDQtMTMgIEJyZW50IEZ1bGdo YW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgW1dpbl0gVW5yZXZpZXdlZCBmaXgg YWZ0ZXIgcjE4Mjc1Ny4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlh RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCmlu ZGV4IDc1YjE3M2QuLjkwNjdkYzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TE1lZGlhRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVt ZW50LmNwcApAQCAtMTA5MCwxMiArMTA5MCwxNyBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6Omxv YWRSZXNvdXJjZShjb25zdCBVUkwmIGluaXRpYWxVUkwsIENvbnRlbnRUeXBlJiBjb250ZW50VAog ICAgICAgICByZXR1cm47CiAgICAgfQogCisgICAgaWYgKCFmcmFtZS0+bWFpbkZyYW1lKCkucGFn ZSgpKSB7CisgICAgICAgIG1lZGlhTG9hZGluZ0ZhaWxlZChNZWRpYVBsYXllcjo6Rm9ybWF0RXJy b3IpOworICAgICAgICByZXR1cm47CisgICAgfQorCiAgICAgVVJMIHVybCA9IGluaXRpYWxVUkw7 CiAgICAgaWYgKCFmcmFtZS0+bG9hZGVyKCkud2lsbExvYWRNZWRpYUVsZW1lbnRVUkwodXJsKSkg ewogICAgICAgICBtZWRpYUxvYWRpbmdGYWlsZWQoTWVkaWFQbGF5ZXI6OkZvcm1hdEVycm9yKTsK ICAgICAgICAgcmV0dXJuOwogICAgIH0KLSAgICAKKwogICAgIC8vIFRoZSByZXNvdXJjZSBmZXRj aCBhbGdvcml0aG0gCiAgICAgbV9uZXR3b3JrU3RhdGUgPSBORVRXT1JLX0xPQURJTkc7CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhU2Vzc2lvbi5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYVNlc3Npb24uY3BwCmluZGV4IGFjMDNmM2YuLjAwODQ5 ZWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhU2Vzc2lvbi5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFTZXNzaW9uLmNwcApAQCAtMTQzLDcg KzE0Myw3IEBAIGJvb2wgSFRNTE1lZGlhU2Vzc2lvbjo6ZnVsbHNjcmVlblBlcm1pdHRlZChjb25z dCBIVE1MTWVkaWFFbGVtZW50JikgY29uc3QKIGJvb2wgSFRNTE1lZGlhU2Vzc2lvbjo6cGFnZUFs bG93c0RhdGFMb2FkaW5nKGNvbnN0IEhUTUxNZWRpYUVsZW1lbnQmIGVsZW1lbnQpIGNvbnN0CiB7 CiAgICAgUGFnZSogcGFnZSA9IGVsZW1lbnQuZG9jdW1lbnQoKS5wYWdlKCk7Ci0gICAgaWYgKG1f cmVzdHJpY3Rpb25zICYgUmVxdWlyZVBhZ2VDb25zZW50VG9Mb2FkTWVkaWEgJiYgcGFnZSAmJiAh cGFnZS0+Y2FuU3RhcnRNZWRpYSgpKSB7CisgICAgaWYgKCFwYWdlIHx8ICFwYWdlLT5jYW5TdGFy dE1lZGlhKCkgfHwgbV9yZXN0cmljdGlvbnMgJiBSZXF1aXJlUGFnZUNvbnNlbnRUb0xvYWRNZWRp YSkgewogICAgICAgICBMT0coTWVkaWEsICJIVE1MTWVkaWFTZXNzaW9uOjpwYWdlQWxsb3dzRGF0 YUxvYWRpbmcgLSByZXR1cm5pbmcgRkFMU0UiKTsKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAg IH0K 250729 2015-04-14 13:03:32 -0700 2015-04-14 13:15:07 -0700 Patch for landing patch text/plain 2885 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3NGNjMDY2Li5jZWMzYzQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTUtMDQtMTQgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIE5lZWQgYSBzaG9ydCBkZXNjcmlwdGlvbiAoT09QUyEpLgorICAgICAgICBOZWVkIHRoZSBi dWcgVVJMIChPT1BTISkuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSmVyIE5vYmxlLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cyAoVGhlb3JldGljYWwgcHJvYmxlbSBub3RpY2VkIGluIGNvZGUgcmV2 aWV3KS4KKworICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50Ojpsb2FkUmVzb3VyY2UpOiBNYWtlIHN1cmUgdGhlIGZy YW1lIGlzIGluIGEgcGFnZS4KKworICAgICAgICAqIGh0bWwvSFRNTE1lZGlhU2Vzc2lvbi5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFTZXNzaW9uOjpwYWdlQWxsb3dzRGF0YUxvYWRp bmcpOiBNYWtlIHN1cmUgdGhlIHBhZ2UgbnVsbCBjaGVjayBhbHdheXMgaGFwcGVucy4KKyAgICAg ICAgKFdlYkNvcmU6OkhUTUxNZWRpYVNlc3Npb246OnBhZ2VBbGxvd3NQbGF5YmFja0FmdGVyUmVz dW1pbmcpOiBEaXR0by4KKwogMjAxNS0wNC0xMyAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFw cGxlLmNvbT4KIAogICAgICAgICBbV2luXSBVbnJldmlld2VkIGZpeCBhZnRlciByMTgyNzU3Lgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKaW5kZXggNzViMTczZC4uOTA2 N2RjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCkBAIC0xMDkw LDEyICsxMDkwLDE3IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6bG9hZFJlc291cmNlKGNvbnN0 IFVSTCYgaW5pdGlhbFVSTCwgQ29udGVudFR5cGUmIGNvbnRlbnRUCiAgICAgICAgIHJldHVybjsK ICAgICB9CiAKKyAgICBpZiAoIWZyYW1lLT5tYWluRnJhbWUoKS5wYWdlKCkpIHsKKyAgICAgICAg bWVkaWFMb2FkaW5nRmFpbGVkKE1lZGlhUGxheWVyOjpGb3JtYXRFcnJvcik7CisgICAgICAgIHJl dHVybjsKKyAgICB9CisKICAgICBVUkwgdXJsID0gaW5pdGlhbFVSTDsKICAgICBpZiAoIWZyYW1l LT5sb2FkZXIoKS53aWxsTG9hZE1lZGlhRWxlbWVudFVSTCh1cmwpKSB7CiAgICAgICAgIG1lZGlh TG9hZGluZ0ZhaWxlZChNZWRpYVBsYXllcjo6Rm9ybWF0RXJyb3IpOwogICAgICAgICByZXR1cm47 CiAgICAgfQotICAgIAorCiAgICAgLy8gVGhlIHJlc291cmNlIGZldGNoIGFsZ29yaXRobSAKICAg ICBtX25ldHdvcmtTdGF0ZSA9IE5FVFdPUktfTE9BRElORzsKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFTZXNzaW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTE1lZGlhU2Vzc2lvbi5jcHAKaW5kZXggYWMwM2YzZi4uMmQ5ZWY1MyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFTZXNzaW9uLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxNZWRpYVNlc3Npb24uY3BwCkBAIC0xNDMsNyArMTQzLDcgQEAgYm9vbCBI VE1MTWVkaWFTZXNzaW9uOjpmdWxsc2NyZWVuUGVybWl0dGVkKGNvbnN0IEhUTUxNZWRpYUVsZW1l bnQmKSBjb25zdAogYm9vbCBIVE1MTWVkaWFTZXNzaW9uOjpwYWdlQWxsb3dzRGF0YUxvYWRpbmco Y29uc3QgSFRNTE1lZGlhRWxlbWVudCYgZWxlbWVudCkgY29uc3QKIHsKICAgICBQYWdlKiBwYWdl ID0gZWxlbWVudC5kb2N1bWVudCgpLnBhZ2UoKTsKLSAgICBpZiAobV9yZXN0cmljdGlvbnMgJiBS ZXF1aXJlUGFnZUNvbnNlbnRUb0xvYWRNZWRpYSAmJiBwYWdlICYmICFwYWdlLT5jYW5TdGFydE1l ZGlhKCkpIHsKKyAgICBpZiAoKCFwYWdlIHx8ICFwYWdlLT5jYW5TdGFydE1lZGlhKCkpICYmIG1f cmVzdHJpY3Rpb25zICYgUmVxdWlyZVBhZ2VDb25zZW50VG9Mb2FkTWVkaWEpIHsKICAgICAgICAg TE9HKE1lZGlhLCAiSFRNTE1lZGlhU2Vzc2lvbjo6cGFnZUFsbG93c0RhdGFMb2FkaW5nIC0gcmV0 dXJuaW5nIEZBTFNFIik7CiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CkBAIC0xNTQsNyAr MTU0LDcgQEAgYm9vbCBIVE1MTWVkaWFTZXNzaW9uOjpwYWdlQWxsb3dzRGF0YUxvYWRpbmcoY29u c3QgSFRNTE1lZGlhRWxlbWVudCYgZWxlbWVudCkgY28KIGJvb2wgSFRNTE1lZGlhU2Vzc2lvbjo6 cGFnZUFsbG93c1BsYXliYWNrQWZ0ZXJSZXN1bWluZyhjb25zdCBIVE1MTWVkaWFFbGVtZW50JiBl bGVtZW50KSBjb25zdAogewogICAgIFBhZ2UqIHBhZ2UgPSBlbGVtZW50LmRvY3VtZW50KCkucGFn ZSgpOwotICAgIGlmIChtX3Jlc3RyaWN0aW9ucyAmIFJlcXVpcmVQYWdlQ29uc2VudFRvUmVzdW1l TWVkaWEgJiYgcGFnZSAmJiAhcGFnZS0+Y2FuU3RhcnRNZWRpYSgpKSB7CisgICAgaWYgKCghcGFn ZSB8fCAhcGFnZS0+Y2FuU3RhcnRNZWRpYSgpKSAmJiBtX3Jlc3RyaWN0aW9ucyAmIFJlcXVpcmVQ YWdlQ29uc2VudFRvUmVzdW1lTWVkaWEpIHsKICAgICAgICAgTE9HKE1lZGlhLCAiSFRNTE1lZGlh U2Vzc2lvbjo6cGFnZUFsbG93c1BsYXliYWNrQWZ0ZXJSZXN1bWluZyAtIHJldHVybmluZyBGQUxT RSIpOwogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQo= 250731 2015-04-14 13:15:07 -0700 2015-04-14 13:35:13 -0700 Real patch for landing. patch text/plain 1384 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3NGNjMDY2Li40ZWM3ZTU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTUtMDQtMTQgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIE1lZGlhIGVsZW1lbnRzIG5vdCBpbiBhIHBhZ2Ugc2hvdWxkbid0IGxvYWQuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDM3MjAKKworICAgICAg ICBSZXZpZXdlZCBieSBKZXIgTm9ibGUuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIChUaGVvcmV0 aWNhbCBwcm9ibGVtIG5vdGljZWQgaW4gY29kZSByZXZpZXcpLgorCisgICAgICAgICogaHRtbC9I VE1MTWVkaWFFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6 OmxvYWRSZXNvdXJjZSk6IE1ha2Ugc3VyZSB0aGUgZnJhbWUgaXMgaW4gYSBwYWdlLgorCiAyMDE1 LTA0LTEzICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFtX aW5dIFVucmV2aWV3ZWQgZml4IGFmdGVyIHIxODI3NTcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M TWVkaWFFbGVtZW50LmNwcAppbmRleCA3NWIxNzNkLi45MDY3ZGMyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKQEAgLTEwOTAsMTIgKzEwOTAsMTcgQEAgdm9pZCBI VE1MTWVkaWFFbGVtZW50Ojpsb2FkUmVzb3VyY2UoY29uc3QgVVJMJiBpbml0aWFsVVJMLCBDb250 ZW50VHlwZSYgY29udGVudFQKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAorICAgIGlmICghZnJh bWUtPm1haW5GcmFtZSgpLnBhZ2UoKSkgeworICAgICAgICBtZWRpYUxvYWRpbmdGYWlsZWQoTWVk aWFQbGF5ZXI6OkZvcm1hdEVycm9yKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKwogICAgIFVS TCB1cmwgPSBpbml0aWFsVVJMOwogICAgIGlmICghZnJhbWUtPmxvYWRlcigpLndpbGxMb2FkTWVk aWFFbGVtZW50VVJMKHVybCkpIHsKICAgICAgICAgbWVkaWFMb2FkaW5nRmFpbGVkKE1lZGlhUGxh eWVyOjpGb3JtYXRFcnJvcik7CiAgICAgICAgIHJldHVybjsKICAgICB9Ci0gICAgCisKICAgICAv LyBUaGUgcmVzb3VyY2UgZmV0Y2ggYWxnb3JpdGhtIAogICAgIG1fbmV0d29ya1N0YXRlID0gTkVU V09SS19MT0FESU5HOwogCg== 250734 2015-04-14 13:35:13 -0700 2015-04-14 14:25:47 -0700 Land it patch text/plain 1372 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3NGNjMDY2Li40ZWM3ZTU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTUtMDQtMTQgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIE1lZGlhIGVsZW1lbnRzIG5vdCBpbiBhIHBhZ2Ugc2hvdWxkbid0IGxvYWQuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDM3MjAKKworICAgICAg ICBSZXZpZXdlZCBieSBKZXIgTm9ibGUuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIChUaGVvcmV0 aWNhbCBwcm9ibGVtIG5vdGljZWQgaW4gY29kZSByZXZpZXcpLgorCisgICAgICAgICogaHRtbC9I VE1MTWVkaWFFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6 OmxvYWRSZXNvdXJjZSk6IE1ha2Ugc3VyZSB0aGUgZnJhbWUgaXMgaW4gYSBwYWdlLgorCiAyMDE1 LTA0LTEzICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFtX aW5dIFVucmV2aWV3ZWQgZml4IGFmdGVyIHIxODI3NTcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M TWVkaWFFbGVtZW50LmNwcAppbmRleCA3NWIxNzNkLi4yNTU5MGVlIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKQEAgLTEwOTAsMTIgKzEwOTAsMTcgQEAgdm9pZCBI VE1MTWVkaWFFbGVtZW50Ojpsb2FkUmVzb3VyY2UoY29uc3QgVVJMJiBpbml0aWFsVVJMLCBDb250 ZW50VHlwZSYgY29udGVudFQKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAorICAgIGlmICghZnJh bWUtPnBhZ2UoKSkgeworICAgICAgICBtZWRpYUxvYWRpbmdGYWlsZWQoTWVkaWFQbGF5ZXI6OkZv cm1hdEVycm9yKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKwogICAgIFVSTCB1cmwgPSBpbml0 aWFsVVJMOwogICAgIGlmICghZnJhbWUtPmxvYWRlcigpLndpbGxMb2FkTWVkaWFFbGVtZW50VVJM KHVybCkpIHsKICAgICAgICAgbWVkaWFMb2FkaW5nRmFpbGVkKE1lZGlhUGxheWVyOjpGb3JtYXRF cnJvcik7CiAgICAgICAgIHJldHVybjsKICAgICB9Ci0gICAgCisKICAgICAvLyBUaGUgcmVzb3Vy Y2UgZmV0Y2ggYWxnb3JpdGhtIAogICAgIG1fbmV0d29ya1N0YXRlID0gTkVUV09SS19MT0FESU5H OwogCg==