143697 2015-04-13 22:31:02 -0700 fast/sub-pixel/input-caret-on-subpixel-bound.html is flaky 2015-04-14 10:35:09 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap commit-queue darin zalan oldest_to_newest 1085059 0 ap 2015-04-13 22:31:02 -0700 fast/sub-pixel/input-caret-on-subpixel-bound.html is flaky on debug WK2 bots. It's a reftest for editing, and caret is not drawn in actual result sometimes. There is a race between a caret blinking timer, and a timer in the test. 1085061 1 250694 ap 2015-04-13 22:34:17 -0700 Created attachment 250694 proposed fix I have a vague memory of us doing something special to always have the caret draw when dumping pixel results, but I cannot find any sign of that in the code. 1085063 2 ap 2015-04-13 22:44:35 -0700 There is a function in FrameSelection named setCaretBlinks which we could potentially call from Internals, but it's completely unused now, and may or may not work. Looks like it was accidentally added when upstreaming iOS code. 1085159 3 ap 2015-04-14 09:48:24 -0700 We should probably delete setCaretBlinks and supporting code, and if we want to disable blinking during tests, we should do that by supporting and tweaking NSTextInsertionPointBlinkPeriod/NSTextInsertionPointBlinkPeriodOn/NSTextInsertionPointBlinkPeriodOff. 1085185 4 250694 commit-queue 2015-04-14 10:35:05 -0700 Comment on attachment 250694 proposed fix Clearing flags on attachment: 250694 Committed r182801: <http://trac.webkit.org/changeset/182801> 1085186 5 commit-queue 2015-04-14 10:35:09 -0700 All reviewed patches have been landed. Closing bug. 250694 2015-04-13 22:34:17 -0700 2015-04-14 10:35:05 -0700 proposed fix Caret.txt text/plain 1446 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE4Mjc4MSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE1LTA0LTEzICBBbGV4ZXkgUHJvc2t1cnlh a292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIGZhc3Qvc3ViLXBpeGVsL2lucHV0LWNhcmV0 LW9uLXN1YnBpeGVsLWJvdW5kLmh0bWwgaXMgZmxha3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MzY5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9zdWItcGl4ZWwvaW5wdXQtY2FyZXQtb24t c3VicGl4ZWwtYm91bmQuaHRtbDogRG9uJ3Qgd2FpdCBmb3IgYSB0aW1lciB0byBmaXJlCisgICAg ICAgIGFmdGVyIHJlbW92aW5nIHRoZSBsYXN0IGNoYXJhY3Rlci4KKwogMjAxNS0wNC0xMyAgTWFu dWVsIFJlZ28gQ2FzYXNub3ZhcyAgPHJlZ29AaWdhbGlhLmNvbT4KIAogICAgICAgICBbQ1NTIEdy aWQgTGF5b3V0XSBDb2x1bW5zIHNldCBpbiBwZXJjZW50YWdlcyBjb2xsYXBzZSB0byBhdXRvIHdp ZHRoCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L3N1Yi1waXhlbC9pbnB1dC1jYXJldC1vbi1zdWJw aXhlbC1ib3VuZC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3Qvc3ViLXBpeGVs L2lucHV0LWNhcmV0LW9uLXN1YnBpeGVsLWJvdW5kLmh0bWwJKHJldmlzaW9uIDE4Mjc3MykKKysr IExheW91dFRlc3RzL2Zhc3Qvc3ViLXBpeGVsL2lucHV0LWNhcmV0LW9uLXN1YnBpeGVsLWJvdW5k Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTM1LDEwICszNSwxMCBAQAogICAgICAgICAgICAgZWwu Zm9jdXMoKTsKICAgICAgICAgICAgIHZhciBzdGVwID0gZnVuY3Rpb24oKSB7CiAgICAgICAgICAg ICAgICAgdmFyIHZhbHVlID0gZWwudmFsdWU7Ci0gICAgICAgICAgICAgICAgaWYgKHZhbHVlKSB7 CisgICAgICAgICAgICAgICAgaWYgKGVsLnZhbHVlKQogICAgICAgICAgICAgICAgICAgICBlbC52 YWx1ZSA9IHZhbHVlLnN1YnN0cigwLCB2YWx1ZS5sZW5ndGggLSAxKTsKKyAgICAgICAgICAgICAg ICBpZiAoZWwudmFsdWUpCiAgICAgICAgICAgICAgICAgICAgIHdpbmRvdy5zZXRUaW1lb3V0KHN0 ZXAsIDEwKTsKLSAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgZWxzZSBpZiAod2lu ZG93LnRlc3RSdW5uZXIpCiAgICAgICAgICAgICAgICAgICAgIHRlc3RSdW5uZXIubm90aWZ5RG9u ZSgpOwogICAgICAgICAgICAgfTsK