143693 2015-04-13 21:40:24 -0700 Skip failing test Tests/WebKit2Cocoa/FixedLayoutSize.mm on iOS 2015-04-14 10:58:38 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates simon.fraser thorton oldest_to_newest 1085045 0 dbates 2015-04-13 21:40:24 -0700 The test Tests/WebKit2Cocoa/FixedLayoutSize.mm is failing on iOS. See <rdar://problem/20530316> for more details. 1085046 1 250691 dbates 2015-04-13 21:44:21 -0700 Created attachment 250691 Skip the test on iOS 1085047 2 dbates 2015-04-13 21:46:55 -0700 I have not had a chance to investigate the test failure. If we feel that we cannot fix the test in a reasonable amount of time then I suggest we temporarily skip it so that the test bot is not red. 1085076 3 250691 thorton 2015-04-14 01:06:02 -0700 Comment on attachment 250691 Skip the test on iOS View in context: https://bugs.webkit.org/attachment.cgi?id=250691&action=review > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:55 > +#if PLATFORM(IOS) Is this how we usually do this? I was expecting a big PLATFORM #if around the whole thing. 1085077 4 thorton 2015-04-14 01:06:58 -0700 I think we should skip it, since I don't have any motivation to make fixed layout take over from the viewport code on iOS at the moment. That would be more like a feature than fixing a test. 1085155 5 dbates 2015-04-14 09:23:41 -0700 (In reply to comment #3) > Comment on attachment 250691 [details] > Skip the test on iOS > > View in context: > https://bugs.webkit.org/attachment.cgi?id=250691&action=review > > > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:55 > > +#if PLATFORM(IOS) > > Is this how we usually do this? I was expecting a big PLATFORM #if around > the whole thing. I will update the patch to disable the test by conditionally compiling it on non-iOS platforms given that you do not "have any motivation to make fixed layout take over from the viewport code on iOS at the moment" (comment #4). When I wrote the original patch I was unclear if we wanted to skip this test permanently on iOS as implied by your remarks in comment #4. So, I chose to prefix the name of the test with "DISABLED_" to demarcate that the test is temporarily disabled. Among of the benefits of this approach is that GoogleTest will print a banner about the disabled tests (as a reminder to fix it). 1085157 6 250711 dbates 2015-04-14 09:32:43 -0700 Created attachment 250711 Skip the test on iOS 1085183 7 thorton 2015-04-14 10:33:01 -0700 (In reply to comment #5) > (In reply to comment #3) > > Comment on attachment 250691 [details] > > Skip the test on iOS > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=250691&action=review > > > > > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:55 > > > +#if PLATFORM(IOS) > > > > Is this how we usually do this? I was expecting a big PLATFORM #if around > > the whole thing. > > I will update the patch to disable the test by conditionally compiling it on > non-iOS platforms given that you do not "have any motivation to make fixed > layout take over from the viewport code on iOS at the moment" (comment #4). > > When I wrote the original patch I was unclear if we wanted to skip this test > permanently on iOS as implied by your remarks in comment #4. So, I chose to > prefix the name of the test with "DISABLED_" to demarcate that the test is > temporarily disabled. Among of the benefits of this approach is that > GoogleTest will print a banner about the disabled tests (as a reminder to > fix it). Ah! That makes sense. Thanks! 1085196 8 dbates 2015-04-14 10:58:38 -0700 Committed r182802: <http://trac.webkit.org/changeset/182802> 250691 2015-04-13 21:44:21 -0700 2015-04-14 09:32:41 -0700 Skip the test on iOS bug-143693-20150413214326.patch text/plain 1647 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyNjQ5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzMxNDY0YzE4YzhlZjhiZjAxNTAyZGNlZjVmZDAxYjk4 MDIyNDA0Mi4uMGExODJkODFhNDZmYWRlNjg1MjM5NTk0OWZhYzhiMzBhY2NjY2U3MyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE1LTA0LTEzICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBTa2lwIGZhaWxpbmcgdGVzdCBvbiBpT1MgVGVzdHMvV2ViS2l0MkNvY29hL0ZpeGVkTGF5 b3V0U2l6ZS5tbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTQzNjkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhlIHRlc3QgVGVzdHMvV2ViS2l0MkNvY29hL0ZpeGVkTGF5b3V0U2l6ZS5tbSBpcyBmYWls aW5nIG9uIGlPUy4KKyAgICAgICAgRm9yIG5vdywgc2tpcCBpdCBvbiBpT1MuIFNlZSA8cmRhcjov L3Byb2JsZW0vMjA1MzAzMTY+IGZvciBtb3JlIGRldGFpbHMuCisKKyAgICAgICAgKiBUZXN0V2Vi S2l0QVBJL1Rlc3RzL1dlYktpdDJDb2NvYS9GaXhlZExheW91dFNpemUubW06CisgICAgICAgIChU RVNUKToKKwogMjAxNS0wNC0xMCAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNv bT4KIAogICAgICAgICBSZXBsYWNlIHNldEZpeGVkTGF5b3V0U2l6ZUVuYWJsZWQ6IHdpdGggYW4g ZW51bSBvZiBsYXlvdXQgbW9kZXMKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVz dHMvV2ViS2l0MkNvY29hL0ZpeGVkTGF5b3V0U2l6ZS5tbSBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkv VGVzdHMvV2ViS2l0MkNvY29hL0ZpeGVkTGF5b3V0U2l6ZS5tbQppbmRleCBlYTQ3MzkwNTM5MTNm NWU0OWRjNDRmMTkzZGEzMDMyOTFiYjRjYzJhLi43Mjc2MzY4MjMzOWM1NDc5ODcyN2M0MGNlZTEx MzQ2Nzk2OTFjYzNkIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktp dDJDb2NvYS9GaXhlZExheW91dFNpemUubW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJLaXQyQ29jb2EvRml4ZWRMYXlvdXRTaXplLm1tCkBAIC01Miw3ICs1MiwxNCBAQCBzdGF0 aWMgYm9vbCBmaXhlZExheW91dFNpemVEaXNhYmxlZERvbmU7CiAKIEBlbmQKIAotVEVTVChXZWJL aXQyLCBGaXhlZExheW91dFNpemUpCisjaWYgUExBVEZPUk0oSU9TKQorI2RlZmluZSBTS0lQX09O X0lPUyhURVNUX05BTUUpIERJU0FCTEVEXyMjVEVTVF9OQU1FCisjZWxzZQorI2RlZmluZSBTS0lQ X09OX0lPUyhURVNUX05BTUUpIFRFU1RfTkFNRQorI2VuZGlmCisKKy8vIEZJWE1FOiBUaGlzIHRl c3QgZmFpbHMgb24gaU9TLiBTZWUgPHJkYXI6Ly9wcm9ibGVtLzIwNTMwMzE2PiBmb3IgbW9yZSBk ZXRhaWxzLgorVEVTVChXZWJLaXQyLCBTS0lQX09OX0lPUyhGaXhlZExheW91dFNpemUpKQogewog ICAgIFJldGFpblB0cjxXS1dlYlZpZXc+IHdlYlZpZXcgPSBhZG9wdE5TKFtbV0tXZWJWaWV3IGFs bG9jXSBpbml0V2l0aEZyYW1lOk5TTWFrZVJlY3QoMCwgMCwgMTAwLCAxMDApXSk7CiAK 250711 2015-04-14 09:32:43 -0700 2015-04-14 10:33:15 -0700 Skip the test on iOS bug-143693-20150414093147.patch text/plain 1446 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyNzk2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDQ5ZWEzOGE1NWIwNzAyZDhlYzAyZjcwOTUxOTcxY2Vm NTgzMjA2Ni4uMzNlNjYxMDczYjg5NjQyNzliMzhmMmY3NTA5NjY3MmZkMjQxZDZiZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE1LTA0LTE0ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBTa2lwIGZhaWxpbmcgdGVzdCBUZXN0cy9XZWJLaXQyQ29jb2EvRml4ZWRMYXlvdXRTaXpl Lm1tIG9uIGlPUworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTQzNjkzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yMDUzMDMxNj4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTa2lwIHRoZSB0ZXN0IFRlc3Rz L1dlYktpdDJDb2NvYS9GaXhlZExheW91dFNpemUubW0gYXMgd2UgZG8gbm90IHBsYW4KKyAgICAg ICAgdG8gdXNlIHRoZSBmaXhlZCBsYXlvdXQgY29kZSBvbiBpT1MgYXQgdGhpcyB0aW1lLgorCisg ICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyQ29jb2EvRml4ZWRMYXlvdXRTaXpl Lm1tOiBBZGQgIVBMQVRGT1JNKElPUyktZ3VhcmQuCisKIDIwMTUtMDQtMTQgIERvbWluaWsgUsO2 dHRzY2hlcyAgPGRvbWluaWsucm90dHNjaGVzQGludGVsLmNvbT4KIAogICAgICAgICBSZW1vdmUg bXlzZWxmIGZyb20gd2F0Y2hsaXN0LCByZW1vdmUgZW1wdHkgQ2Fpcm8gYW5kIEhhcmZCdXp6IHdh dGNobGlzdHMKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0MkNv Y29hL0ZpeGVkTGF5b3V0U2l6ZS5tbSBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0 MkNvY29hL0ZpeGVkTGF5b3V0U2l6ZS5tbQppbmRleCBlYTQ3MzkwNTM5MTNmNWU0OWRjNDRmMTkz ZGEzMDMyOTFiYjRjYzJhLi40Mjk1MzVjYjNjZDhjMGFlMjRjNGU3MWFjM2FmZTM3YmU4MzMzZTE1 IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJDb2NvYS9GaXhl ZExheW91dFNpemUubW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyQ29j b2EvRml4ZWRMYXlvdXRTaXplLm1tCkBAIC0zMCw3ICszMCw3IEBACiAjaW1wb3J0IDxXZWJLaXQv V0tXZWJWaWV3UHJpdmF0ZS5oPgogI2ltcG9ydCA8d3RmL1JldGFpblB0ci5oPgogCi0jaWYgV0tf QVBJX0VOQUJMRUQKKyNpZiBXS19BUElfRU5BQkxFRCAmJiAhUExBVEZPUk0oSU9TKQogCiBzdGF0 aWMgYm9vbCBmaXhlZExheW91dFNpemVEb25lOwogc3RhdGljIGJvb2wgZml4ZWRMYXlvdXRTaXpl QWZ0ZXJOYXZpZ2F0aW9uRG9uZTsK