143687 2015-04-13 18:00:42 -0700 Keep track of each shared memory object's protection when deciding whether to return our existing port 2015-04-14 10:40:06 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca bfulgham oldest_to_newest 1085019 0 andersca 2015-04-13 18:00:42 -0700 Keep track of each shared memory object's protection when deciding whether to return our existing port 1085020 1 250685 andersca 2015-04-13 18:01:51 -0700 Created attachment 250685 Patch 1085026 2 andersca 2015-04-13 18:34:48 -0700 Committed r182774: <http://trac.webkit.org/changeset/182774> 1085177 3 bfulgham 2015-04-14 10:28:17 -0700 This patch is making the Debug Windows bot go crazy with errors. Why!?! Can you please fix?!? 1085178 4 bfulgham 2015-04-14 10:28:58 -0700 Crash Crash Crash: https://build.webkit.org/results/Apple%20Win%207%20Debug%20(Tests)/r182774%20(65688)/results.html 1085179 5 bfulgham 2015-04-14 10:31:25 -0700 Whoops! False alarm -- it was Chris's patch that landed just prior to yours. Nothing to see here. Carry on... 1085189 6 andersca 2015-04-14 10:40:06 -0700 (In reply to comment #5) > Whoops! False alarm -- it was Chris's patch that landed just prior to yours. > Nothing to see here. Carry on... Right. Pro tip: If a patch only touches WebKit2 it's impossible for it to cause crashes on Windows ;) 250685 2015-04-13 18:01:51 -0700 2015-04-13 18:12:57 -0700 Patch bug-143687-20150413180102.patch text/plain 4973 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyNzYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOWVjZGEwOWE4MGQ1MzIx NTFjNDY3ODcwZjI0NmNiNmIyOWU1ZmFmNy4uYmFmMjlhZjRkMjk5MTFmNGQ2NzA2MGI2YmEzZjNl MDZhYTAxNmRjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE1LTA0LTEzICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgS2VlcCB0cmFjayBv ZiBlYWNoIHNoYXJlZCBtZW1vcnkgb2JqZWN0J3MgcHJvdGVjdGlvbiB3aGVuIGRlY2lkaW5nIHdo ZXRoZXIgdG8gcmV0dXJuIG91ciBleGlzdGluZyBwb3J0CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDM2ODcKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFBsYXRmb3JtL1NoYXJlZE1lbW9yeS5oOgorICAg ICAgICAqIFBsYXRmb3JtL21hYy9TaGFyZWRNZW1vcnlNYWMuY3BwOgorICAgICAgICAoV2ViS2l0 OjptYWNoUHJvdGVjdGlvbik6CisgICAgICAgIChXZWJLaXQ6OlNoYXJlZE1lbW9yeTo6Y3JlYXRl KToKKyAgICAgICAgKFdlYktpdDo6U2hhcmVkTWVtb3J5OjptYXApOgorICAgICAgICAoV2ViS2l0 OjpTaGFyZWRNZW1vcnk6OmNyZWF0ZUhhbmRsZSk6CisKKzIwMTUtMDQtMTMgIEFuZGVycyBDYXJs c3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKwogICAgICAgICBSZW5hbWUgU2hhcmVkTWVtb3J5 OjpjcmVhdGUgb3ZlcmxvYWRzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNDM2NzkKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0v U2hhcmVkTWVtb3J5LmggYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9TaGFyZWRNZW1vcnkuaApp bmRleCAzZDg3NzVjZWU5NzBmYmIyMmFkZjYyMTVlMGJkYjhlMWJmODg1ZjQ2Li42NTA3Y2M1ZDU4 ZThjNDE1NjE4NDFiZTYxNWQ1ODQyYzMyNWM5MGUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9QbGF0Zm9ybS9TaGFyZWRNZW1vcnkuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9T aGFyZWRNZW1vcnkuaApAQCAtOTQsNiArOTQsNyBAQCBwcml2YXRlOgogICAgIHNpemVfdCBtX3Np emU7CiAgICAgdm9pZCogbV9kYXRhOwogICAgIGJvb2wgbV9zaG91bGRWTURlYWxsb2NhdGVEYXRh OworICAgIFByb3RlY3Rpb24gbV9wcm90ZWN0aW9uOwogCiAjaWYgT1MoREFSV0lOKQogICAgIG1h Y2hfcG9ydF90IG1fcG9ydDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL21h Yy9TaGFyZWRNZW1vcnlNYWMuY3BwIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vbWFjL1NoYXJl ZE1lbW9yeU1hYy5jcHAKaW5kZXggNDU5MjRhODQxMmNlNjE2MzA2OThlYzc2MzYxNWU1Mjk4MzJm YzQwYi4uZmEwYjQyMjczMjU5MDM5N2ZlZmE0ZTJiMzhiODMxYmE2NzNlNWI3ZCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vbWFjL1NoYXJlZE1lbW9yeU1hYy5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvUGxhdGZvcm0vbWFjL1NoYXJlZE1lbW9yeU1hYy5jcHAKQEAgLTExOSwx NCArMTE5LDI3IEBAIFJlZlB0cjxTaGFyZWRNZW1vcnk+IFNoYXJlZE1lbW9yeTo6YWxsb2NhdGUo c2l6ZV90IHNpemUpCiAgICAgcmV0dXJuIHNoYXJlZE1lbW9yeS5yZWxlYXNlKCk7CiB9CiAKLVJl ZlB0cjxTaGFyZWRNZW1vcnk+IFNoYXJlZE1lbW9yeTo6Y3JlYXRlKHZvaWQqIGRhdGEsIHNpemVf dCBzaXplLCBQcm90ZWN0aW9uKQorc3RhdGljIGlubGluZSB2bV9wcm90X3QgbWFjaFByb3RlY3Rp b24oU2hhcmVkTWVtb3J5OjpQcm90ZWN0aW9uIHByb3RlY3Rpb24pCit7CisgICAgc3dpdGNoIChw cm90ZWN0aW9uKSB7CisgICAgY2FzZSBTaGFyZWRNZW1vcnk6OlByb3RlY3Rpb246OlJlYWRPbmx5 OgorICAgICAgICByZXR1cm4gVk1fUFJPVF9SRUFEOworICAgIGNhc2UgU2hhcmVkTWVtb3J5OjpQ cm90ZWN0aW9uOjpSZWFkV3JpdGU6CisgICAgICAgIHJldHVybiBWTV9QUk9UX1JFQUQgfCBWTV9Q Uk9UX1dSSVRFOworICAgIH0KKworICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgIHJldHVy biBWTV9QUk9UX05PTkU7Cit9CisKK1JlZlB0cjxTaGFyZWRNZW1vcnk+IFNoYXJlZE1lbW9yeTo6 Y3JlYXRlKHZvaWQqIGRhdGEsIHNpemVfdCBzaXplLCBQcm90ZWN0aW9uIHByb3RlY3Rpb24pCiB7 CiAgICAgQVNTRVJUKHNpemUpOwogICAgIAogICAgIC8vIENyZWF0ZSBhIE1hY2ggcG9ydCB0aGF0 IHJlcHJlc2VudHMgdGhlIHNoYXJlZCBtZW1vcnkuCiAgICAgbWFjaF9wb3J0X3QgcG9ydDsKICAg ICBtZW1vcnlfb2JqZWN0X3NpemVfdCBtZW1vcnlPYmplY3RTaXplID0gcm91bmRfcGFnZShzaXpl KTsKLSAgICBrZXJuX3JldHVybl90IGtyID0gbWFjaF9tYWtlX21lbW9yeV9lbnRyeV82NChtYWNo X3Rhc2tfc2VsZigpLCAmbWVtb3J5T2JqZWN0U2l6ZSwgdG9WTUFkZHJlc3MoZGF0YSksIFZNX1BS T1RfREVGQVVMVCB8IFZNX1BST1RfSVNfTUFTSywgJnBvcnQsIE1BQ0hfUE9SVF9OVUxMKTsKKyAg ICBrZXJuX3JldHVybl90IGtyID0gbWFjaF9tYWtlX21lbW9yeV9lbnRyeV82NChtYWNoX3Rhc2tf c2VsZigpLCAmbWVtb3J5T2JqZWN0U2l6ZSwgdG9WTUFkZHJlc3MoZGF0YSksIG1hY2hQcm90ZWN0 aW9uKHByb3RlY3Rpb24pIHwgVk1fUFJPVF9JU19NQVNLLCAmcG9ydCwgTUFDSF9QT1JUX05VTEwp OwogICAgIAogICAgIGlmIChrciAhPSBLRVJOX1NVQ0NFU1MpIHsKICAgICAgICAgTE9HX0VSUk9S KCJGYWlsZWQgdG8gY3JlYXRlIGEgbWFjaCBwb3J0IGZvciBzaGFyZWQgbWVtb3J5LiAlcyAoJXgp IiwgbWFjaF9lcnJvcl9zdHJpbmcoa3IpLCBrcik7CkBAIC0xNDUsMjMgKzE1OCwxMSBAQCBSZWZQ dHI8U2hhcmVkTWVtb3J5PiBTaGFyZWRNZW1vcnk6OmNyZWF0ZSh2b2lkKiBkYXRhLCBzaXplX3Qg c2l6ZSwgUHJvdGVjdGlvbikKICAgICBzaGFyZWRNZW1vcnktPm1fZGF0YSA9IGRhdGE7CiAgICAg c2hhcmVkTWVtb3J5LT5tX3Nob3VsZFZNRGVhbGxvY2F0ZURhdGEgPSBmYWxzZTsKICAgICBzaGFy ZWRNZW1vcnktPm1fcG9ydCA9IHBvcnQ7CisgICAgc2hhcmVkTWVtb3J5LT5tX3Byb3RlY3Rpb24g PSBwcm90ZWN0aW9uOwogCiAgICAgcmV0dXJuIHNoYXJlZE1lbW9yeS5yZWxlYXNlKCk7CiB9CiAK LXN0YXRpYyBpbmxpbmUgdm1fcHJvdF90IG1hY2hQcm90ZWN0aW9uKFNoYXJlZE1lbW9yeTo6UHJv dGVjdGlvbiBwcm90ZWN0aW9uKQotewotICAgIHN3aXRjaCAocHJvdGVjdGlvbikgewotICAgIGNh c2UgU2hhcmVkTWVtb3J5OjpQcm90ZWN0aW9uOjpSZWFkT25seToKLSAgICAgICAgcmV0dXJuIFZN X1BST1RfUkVBRDsKLSAgICBjYXNlIFNoYXJlZE1lbW9yeTo6UHJvdGVjdGlvbjo6UmVhZFdyaXRl OgotICAgICAgICByZXR1cm4gVk1fUFJPVF9SRUFEIHwgVk1fUFJPVF9XUklURTsKLSAgICB9Ci0K LSAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKLSAgICByZXR1cm4gVk1fUFJPVF9OT05FOyAgICAK LX0KLQogUmVmUHRyPFNoYXJlZE1lbW9yeT4gU2hhcmVkTWVtb3J5OjptYXAoY29uc3QgSGFuZGxl JiBoYW5kbGUsIFByb3RlY3Rpb24gcHJvdGVjdGlvbikKIHsKICAgICBpZiAoaGFuZGxlLmlzTnVs bCgpKQpAQCAtMTczLDE1ICsxNzQsMTYgQEAgUmVmUHRyPFNoYXJlZE1lbW9yeT4gU2hhcmVkTWVt b3J5OjptYXAoY29uc3QgSGFuZGxlJiBoYW5kbGUsIFByb3RlY3Rpb24gcHJvdGVjdGkKICAgICBt YWNoX3ZtX2FkZHJlc3NfdCBtYXBwZWRBZGRyZXNzID0gMDsKICAgICBrZXJuX3JldHVybl90IGty ID0gbWFjaF92bV9tYXAobWFjaF90YXNrX3NlbGYoKSwgJm1hcHBlZEFkZHJlc3MsIHJvdW5kX3Bh Z2UoaGFuZGxlLm1fc2l6ZSksIDAsIFZNX0ZMQUdTX0FOWVdIRVJFLCBoYW5kbGUubV9wb3J0LCAw LCBmYWxzZSwgdm1Qcm90ZWN0aW9uLCB2bVByb3RlY3Rpb24sIFZNX0lOSEVSSVRfTk9ORSk7CiAg ICAgaWYgKGtyICE9IEtFUk5fU1VDQ0VTUykKLSAgICAgICAgcmV0dXJuIDA7CisgICAgICAgIHJl dHVybiBudWxscHRyOwogCiAgICAgUmVmUHRyPFNoYXJlZE1lbW9yeT4gc2hhcmVkTWVtb3J5KGFk b3B0UmVmKG5ldyBTaGFyZWRNZW1vcnkpKTsKICAgICBzaGFyZWRNZW1vcnktPm1fc2l6ZSA9IGhh bmRsZS5tX3NpemU7CiAgICAgc2hhcmVkTWVtb3J5LT5tX2RhdGEgPSB0b1BvaW50ZXIobWFwcGVk QWRkcmVzcyk7CiAgICAgc2hhcmVkTWVtb3J5LT5tX3Nob3VsZFZNRGVhbGxvY2F0ZURhdGEgPSB0 cnVlOwogICAgIHNoYXJlZE1lbW9yeS0+bV9wb3J0ID0gTUFDSF9QT1JUX05VTEw7CisgICAgc2hh cmVkTWVtb3J5LT5tX3Byb3RlY3Rpb24gPSBwcm90ZWN0aW9uOwogCi0gICAgcmV0dXJuIHNoYXJl ZE1lbW9yeS5yZWxlYXNlKCk7CisgICAgcmV0dXJuIHNoYXJlZE1lbW9yeTsKIH0KIAogU2hhcmVk TWVtb3J5Ojp+U2hhcmVkTWVtb3J5KCkKQEAgLTIwNyw3ICsyMDksNyBAQCBib29sIFNoYXJlZE1l bW9yeTo6Y3JlYXRlSGFuZGxlKEhhbmRsZSYgaGFuZGxlLCBQcm90ZWN0aW9uIHByb3RlY3Rpb24p CiAKICAgICBtYWNoX3BvcnRfdCBwb3J0OwogCi0gICAgaWYgKHByb3RlY3Rpb24gPT0gUHJvdGVj dGlvbjo6UmVhZFdyaXRlICYmIG1fcG9ydCkgeworICAgIGlmIChwcm90ZWN0aW9uID09IG1fcHJv dGVjdGlvbiAmJiBtX3BvcnQpIHsKICAgICAgICAgLy8gSnVzdCByZS11c2UgdGhlIHBvcnQgd2Ug aGF2ZS4KICAgICAgICAgcG9ydCA9IG1fcG9ydDsKICAgICAgICAgaWYgKG1hY2hfcG9ydF9tb2Rf cmVmcyhtYWNoX3Rhc2tfc2VsZigpLCBwb3J0LCBNQUNIX1BPUlRfUklHSFRfU0VORCwgMSkgIT0g S0VSTl9TVUNDRVNTKQo=