143670 2015-04-13 09:48:21 -0700 [EFL] fix efreet error 2015-05-20 19:33:29 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=134023 P2 Normal --- 1 hyuki.kim webkit-unassigned commit-queue gyuyoung.kim lucas.de.marchi ossy ryuan.choi oldest_to_newest 1084836 0 hyuki.kim 2015-04-13 09:48:21 -0700 ERR<25282>:efreet_cache lib/efreet/efreet_cache.c:1134 on_send_register() org.freedesktop.DBus.Error.ServiceUnknown The name org.enlightenment.Efreet was not provided by any .service files 1084842 1 250646 hyuki.kim 2015-04-13 09:56:09 -0700 Created attachment 250646 Patch 1084937 2 ossy 2015-04-13 13:15:34 -0700 Is this bug same as bug134023? It would be good to fix it once. This undocumented "feature" is so annoying that the user have to add symlinks as root user manually to have a working EFL WebKit. :-/ I tried to get answer for this bug, bug noone answered ever. :( 1084941 3 ossy 2015-04-13 13:18:30 -0700 So could you describe me what is this efreet_cache_update magic variable? And why do we need magic symlinks if it isn't set and why don't we need if it is set. This changelog doesn't say anything about why is this fix good. 1085048 4 hyuki.kim 2015-04-13 21:57:57 -0700 (In reply to comment #3) > So could you describe me what is this efreet_cache_update magic variable? > And why do we need magic symlinks if it isn't set and why don't we need > if it is set. This changelog doesn't say anything about why is this fix good. It will not monitor icon and desktop cache basically. however, in the webkit there is no listener for those caches AFAIK. 1095639 5 253331 hyuki.kim 2015-05-18 10:54:16 -0700 Created attachment 253331 Patch 1095757 6 253331 ryuan.choi 2015-05-18 17:40:31 -0700 Comment on attachment 253331 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253331&action=review > Tools/ChangeLog:10 > + Fix efreet error by using external variable efreet_cache_update. > + As 0 value of efreet_cache_update prevents monitoring of icon and desktop cache, > + efreet error for efreet_cache does not occur. Although I am not familiar with efreet_cache_update, I think that it looks workaround not to monitor efreet because elm_file_chooser uses efreet for the icon. (MiniBrowser uses elm_file_chooser to download and open dialog for input[type=file]) Could you check whether these usages are fine with your patch? 1096229 7 hyuki.kim 2015-05-20 07:38:19 -0700 (In reply to comment #6) > Comment on attachment 253331 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253331&action=review > > > Tools/ChangeLog:10 > > + Fix efreet error by using external variable efreet_cache_update. > > + As 0 value of efreet_cache_update prevents monitoring of icon and desktop cache, > > + efreet error for efreet_cache does not occur. > > Although I am not familiar with efreet_cache_update, > I think that it looks workaround not to monitor efreet because > elm_file_chooser uses efreet for the icon. > (MiniBrowser uses elm_file_chooser to download and open dialog for > input[type=file]) > > Could you check whether these usages are fine with your patch? I checked that file chooser is working without any issue or error messages. :) 1096432 8 253331 gyuyoung.kim 2015-05-20 18:36:01 -0700 Comment on attachment 253331 Patch I don't know why EFL application should set "efree_cache_update" though, I feel I need to do rubber stamp. rs=me. 1096461 9 253331 commit-queue 2015-05-20 19:33:24 -0700 Comment on attachment 253331 Patch Clearing flags on attachment: 253331 Committed r184691: <http://trac.webkit.org/changeset/184691> 1096462 10 commit-queue 2015-05-20 19:33:29 -0700 All reviewed patches have been landed. Closing bug. 250646 2015-04-13 09:56:09 -0700 2015-05-18 10:54:08 -0700 Patch bug-143670-20150414015514.patch text/plain 1316 hyuki.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyNzI2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzBmZWUzMmM4MTAzZTYzNjk1MzAwMTQ5ZGY5YTY5Zjdh NTBjMzI1NS4uNWQ4ZDA5ZmFlZmU2OTJlOTJhOGRiZjBmZTM0ZTlkZjVlODdjNzViZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE1LTA0LTEzICBLd2FuZ0h5dWsgS2ltICA8aHl1a2kua2ltQHNhbXN1bmcuY29tPgor CisgICAgICAgIFtFRkxdIGZpeCBlZnJlZXQgZXJyb3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MzY3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBlZnJlZXQgZXJyb3IgYnkgdXNpbmcgZXh0ZXJu YWwgdmFyaWFibGUgZWZyZWV0X2NhY2hlX3VwZGF0ZS4KKworICAgICAgICAqIE1pbmlCcm93c2Vy L2VmbC9tYWluLmM6CisgICAgICAgIChlbG1fbWFpbik6CisKIDIwMTUtMDQtMTIgIEd5dXlvdW5n IEtpbSAgPGd5dXlvdW5nLmtpbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtFRkxdIEVuYWJsZSBN ZWRpYSBTb3VyY2UKZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMgYi9U b29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCmluZGV4IGNlYTFmODIwNDQ0NWYxYWQyYjIyZjY5 Nzg0ODBiYjFiYzM0ZWMyY2UuLmE2YzBkYjA0NDc5Yzk1YjgxNmJmMjExZDNlMmE5ZWYxZGVlNjY0 ZGIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMKKysrIGIvVG9vbHMv TWluaUJyb3dzZXIvZWZsL21haW4uYwpAQCAtMjYsNiArMjYsOCBAQAogI2luY2x1ZGUgPEVsZW1l bnRhcnkuaD4KICNpbmNsdWRlIDxFdmFzLmg+CiAKK2V4dGVybiBpbnQgZWZyZWV0X2NhY2hlX3Vw ZGF0ZTsKKwogc3RhdGljIGNvbnN0IGNoYXIgREVGQVVMVF9VUkxbXSA9ICJodHRwOi8vd3d3Lmdv b2dsZS5jb20vIjsKIHN0YXRpYyBjb25zdCBjaGFyIEFQUF9OQU1FW10gPSAiRUZMIE1pbmlCcm93 c2VyIjsKIHN0YXRpYyBjb25zdCBpbnQgVE9PTF9CQVJfSUNPTl9TSVpFID0gMjQ7CkBAIC0yMzcw LDYgKzIzNzIsOCBAQCBlbG1fbWFpbihpbnQgYXJnYywgY2hhciAqYXJndltdKQogICAgICAgICBF Q09SRV9HRVRPUFRfVkFMVUVfTk9ORQogICAgIH07CiAKKyAgICBlZnJlZXRfY2FjaGVfdXBkYXRl ID0gMDsKKwogICAgIGlmICghZXdrX2luaXQoKSkKICAgICAgICAgcmV0dXJuIEVYSVRfRkFJTFVS RTsKIAo= 253331 2015-05-18 10:54:16 -0700 2015-05-20 19:33:24 -0700 Patch bug-143670-20150519025415.patch text/plain 1506 hyuki.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0NDQ5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWJjMmNlOWMyNTE3OTk2MjM2MzI0NzM4ODgwOTUxMTBl M2RmYWI1Mi4uZmRlMjQ4ZmM3NDRlMWJkNjM5OTQ3OGFmNGEzMDUxZGQwMThkMGQ4MyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE1LTA1LTE4ICBLd2FuZ0h5dWsgS2ltICA8aHl1a2kua2ltQHNhbXN1bmcuY29tPgor CisgICAgICAgIFtFRkxdIGZpeCBlZnJlZXQgZXJyb3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MzY3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBlZnJlZXQgZXJyb3IgYnkgdXNpbmcgZXh0ZXJu YWwgdmFyaWFibGUgZWZyZWV0X2NhY2hlX3VwZGF0ZS4KKyAgICAgICAgQXMgMCB2YWx1ZSBvZiBl ZnJlZXRfY2FjaGVfdXBkYXRlIHByZXZlbnRzIG1vbml0b3Jpbmcgb2YgaWNvbiBhbmQgZGVza3Rv cCBjYWNoZSwKKyAgICAgICAgZWZyZWV0IGVycm9yIGZvciBlZnJlZXRfY2FjaGUgZG9lcyBub3Qg b2NjdXIuCisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9lZmwvbWFpbi5jOgorICAgICAgICAoZWxt X21haW4pOgorCiAyMDE1LTA1LTE3ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+ CiAKICAgICAgICAgYmlzZWN0LWJ1aWxkczogQWRkICdyZXRyeScgb3B0aW9uIHdoZW4gcHJvbXB0 aW5nIHdoZXRoZXIgdGhlIGJ1ZyByZXByb2R1Y2VkCmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJv d3Nlci9lZmwvbWFpbi5jIGIvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYwppbmRleCBhY2Rh Y2Q1MzRiY2Q4ZDBkNmNkMDMxOGE4OWJjZDU0Y2RkMzkxZTk5Li42ZjQ4ZGNlYWYwNjEwNDIwNmQ0 OWFiZGU5YzM4ODA5ZTI5NmZlYjQ2IDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nlci9lZmwv bWFpbi5jCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMKQEAgLTI2LDYgKzI2LDgg QEAKICNpbmNsdWRlIDxFbGVtZW50YXJ5Lmg+CiAjaW5jbHVkZSA8RXZhcy5oPgogCitleHRlcm4g aW50IGVmcmVldF9jYWNoZV91cGRhdGU7CisKIHN0YXRpYyBjb25zdCBjaGFyIERFRkFVTFRfVVJM W10gPSAiaHR0cDovL3d3dy5nb29nbGUuY29tLyI7CiBzdGF0aWMgY29uc3QgY2hhciBBUFBfTkFN RVtdID0gIkVGTCBNaW5pQnJvd3NlciI7CiBzdGF0aWMgY29uc3QgaW50IFRPT0xfQkFSX0lDT05f U0laRSA9IDI0OwpAQCAtMjM4Myw2ICsyMzg1LDggQEAgZWxtX21haW4oaW50IGFyZ2MsIGNoYXIg KmFyZ3ZbXSkKICAgICAgICAgRUNPUkVfR0VUT1BUX1ZBTFVFX05PTkUKICAgICB9OwogCisgICAg ZWZyZWV0X2NhY2hlX3VwZGF0ZSA9IDA7CisKICAgICBpZiAoIWV3a19pbml0KCkpCiAgICAgICAg IHJldHVybiBFWElUX0ZBSUxVUkU7CiAK