143666 2015-04-13 06:41:46 -0700 [Win] Incorrect parameter order in call to WebView::repaint. 2015-04-13 09:26:13 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned achristensen bfulgham oldest_to_newest 1084779 0 peavo 2015-04-13 06:41:46 -0700 The 'immediate' default parameter has been forgotten. 1084781 1 250636 peavo 2015-04-13 06:44:51 -0700 Created attachment 250636 Patch 1084812 2 250636 bfulgham 2015-04-13 08:48:14 -0700 Comment on attachment 250636 Patch Yikes! Thank you for finding this! r=me. 1084815 3 peavo 2015-04-13 08:55:46 -0700 (In reply to comment #2) > Comment on attachment 250636 [details] > Patch > > Yikes! Thank you for finding this! r=me. Thanks for reviewing :) 1084825 4 peavo 2015-04-13 09:25:27 -0700 Committed r182736: <http://trac.webkit.org/changeset/182736> 250636 2015-04-13 06:44:51 -0700 2015-04-13 08:48:14 -0700 Patch bug-143666-20150413154353.patch text/plain 2271 peavo SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MjcyNykKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA0LTEz ICBQZXIgQXJuZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2luXSBJ bmNvcnJlY3QgcGFyYW1ldGVyIG9yZGVyIGluIGNhbGwgdG8gV2ViVmlldzo6cmVwYWludC4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MzY2NgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSAnaW1tZWRp YXRlJyBkZWZhdWx0IHBhcmFtZXRlciBoYXMgYmVlbiBmb3Jnb3R0ZW4uCisKKyAgICAgICAgKiBX ZWJDb3JlU3VwcG9ydC9XZWJDaHJvbWVDbGllbnQuY3BwOgorICAgICAgICAoV2ViQ2hyb21lQ2xp ZW50OjppbnZhbGlkYXRlUm9vdFZpZXcpOgorICAgICAgICAoV2ViQ2hyb21lQ2xpZW50OjppbnZh bGlkYXRlQ29udGVudHNBbmRSb290Vmlldyk6CisgICAgICAgIChXZWJDaHJvbWVDbGllbnQ6Omlu dmFsaWRhdGVDb250ZW50c0ZvclNsb3dTY3JvbGwpOgorCiAyMDE1LTA0LTExICBZdXN1a2UgU3V6 dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIFtFUzZdIEVuYWJsZSBTeW1i b2wgaW4gd2ViIHBhZ2VzCkluZGV4OiBTb3VyY2UvV2ViS2l0L3dpbi9XZWJDb3JlU3VwcG9ydC9X ZWJDaHJvbWVDbGllbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvd2luL1dlYkNv cmVTdXBwb3J0L1dlYkNocm9tZUNsaWVudC5jcHAJKHJldmlzaW9uIDE4MjY4NSkKKysrIFNvdXJj ZS9XZWJLaXQvd2luL1dlYkNvcmVTdXBwb3J0L1dlYkNocm9tZUNsaWVudC5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTQ2MywxOSArNDYzLDE5IEBAIEludFJlY3QgV2ViQ2hyb21lQ2xpZW50Ojp3aW5k b3dSZXNpemVyUmUKIHZvaWQgV2ViQ2hyb21lQ2xpZW50OjppbnZhbGlkYXRlUm9vdFZpZXcoY29u c3QgSW50UmVjdCYgd2luZG93UmVjdCkKIHsKICAgICBBU1NFUlQoY29yZShtX3dlYlZpZXctPnRv cExldmVsRnJhbWUoKSkpOwotICAgIG1fd2ViVmlldy0+cmVwYWludCh3aW5kb3dSZWN0LCBmYWxz ZSAvKmNvbnRlbnRDaGFuZ2VkKi8sIGZhbHNlIC8qcmVwYWludENvbnRlbnRPbmx5Ki8pOworICAg IG1fd2ViVmlldy0+cmVwYWludCh3aW5kb3dSZWN0LCBmYWxzZSAvKmNvbnRlbnRDaGFuZ2VkKi8s IGZhbHNlIC8qaW1tZWRpYXRlKi8sIGZhbHNlIC8qcmVwYWludENvbnRlbnRPbmx5Ki8pOwogfQog CiB2b2lkIFdlYkNocm9tZUNsaWVudDo6aW52YWxpZGF0ZUNvbnRlbnRzQW5kUm9vdFZpZXcoY29u c3QgSW50UmVjdCYgd2luZG93UmVjdCkKIHsKICAgICBBU1NFUlQoY29yZShtX3dlYlZpZXctPnRv cExldmVsRnJhbWUoKSkpOwotICAgIG1fd2ViVmlldy0+cmVwYWludCh3aW5kb3dSZWN0LCB0cnVl IC8qY29udGVudENoYW5nZWQqLywgZmFsc2UgLypyZXBhaW50Q29udGVudE9ubHkqLyk7CisgICAg bV93ZWJWaWV3LT5yZXBhaW50KHdpbmRvd1JlY3QsIHRydWUgLypjb250ZW50Q2hhbmdlZCovLCBm YWxzZSAvKmltbWVkaWF0ZSovLCBmYWxzZSAvKnJlcGFpbnRDb250ZW50T25seSovKTsKIH0KIAog dm9pZCBXZWJDaHJvbWVDbGllbnQ6OmludmFsaWRhdGVDb250ZW50c0ZvclNsb3dTY3JvbGwoY29u c3QgSW50UmVjdCYgd2luZG93UmVjdCkKIHsKICAgICBBU1NFUlQoY29yZShtX3dlYlZpZXctPnRv cExldmVsRnJhbWUoKSkpOwotICAgIG1fd2ViVmlldy0+cmVwYWludCh3aW5kb3dSZWN0LCB0cnVl IC8qY29udGVudENoYW5nZWQqLywgdHJ1ZSAvKnJlcGFpbnRDb250ZW50T25seSovKTsKKyAgICBt X3dlYlZpZXctPnJlcGFpbnQod2luZG93UmVjdCwgdHJ1ZSAvKmNvbnRlbnRDaGFuZ2VkKi8sIGZh bHNlIC8qaW1tZWRpYXRlKi8sIHRydWUgLypyZXBhaW50Q29udGVudE9ubHkqLyk7CiB9CiAKIHZv aWQgV2ViQ2hyb21lQ2xpZW50OjpzY3JvbGwoY29uc3QgSW50U2l6ZSYgZGVsdGEsIGNvbnN0IElu dFJlY3QmIHNjcm9sbFZpZXdSZWN0LCBjb25zdCBJbnRSZWN0JiBjbGlwUmVjdCkK