143665 2015-04-13 06:24:13 -0700 [cmake] REGRESSION(182663): It broke feature dependency handling 2015-04-13 10:43:43 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Critical --- 143596 1 ossy mcatanzaro commit-queue mcatanzaro mrobinson oldest_to_newest 1084778 0 ossy 2015-04-13 06:24:13 -0700 Before http://trac.webkit.org/changeset/182663 the EFL --minimal build worked fine, because ENABLE_ENCRYPTED_MEDIA_V2 and ENABLE_MEDIA_CONTROLS_SCRIPT were disabled automatically by cmake: -- Disabling ENABLE_ENCRYPTED_MEDIA_V2 since ENABLE_VIDEO support is disabled. -- Disabling ENABLE_MEDIA_CONTROLS_SCRIPT since ENABLE_VIDEO support is disabled. But r182663 made something wrong, because these options aren't disabled automatically which cause build failure. Could you check what was going wrong? 1084810 1 250640 mcatanzaro 2015-04-13 08:43:08 -0700 Created attachment 250640 [cmake] REGRESSION(182663): It broke feature dependency handling 1084811 2 mcatanzaro 2015-04-13 08:44:02 -0700 This *isn't tested* because I have to run right now. I'll test it later today. 1084814 3 250640 ossy 2015-04-13 08:55:42 -0700 Comment on attachment 250640 [cmake] REGRESSION(182663): It broke feature dependency handling Thanks for the patch, it looks reasonable and fixes the issue I reported. If you can't see any other issue, feel free to land it. 1084869 4 250640 commit-queue 2015-04-13 10:43:38 -0700 Comment on attachment 250640 [cmake] REGRESSION(182663): It broke feature dependency handling Clearing flags on attachment: 250640 Committed r182740: <http://trac.webkit.org/changeset/182740> 1084870 5 commit-queue 2015-04-13 10:43:43 -0700 All reviewed patches have been landed. Closing bug. 250640 2015-04-13 08:43:08 -0700 2015-04-13 10:43:38 -0700 [cmake] REGRESSION(182663): It broke feature dependency handling bug-143665-20150413104213.patch text/plain 2156 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyNjY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0RmVhdHVyZXMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKaW5k ZXggMGMwZjVmNzVmMWMwMTFhNzU3MjBlMThlNTY4YTk5ZGVlZWI1ZTY0ZS4uOGE2YzgwNGNhYzc3 MmNlM2FmMTM5ZjZlYmZlYWIyZTBkYmQ3Y2RkYyAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dl YktpdEZlYXR1cmVzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFr ZQpAQCAtMTc2LDYgKzE3NiwxMSBAQCBtYWNybyhXRUJLSVRfT1BUSU9OX0VORCkKICAgICAgICAg ICAgIHNldChfTUFYX0ZFQVRVUkVfTEVOR1RIICR7X05BTUVfTEVOR1RIfSkKICAgICAgICAgZW5k aWYgKCkKIAorICAgICAgICBvcHRpb24oJHtfbmFtZX0gIiR7X1dFQktJVF9BVkFJTEFCTEVfT1BU SU9OU19ERVNDUklQVElPTl8ke19uYW1lfX0iICR7X1dFQktJVF9BVkFJTEFCTEVfT1BUSU9OU19J TklUSUFMX1ZBTFVFXyR7X25hbWV9fSkKKyAgICAgICAgaWYgKE5PVCBfV0VCS0lUX0FWQUlMQUJM RV9PUFRJT05TX0lTX1BVQkxJQ18ke19uYW1lfSkKKyAgICAgICAgICAgIG1hcmtfYXNfYWR2YW5j ZWQoRk9SQ0UgJHtfbmFtZX0pCisgICAgICAgIGVuZGlmICgpCisKICAgICAgICAgaWYgKCR7X25h bWV9IEFORCBERUZJTkVEIF9XRUJLSVRfQVZBSUxBQkxFX09QVElPTlNfREVQRU5ERU5DWV9PRl8k e19uYW1lfSkKICAgICAgICAgICAgIGlmIChOT1QgJHske19XRUJLSVRfQVZBSUxBQkxFX09QVElP TlNfREVQRU5ERU5DWV9PRl8ke19uYW1lfX19KQogICAgICAgICAgICAgICAgIG1lc3NhZ2UoU1RB VFVTICJEaXNhYmxpbmcgJHtfbmFtZX0gc2luY2UgJHtfV0VCS0lUX0FWQUlMQUJMRV9PUFRJT05T X0RFUEVOREVOQ1lfT0ZfJHtfbmFtZX19IHN1cHBvcnQgaXMgZGlzYWJsZWQuIikKQEAgLTE4Mywx MSArMTg4LDYgQEAgbWFjcm8oV0VCS0lUX09QVElPTl9FTkQpCiAgICAgICAgICAgICBlbmRpZiAo KQogICAgICAgICBlbmRpZiAoKQogCi0gICAgICAgIG9wdGlvbigke19uYW1lfSAiJHtfV0VCS0lU X0FWQUlMQUJMRV9PUFRJT05TX0RFU0NSSVBUSU9OXyR7X25hbWV9fSIgJHtfV0VCS0lUX0FWQUlM QUJMRV9PUFRJT05TX0lOSVRJQUxfVkFMVUVfJHtfbmFtZX19KQotICAgICAgICBpZiAoTk9UIF9X RUJLSVRfQVZBSUxBQkxFX09QVElPTlNfSVNfUFVCTElDXyR7X25hbWV9KQotICAgICAgICAgICAg bWFya19hc19hZHZhbmNlZChGT1JDRSAke19uYW1lfSkKLSAgICAgICAgZW5kaWYgKCkKLQogICAg ICAgICBpZiAoJHtfbmFtZX0pCiAgICAgICAgICAgICBsaXN0KEFQUEVORCBGRUFUVVJFX0RFRklO RVMgJHtfbmFtZX0pCiAgICAgICAgICAgICBzZXQoRkVBVFVSRV9ERUZJTkVTX1dJVEhfU1BBQ0Vf U0VQQVJBVE9SICIke0ZFQVRVUkVfREVGSU5FU19XSVRIX1NQQUNFX1NFUEFSQVRPUn0gJHtfbmFt ZX0iKQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDBhZDAyMDFiNDAz NmNmMjE2MTQ4ZDYyZjUyZjY5ZThjMGY4NGYyMzEuLjgyNjZjMDQxMWQ3ZmVmYWJhZjI2ZjgxOWY5 YTBiOGU1NGQ1Mzk1NDEgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNCBAQAorMjAxNS0wNC0xMyAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJv QGlnYWxpYS5jb20+CisKKyAgICAgICAgW2NtYWtlXSBSRUdSRVNTSU9OKDE4MjY2Myk6IEl0IGJy b2tlIGZlYXR1cmUgZGVwZW5kZW5jeSBoYW5kbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzNjY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRG9uJ3QgdHJ5IHRvIGNoZWNrIHRoZSB2YWx1ZSBvZiBv cHRpb25zIGJlZm9yZSBkZWZpbmluZyB0aGUgb3B0aW9ucy4KKworICAgICAgICAqIFNvdXJjZS9j bWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFrZToKKwogMjAxNS0wNC0xMSAgTWljaGFlbCBDYXRhbnph cm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gTWFyayBhcyBhZHZh bmNlZCB0aGUgYnVpbGQgb3B0aW9ucyB3ZSBkb24ndCB3YW50IHRvIGV4cG9zZQo=