143664 2015-04-13 05:51:06 -0700 [cmake] Add ENABLE(ATTACHMENT_ELEMENT) to the build system 2015-04-13 07:12:43 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy ossy cgarcia gyuyoung.kim ossy oldest_to_newest 1084770 0 ossy 2015-04-13 05:51:06 -0700 HTML <attachment> element introduced in https://trac.webkit.org/changeset/180193 and was enable for Apple Mac only. We should add ENABLE(ATTACHMENT_ELEMENT) to the cmake build system to be able to enable it on other ports later. 1084771 1 250634 ossy 2015-04-13 05:54:28 -0700 Created attachment 250634 Patch 1084784 2 250634 gyuyoung.kim 2015-04-13 07:04:44 -0700 Comment on attachment 250634 Patch LGTM. r=me. 1084790 3 250634 ossy 2015-04-13 07:12:34 -0700 Comment on attachment 250634 Patch Clearing flags on attachment: 250634 Committed r182731: <http://trac.webkit.org/changeset/182731> 1084791 4 ossy 2015-04-13 07:12:43 -0700 All reviewed patches have been landed. Closing bug. 250634 2015-04-13 05:54:28 -0700 2015-04-13 07:12:34 -0700 Patch bug-143664-20150413145333.patch text/plain 7295 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyNzAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzE0N2VkOTM2NmU0NGQy NWVlM2NlNTBjMDI3NjYyMTA4NjEzZmIxZi4uYTM2Y2RhNTQwODRlZDY2ZjZmZWVkODMxYmQxY2Uy YzVmNDFiODYwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA0LTEzICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW2NtYWtlXSBBZGQg RU5BQkxFKEFUVEFDSE1FTlRfRUxFTUVOVCkgdG8gdGhlIGJ1aWxkIHN5c3RlbQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzNjY0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwYWdlL2VmbC9EcmFnQ29u dHJvbGxlckVmbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEcmFnQ29udHJvbGxlcjo6ZGVjbGFy ZUFuZFdyaXRlQXR0YWNobWVudCk6IEFkZGVkIHN0dWIgaW1wbGVtZW50YXRpb24gdG8gZml4IHRo ZSBidWlsZC4KKyAgICAgICAgKiBwYWdlL2d0ay9EcmFnQ29udHJvbGxlckd0ay5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpEcmFnQ29udHJvbGxlcjo6ZGVjbGFyZUFuZFdyaXRlQXR0YWNobWVudCk6 IEFkZGVkIHN0dWIgaW1wbGVtZW50YXRpb24gdG8gZml4IHRoZSBidWlsZC4KKwogMjAxNS0wNC0x MiAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTGVn YWN5IHNjcm9sbCBiZWhhdmlvciBvbiBIVE1MQm9keUVsZW1lbnQgc2hvdWxkIG9ubHkgYXBwbHkg dG8gdGhlIGZpcnN0IGJvZHkgZWxlbWVudCBvZiBhIGRvY3VtZW50CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL2VmbC9EcmFnQ29udHJvbGxlckVmbC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wYWdlL2VmbC9EcmFnQ29udHJvbGxlckVmbC5jcHAKaW5kZXggOWM1NDBlNzYxMzZkMGE5MGEw NThhMGFmOTk1Y2RmNmI5MDk5NDI1Yy4uZjc1YTBhYjNiMjAwODIyYjI3NjZiNGExMDE2ZGI0MWFh N2NjODQ2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9lZmwvRHJhZ0NvbnRyb2xs ZXJFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvZWZsL0RyYWdDb250cm9sbGVyRWZs LmNwcApAQCAtNzMsNCArNzMsMTAgQEAgdm9pZCBEcmFnQ29udHJvbGxlcjo6ZGVjbGFyZUFuZFdy aXRlRHJhZ0ltYWdlKERhdGFUcmFuc2ZlciYsIEVsZW1lbnQmLCBjb25zdCBVUkwKIHsKIH0KIAor I2lmIEVOQUJMRShBVFRBQ0hNRU5UX0VMRU1FTlQpCit2b2lkIERyYWdDb250cm9sbGVyOjpkZWNs YXJlQW5kV3JpdGVBdHRhY2htZW50KERhdGFUcmFuc2ZlciYsIEVsZW1lbnQmLCBjb25zdCBVUkwm KQoreworfQorI2VuZGlmCisKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvZ3Rr L0RyYWdDb250cm9sbGVyR3RrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvZ3RrL0RyYWdDb250 cm9sbGVyR3RrLmNwcAppbmRleCAzYmM3Yzg3ZDU4ZDkwYmE0ZGJjY2ZkZmI1NWFmNTQyMjVmZTIy N2UxLi5lNjZiMGUzOGU4OGNjNmJlYWZjYTU0OTRjNzg4Mzc5NDVmZGUwZDBiIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wYWdlL2d0ay9EcmFnQ29udHJvbGxlckd0ay5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGFnZS9ndGsvRHJhZ0NvbnRyb2xsZXJHdGsuY3BwCkBAIC04MSw0ICs4MSwx MCBAQCB2b2lkIERyYWdDb250cm9sbGVyOjpkZWNsYXJlQW5kV3JpdGVEcmFnSW1hZ2UoRGF0YVRy YW5zZmVyJiBkYXRhVHJhbnNmZXIsIEVsZW1lbgogICAgIGZyYW1lLT5lZGl0b3IoKS53cml0ZUlt YWdlVG9QYXN0ZWJvYXJkKGRhdGFUcmFuc2Zlci5wYXN0ZWJvYXJkKCksIGVsZW1lbnQsIHVybCwg bGFiZWwpOwogfQogCisjaWYgRU5BQkxFKEFUVEFDSE1FTlRfRUxFTUVOVCkKK3ZvaWQgRHJhZ0Nv bnRyb2xsZXI6OmRlY2xhcmVBbmRXcml0ZUF0dGFjaG1lbnQoRGF0YVRyYW5zZmVyJiwgRWxlbWVu dCYsIGNvbnN0IFVSTCYpCit7Cit9CisjZW5kaWYKKwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL2Nt YWtlL09wdGlvbnNFZmwuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZQppbmRl eCBmMjg5ZmNiYzA5MjBkYjlhOWEwMzQ3OTJlMmI4ODU4YmE5MDdmMGZhLi42ZWQ4ZDVhODljOGQ4 YTVmYTE5ZDdlMjZjMGEwNzI0YWU1NWZhYzg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0VmbC5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZQpAQCAtNjgs NiArNjgsNyBAQCBlbmRpZiAoKQogCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShF TkFCTEVfM0RfUkVOREVSSU5HIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUo RU5BQkxFX0FDQ0VTU0lCSUxJVFkgT04pCitXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxV RShFTkFCTEVfQVRUQUNITUVOVF9FTEVNRU5UIE9GRikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9Q T1JUX1ZBTFVFKEVOQUJMRV9CQVRURVJZX1NUQVRVUyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVM VF9QT1JUX1ZBTFVFKEVOQUJMRV9DU1MzX1RFWFQgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRf UE9SVF9WQUxVRShFTkFCTEVfQ1NTX0RFVklDRV9BREFQVEFUSU9OIE9OKQpkaWZmIC0tZ2l0IGEv U291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5j bWFrZQppbmRleCAxMmZhNDcyMTVmZjY0MmVhMDJjNDFmMTgyNmYyMGNhYmQ3YmEyNTBiLi5hNGE5 YTBkNTYyNmU5NGNkYTZhOGYwYmMyMGQxZDNiNDg5OTdhZjBjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv Y21ha2UvT3B0aW9uc0dUSy5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFr ZQpAQCAtMTU0LDYgKzE1NCw3IEBAIGVuZGlmICgpCiAjIEZJWE1FOiBXZSB3YW50IHRvIGV4cG9z ZSBmZXdlciBvcHRpb25zIHRvIGRvd25zdHJlYW0sIGJ1dCBmb3Igbm93IGV2ZXJ5dGhpbmcgaXMg cHVibGljLgogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFXzNEX1JFTkRF UklORyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9BQ0NFU1NJ QklMSVRZIE9OKQorV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0FUVEFD SE1FTlRfRUxFTUVOVCBPRkYpCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFC TEVfQkFUVEVSWV9TVEFUVVMgT0ZGKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUo RU5BQkxFX0NBTlZBU19QQVRIIE9GRikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVF KEVOQUJMRV9DU1MzX1RFWFQgT0ZGKQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL1dlYktpdEZl YXR1cmVzLmNtYWtlIGIvU291cmNlL2NtYWtlL1dlYktpdEZlYXR1cmVzLmNtYWtlCmluZGV4IDBj MGY1Zjc1ZjFjMDExYTc1NzIwZTE4ZTU2OGE5OWRlZWViNWU2NGUuLjg0YzhkY2QzOTlhZjkwYzA3 OWUxMTBlYWY4M2ViOTcyOTA4OTZjNzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9XZWJLaXRG ZWF0dXJlcy5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKQEAg LTMwLDYgKzMwLDcgQEAgbWFjcm8oV0VCS0lUX09QVElPTl9CRUdJTikKICAgICBXRUJLSVRfT1BU SU9OX0RFRklORShFTkFCTEVfQUNDRUxFUkFURURfT1ZFUkZMT1dfU0NST0xMSU5HICJUb2dnbGUg YWNjZWxlcmF0ZWQgc2Nyb2xsaW5nIHN1cHBvcnQiIE9GRikKICAgICBXRUJLSVRfT1BUSU9OX0RF RklORShFTkFCTEVfQUNDRVNTSUJJTElUWSAiVG9nZ2xlIGFjY2Vzc2liaWxpdHkgc3VwcG9ydCIg T0ZGKQogICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9BUElfVEVTVFMgIkVuYWJsZSBw dWJsaWMgQVBJIHVuaXQgdGVzdHMiIE9GRikKKyAgICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFC TEVfQVRUQUNITUVOVF9FTEVNRU5UICJUb2dnbGUgYXR0YWNobWVudCBlbGVtZW50IHN1cHBvcnQi IE9GRikKICAgICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfQVZGX0NBUFRJT05TICJUb2dn bGUgQVZGb3VuZGF0aW9uIGNhcHRpb24gc3VwcG9ydCIgT0ZGKQogICAgIFdFQktJVF9PUFRJT05f REVGSU5FKEVOQUJMRV9BU1NFTUJMRVJfV1hfRVhDTFVTSVZFICJUb2dnbGUgQXNzZW1ibGVyIFdY IEV4Y2x1c2l2ZSBzdXBwb3J0IiBPRkYpCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxF X0JBVFRFUllfU1RBVFVTICJUb2dnbGUgYmF0dGVyeSBzdGF0dXMgQVBJIHN1cHBvcnQiIE9GRikK ZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZWNvbmZpZy5oLmNtYWtlIGIvU291cmNlL2NtYWtlY29u ZmlnLmguY21ha2UKaW5kZXggMjFkM2ZjYzVkOTgzZjk1OTVkZWYzNTEwNTY4Y2RjOTg5NjUyNDZl ZC4uNWU5ODNkNWU2NWIwN2VmN2RjNTNlYzlkM2M2YThhMjkzOTE3NWNiMiAxMDA2NDQKLS0tIGEv U291cmNlL2NtYWtlY29uZmlnLmguY21ha2UKKysrIGIvU291cmNlL2NtYWtlY29uZmlnLmguY21h a2UKQEAgLTUsNiArNSw3IEBACiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfQUNDRUxFUkFURURfMkRf Q0FOVkFTCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfQUNDRUxFUkFURURfT1ZFUkZMT1dfU0NST0xM SU5HCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfQVBJX1RFU1RTCisjY21ha2VkZWZpbmUwMSBFTkFC TEVfQVRUQUNITUVOVF9FTEVNRU5UCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfQVZGX0NBUFRJT05T CiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfQVNTRU1CTEVSX1dYX0VYQ0xVU0lWRQogI2NtYWtlZGVm aW5lMDEgRU5BQkxFX0JBVFRFUllfU1RBVFVTCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzBmZWUzMmM4MTAzZTYzNjk1MzAwMTQ5ZGY5YTY5Zjdh NTBjMzI1NS4uMjdiMmQwMDE2NGJiYzU1MjZmNDU2NTAzNzI5ZWFjNDA1ZDkxZjMzNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDE1LTA0LTEzICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgW2NtYWtlXSBBZGQgRU5BQkxFKEFUVEFDSE1FTlRfRUxFTUVOVCkgdG8gdGhlIGJ1 aWxkIHN5c3RlbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTQzNjY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBTY3JpcHRzL3dlYmtpdHBlcmwvRmVhdHVyZUxpc3QucG06CisKIDIwMTUtMDQtMTIgIEd5 dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtFRkxdIEVu YWJsZSBNZWRpYSBTb3VyY2UKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9G ZWF0dXJlTGlzdC5wbSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9GZWF0dXJlTGlzdC5wbQpp bmRleCAwYjM0ZDQ5YTgxYWI5NTA5MmMyN2Q5YWIyMjUzNWE2MmMzNTFkM2NjLi4zMmY4Yzk4Yjcw M2E5MDU0ZDMzNzM0YzRiMTAwOTI5OGFkYWQ0OTU4IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRz L3dlYmtpdHBlcmwvRmVhdHVyZUxpc3QucG0KKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJs L0ZlYXR1cmVMaXN0LnBtCkBAIC00NCw2ICs0NCw3IEBAIEJFR0lOIHsKIG15ICgKICAgICAkdGhy ZWVEUmVuZGVyaW5nU3VwcG9ydCwKICAgICAkYWNjZWxlcmF0ZWQyRENhbnZhc1N1cHBvcnQsCisg ICAgJGF0dGFjaG1lbnRFbGVtZW50U3VwcG9ydCwKICAgICAkYmF0dGVyeVN0YXR1c1N1cHBvcnQs CiAgICAgJGNhbnZhc1BhdGhTdXBwb3J0LAogICAgICRjYW52YXNQcm94eVN1cHBvcnQsCkBAIC0x NTQsNiArMTU1LDkgQEAgbXkgQGZlYXR1cmVzID0gKAogICAgIHsgb3B0aW9uID0+ICJhY2NlbGVy YXRlZC0yZC1jYW52YXMiLCBkZXNjID0+ICJUb2dnbGUgQWNjZWxlcmF0ZWQgMkQgQ2FudmFzIHN1 cHBvcnQiLAogICAgICAgZGVmaW5lID0+ICJFTkFCTEVfQUNDRUxFUkFURURfMkRfQ0FOVkFTIiwg ZGVmYXVsdCA9PiBpc0d0aygpLCB2YWx1ZSA9PiBcJGFjY2VsZXJhdGVkMkRDYW52YXNTdXBwb3J0 IH0sCiAKKyAgICB7IG9wdGlvbiA9PiAiYXR0YWNobWVudC1lbGVtZW50IiwgZGVzYyA9PiAiVG9n Z2xlIEF0dGFjaG1lbnQgRWxlbWVudCBzdXBwb3J0IiwKKyAgICAgIGRlZmluZSA9PiAiRU5BQkxF X0FUVEFDSE1FTlRfRUxFTUVOVCIsIGRlZmF1bHQgPT4gMCwgdmFsdWUgPT4gXCRhdHRhY2htZW50 RWxlbWVudFN1cHBvcnQgfSwKKwogICAgIHsgb3B0aW9uID0+ICJiYXR0ZXJ5LXN0YXR1cyIsIGRl c2MgPT4gIlRvZ2dsZSBCYXR0ZXJ5IFN0YXR1cyBzdXBwb3J0IiwKICAgICAgIGRlZmluZSA9PiAi RU5BQkxFX0JBVFRFUllfU1RBVFVTIiwgZGVmYXVsdCA9PiBpc0VmbCgpLCB2YWx1ZSA9PiBcJGJh dHRlcnlTdGF0dXNTdXBwb3J0IH0sCiAKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxv ZwppbmRleCBiMzY5ZTVjNzMwYWU0NzViNTk0Yjg2YTI3MTNiMDIzMmExZGVlNzQ4Li5iOTM2MmY3 YWI0NDk2ZTJmMzliY2YyNWJiZTk0OTJhM2U0YmJmOTk1IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cK KysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTUtMDQtMTMgIENzYWJhIE9zenRy b2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBbY21ha2VdIEFkZCBFTkFCTEUo QVRUQUNITUVOVF9FTEVNRU5UKSB0byB0aGUgYnVpbGQgc3lzdGVtCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDM2NjQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zRWZs LmNtYWtlOgorICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlOgorICAgICAg ICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFrZToKKyAgICAgICAgKiBTb3VyY2Uv Y21ha2Vjb25maWcuaC5jbWFrZToKKwogMjAxNS0wNC0xMiAgR3l1eW91bmcgS2ltICA8Z3l1eW91 bmcua2ltQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW0VGTF0gRW5hYmxlIE1lZGlhIFNvdXJjZQo=