143659 2015-04-12 23:06:58 -0700 String.prototype.startsWith/endsWith/includes have wrong length in r182673 2015-04-15 17:16:17 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ljharb ljharb commit-queue oldest_to_newest 1084733 0 ljharb 2015-04-12 23:06:58 -0700 In r182673 nightly, String.prototype.startsWith and String.prototype.endsWith both have a length of 0. According to https://people.mozilla.org/~jorendorff/es6-draft.html#sec-string.prototype.startswith and https://people.mozilla.org/~jorendorff/es6-draft.html#sec-string.prototype.endswith the length of both should explicitly be 1, since they have 1 required argument. 1085747 1 ljharb 2015-04-15 16:04:06 -0700 *** Bug 143660 has been marked as a duplicate of this bug. *** 1085757 2 250881 ljharb 2015-04-15 16:18:34 -0700 Created attachment 250881 Patch 1085771 3 250881 commit-queue 2015-04-15 17:16:14 -0700 Comment on attachment 250881 Patch Clearing flags on attachment: 250881 Committed r182872: <http://trac.webkit.org/changeset/182872> 1085772 4 commit-queue 2015-04-15 17:16:17 -0700 All reviewed patches have been landed. Closing bug. 250881 2015-04-15 16:18:34 -0700 2015-04-15 17:16:14 -0700 Patch bug-143659-20150415161737.patch text/plain 6398 ljharb U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyODY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw MzA3MTMxMThjNTI4NGU1ZGY4N2UxNTUzYzQxZTM0MDBhNWMxNmEzLi5iM2M3NzQ5ZDI0ZDJmYjc5 NGU4M2RlNGM1MWM1NGJhMDkzOGUzY2NjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMCBAQAogMjAxNS0wNC0xNSAgSm9yZGFuIEhhcmJhbmQgIDxsamhhcmJAZ21haWwuY29t PgogCisgICAgICAgIFN0cmluZy5wcm90b3R5cGUuc3RhcnRzV2l0aC9lbmRzV2l0aC9pbmNsdWRl cyBoYXZlIHdyb25nIGxlbmd0aCBpbiByMTgyNjczCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDM2NTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBGaXggbGVuZ3RocyBvZiBTdHJpbmcucHJvdG90eXBlLntp bmNsdWRlcyxzdGFydHNXaXRoLGVuZHNXaXRofSBwZXIgc3BlYworICAgICAgICBodHRwczovL3Bl b3BsZS5tb3ppbGxhLm9yZy9+am9yZW5kb3JmZi9lczYtZHJhZnQuaHRtbCNzZWMtc3RyaW5nLnBy b3RvdHlwZS5pbmNsdWRlcworICAgICAgICBodHRwczovL3Blb3BsZS5tb3ppbGxhLm9yZy9+am9y ZW5kb3JmZi9lczYtZHJhZnQuaHRtbCNzZWMtc3RyaW5nLnByb3RvdHlwZS5zdGFydHN3aXRoCisg ICAgICAgIGh0dHBzOi8vcGVvcGxlLm1vemlsbGEub3JnL35qb3JlbmRvcmZmL2VzNi1kcmFmdC5o dG1sI3NlYy1zdHJpbmcucHJvdG90eXBlLmVuZHN3aXRoCisKKyAgICAgICAgKiBydW50aW1lL1N0 cmluZ1Byb3RvdHlwZS5jcHA6CisgICAgICAgIChKU0M6OlN0cmluZ1Byb3RvdHlwZTo6ZmluaXNo Q3JlYXRpb24pOgorCisyMDE1LTA0LTE1ICBKb3JkYW4gSGFyYmFuZCAgPGxqaGFyYkBnbWFpbC5j b20+CisKICAgICAgICAgTnVtYmVyLnBhcnNlSW50IGluIG5pZ2h0bHkgcjE4MjY3MyBoYXMgd3Jv bmcgbGVuZ3RoCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNDM2NTcKIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3Ry aW5nUHJvdG90eXBlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cmluZ1By b3RvdHlwZS5jcHAKaW5kZXggY2E2MmM0MWIwZjM1ODk2OTE2ZDFjNjI1ZDdjMzQwZmE0ZGYyNDky MS4uOTlkYWMzMWQ2MzRmOGQ0ZDFlNGE1OWI4ZjU3ZTcwOGRiOGQ5ZGQ1YiAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RyaW5nUHJvdG90eXBlLmNwcAorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJpbmdQcm90b3R5cGUuY3BwCkBAIC0yLDYg KzIsNyBAQAogICogIENvcHlyaWdodCAoQykgMTk5OS0yMDAxIEhhcnJpIFBvcnRlbiAocG9ydGVu QGtkZS5vcmcpCiAgKiAgQ29weXJpZ2h0IChDKSAyMDA0LCAyMDA1LCAyMDA2LCAyMDA3LCAyMDA4 LCAyMDEzIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqICBDb3B5cmlnaHQgKEMp IDIwMDkgVG9yY2ggTW9iaWxlLCBJbmMuCisgKiAgQ29weXJpZ2h0IChDKSAyMDE1IEpvcmRhbiBI YXJiYW5kIChsamhhcmJAZ21haWwuY29tKQogICoKICAqICBUaGlzIGxpYnJhcnkgaXMgZnJlZSBz b2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCiAgKiAgbW9kaWZ5IGl0IHVu ZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIExlc3NlciBHZW5lcmFsIFB1YmxpYwpAQCAtMTM5LDkg KzE0MCw5IEBAIHZvaWQgU3RyaW5nUHJvdG90eXBlOjpmaW5pc2hDcmVhdGlvbihWTSYgdm0sIEpT R2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QsIEpTU3RyCiAgICAgSlNDX05BVElWRV9GVU5DVElP TigidHJpbSIsIHN0cmluZ1Byb3RvRnVuY1RyaW0sIERvbnRFbnVtLCAwKTsKICAgICBKU0NfTkFU SVZFX0ZVTkNUSU9OKCJ0cmltTGVmdCIsIHN0cmluZ1Byb3RvRnVuY1RyaW1MZWZ0LCBEb250RW51 bSwgMCk7CiAgICAgSlNDX05BVElWRV9GVU5DVElPTigidHJpbVJpZ2h0Iiwgc3RyaW5nUHJvdG9G dW5jVHJpbVJpZ2h0LCBEb250RW51bSwgMCk7Ci0gICAgSlNDX05BVElWRV9GVU5DVElPTigic3Rh cnRzV2l0aCIsIHN0cmluZ1Byb3RvRnVuY1N0YXJ0c1dpdGgsIERvbnRFbnVtLCAwKTsKLSAgICBK U0NfTkFUSVZFX0ZVTkNUSU9OKCJlbmRzV2l0aCIsIHN0cmluZ1Byb3RvRnVuY0VuZHNXaXRoLCBE b250RW51bSwgMCk7Ci0gICAgSlNDX05BVElWRV9GVU5DVElPTigiaW5jbHVkZXMiLCBzdHJpbmdQ cm90b0Z1bmNJbmNsdWRlcywgRG9udEVudW0sIDApOworICAgIEpTQ19OQVRJVkVfRlVOQ1RJT04o InN0YXJ0c1dpdGgiLCBzdHJpbmdQcm90b0Z1bmNTdGFydHNXaXRoLCBEb250RW51bSwgMSk7Cisg ICAgSlNDX05BVElWRV9GVU5DVElPTigiZW5kc1dpdGgiLCBzdHJpbmdQcm90b0Z1bmNFbmRzV2l0 aCwgRG9udEVudW0sIDEpOworICAgIEpTQ19OQVRJVkVfRlVOQ1RJT04oImluY2x1ZGVzIiwgc3Ry aW5nUHJvdG9GdW5jSW5jbHVkZXMsIERvbnRFbnVtLCAxKTsKICAgICBKU0NfTkFUSVZFX0ZVTkNU SU9OKHZtLnByb3BlcnR5TmFtZXMtPml0ZXJhdG9yU3ltYm9sLCBzdHJpbmdQcm90b0Z1bmNJdGVy YXRvciwgRG9udEVudW0sIDApOwogCiAgICAgSlNDX05BVElWRV9JTlRSSU5TSUNfRlVOQ1RJT04o dm0ucHJvcGVydHlOYW1lcy0+Y2hhckNvZGVBdFByaXZhdGVOYW1lLCBzdHJpbmdQcm90b0Z1bmND aGFyQ29kZUF0LCBEb250RW51bSwgMSwgQ2hhckNvZGVBdEludHJpbnNpYyk7CmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMzlh MGE1OTRjYzFkMTU5MWIzNDIxNThjNGNmZWE4M2JlNWYxZDhhYi4uOTJkZWQ3MzdlYmZjODRhY2Mw MGM0NmQ1ZDZiOWNhOGI0NjdhNzVkMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDE1LTA0LTE1 ICBKb3JkYW4gSGFyYmFuZCAgPGxqaGFyYkBnbWFpbC5jb20+CiAKKyAgICAgICAgU3RyaW5nLnBy b3RvdHlwZS5zdGFydHNXaXRoL2VuZHNXaXRoL2luY2x1ZGVzIGhhdmUgd3JvbmcgbGVuZ3RoIGlu IHIxODI2NzMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE0MzY1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICoganMvc2NyaXB0LXRlc3RzL3N0cmluZy1pbmNsdWRlcy5qczoKKyAgICAgICAgKiBqcy9zdHJp bmctaW5jbHVkZXMtZXhwZWN0ZWQudHh0OgorCisyMDE1LTA0LTE1ICBKb3JkYW4gSGFyYmFuZCAg PGxqaGFyYkBnbWFpbC5jb20+CisKICAgICAgICAgTnVtYmVyLnBhcnNlSW50IGluIG5pZ2h0bHkg cjE4MjY3MyBoYXMgd3JvbmcgbGVuZ3RoCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNDM2NTcKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvanMvc2Ny aXB0LXRlc3RzL3N0cmluZy1pbmNsdWRlcy5qcyBiL0xheW91dFRlc3RzL2pzL3NjcmlwdC10ZXN0 cy9zdHJpbmctaW5jbHVkZXMuanMKaW5kZXggOWUxNjZiMDQ5MmIwYmU5NmViODUwZjhhN2UyYzVi MDM2NDQxMDdhZS4uMjUyYTJhNGExZmI3YjFkNjRkZmYwMjdlZWEzNjczYWRkNTNlYzI4YyAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvanMvc2NyaXB0LXRlc3RzL3N0cmluZy1pbmNsdWRlcy5qcwor KysgYi9MYXlvdXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMvc3RyaW5nLWluY2x1ZGVzLmpzCkBAIC0x LDYgKzEsNyBAQAogZGVzY3JpcHRpb24oIlRoaXMgdGVzdCBjaGVja3MgdGhlIEVTNiBzdHJpbmcg ZnVuY3Rpb25zIHN0YXJ0c1dpdGgoKSwgZW5kc1dpdGgoKSBhbmQgaW5jbHVkZXMoKS4iKTsKIAog Ly8gVGVzdCBpbmNsdWRlcworc2hvdWxkQmUoIlN0cmluZy5wcm90b3R5cGUuaW5jbHVkZXMubGVu Z3RoIiwgIjEiKTsKIHNob3VsZEJlKCInZm9vIGJhcicuaW5jbHVkZXMoJ2JhcicpIiwgInRydWUi KTsKIHNob3VsZEJlKCInZm9vIGJhcicuaW5jbHVkZXMoJ2JhcicsIDQpIiwgInRydWUiKTsKIHNo b3VsZEJlKCInZm9vIGJhcicuaW5jbHVkZXMoJ2FyJywgNSkiLCAidHJ1ZSIpOwpAQCAtMzEsNiAr MzIsNyBAQCBzaG91bGRCZSgiJ+ODleODvOODkOODvCcuaW5jbHVkZXMoJ+ODvOODkCcpIiwgInRy dWUiKTsKIHNob3VsZEJlKCIn44OV44O844OQ44O8Jy5pbmNsdWRlcygn44Kv44O8JykiLCAiZmFs c2UiKTsKIAogLy8gVGVzdCBzdGFydHNXaXRoCitzaG91bGRCZSgiU3RyaW5nLnByb3RvdHlwZS5z dGFydHNXaXRoLmxlbmd0aCIsICIxIik7CiBzaG91bGRCZSgiJ2ZvbyBiYXInLnN0YXJ0c1dpdGgo J2ZvbycpIiwgInRydWUiKTsKIHNob3VsZEJlKCInZm9vIGJhcicuc3RhcnRzV2l0aCgnZm9vJywg MCkiLCAidHJ1ZSIpOwogc2hvdWxkQmUoIidmb28gYmFyJy5zdGFydHNXaXRoKCdmb28nLCAtMSki LCAidHJ1ZSIpOwpAQCAtNjAsNiArNjIsNyBAQCBzaG91bGRCZSgiJ2ZvbyBiYXInLnN0YXJ0c1dp dGgoJ+ODleODvCcpIiwgImZhbHNlIik7CiBzaG91bGRCZSgiJ2ZvbyBiYXInLnN0YXJ0c1dpdGgo J+ODleODvCcsIDEpIiwgImZhbHNlIik7CiAKIC8vIFRlc3QgZW5kc1dpdGgKK3Nob3VsZEJlKCJT dHJpbmcucHJvdG90eXBlLmVuZHNXaXRoLmxlbmd0aCIsICIxIik7CiBzaG91bGRCZSgiJ2ZvbyBi YXInLmVuZHNXaXRoKCdiYXInKSIsICJ0cnVlIik7CiBzaG91bGRCZSgiJ2ZvbyBiYXInLmVuZHNX aXRoKCdiYScsIDYpIiwgInRydWUiKTsKIHNob3VsZEJlKCInZm9vIGJhcicuZW5kc1dpdGgoJyBi YScsIDYpIiwgInRydWUiKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2pzL3N0cmluZy1pbmNs dWRlcy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9qcy9zdHJpbmctaW5jbHVkZXMtZXhwZWN0 ZWQudHh0CmluZGV4IDlhYWJiNTJmZmY4NmEyYzVjYmM2ZTE2MGQ2NzExYTIyOGMxMmZkNjkuLjI1 YmE1NzhjZGQ1MmZlN2I3ZDgzNWZjYmI3NThjNjJiOGRiYjhlMzIgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL2pzL3N0cmluZy1pbmNsdWRlcy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMv anMvc3RyaW5nLWluY2x1ZGVzLWV4cGVjdGVkLnR4dApAQCAtMyw2ICszLDcgQEAgVGhpcyB0ZXN0 IGNoZWNrcyB0aGUgRVM2IHN0cmluZyBmdW5jdGlvbnMgc3RhcnRzV2l0aCgpLCBlbmRzV2l0aCgp IGFuZCBpbmNsdWRlcygKIE9uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFT UyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KIAogCitQQVNTIFN0cmlu Zy5wcm90b3R5cGUuaW5jbHVkZXMubGVuZ3RoIGlzIDEKIFBBU1MgJ2ZvbyBiYXInLmluY2x1ZGVz KCdiYXInKSBpcyB0cnVlCiBQQVNTICdmb28gYmFyJy5pbmNsdWRlcygnYmFyJywgNCkgaXMgdHJ1 ZQogUEFTUyAnZm9vIGJhcicuaW5jbHVkZXMoJ2FyJywgNSkgaXMgdHJ1ZQpAQCAtMzEsNiArMzIs NyBAQCBQQVNTICdmb28gMWUrMTAwIGJhcicuaW5jbHVkZXMoMWUrMTAwKSBpcyB0cnVlCiBQQVNT ICdmb28gMWUxMDAgYmFyJy5pbmNsdWRlcygxZTEwMCkgaXMgZmFsc2UKIFBBU1MgJ+ODleODvOOD kOODvCcuaW5jbHVkZXMoJ+ODvOODkCcpIGlzIHRydWUKIFBBU1MgJ+ODleODvOODkOODvCcuaW5j bHVkZXMoJ+OCr+ODvCcpIGlzIGZhbHNlCitQQVNTIFN0cmluZy5wcm90b3R5cGUuc3RhcnRzV2l0 aC5sZW5ndGggaXMgMQogUEFTUyAnZm9vIGJhcicuc3RhcnRzV2l0aCgnZm9vJykgaXMgdHJ1ZQog UEFTUyAnZm9vIGJhcicuc3RhcnRzV2l0aCgnZm9vJywgMCkgaXMgdHJ1ZQogUEFTUyAnZm9vIGJh cicuc3RhcnRzV2l0aCgnZm9vJywgLTEpIGlzIHRydWUKQEAgLTU4LDYgKzYwLDcgQEAgUEFTUyAn 44OV44O844OQ44O8Jy5zdGFydHNXaXRoKCdhYmMnKSBpcyBmYWxzZQogUEFTUyAn44OV44O844OQ 44O8Jy5zdGFydHNXaXRoKCdhYmMnLCAxKSBpcyBmYWxzZQogUEFTUyAnZm9vIGJhcicuc3RhcnRz V2l0aCgn44OV44O8JykgaXMgZmFsc2UKIFBBU1MgJ2ZvbyBiYXInLnN0YXJ0c1dpdGgoJ+ODleOD vCcsIDEpIGlzIGZhbHNlCitQQVNTIFN0cmluZy5wcm90b3R5cGUuZW5kc1dpdGgubGVuZ3RoIGlz IDEKIFBBU1MgJ2ZvbyBiYXInLmVuZHNXaXRoKCdiYXInKSBpcyB0cnVlCiBQQVNTICdmb28gYmFy Jy5lbmRzV2l0aCgnYmEnLCA2KSBpcyB0cnVlCiBQQVNTICdmb28gYmFyJy5lbmRzV2l0aCgnIGJh JywgNikgaXMgdHJ1ZQo=