143646 2015-04-12 11:06:59 -0700 build.webkit.org/dashboard: Crash-only queues should show failure when failure limit is exceeded 2015-04-12 13:05:47 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap commit-queue ddkilzer oldest_to_newest 1084665 0 ap 2015-04-12 11:06:59 -0700 When there are too many failures on crash-only queues (e.g. 50 timeouts), they remain green, because there are no crashes. This is clearly wrong, the queue is in a broken state, and we need to know about it. 1084666 1 250613 ap 2015-04-12 11:10:07 -0700 Created attachment 250613 proposed fix 1084670 2 250613 ddkilzer 2015-04-12 12:18:34 -0700 Comment on attachment 250613 proposed fix r=me 1084679 3 250613 commit-queue 2015-04-12 13:05:44 -0700 Comment on attachment 250613 proposed fix Clearing flags on attachment: 250613 Committed r182670: <http://trac.webkit.org/changeset/182670> 1084680 4 commit-queue 2015-04-12 13:05:47 -0700 All reviewed patches have been landed. Closing bug. 250613 2015-04-12 11:10:07 -0700 2015-04-12 13:05:44 -0700 proposed fix GuardMallocTooManyFailures.txt text/plain 2329 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4MjY2OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE1LTA0LTEyICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIGJ1aWxkLndlYmtpdC5vcmcvZGFzaGJvYXJkOiBDcmFzaC1vbmx5IHF1ZXVl cyBzaG91bGQgc2hvdyBmYWlsdXJlIHdoZW4gZmFpbHVyZSBsaW1pdCBpcyBleGNlZWRlZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzNjQ2CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZl U3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2Ny aXB0cy9CdWlsZGJvdFRlc3RlclF1ZXVlVmlldy5qczoKKyAgICAgICAgKEJ1aWxkYm90VGVzdGVy UXVldWVWaWV3LnByb3RvdHlwZS51cGRhdGUuYXBwZW5kQnVpbGRlclF1ZXVlU3RhdHVzKToKKwog MjAxNS0wNC0xMSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAg ICBVc2UgZW5fVVMgc3BlbGwgY2hlY2tlciBmb3IgdGVzdHMgb24gTWFjIGluc3RlYWQgb2YgTXVs dGlsaW5ndWFsCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdFRlc3RlclF1ZXVl Vmlldy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJr aXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdFRlc3Rl clF1ZXVlVmlldy5qcwkocmV2aXNpb24gMTgyNjY5KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBv cnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMv QnVpbGRib3RUZXN0ZXJRdWV1ZVZpZXcuanMJKHdvcmtpbmcgY29weSkKQEAgLTc5LDcgKzc5LDEw IEBAIEJ1aWxkYm90VGVzdGVyUXVldWVWaWV3LnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgICAg ICAgICAgLy8gQSBjcmFzaGVzLW9ubHkgcXVldWUgaXMgYSBxdWV1ZSB3aGVyZSB3ZSBhcmUgb25s eSBpbnRlcmVzdGVkIGluIGNyYXNoZXMsIGUuZy4gYSBHdWFyZE1hbGxvYyBvciBhbiBBU2FuIG9u ZS4KICAgICAgICAgICAgICAgICAgICAgLy8gQ3VycmVudGx5LCBvbmx5IGxheW91dCB0ZXN0cyBh cmUgc3VwcG9ydGVkIGluIHN1Y2guCiAgICAgICAgICAgICAgICAgICAgIHZhciBsYXlvdXRUZXN0 UmVzdWx0cyA9IGl0ZXJhdGlvbi5sYXlvdXRUZXN0UmVzdWx0czsKLSAgICAgICAgICAgICAgICAg ICAgaWYgKCFsYXlvdXRUZXN0UmVzdWx0cy5jcmFzaENvdW50KSB7CisgICAgICAgICAgICAgICAg ICAgIGlmIChsYXlvdXRUZXN0UmVzdWx0cy50b29NYW55RmFpbHVyZXMpIHsKKyAgICAgICAgICAg ICAgICAgICAgICAgIHZhciBzdGF0dXMgPSBuZXcgU3RhdHVzTGluZVZpZXcobWVzc2FnZUVsZW1l bnQsIFN0YXR1c0xpbmVWaWV3LlN0YXR1cy5EYW5nZXIsICJmYWlsdXJlIGxpbWl0IGV4Y2VlZGVk IiwgdW5kZWZpbmVkLCBpdGVyYXRpb24ucXVldWUuYnVpbGRib3QubGF5b3V0VGVzdFJlc3VsdHNV UkxGb3JJdGVyYXRpb24oaXRlcmF0aW9uKSk7CisgICAgICAgICAgICAgICAgICAgICAgICBuZXcg UG9wb3ZlclRyYWNrZXIoc3RhdHVzLnN0YXR1c0J1YmJsZUVsZW1lbnQsIHRoaXMuX3ByZXNlbnRQ b3BvdmVyRm9yTGF5b3V0VGVzdFJlZ3Jlc3Npb25zLmJpbmQodGhpcyksIGl0ZXJhdGlvbik7Cisg ICAgICAgICAgICAgICAgICAgIH0gZWxzZSBpZiAoIWxheW91dFRlc3RSZXN1bHRzLmNyYXNoQ291 bnQpIHsKICAgICAgICAgICAgICAgICAgICAgICAgIHZhciB1cmwgPSBpdGVyYXRpb24ucXVldWUu YnVpbGRib3QuYnVpbGRQYWdlVVJMRm9ySXRlcmF0aW9uKGl0ZXJhdGlvbik7CiAgICAgICAgICAg ICAgICAgICAgICAgICB2YXIgc3RhdHVzID0gbmV3IFN0YXR1c0xpbmVWaWV3KG1lc3NhZ2VFbGVt ZW50LCBTdGF0dXNMaW5lVmlldy5TdGF0dXMuR29vZCwgIm5vIGNyYXNoZXMgZm91bmQiLCB1bmRl ZmluZWQsIHVybCk7CiAgICAgICAgICAgICAgICAgICAgICAgICBsaW1pdCA9IDA7Cg==