143634 2015-04-11 10:41:58 -0700 Run flaky conservative GC related test first before polluting stack and registers 2015-04-11 12:44:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ysuzuki ysuzuki ap benjamin commit-queue darin fpizlo ggaren kling rniwa oldest_to_newest 1084531 0 ysuzuki 2015-04-11 10:41:58 -0700 Run flaky conservative GC related test first before polluting stack and registers 1084534 1 250575 ysuzuki 2015-04-11 10:48:53 -0700 Created attachment 250575 Patch 1084535 2 ysuzuki 2015-04-11 10:51:08 -0700 This patch fixes https://build.webkit.org/builders/Apple%20Yosemite%20Debug%20JSC%20%28Tests%29?numbuilds=25 failures. However, we cannot avoid this flakiness completely since JSC GC is conservative. 1084545 3 250575 rniwa 2015-04-11 11:51:03 -0700 Comment on attachment 250575 Patch It's sad that we can't test more realistic scenario but I can't think of a way around it. 1084557 4 250575 commit-queue 2015-04-11 12:44:32 -0700 Comment on attachment 250575 Patch Clearing flags on attachment: 250575 Committed r182661: <http://trac.webkit.org/changeset/182661> 1084558 5 commit-queue 2015-04-11 12:44:38 -0700 All reviewed patches have been landed. Closing bug. 250575 2015-04-11 10:48:53 -0700 2015-04-11 12:44:32 -0700 Patch bug-143634-20150412024759.patch text/plain 4785 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyNjUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 NDk5OWFkODA1MmE5YzhlNWM1NmI2NDg4ZjY3NmY1ZTNmZmYwNzZjLi44ZTkyMGZhZDc3Y2M2MmRj NmY4MzczYTA0ZDZlYWUwMDVmNDkwNDU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyOCBAQAogMjAxNS0wNC0xMSAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KIAorICAgICAgICBSdW4gZmxha3kgY29uc2VydmF0aXZlIEdDIHJlbGF0ZWQgdGVzdCBm aXJzdCBiZWZvcmUgcG9sbHV0aW5nIHN0YWNrIGFuZCByZWdpc3RlcnMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MzYzNAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFmdGVyIHIxODI2NTMsIEpTQyBBUEkg dGVzdHMgZmFpbC4gSG93ZXZlciwgaXQncyBub3QgcmVsYXRlZCB0byB0aGUgY2hhbmdlLgorICAg ICAgICBBZnRlciBpbnZlc3RpZ2F0aW5nIHRoZSBjYXVzZSBvZiB0aGlzIGZhaWx1cmUsIEkndmUg Zm91bmQgdGhhdCB0aGUgZmFpbGVkIHRlc3QgaXMgZmxha3kKKyAgICAgICAgYmVjYXVzZSBKU0Mn cyBHQyBpcyBjb25zZXJ2YXRpdmUuIElmIHByZXZpb3VzbHkgYWxsb2NhdGVkIEpTR2xvYmFsT2Jq ZWN0IGlzIGFjY2lkZW50YWxseSBhbGl2ZQorICAgICAgICBkdWUgdG8gY29uc2VydmF0aXZlIHJv b3RzIGluIEMgc3RhY2sgYW5kIHJlZ2lzdGVycywgdGhpcyB0ZXN0IGZhaWxzLgorCisgICAgICAg IFNpbmNlIEdDIG1hcmtzIEMgc3RhY2sgYW5kIHJlZ2lzdGVycyBhcyByb290cyBjb25zZXJ2YXRp dmVseSwKKyAgICAgICAgb2JqZWN0cyBub3QgcmVmZXJlbmNlZCBsb2dpY2FsbHkgY2FuIGJlIGFj Y2lkZW50YWxseSBtYXJrZWQgYW5kIGFsaXZlLgorICAgICAgICBUbyBhdm9pZCB0aGlzIHNpdHVh dGlvbiBhcyBwb3NzaWJsZSBhcyB3ZSBjYW4sCisgICAgICAgIDEuIHJ1biB0aGlzIHRlc3QgZmly c3QgYmVmb3JlIHN0YWNrIGlzIHBvbGx1dGVkLAorICAgICAgICAyLiBleHRyYWN0IHRoaXMgdGVz dCBhcyBhIGZ1bmN0aW9uIHRvIHN1cHByZXNzIHN0YWNrIGhlaWdodC4KKworICAgICAgICAqIEFQ SS90ZXN0cy90ZXN0YXBpLm1tOgorICAgICAgICAodGVzdFdlYWtWYWx1ZSk6CisgICAgICAgICh0 ZXN0T2JqZWN0aXZlQ0FQSU1haW4pOgorICAgICAgICAodGVzdE9iamVjdGl2ZUNBUEkpOgorCisy MDE1LTA0LTExICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgorCiAgICAg ICAgIFtFUzZdIEVuYWJsZSBTeW1ib2wgaW4gd2ViIHBhZ2VzCiAgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDMzNzUKIApkaWZmIC0tZ2l0IGEvU291cmNl L0phdmFTY3JpcHRDb3JlL0FQSS90ZXN0cy90ZXN0YXBpLm1tIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0FQSS90ZXN0cy90ZXN0YXBpLm1tCmluZGV4IDM0NGMzN2VlYTJiMzM4MTBlZjRiNTlmZTdl NDA2OTJkYWM5YmVhOWMuLjE3NjY4YzEzZTA2ZTA2NTdjNTJjYzk4MGVkMjE0ZTA3YmZkZTdmNDUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvdGVzdHMvdGVzdGFwaS5tbQor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rlc3RzL3Rlc3RhcGkubW0KQEAgLTQ4NCw5 ICs0ODQsMzUgQEAgc3RhdGljIHZvaWQqIHRocmVhZE1haW4odm9pZCogY29udGV4dFB0cikKICAg ICBwdGhyZWFkX2V4aXQobnVsbHB0cik7CiB9CiAKLXZvaWQgdGVzdE9iamVjdGl2ZUNBUEkoKQor Ly8gVGhpcyB0ZXN0IGlzIGZsYWt5LiBTaW5jZSBHQyBtYXJrcyBDIHN0YWNrIGFuZCByZWdpc3Rl cnMgYXMgcm9vdHMgY29uc2VydmF0aXZlbHksCisvLyBvYmplY3RzIG5vdCByZWZlcmVuY2VkIGxv Z2ljYWxseSBjYW4gYmUgYWNjaWRlbnRhbGx5IG1hcmtlZCBhbmQgYWxpdmUuCisvLyBUbyBhdm9p ZCB0aGlzIHNpdHVhdGlvbiBhcyBwb3NzaWJsZSBhcyB3ZSBjYW4sCisvLyAxLiBydW4gdGhpcyB0 ZXN0IGZpcnN0IGJlZm9yZSBzdGFjayBpcyBwb2xsdXRlZCwKKy8vIDIuIGV4dHJhY3QgdGhpcyB0 ZXN0IGFzIGEgZnVuY3Rpb24gdG8gc3VwcHJlc3Mgc3RhY2sgaGVpZ2h0Lgorc3RhdGljIHZvaWQg dGVzdFdlYWtWYWx1ZSgpCit7CisgICAgQGF1dG9yZWxlYXNlcG9vbCB7CisgICAgICAgIEpTVmly dHVhbE1hY2hpbmUgKnZtID0gW1tKU1ZpcnR1YWxNYWNoaW5lIGFsbG9jXSBpbml0XTsKKyAgICAg ICAgVGVzdE9iamVjdCAqdGVzdE9iamVjdCA9IFtUZXN0T2JqZWN0IHRlc3RPYmplY3RdOworICAg ICAgICBKU01hbmFnZWRWYWx1ZSAqd2Vha1ZhbHVlOworICAgICAgICBAYXV0b3JlbGVhc2Vwb29s IHsKKyAgICAgICAgICAgIEpTQ29udGV4dCAqY29udGV4dCA9IFtbSlNDb250ZXh0IGFsbG9jXSBp bml0V2l0aFZpcnR1YWxNYWNoaW5lOnZtXTsKKyAgICAgICAgICAgIGNvbnRleHRbQCJ0ZXN0T2Jq ZWN0Il0gPSB0ZXN0T2JqZWN0OworICAgICAgICAgICAgd2Vha1ZhbHVlID0gW1tKU01hbmFnZWRW YWx1ZSBhbGxvY10gaW5pdFdpdGhWYWx1ZTpjb250ZXh0W0AidGVzdE9iamVjdCJdXTsKKyAgICAg ICAgfQorCisgICAgICAgIEBhdXRvcmVsZWFzZXBvb2wgeworICAgICAgICAgICAgSlNDb250ZXh0 ICpjb250ZXh0ID0gW1tKU0NvbnRleHQgYWxsb2NdIGluaXRXaXRoVmlydHVhbE1hY2hpbmU6dm1d OworICAgICAgICAgICAgY29udGV4dFtAInRlc3RPYmplY3QiXSA9IHRlc3RPYmplY3Q7CisgICAg ICAgICAgICBKU1N5bmNocm9ub3VzR2FyYmFnZUNvbGxlY3RGb3JEZWJ1Z2dpbmcoW2NvbnRleHQg SlNHbG9iYWxDb250ZXh0UmVmXSk7CisgICAgICAgICAgICBjaGVja1Jlc3VsdChAIndlYWsgdmFs dWUgPT0gbmlsIiwgIVt3ZWFrVmFsdWUgdmFsdWVdKTsKKyAgICAgICAgICAgIGNoZWNrUmVzdWx0 KEAicm9vdCBpcyBzdGlsbCBhbGl2ZSIsICFjb250ZXh0W0AidGVzdE9iamVjdCJdLmlzVW5kZWZp bmVkKTsKKyAgICAgICAgfQorICAgIH0KK30KKworc3RhdGljIHZvaWQgdGVzdE9iamVjdGl2ZUNB UElNYWluKCkKIHsKLSAgICBOU0xvZyhAIlRlc3RpbmcgT2JqZWN0aXZlLUMgQVBJIik7CiAgICAg QGF1dG9yZWxlYXNlcG9vbCB7CiAgICAgICAgIEpTVmlydHVhbE1hY2hpbmUqIHZtID0gW1tKU1Zp cnR1YWxNYWNoaW5lIGFsbG9jXSBpbml0XTsKICAgICAgICAgSlNDb250ZXh0KiBjb250ZXh0ID0g W1tKU0NvbnRleHQgYWxsb2NdIGluaXRXaXRoVmlydHVhbE1hY2hpbmU6dm1dOwpAQCAtMTA2Mywy NSArMTA4OSw2IEBAIHZvaWQgdGVzdE9iamVjdGl2ZUNBUEkoKQogICAgIH0KIAogICAgIEBhdXRv cmVsZWFzZXBvb2wgewotICAgICAgICBKU1ZpcnR1YWxNYWNoaW5lICp2bSA9IFtbSlNWaXJ0dWFs TWFjaGluZSBhbGxvY10gaW5pdF07Ci0gICAgICAgIFRlc3RPYmplY3QgKnRlc3RPYmplY3QgPSBb VGVzdE9iamVjdCB0ZXN0T2JqZWN0XTsKLSAgICAgICAgSlNNYW5hZ2VkVmFsdWUgKndlYWtWYWx1 ZTsKLSAgICAgICAgQGF1dG9yZWxlYXNlcG9vbCB7Ci0gICAgICAgICAgICBKU0NvbnRleHQgKmNv bnRleHQgPSBbW0pTQ29udGV4dCBhbGxvY10gaW5pdFdpdGhWaXJ0dWFsTWFjaGluZTp2bV07Ci0g ICAgICAgICAgICBjb250ZXh0W0AidGVzdE9iamVjdCJdID0gdGVzdE9iamVjdDsKLSAgICAgICAg ICAgIHdlYWtWYWx1ZSA9IFtbSlNNYW5hZ2VkVmFsdWUgYWxsb2NdIGluaXRXaXRoVmFsdWU6Y29u dGV4dFtAInRlc3RPYmplY3QiXV07Ci0gICAgICAgIH0KLQotICAgICAgICBAYXV0b3JlbGVhc2Vw b29sIHsKLSAgICAgICAgICAgIEpTQ29udGV4dCAqY29udGV4dCA9IFtbSlNDb250ZXh0IGFsbG9j XSBpbml0V2l0aFZpcnR1YWxNYWNoaW5lOnZtXTsKLSAgICAgICAgICAgIGNvbnRleHRbQCJ0ZXN0 T2JqZWN0Il0gPSB0ZXN0T2JqZWN0OwotICAgICAgICAgICAgSlNTeW5jaHJvbm91c0dhcmJhZ2VD b2xsZWN0Rm9yRGVidWdnaW5nKFtjb250ZXh0IEpTR2xvYmFsQ29udGV4dFJlZl0pOwotICAgICAg ICAgICAgY2hlY2tSZXN1bHQoQCJ3ZWFrIHZhbHVlID09IG5pbCIsICFbd2Vha1ZhbHVlIHZhbHVl XSk7Ci0gICAgICAgICAgICBjaGVja1Jlc3VsdChAInJvb3QgaXMgc3RpbGwgYWxpdmUiLCAhY29u dGV4dFtAInRlc3RPYmplY3QiXS5pc1VuZGVmaW5lZCk7Ci0gICAgICAgIH0KLSAgICB9Ci0KLSAg ICBAYXV0b3JlbGVhc2Vwb29sIHsKICAgICAgICAgSlNDb250ZXh0ICpjb250ZXh0ID0gW1tKU0Nv bnRleHQgYWxsb2NdIGluaXRdOwogICAgICAgICBUaW55RE9NTm9kZSAqcm9vdCA9IFtbVGlueURP TU5vZGUgYWxsb2NdIGluaXRXaXRoVmlydHVhbE1hY2hpbmU6Y29udGV4dC52aXJ0dWFsTWFjaGlu ZV07CiAgICAgICAgIFRpbnlET01Ob2RlICpsYXN0Tm9kZSA9IHJvb3Q7CkBAIC0xNDA5LDYgKzE0 MTYsMTMgQEAgdm9pZCB0ZXN0T2JqZWN0aXZlQ0FQSSgpCiAgICAgcnVuUmVncmVzczE0MTgwOSgp OwogfQogCit2b2lkIHRlc3RPYmplY3RpdmVDQVBJKCkKK3sKKyAgICBOU0xvZyhAIlRlc3Rpbmcg T2JqZWN0aXZlLUMgQVBJIik7CisgICAgdGVzdFdlYWtWYWx1ZSgpOworICAgIHRlc3RPYmplY3Rp dmVDQVBJTWFpbigpOworfQorCiAjZWxzZQogCiB2b2lkIHRlc3RPYmplY3RpdmVDQVBJKCkK