143624 2015-04-10 18:25:27 -0700 Cannot click "Next" button on Google two-factor auth setup page 2015-04-13 12:53:09 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified iOS 8.2 RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 1 jhoneycutt jhoneycutt enrica oldest_to_newest 1084434 0 jhoneycutt 2015-04-10 18:25:27 -0700 When trying to enable two-factor authentication for a Google account on iOS, it is sometimes not possible to click the "Next" button to advance the process. <rdar://problem/19175714> 1084456 1 250557 jhoneycutt 2015-04-10 19:32:27 -0700 Created attachment 250557 Patch 1084474 2 250557 ddkilzer 2015-04-10 21:24:24 -0700 Comment on attachment 250557 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250557&action=review > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2784 > + default: I think we should list all InputTypes here explicitly (instead of using 'default') so that new values will cause a build failure, and a will force a decision to be made by the patch author. 1084519 3 250557 darin 2015-04-11 08:40:54 -0700 Comment on attachment 250557 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250557&action=review >> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2784 >> + default: > > I think we should list all InputTypes here explicitly (instead of using 'default') so that new values will cause a build failure, and a will force a decision to be made by the patch author. I agree. Then we can also stick an ASSERT_NOT_REACHED() after the switch (along with a second return false). Please make that change. 1084921 4 jhoneycutt 2015-04-13 12:53:09 -0700 Committed r182749: <http://trac.webkit.org/changeset/182749> 250557 2015-04-10 19:32:27 -0700 2015-04-11 08:40:54 -0700 Patch bug-143624-20150410193134.patch text/plain 5283 jhoneycutt U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyNTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODU2ODU2NTJmZTcyZmNj MGVjMTFkNzdmOTg0NTExMmY2M2Q0YzI1ZC4uZWQ3OGI4Nzk1MWJlMjQxNmIwMTRmNjI5MWZjNWNi YjQ2OWMzYTVlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE1LTA0LTEwICBKb24g SG9uZXljdXR0ICA8amhvbmV5Y3V0dEBhcHBsZS5jb20+CisKKyAgICAgICAgQ2Fubm90IGNsaWNr ICJOZXh0IiBidXR0b24gb24gR29vZ2xlIHR3by1mYWN0b3IgYXV0aCBzZXR1cCBwYWdlCisKKyAg ICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDM2MjQ+Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xOTE3NTcxND4KKworICAgICAgICBUaGlzIGlzc3VlIG9j Y3VycyB3aGVuIHRoaXMgc2l0ZSBmb2N1c2VzIHRoZSBzdWJtaXQgYnV0dG9uLiBXaGVuIGl0Cisg ICAgICAgIHJlY2VpdmVzIGZvY3VzLCB3ZSB0cnkgdG8gYXNzaXN0IGl0LiBXaGlsZSB3ZSBjb25z aWRlciBvdXJzZWx2ZXMgdG8gYmUKKyAgICAgICAgYXNzaXN0aW5nIGl0LCB3ZSBpZ25vcmUgZnVy dGhlciBnZXN0dXJlIGlucHV0cyBmb3IgdGhhdCBub2RlLCBpbmNsdWRpbmcKKyAgICAgICAgdGhl IHRhcCBnZXN0dXJlLgorCisgICAgICAgIFRvIGZpeCB0aGlzLCBvbmx5IGFzc2lzdCBpbnB1dCB0 eXBlcyB0aGF0IHdlIGtub3cgYXJlIGFzc2lzdGFibGUsCisgICAgICAgIGluY2x1ZGluZyB0ZXh0 IGZpZWxkcywgc2VsZWN0IGFuZCBkYXRlIGVsZW1lbnRzLCBldGMuCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVu dFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKGlzQXNzaXN0YWJsZUlucHV0VHlwZSk6Cisg ICAgICAgIElmIHRoZSB0eXBlIGlzIGEga25vd24tYXNzaXN0YWJsZSB0eXBlLCByZXR1cm4gdHJ1 ZS4KKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBfc3RhcnRBc3Npc3RpbmdOb2RlOnVzZXJJc0lu dGVyYWN0aW5nOmJsdXJQcmV2aW91c05vZGU6dXNlck9iamVjdDpdKToKKyAgICAgICAgQ2FsbCBp c0Fzc2lzdGFibGVJbnB1dFR5cGUoKSB0byBkZXRlcm1pbmUgd2hldGhlciB3ZSBzaG91bGQgZG8g YW55IGtpbmQKKyAgICAgICAgb2YgYXNzaXN0YW5jZSBmb3IgdGhpcyBub2RlLgorCiAyMDE1LTA0 LTA3ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIEZp eCB0aGUgYnVpbGQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dL Q29udGVudFZpZXdJbnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3Mv V0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IDhmMWQ3NTVhYTdlYzJkYmJlMDAzMzNl YjUwMjM1ODQyZWQ5MjNmYTkuLmU4MmU0ZTNlNjA4NWE1ZTMxNTgwMTQwNDA0MTNiZTkzN2Q1OGM3 YjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmll d0ludGVyYWN0aW9uLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250 ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBAIC0yNzYwLDYgKzI3NjAsMzIgQEAgLSAoVUlXZWJGb3Jt QWNjZXNzb3J5ICopZm9ybUFjY2Vzc29yeVZpZXcKICAgICByZXR1cm4gX2Zvcm1BY2Nlc3NvcnlW aWV3LmdldCgpOwogfQogCitzdGF0aWMgYm9vbCBpc0Fzc2lzdGFibGVJbnB1dFR5cGUoSW5wdXRU eXBlIHR5cGUpCit7CisgICAgc3dpdGNoICh0eXBlKSB7CisgICAgY2FzZSBJbnB1dFR5cGU6OkNv bnRlbnRFZGl0YWJsZToKKyAgICBjYXNlIElucHV0VHlwZTo6VGV4dDoKKyAgICBjYXNlIElucHV0 VHlwZTo6UGFzc3dvcmQ6CisgICAgY2FzZSBJbnB1dFR5cGU6OlRleHRBcmVhOgorICAgIGNhc2Ug SW5wdXRUeXBlOjpTZWFyY2g6CisgICAgY2FzZSBJbnB1dFR5cGU6OkVtYWlsOgorICAgIGNhc2Ug SW5wdXRUeXBlOjpVUkw6CisgICAgY2FzZSBJbnB1dFR5cGU6OlBob25lOgorICAgIGNhc2UgSW5w dXRUeXBlOjpOdW1iZXI6CisgICAgY2FzZSBJbnB1dFR5cGU6Ok51bWJlclBhZDoKKyAgICBjYXNl IElucHV0VHlwZTo6RGF0ZToKKyAgICBjYXNlIElucHV0VHlwZTo6RGF0ZVRpbWU6CisgICAgY2Fz ZSBJbnB1dFR5cGU6OkRhdGVUaW1lTG9jYWw6CisgICAgY2FzZSBJbnB1dFR5cGU6Ok1vbnRoOgor ICAgIGNhc2UgSW5wdXRUeXBlOjpXZWVrOgorICAgIGNhc2UgSW5wdXRUeXBlOjpUaW1lOgorICAg IGNhc2UgSW5wdXRUeXBlOjpTZWxlY3Q6CisgICAgICAgIHJldHVybiB0cnVlOworICAgIGRlZmF1 bHQ6CisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9Cit9CisKIC0gKHZvaWQpX3N0YXJ0QXNz aXN0aW5nTm9kZTooY29uc3QgQXNzaXN0ZWROb2RlSW5mb3JtYXRpb24mKWluZm9ybWF0aW9uIHVz ZXJJc0ludGVyYWN0aW5nOihCT09MKXVzZXJJc0ludGVyYWN0aW5nIGJsdXJQcmV2aW91c05vZGU6 KEJPT0wpYmx1clByZXZpb3VzTm9kZSB1c2VyT2JqZWN0OihOU09iamVjdCA8TlNTZWN1cmVDb2Rp bmc+ICopdXNlck9iamVjdAogewogICAgIGlmICghdXNlcklzSW50ZXJhY3RpbmcgJiYgIV90ZXh0 U2VsZWN0aW9uQXNzaXN0YW50KQpAQCAtMjc2OCw2ICsyNzk0LDkgQEAgLSAodm9pZClfc3RhcnRB c3Npc3RpbmdOb2RlOihjb25zdCBBc3Npc3RlZE5vZGVJbmZvcm1hdGlvbiYpaW5mb3JtYXRpb24g dXNlcklzSW4KICAgICBpZiAoYmx1clByZXZpb3VzTm9kZSkKICAgICAgICAgW3NlbGYgX3N0b3BB c3Npc3RpbmdOb2RlXTsKIAorICAgIGlmICghaXNBc3Npc3RhYmxlSW5wdXRUeXBlKGluZm9ybWF0 aW9uLmVsZW1lbnRUeXBlKSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgLy8gRklYTUU6IFdlIHNo b3VsZCByZW1vdmUgdGhpcyBjaGVjayB3aGVuIHdlIG1hbmFnZSB0byBzZW5kIFN0YXJ0QXNzaXN0 aW5nTm9kZSBmcm9tIHRoZSBXZWJQcm9jZXNzCiAgICAgLy8gb25seSB3aGVuIGl0IGlzIHRydWx5 IHRpbWUgdG8gc2hvdyB0aGUga2V5Ym9hcmQuCiAgICAgaWYgKF9hc3Npc3RlZE5vZGVJbmZvcm1h dGlvbi5lbGVtZW50VHlwZSA9PSBpbmZvcm1hdGlvbi5lbGVtZW50VHlwZSAmJiBfYXNzaXN0ZWRO b2RlSW5mb3JtYXRpb24uZWxlbWVudFJlY3QgPT0gaW5mb3JtYXRpb24uZWxlbWVudFJlY3QpCmRp ZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggMjVkMzJhM2QzOTA4ZTA0OTkw YjdjZWJhOGIzNjVkNTJlOTNiZmYxNS4uYzdiNDUwM2M1OTM5NWVkODM5NGIwNWEyZjJjNDI5NGNk NmMwNTcwNSAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE0IEBACisyMDE1LTA0LTEwICBKb24gSG9uZXljdXR0ICA8amhvbmV5Y3V0dEBhcHBsZS5jb20+ CisKKyAgICAgICAgQ2Fubm90IGNsaWNrICJOZXh0IiBidXR0b24gb24gR29vZ2xlIHR3by1mYWN0 b3IgYXV0aCBzZXR1cCBwYWdlCisKKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDM2MjQ+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xOTE3NTcxND4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIE1hbnVh bFRlc3RzL2J1dHRvbi10aGF0LWZvY3VzZXMtaXRzZWxmLW9uLWNsaWNrLmh0bWw6IEFkZGVkLgor CiAyMDE1LTA0LTA2ICBBbGJlcnRvIEdhcmNpYSAgPGJlcnRvQGlnYWxpYS5jb20+CiAKICAgICAg ICAgW0dUS10gRml4IEhQUEEgYnVpbGQKZGlmZiAtLWdpdCBhL01hbnVhbFRlc3RzL2J1dHRvbi10 aGF0LWZvY3VzZXMtaXRzZWxmLW9uLWNsaWNrLmh0bWwgYi9NYW51YWxUZXN0cy9idXR0b24tdGhh dC1mb2N1c2VzLWl0c2VsZi1vbi1jbGljay5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjNkNWQ5M2FiNTdmYmY0 ODkzNWJlMzdmMzIxZDE3MjFkMDNhMjI0MmQKLS0tIC9kZXYvbnVsbAorKysgYi9NYW51YWxUZXN0 cy9idXR0b24tdGhhdC1mb2N1c2VzLWl0c2VsZi1vbi1jbGljay5odG1sCkBAIC0wLDAgKzEsMzMg QEAKKzxoZWFkPgorICAgIDxtZXRhIG5hbWU9InZpZXdwb3J0IiBjb250ZW50PSJ3aWR0aD1kZXZp Y2Utd2lkdGgiPgorICAgIDxzY3JpcHQ+CisgICAgICAgIHZhciBoYXZlQ2xpY2tlZCA9IGZhbHNl OworICAgICAgICBmdW5jdGlvbiBydW5UZXN0KGUpIHsKKyAgICAgICAgICAgIGlmIChoYXZlQ2xp Y2tlZCkgeworICAgICAgICAgICAgICAgIGUudmFsdWUgPSAiVGVzdCBwYXNzZWQiOworICAgICAg ICAgICAgICAgIGUuZGlzYWJsZWQgPSB0cnVlOworICAgICAgICAgICAgICAgIHJldHVybjsKKyAg ICAgICAgICAgIH0KKyAgICAgICAgICAgIGUudmFsdWUgPSAiQ2xpY2sgbWUgYWdhaW4iOworICAg ICAgICAgICAgZS5mb2N1cygpOworICAgICAgICAgICAgaGF2ZUNsaWNrZWQgPSB0cnVlOworICAg ICAgICB9CisgICAgPC9zY3JpcHQ+Cis8L2hlYWQ+CisKKzxib2R5PgorICAgIDxjZW50ZXI+Cisg ICAgICAgIDxpbnB1dCB0eXBlPXN1Ym1pdCBvbmNsaWNrPSJydW5UZXN0KHRoaXMpOyByZXR1cm4g ZmFsc2U7IiB2YWx1ZT0iQ2xpY2sgbWUiIHN0eWxlPSJmb250LXNpemU6IDM2cHgiPgorICAgIDwv Y2VudGVyPgorICAgIDxicj48YnI+CisgICAgPGRpdiBzdHlsZT0iZm9udC1zaXplOiAyMHB4OyBm b250LWZhbWlseTogaGVsdmV0aWNhOyI+CisgICAgICAgIFRlc3QgZm9yIFdlYktpdCBidWcgIzxh IGhyZWY9Imh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDM2MjQiPjE0 MzYyNDwvYT4KKyAgICAgICAgPGJyPjxicj4KKyAgICAgICAgVGFwIGJ1dHRvbiBhYm92ZSB0d2lj ZSB0byBydW4gdGVzdC4gJmxkcXVvO1Rlc3QgcGFzc2VkJnJkcXVvOyB3aWxsCisgICAgICAgIGFw cGVhciBhYm92ZSBpZiB0aGUgdGVzdCBwYXNzZXMuIElmIHlvdSBjYW5ub3QgY2xpY2sgdGhlIGJ1 dHRvbiBhCisgICAgICAgIHNlY29uZCB0aW1lLCB0aGUgdGVzdCBmYWlsZWQuCisgICAgICAgIDxi cj48YnI+CisgICAgICAgIFRvIHJlcnVuIHRoaXMgdGVzdCwgb3BlbiBpdCBpbiBhIG5ldyB0YWIu IERvIG5vdCByZWxvYWQuCisgICAgPC9kaXY+Cis8L2JvZHk+CisK