143621 2015-04-10 16:12:49 -0700 Hide volume controls when playing wirelessly 2015-04-10 23:25:34 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 roger_fong webkit-unassigned eric.carlson roger_fong oldest_to_newest 1084402 0 roger_fong 2015-04-10 16:12:49 -0700 Hide volume controls when playing wirelessly 1084403 1 roger_fong 2015-04-10 16:13:17 -0700 rdar://problem/20490673 1084408 2 250540 roger_fong 2015-04-10 16:48:12 -0700 Created attachment 250540 patch 1084462 3 250540 darin 2015-04-10 19:49:32 -0700 Comment on attachment 250540 patch View in context: https://bugs.webkit.org/attachment.cgi?id=250540&action=review > Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1776 > + if (!this.controls.panel.contains(this.controls.volumeBox)) Would it be more efficient to check the parent of volumeBox rather than calling contains? 1084485 4 roger_fong 2015-04-10 23:25:34 -0700 True this. Committed with changes: http://trac.webkit.org/changeset/182652 250540 2015-04-10 16:48:12 -0700 2015-04-10 19:49:32 -0700 patch patch.patch text/plain 2058 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MjY0MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA0LTEwICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgSGlkZSB2b2x1bWUgY29udHJv bHMgd2hlbiBwbGF5aW5nIHdpcmVsZXNzbHkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNDM2MjEuCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yMDQ5 MDY3Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IE1vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUuanM6CisgICAgICAgIChD b250cm9sbGVyLnByb3RvdHlwZS51cGRhdGVXaXJlbGVzc1BsYXliYWNrU3RhdHVzKToKKwogMjAx NS0wNC0xMCAgQmVtIEpvbmVzLUJleSAgPGJqb25lc2JlQGFkb2JlLmNvbT4KIAogICAgICAgICBV bnJldmlld2VkLCBhZGRlZCBDU1MgU2hhcGVzIHRvIGZlYXR1cmVzLmpzb24gZmlsZS4KSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUu anMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21l ZGlhQ29udHJvbHNBcHBsZS5qcwkocmV2aXNpb24gMTgyNjMxKQorKysgU291cmNlL1dlYkNvcmUv TW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBcHBsZS5qcwkod29ya2luZyBjb3B5 KQpAQCAtMTc2NSw5ICsxNzY1LDIwIEBAIENvbnRyb2xsZXIucHJvdG90eXBlID0gewogICAgICAg ICAgICAgICAgIHRoaXMuY29udHJvbHMuaW5saW5lUGxheWJhY2tQbGFjZWhvbGRlclRleHRUb3Au Y2xhc3NMaXN0LnJlbW92ZSh0aGlzLkNsYXNzTmFtZXMuc21hbGwpOwogICAgICAgICAgICAgICAg IHRoaXMuY29udHJvbHMuaW5saW5lUGxheWJhY2tQbGFjZWhvbGRlclRleHRCb3R0b20uY2xhc3NM aXN0LnJlbW92ZSh0aGlzLkNsYXNzTmFtZXMuc21hbGwpOwogICAgICAgICAgICAgfQorICAgICAg ICAgICAgaWYgKHRoaXMuaXNGdWxsU2NyZWVuKCkpCisgICAgICAgICAgICAgICAgdGhpcy5jb250 cm9scy5wYW5lbC5yZW1vdmVDaGlsZCh0aGlzLmNvbnRyb2xzLnZvbHVtZUJveCk7CisgICAgICAg ICAgICBlbHNlCisgICAgICAgICAgICAgICAgdGhpcy5jb250cm9scy5wYW5lbC5yZW1vdmVDaGls ZCh0aGlzLmNvbnRyb2xzLm11dGVCb3gpOwogICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAg dGhpcy5jb250cm9scy5pbmxpbmVQbGF5YmFja1BsYWNlaG9sZGVyLmNsYXNzTGlzdC5hZGQodGhp cy5DbGFzc05hbWVzLmhpZGRlbik7CiAgICAgICAgICAgICB0aGlzLmNvbnRyb2xzLndpcmVsZXNz VGFyZ2V0UGlja2VyLmNsYXNzTGlzdC5yZW1vdmUodGhpcy5DbGFzc05hbWVzLnBsYXlpbmcpOwor ICAgICAgICAgICAgaWYgKHRoaXMuaXNGdWxsU2NyZWVuKCkpIHsKKyAgICAgICAgICAgICAgICBp ZiAoIXRoaXMuY29udHJvbHMucGFuZWwuY29udGFpbnModGhpcy5jb250cm9scy52b2x1bWVCb3gp KQorICAgICAgICAgICAgICAgICAgICB0aGlzLmNvbnRyb2xzLnBhbmVsLmFwcGVuZENoaWxkKHRo aXMuY29udHJvbHMudm9sdW1lQm94KTsKKyAgICAgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAg ICAgICAgaWYgKCF0aGlzLmNvbnRyb2xzLnBhbmVsLmNvbnRhaW5zKHRoaXMuY29udHJvbHMubXV0 ZUJveCkpCisgICAgICAgICAgICAgICAgICAgIHRoaXMuY29udHJvbHMucGFuZWwuYXBwZW5kQ2hp bGQodGhpcy5jb250cm9scy5tdXRlQm94KTsKKyAgICAgICAgICAgIH0KICAgICAgICAgfQogICAg IH0sCiAK