143611 2015-04-10 10:48:39 -0700 Remove use of deprecated stringByReplacingPercentEscapesUsingEncoding API. 2024-08-27 08:24:29 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED CONFIGURATION CHANGED P2 Normal --- 1 enrica enrica annevk ap oldest_to_newest 1084333 0 enrica 2015-04-10 10:48:39 -0700 Needs to be replaced with stringByRemovingPercentEncoding, which always uses the recommended UTF-8 encoding. 1084337 1 250523 enrica 2015-04-10 10:58:06 -0700 Created attachment 250523 Patch 1084344 2 250523 ap 2015-04-10 11:12:50 -0700 Comment on attachment 250523 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250523&action=review > Source/WebKit/mac/ChangeLog:9 > + We now use stringByRemovingPercentEncoding, which always > + uses the recommended UTF-8 encoding. This looks like an undesirable change in behavior. When UTF-8 fails, we'll just get a null string, which is unacceptable. We should fall back to Latin-1 or maybe to keep the string percent encoded, I'm not sure what's actually best. 2055653 3 annevk 2024-08-27 08:24:29 -0700 > git grep stringByReplacingPercentEscapesUsingEncoding Source crickets 250523 2015-04-10 10:58:06 -0700 2015-04-10 11:12:50 -0700 Patch remove-deprecated.txt text/plain 1678 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MjYzMSkKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA0LTEw ICBFbnJpY2EgQ2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHVz ZSBvZiBkZXByZWNhdGVkIHN0cmluZ0J5UmVwbGFjaW5nUGVyY2VudEVzY2FwZXNVc2luZ0VuY29k aW5nIEFQSS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE0MzYxMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFdlIG5vdyB1c2Ugc3RyaW5nQnlSZW1vdmluZ1BlcmNlbnRFbmNvZGluZywgd2hpY2ggYWx3YXlz CisgICAgICAgIHVzZXMgdGhlIHJlY29tbWVuZGVkIFVURi04IGVuY29kaW5nLgorCisgICAgICAg ICogTWlzYy9XZWJOU1VSTEV4dHJhcy5tbToKKyAgICAgICAgKC1bTlNTdHJpbmcgX3dlYmtpdF91 bmVzY2FwZWRRdWVyeVZhbHVlXSk6CisKIDIwMTUtMDQtMTAgIEVyaWMgQ2FybHNvbiAgPGVyaWMu Y2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgW01hY10gUmVmYWN0b3IgTWVkaWFQbGF5YmFj a1RhcmdldApJbmRleDogU291cmNlL1dlYktpdC9tYWMvTWlzYy9XZWJOU1VSTEV4dHJhcy5tbQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L21hYy9NaXNjL1dlYk5TVVJMRXh0cmFzLm1tCShy ZXZpc2lvbiAxODI1NTMpCisrKyBTb3VyY2UvV2ViS2l0L21hYy9NaXNjL1dlYk5TVVJMRXh0cmFz Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yOTUsOSArMjk1LDcgQEAgLShCT09MKV93ZWJraXRfbG9v a3NMaWtlQWJzb2x1dGVVUkwKIAogLSAoTlNTdHJpbmcgKilfd2Via2l0X3VuZXNjYXBlZFF1ZXJ5 VmFsdWUKIHsKLSAgICBOU011dGFibGVTdHJpbmcgKnN0cmluZyA9IFtbW3NlbGYgc3RyaW5nQnlS ZXBsYWNpbmdQZXJjZW50RXNjYXBlc1VzaW5nRW5jb2Rpbmc6TlNVVEY4U3RyaW5nRW5jb2Rpbmdd IG11dGFibGVDb3B5XSBhdXRvcmVsZWFzZV07Ci0gICAgaWYgKCFzdHJpbmcpIC8vIElmIHdlIGZh aWxlZCB0byBkZWNvZGUgdGhlIFVSTCBhcyBVVEY4LCBmYWxsIGJhY2sgdG8gTGF0aW4xCi0gICAg ICAgIHN0cmluZyA9IFtbW3NlbGYgc3RyaW5nQnlSZXBsYWNpbmdQZXJjZW50RXNjYXBlc1VzaW5n RW5jb2Rpbmc6TlNJU09MYXRpbjFTdHJpbmdFbmNvZGluZ10gbXV0YWJsZUNvcHldIGF1dG9yZWxl YXNlXTsKKyAgICBOU011dGFibGVTdHJpbmcgKnN0cmluZyA9IFtbW3NlbGYgc3RyaW5nQnlSZW1v dmluZ1BlcmNlbnRFbmNvZGluZ10gbXV0YWJsZUNvcHldIGF1dG9yZWxlYXNlXTsKICAgICBbc3Ry aW5nIHJlcGxhY2VPY2N1cnJlbmNlc09mU3RyaW5nOkAiKyIgd2l0aFN0cmluZzpAIiAiIG9wdGlv bnM6TlNMaXRlcmFsU2VhcmNoIHJhbmdlOk5TTWFrZVJhbmdlKDAsIFtzdHJpbmcgbGVuZ3RoXSld OwogICAgIHJldHVybiBzdHJpbmc7CiB9Cg==