143597 2015-04-09 22:53:33 -0700 [Curl] Small improvements to CurlCacheEntry::parseResponseHeaders() 2015-04-13 07:06:42 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sungmann.cho webkit-unassigned bfulgham commit-queue galpeter ossy oldest_to_newest 1084208 0 sungmann.cho 2015-04-09 22:53:33 -0700 Most lines of code in CurlCacheEntry::parseResponseHeaders() don't need to be executed if the response has "no-cache" or "no-store" directive, but we are checking these conditions in the middle of the method. We can move this to the beginning of the method for efficiency. 1084209 1 250501 sungmann.cho 2015-04-09 22:55:11 -0700 Created attachment 250501 Patch 1084768 2 250501 ossy 2015-04-13 04:45:32 -0700 Comment on attachment 250501 Patch LGTM, r=me. 1084785 3 250501 commit-queue 2015-04-13 07:06:37 -0700 Comment on attachment 250501 Patch Clearing flags on attachment: 250501 Committed r182729: <http://trac.webkit.org/changeset/182729> 1084786 4 commit-queue 2015-04-13 07:06:42 -0700 All reviewed patches have been landed. Closing bug. 250501 2015-04-09 22:55:11 -0700 2015-04-13 07:06:37 -0700 Patch bug-143597-20150410145418.patch text/plain 2463 sungmann.cho U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyNjIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTg0ZWY1MGNiM2EwMjA1 YzgyNDY0MGQ5NGFhMTgxODYwMGYxMTlkYy4uY2M3NTFhYjBhMTg4MzNmYWY4MmRjOTljMTg2OGM1 NjQ1ODBlNDlhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTA0LTA5ICBTdW5n bWFubiBDaG8gIDxzdW5nbWFubi5jaG9AbmF2ZXJjb3JwLmNvbT4KKworICAgICAgICBbQ3VybF0g U21hbGwgaW1wcm92ZW1lbnRzIHRvIEN1cmxDYWNoZUVudHJ5OjpwYXJzZVJlc3BvbnNlSGVhZGVy cygpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDM1 OTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNb3N0 IGxpbmVzIG9mIGNvZGUgaW4gQ3VybENhY2hlRW50cnk6OnBhcnNlUmVzcG9uc2VIZWFkZXJzKCkg ZG9uJ3QgbmVlZCB0byBiZQorICAgICAgICBleGVjdXRlZCBpZiB0aGUgcmVzcG9uc2UgaGFzICJu by1jYWNoZSIgb3IgIm5vLXN0b3JlIiBkaXJlY3RpdmUsIGJ1dCB3ZSBhcmUKKyAgICAgICAgY2hl Y2tpbmcgdGhlc2UgY29uZGl0aW9ucyBpbiB0aGUgbWlkZGxlIG9mIHRoZSBtZXRob2QuIFdlIGNh biBtb3ZlIHRoaXMgdG8gdGhlCisgICAgICAgIGJlZ2lubmluZyBvZiB0aGUgbWV0aG9kIGZvciBl ZmZpY2llbmN5LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdlLgor CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxDYWNoZUVudHJ5LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkN1cmxDYWNoZUVudHJ5OjpwYXJzZVJlc3BvbnNlSGVhZGVycyk6CisK IDIwMTUtMDQtMDkgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBT aW1wbGUgbGluZSBsYXlvdXQ6IEFkZCA8YnI+IHN1cHBvcnQuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybENhY2hlRW50cnkuY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxDYWNoZUVudHJ5LmNwcAppbmRleCAw MzQyNDE4YTYxMGNiNzVhMDBkNTczNDNhM2VhYTExZGNmMzJjZDEyLi4zMTRlNWJmMmU0ZjBiNTU4 NmYzOGNhYTE2YTI4NDUyOWRjYTZlNmIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybENhY2hlRW50cnkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsQ2FjaGVFbnRyeS5jcHAKQEAgLTI3MywyMSArMjcz LDE3IEBAIGJvb2wgQ3VybENhY2hlRW50cnk6OnBhcnNlUmVzcG9uc2VIZWFkZXJzKGNvbnN0IFJl c291cmNlUmVzcG9uc2UmIHJlc3BvbnNlKQogewogICAgIHVzaW5nIG5hbWVzcGFjZSBzdGQ6OmNo cm9ubzsKIAorICAgIGlmIChyZXNwb25zZS5jYWNoZUNvbnRyb2xDb250YWluc05vQ2FjaGUoKSB8 fCByZXNwb25zZS5jYWNoZUNvbnRyb2xDb250YWluc05vU3RvcmUoKSB8fCAhcmVzcG9uc2UuaGFz Q2FjaGVWYWxpZGF0b3JGaWVsZHMoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCiAgICAgZG91 YmxlIGZpbGVUaW1lOwogICAgIHRpbWVfdCBmaWxlTW9kaWZpY2F0aW9uRGF0ZTsKIAotICAgIGlm IChnZXRGaWxlTW9kaWZpY2F0aW9uVGltZShtX2hlYWRlckZpbGVuYW1lLCBmaWxlTW9kaWZpY2F0 aW9uRGF0ZSkpIHsKLSAgICAgICAgZmlsZVRpbWUgPSBkaWZmdGltZShmaWxlTW9kaWZpY2F0aW9u RGF0ZSwgMCk7Ci0gICAgICAgIGZpbGVUaW1lICo9IDEwMDAuMDsKLSAgICB9IGVsc2UKKyAgICBp ZiAoZ2V0RmlsZU1vZGlmaWNhdGlvblRpbWUobV9oZWFkZXJGaWxlbmFtZSwgZmlsZU1vZGlmaWNh dGlvbkRhdGUpKQorICAgICAgICBmaWxlVGltZSA9IGRpZmZ0aW1lKGZpbGVNb2RpZmljYXRpb25E YXRlLCAwKSAqIDEwMDAuMDsKKyAgICBlbHNlCiAgICAgICAgIGZpbGVUaW1lID0gY3VycmVudFRp bWVNUygpOyAvLyBHTVQKIAotICAgIGlmIChyZXNwb25zZS5jYWNoZUNvbnRyb2xDb250YWluc05v Q2FjaGUoKSB8fCByZXNwb25zZS5jYWNoZUNvbnRyb2xDb250YWluc05vU3RvcmUoKSkKLSAgICAg ICAgcmV0dXJuIGZhbHNlOwotCi0gICAgaWYgKCFyZXNwb25zZS5oYXNDYWNoZVZhbGlkYXRvckZp ZWxkcygpKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0KICAgICBhdXRvIG1heEFnZSA9IHJlc3Bv bnNlLmNhY2hlQ29udHJvbE1heEFnZSgpOwogICAgIGF1dG8gbGFzdE1vZGlmaWNhdGlvbkRhdGUg PSByZXNwb25zZS5sYXN0TW9kaWZpZWQoKTsKICAgICBhdXRvIHJlc3BvbnNlRGF0ZSA9IHJlc3Bv bnNlLmRhdGUoKTsK