143596 2015-04-09 21:33:10 -0700 [CMake] Print sorted feature list at the very end of the configure process 2015-04-13 06:24:13 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Enhancement --- 143665 143636 1 mcatanzaro mcatanzaro cgarcia commit-queue mcatanzaro mrobinson oldest_to_newest 1084189 0 mcatanzaro 2015-04-09 21:33:10 -0700 Print the list of enabled features at the end of the configure process, instead of in the middle, so that users can actually see it. This is traditional in autotools projects. Also, sort the list. 1084194 1 250500 mcatanzaro 2015-04-09 21:35:40 -0700 Created attachment 250500 [CMake] Print sorted feature list at the very end 1084559 2 250578 mcatanzaro 2015-04-11 12:52:05 -0700 Created attachment 250578 [CMake] Print sorted feature list at the very end 1084560 3 250578 mrobinson 2015-04-11 12:58:04 -0700 Comment on attachment 250578 [CMake] Print sorted feature list at the very end View in context: https://bugs.webkit.org/attachment.cgi?id=250578&action=review Thanks for taking care of the details! This looks good to me, though I have a few picky suggestions. > Source/cmake/WebKitFeatures.cmake:161 > + WEBKIT_OPTION_DEFINE(USE_SYSTEM_MALLOC "Toggle system allocator instead of malloc" OFF) Maybe you could write "WebKit's custom allocator" instead of "malloc." I think "malloc" might be confusing because I think of that as the system allocator. :) > Source/cmake/WebKitFeatures.cmake:171 > + # Alphabetize. Comments in WebKit should really be complete sentences. I'm not sure if a comment is really necessary here though, since list(SORT isn't much less obscure than "Alphabetize." > Source/cmake/WebKitFeatures.cmake:189 > + if (NOT _WEBKIT_AVAILABLE_OPTIONS_ISPUBLIC_${_name}) I also greatly prefer IS_PUBLIC to ISPUBLIC. I think we should fix INITIALVALUE as well. > Source/cmake/WebKitFeatures.cmake:210 > + # Print dots every other row, to improve readability of the features list. > if (_SHOULD_PRINT_POINTS) Can we simply rename this variable to be clearer? Why not just call do _SHOULD_PRINT_POINTS to _SHOULD_PRINT_DOTS_FOR_READABILITY? > CMakeLists.txt:183 > +# Print enabled features last for maximum visibility Nit: Missing a period here. 1084563 4 250581 mcatanzaro 2015-04-11 13:07:35 -0700 Created attachment 250581 [CMake] Print sorted feature list at the very end 1084564 5 mcatanzaro 2015-04-11 13:14:21 -0700 Sorry, the updated patch does not address your review comments, because I did not notice your review yet. :) (In reply to comment #3) > Maybe you could write "WebKit's custom allocator" instead of "malloc." I > think "malloc" might be confusing because I think of that as the system > allocator. :) Yes, I meant to put bmalloc there, but actually I meant to do that in a separate patch. :p Hence the re-uploaded patch that does not include this change. I will do this in a separate style patch. > > Source/cmake/WebKitFeatures.cmake:171 > > + # Alphabetize. > > Comments in WebKit should really be complete sentences. I'm not sure if a > comment is really necessary here though, since list(SORT isn't much less > obscure than "Alphabetize." OK. It's probably not needed. I thought "sort how?" but it should be clear enough. > > Source/cmake/WebKitFeatures.cmake:189 > > + if (NOT _WEBKIT_AVAILABLE_OPTIONS_ISPUBLIC_${_name}) > > I also greatly prefer IS_PUBLIC to ISPUBLIC. I think we should fix > INITIALVALUE as well. OK. I will do this in the style patch (since this patch does not introduce the variable.) > > Source/cmake/WebKitFeatures.cmake:210 > > + # Print dots every other row, to improve readability of the features list. > > if (_SHOULD_PRINT_POINTS) > > Can we simply rename this variable to be clearer? Why not just call do > _SHOULD_PRINT_POINTS to _SHOULD_PRINT_DOTS_FOR_READABILITY? Ummmmm... I don't think so, what was initially unclear to me was that the dots are intended to be printed on every other line. What I would think after seeing that name is "why should it sometimes not be readable?" Anyway, this comment should move to the style patch. > > CMakeLists.txt:183 > > +# Print enabled features last for maximum visibility > > Nit: Missing a period here. OK 1084565 6 250582 mcatanzaro 2015-04-11 13:20:25 -0700 Created attachment 250582 [CMake] Print sorted feature list at the very end 1084566 7 mrobinson 2015-04-11 13:31:26 -0700 (In reply to comment #5) > > > Source/cmake/WebKitFeatures.cmake:210 > > > + # Print dots every other row, to improve readability of the features list. > > > if (_SHOULD_PRINT_POINTS) > > > > Can we simply rename this variable to be clearer? Why not just call do > > _SHOULD_PRINT_POINTS to _SHOULD_PRINT_DOTS_FOR_READABILITY? > > Ummmmm... I don't think so, what was initially unclear to me was that the > dots are intended to be printed on every other line. What I would think > after seeing that name is "why should it sometimes not be readable?" Anyway, > this comment should move to the style patch. I misread the original comment, but now that I understand it I agree with you. 1084574 8 250582 commit-queue 2015-04-11 14:29:33 -0700 Comment on attachment 250582 [CMake] Print sorted feature list at the very end Clearing flags on attachment: 250582 Committed r182663: <http://trac.webkit.org/changeset/182663> 1084575 9 commit-queue 2015-04-11 14:29:38 -0700 All reviewed patches have been landed. Closing bug. 250500 2015-04-09 21:35:40 -0700 2015-04-11 10:15:00 -0700 [CMake] Print sorted feature list at the very end bug-143596-20150409233448.patch text/plain 1927 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyNTY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0RmVhdHVyZXMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKaW5k ZXggYzE4ZjgxYmE2NTQ2ZTY0OWNmODU4YmZlNWJhZWJmOWVjN2ZlOTJiMS4uNGEwOWUyZDI3YTY0 NjRjNjY3MzgwYjNhYzQzOGI1MDFlMGVmNzZkNCAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dl YktpdEZlYXR1cmVzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFr ZQpAQCAtMTg5LDYgKzE4OSwxMSBAQCBtYWNybyhXRUJLSVRfT1BUSU9OX0VORCkKICAgICAgICAg ICAgIGVuZGlmICgpCiAgICAgICAgIGVuZGlmICgpCiAgICAgZW5kZm9yZWFjaCAoKQorZW5kbWFj cm8oKQorCittYWNybyhQUklOVF9XRUJLSVRfT1BUSU9OUykKKyAgICAjIEFscGhhYmV0aXplIGZl YXR1cmVzIGJlZm9yZSBwcmludGluZworICAgIGxpc3QoU09SVCBfV0VCS0lUX0FWQUlMQUJMRV9P UFRJT05TKQogCiAgICAgbWVzc2FnZShTVEFUVVMgIkVuYWJsZWQgZmVhdHVyZXM6IikKIApkaWZm IC0tZ2l0IGEvQ01ha2VMaXN0cy50eHQgYi9DTWFrZUxpc3RzLnR4dAppbmRleCAzMDEwMTM0MzFm Y2NkOWY2OThiZTRmYWU3YmRlMGQzOTJkNTgzZTk0Li4zMzM4Y2Q3ZmY5OWRjYzIxZDM0MmY5MDA2 NWVmYzc2ZWNiMmY2MTZkIDEwMDY0NAotLS0gYS9DTWFrZUxpc3RzLnR4dAorKysgYi9DTWFrZUxp c3RzLnR4dApAQCAtMTgwLDMgKzE4MCw4IEBAIGFkZF9zdWJkaXJlY3RvcnkoU291cmNlKQogaWYg KEVOQUJMRV9UT09MUykKICAgICBhZGRfc3ViZGlyZWN0b3J5KFRvb2xzKQogZW5kaWYgKCkKKwor IyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLQorIyBQcmludCBlbmFibGVkIGZlYXR1cmVzIGxhc3QgZm9y IG1heGltdW0gdmlzaWJpbGl0eQorIyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQorUFJJTlRfV0VCS0lU X09QVElPTlMoKQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDBmZTc3 NGYwMzZhZGRkNDEzYTk0NTVkYTAyZTZjNTE5YzNjZDY1YjUuLjdiZWFkNDZlMjlmMDVkNzYxMTA0 ZTJlNDAxNzVmNTZkOTJkZDMyOTMgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VM b2cKQEAgLTEsNSArMSwxNiBAQAogMjAxNS0wNC0wOSAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0 YW56YXJvQGlnYWxpYS5jb20+CiAKKyAgICAgICAgW0NNYWtlXSBQcmludCBzb3J0ZWQgZmVhdHVy ZSBsaXN0IGF0IHRoZSB2ZXJ5IGVuZCBvZiB0aGUgY29uZmlndXJlIHByb2Nlc3MKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MzU5NgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6 IENhbGwgUFJJTlRfV0VCS0lUX09QVElPTlMgYXQgdGhlIGJvdHRvbSBvZiB0aGUgZmlsZS4KKyAg ICAgICAgKiBTb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2U6IFNwbGl0IG9wdGlvbiBw cmludGluZyBpbnRvIFBSSU5UX1dFQktJVF9PUFRJT05TIG1hY3JvLAorICAgICAgICBhbmQgc29y dCB0aGUgb3B0aW9ucyBiZWZvcmUgcHJpbnRpbmcuCisKKzIwMTUtMDQtMDkgIE1pY2hhZWwgQ2F0 YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCiAgICAgICAgIFtDTWFrZV0gU29tZSBp bnRlcm5hbCB2YXJpYWJsZXMgYXJlIG5vdCBtYXJrZWQgYXMgYWR2YW5jZWQKICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MzU5NQogCg== 250578 2015-04-11 12:52:05 -0700 2015-04-11 13:07:31 -0700 [CMake] Print sorted feature list at the very end bug-143596-20150411145111.patch text/plain 4295 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyNjM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0RmVhdHVyZXMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKaW5k ZXggYzE4ZjgxYmE2NTQ2ZTY0OWNmODU4YmZlNWJhZWJmOWVjN2ZlOTJiMS4uMzM5MzQzNWFmOTBm YjdhNmRkNTg2OGM3NjVmN2FkMzFkZTJiYTYyYyAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dl YktpdEZlYXR1cmVzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFr ZQpAQCAtMTU4LDcgKzE1OCw3IEBAIG1hY3JvKFdFQktJVF9PUFRJT05fQkVHSU4pCiAgICAgV0VC S0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX1dFQlZUVF9SRUdJT05TICJUb2dnbGUgd2VidnR0IHJl Z2lvbiBzdXBwb3J0IiBPRkYpCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX1hIUl9U SU1FT1VUICJUb2dnbGUgWEhSIHRpbWVvdXQgc3VwcG9ydCIgT0ZGKQogICAgIFdFQktJVF9PUFRJ T05fREVGSU5FKEVOQUJMRV9YU0xUICJUb2dnbGUgWFNMVCBzdXBwb3J0IiBPTikKLSAgICBXRUJL SVRfT1BUSU9OX0RFRklORShVU0VfU1lTVEVNX01BTExPQyAiVG9nZ2xlIHN5c3RlbSBhbGxvY2F0 b3IgaW5zdGVhZCBvZiBUQ21hbGxvYyIgT0ZGKQorICAgIFdFQktJVF9PUFRJT05fREVGSU5FKFVT RV9TWVNURU1fTUFMTE9DICJUb2dnbGUgc3lzdGVtIGFsbG9jYXRvciBpbnN0ZWFkIG9mIG1hbGxv YyIgT0ZGKQogICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9USFJFQURFRF9DT01QT1NJ VE9SICJUb2dnbGUgdGhyZWFkZWQgY29tcG9zaXRvciBzdXBwb3J0IiBPRkYpCiAKICAgICBXRUJL SVRfT1BUSU9OX0RFUEVORChFTkFCTEVfRU5DUllQVEVEX01FRElBX1YyIEVOQUJMRV9WSURFTykK QEAgLTE2OCwxMiArMTY4LDggQEAgbWFjcm8oV0VCS0lUX09QVElPTl9CRUdJTikKIGVuZG1hY3Jv KCkKIAogbWFjcm8oV0VCS0lUX09QVElPTl9FTkQpCi0gICAgZm9yZWFjaCAoX25hbWUgJHtfV0VC S0lUX0FWQUlMQUJMRV9PUFRJT05TfSkKLSAgICAgICAgb3B0aW9uKCR7X25hbWV9ICIke19XRUJL SVRfQVZBSUxBQkxFX09QVElPTlNfREVTQ1JJUFRJT05fJHtfbmFtZX19IiAke19XRUJLSVRfQVZB SUxBQkxFX09QVElPTlNfSU5JVElBTFZBTFVFXyR7X25hbWV9fSkKLSAgICAgICAgaWYgKE5PVCBf V0VCS0lUX0FWQUlMQUJMRV9PUFRJT05TX0lTUFVCTElDXyR7X25hbWV9KQotICAgICAgICAgICAg bWFya19hc19hZHZhbmNlZChGT1JDRSAke19uYW1lfSkKLSAgICAgICAgZW5kaWYgKCkKLSAgICBl bmRmb3JlYWNoICgpCisgICAgIyBBbHBoYWJldGl6ZS4KKyAgICBsaXN0KFNPUlQgX1dFQktJVF9B VkFJTEFCTEVfT1BUSU9OUykKIAogICAgIHNldChfTUFYX0ZFQVRVUkVfTEVOR1RIIDApCiAgICAg Zm9yZWFjaCAoX25hbWUgJHtfV0VCS0lUX0FWQUlMQUJMRV9PUFRJT05TfSkKQEAgLTE4OCw4ICsx ODQsMjAgQEAgbWFjcm8oV0VCS0lUX09QVElPTl9FTkQpCiAgICAgICAgICAgICAgICAgc2V0KCR7 X25hbWV9IE9GRikKICAgICAgICAgICAgIGVuZGlmICgpCiAgICAgICAgIGVuZGlmICgpCisKKyAg ICAgICAgb3B0aW9uKCR7X25hbWV9ICIke19XRUJLSVRfQVZBSUxBQkxFX09QVElPTlNfREVTQ1JJ UFRJT05fJHtfbmFtZX19IiAke19XRUJLSVRfQVZBSUxBQkxFX09QVElPTlNfSU5JVElBTFZBTFVF XyR7X25hbWV9fSkKKyAgICAgICAgaWYgKE5PVCBfV0VCS0lUX0FWQUlMQUJMRV9PUFRJT05TX0lT UFVCTElDXyR7X25hbWV9KQorICAgICAgICAgICAgbWFya19hc19hZHZhbmNlZChGT1JDRSAke19u YW1lfSkKKyAgICAgICAgZW5kaWYgKCkKKworICAgICAgICBpZiAoJHtfbmFtZX0pCisgICAgICAg ICAgICBsaXN0KEFQUEVORCBGRUFUVVJFX0RFRklORVMgJHtfbmFtZX0pCisgICAgICAgICAgICBz ZXQoRkVBVFVSRV9ERUZJTkVTX1dJVEhfU1BBQ0VfU0VQQVJBVE9SICIke0ZFQVRVUkVfREVGSU5F U19XSVRIX1NQQUNFX1NFUEFSQVRPUn0gJHtfbmFtZX0iKQorICAgICAgICBlbmRpZiAoKQogICAg IGVuZGZvcmVhY2ggKCkKK2VuZG1hY3JvKCkKIAorbWFjcm8oUFJJTlRfV0VCS0lUX09QVElPTlMp CiAgICAgbWVzc2FnZShTVEFUVVMgIkVuYWJsZWQgZmVhdHVyZXM6IikKIAogICAgIHNldChfU0hP VUxEX1BSSU5UX1BPSU5UUyBPRkYpCkBAIC0xOTgsNiArMjA2LDcgQEAgbWFjcm8oV0VCS0lUX09Q VElPTl9FTkQpCiAKICAgICAgICAgc2V0KF9NRVNTQUdFICIgJHtfbmFtZX0gIikKIAorICAgICAg ICAjIFByaW50IGRvdHMgZXZlcnkgb3RoZXIgcm93LCB0byBpbXByb3ZlIHJlYWRhYmlsaXR5IG9m IHRoZSBmZWF0dXJlcyBsaXN0LgogICAgICAgICBpZiAoX1NIT1VMRF9QUklOVF9QT0lOVFMpCiAg ICAgICAgICAgICBmb3JlYWNoIChJR05PUkUgUkFOR0UgJHtfTkFNRV9MRU5HVEh9ICR7X01BWF9G RUFUVVJFX0xFTkdUSH0pCiAgICAgICAgICAgICAgICAgc2V0KF9NRVNTQUdFICIke19NRVNTQUdF fSAiKQpAQCAtMjEwLDExICsyMTksNiBAQCBtYWNybyhXRUJLSVRfT1BUSU9OX0VORCkKICAgICAg ICAgICAgIHNldChfU0hPVUxEX1BSSU5UX1BPSU5UUyBPTikKICAgICAgICAgZW5kaWYgKCkKIAot ICAgICAgICBpZiAoJHtfbmFtZX0pCi0gICAgICAgICAgICBsaXN0KEFQUEVORCBGRUFUVVJFX0RF RklORVMgJHtfbmFtZX0pCi0gICAgICAgICAgICBzZXQoRkVBVFVSRV9ERUZJTkVTX1dJVEhfU1BB Q0VfU0VQQVJBVE9SICIke0ZFQVRVUkVfREVGSU5FU19XSVRIX1NQQUNFX1NFUEFSQVRPUn0gJHtf bmFtZX0iKQotICAgICAgICBlbmRpZiAoKQotCiAgICAgICAgIHNldChfTUVTU0FHRSAiJHtfTUVT U0FHRX0gJHske19uYW1lfX0iKQogCiAgICAgICAgIGlmIChfV0VCS0lUX0FWQUlMQUJMRV9PUFRJ T05TX0lTUFVCTElDXyR7X25hbWV9KQpkaWZmIC0tZ2l0IGEvQ01ha2VMaXN0cy50eHQgYi9DTWFr ZUxpc3RzLnR4dAppbmRleCBlMjJkNmQ3NjkwMmJlOTM0NDgzMzU1NDE2NmE2ZWFlMGNhNGUyYzk1 Li4xY2JiODk2YzIwOGFkYzJmMWY4NjgwMWIyOTZiMjAzNzAwMmY1ZDU5IDEwMDY0NAotLS0gYS9D TWFrZUxpc3RzLnR4dAorKysgYi9DTWFrZUxpc3RzLnR4dApAQCAtMTc4LDMgKzE3OCw4IEBAIGFk ZF9zdWJkaXJlY3RvcnkoU291cmNlKQogaWYgKEVOQUJMRV9UT09MUykKICAgICBhZGRfc3ViZGly ZWN0b3J5KFRvb2xzKQogZW5kaWYgKCkKKworIyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQorIyBQcmlu dCBlbmFibGVkIGZlYXR1cmVzIGxhc3QgZm9yIG1heGltdW0gdmlzaWJpbGl0eQorIyAtLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLQorUFJJTlRfV0VCS0lUX09QVElPTlMoKQpkaWZmIC0tZ2l0IGEvQ2hhbmdl TG9nIGIvQ2hhbmdlTG9nCmluZGV4IDVkMzdiZTljYzcxNjFkNWI5YTE5NWY4YjllNDMyYzQyNTk3 NTVkNjYuLjdiOWFhODc2NjQ4MzExM2Q0MDU3NGE4ZjcxOGVmMDc5ODQ4ZmIzYzIgMTAwNjQ0Ci0t LSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTE1LDYgKzE1LDE3IEBACiAKIDIwMTUt MDQtMDkgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgogCisgICAg ICAgIFtDTWFrZV0gUHJpbnQgc29ydGVkIGZlYXR1cmUgbGlzdCBhdCB0aGUgdmVyeSBlbmQgb2Yg dGhlIGNvbmZpZ3VyZSBwcm9jZXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDM1OTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OiBDYWxsIFBSSU5UX1dFQktJVF9PUFRJT05T IGF0IHRoZSBib3R0b20gb2YgdGhlIGZpbGUuCisgICAgICAgICogU291cmNlL2NtYWtlL1dlYktp dEZlYXR1cmVzLmNtYWtlOiBTcGxpdCBvcHRpb24gcHJpbnRpbmcgaW50byBQUklOVF9XRUJLSVRf T1BUSU9OUyBtYWNybywKKyAgICAgICAgYW5kIHNvcnQgdGhlIG9wdGlvbnMgYmVmb3JlIHByaW50 aW5nLgorCisyMDE1LTA0LTA5ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlh LmNvbT4KKwogICAgICAgICBbQ01ha2VdIFNvbWUgaW50ZXJuYWwgdmFyaWFibGVzIGFyZSBub3Qg bWFya2VkIGFzIGFkdmFuY2VkCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNDM1OTUKIAo= 250581 2015-04-11 13:07:35 -0700 2015-04-11 13:20:21 -0700 [CMake] Print sorted feature list at the very end bug-143596-20150411150641.patch text/plain 3345 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyNjM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0RmVhdHVyZXMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKaW5k ZXggYzE4ZjgxYmE2NTQ2ZTY0OWNmODU4YmZlNWJhZWJmOWVjN2ZlOTJiMS4uYTdhMjI4NzI2NGRl OTljYzFjNDZjZmIwOWZhNjQ0N2UzYzJiZDQyZSAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dl YktpdEZlYXR1cmVzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFr ZQpAQCAtMTY4LDEyICsxNjgsOCBAQCBtYWNybyhXRUJLSVRfT1BUSU9OX0JFR0lOKQogZW5kbWFj cm8oKQogCiBtYWNybyhXRUJLSVRfT1BUSU9OX0VORCkKLSAgICBmb3JlYWNoIChfbmFtZSAke19X RUJLSVRfQVZBSUxBQkxFX09QVElPTlN9KQotICAgICAgICBvcHRpb24oJHtfbmFtZX0gIiR7X1dF QktJVF9BVkFJTEFCTEVfT1BUSU9OU19ERVNDUklQVElPTl8ke19uYW1lfX0iICR7X1dFQktJVF9B VkFJTEFCTEVfT1BUSU9OU19JTklUSUFMVkFMVUVfJHtfbmFtZX19KQotICAgICAgICBpZiAoTk9U IF9XRUJLSVRfQVZBSUxBQkxFX09QVElPTlNfSVNQVUJMSUNfJHtfbmFtZX0pCi0gICAgICAgICAg ICBtYXJrX2FzX2FkdmFuY2VkKEZPUkNFICR7X25hbWV9KQotICAgICAgICBlbmRpZiAoKQotICAg IGVuZGZvcmVhY2ggKCkKKyAgICAjIEFscGhhYmV0aXplLgorICAgIGxpc3QoU09SVCBfV0VCS0lU X0FWQUlMQUJMRV9PUFRJT05TKQogCiAgICAgc2V0KF9NQVhfRkVBVFVSRV9MRU5HVEggMCkKICAg ICBmb3JlYWNoIChfbmFtZSAke19XRUJLSVRfQVZBSUxBQkxFX09QVElPTlN9KQpAQCAtMTg4LDgg KzE4NCwyMCBAQCBtYWNybyhXRUJLSVRfT1BUSU9OX0VORCkKICAgICAgICAgICAgICAgICBzZXQo JHtfbmFtZX0gT0ZGKQogICAgICAgICAgICAgZW5kaWYgKCkKICAgICAgICAgZW5kaWYgKCkKKwor ICAgICAgICBvcHRpb24oJHtfbmFtZX0gIiR7X1dFQktJVF9BVkFJTEFCTEVfT1BUSU9OU19ERVND UklQVElPTl8ke19uYW1lfX0iICR7X1dFQktJVF9BVkFJTEFCTEVfT1BUSU9OU19JTklUSUFMVkFM VUVfJHtfbmFtZX19KQorICAgICAgICBpZiAoTk9UIF9XRUJLSVRfQVZBSUxBQkxFX09QVElPTlNf SVNQVUJMSUNfJHtfbmFtZX0pCisgICAgICAgICAgICBtYXJrX2FzX2FkdmFuY2VkKEZPUkNFICR7 X25hbWV9KQorICAgICAgICBlbmRpZiAoKQorCisgICAgICAgIGlmICgke19uYW1lfSkKKyAgICAg ICAgICAgIGxpc3QoQVBQRU5EIEZFQVRVUkVfREVGSU5FUyAke19uYW1lfSkKKyAgICAgICAgICAg IHNldChGRUFUVVJFX0RFRklORVNfV0lUSF9TUEFDRV9TRVBBUkFUT1IgIiR7RkVBVFVSRV9ERUZJ TkVTX1dJVEhfU1BBQ0VfU0VQQVJBVE9SfSAke19uYW1lfSIpCisgICAgICAgIGVuZGlmICgpCiAg ICAgZW5kZm9yZWFjaCAoKQorZW5kbWFjcm8oKQogCittYWNybyhQUklOVF9XRUJLSVRfT1BUSU9O UykKICAgICBtZXNzYWdlKFNUQVRVUyAiRW5hYmxlZCBmZWF0dXJlczoiKQogCiAgICAgc2V0KF9T SE9VTERfUFJJTlRfUE9JTlRTIE9GRikKQEAgLTIxMCwxMSArMjE4LDYgQEAgbWFjcm8oV0VCS0lU X09QVElPTl9FTkQpCiAgICAgICAgICAgICBzZXQoX1NIT1VMRF9QUklOVF9QT0lOVFMgT04pCiAg ICAgICAgIGVuZGlmICgpCiAKLSAgICAgICAgaWYgKCR7X25hbWV9KQotICAgICAgICAgICAgbGlz dChBUFBFTkQgRkVBVFVSRV9ERUZJTkVTICR7X25hbWV9KQotICAgICAgICAgICAgc2V0KEZFQVRV UkVfREVGSU5FU19XSVRIX1NQQUNFX1NFUEFSQVRPUiAiJHtGRUFUVVJFX0RFRklORVNfV0lUSF9T UEFDRV9TRVBBUkFUT1J9ICR7X25hbWV9IikKLSAgICAgICAgZW5kaWYgKCkKLQogICAgICAgICBz ZXQoX01FU1NBR0UgIiR7X01FU1NBR0V9ICR7JHtfbmFtZX19IikKIAogICAgICAgICBpZiAoX1dF QktJVF9BVkFJTEFCTEVfT1BUSU9OU19JU1BVQkxJQ18ke19uYW1lfSkKZGlmZiAtLWdpdCBhL0NN YWtlTGlzdHMudHh0IGIvQ01ha2VMaXN0cy50eHQKaW5kZXggZTIyZDZkNzY5MDJiZTkzNDQ4MzM1 NTQxNjZhNmVhZTBjYTRlMmM5NS4uMWNiYjg5NmMyMDhhZGMyZjFmODY4MDFiMjk2YjIwMzcwMDJm NWQ1OSAxMDA2NDQKLS0tIGEvQ01ha2VMaXN0cy50eHQKKysrIGIvQ01ha2VMaXN0cy50eHQKQEAg LTE3OCwzICsxNzgsOCBAQCBhZGRfc3ViZGlyZWN0b3J5KFNvdXJjZSkKIGlmIChFTkFCTEVfVE9P TFMpCiAgICAgYWRkX3N1YmRpcmVjdG9yeShUb29scykKIGVuZGlmICgpCisKKyMgLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0KKyMgUHJpbnQgZW5hYmxlZCBmZWF0dXJlcyBsYXN0IGZvciBtYXhpbXVtIHZp c2liaWxpdHkKKyMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KK1BSSU5UX1dFQktJVF9PUFRJT05TKCkK ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA1ZDM3YmU5Y2M3MTYxZDVi OWExOTVmOGI5ZTQzMmM0MjU5NzU1ZDY2Li43YjlhYTg3NjY0ODMxMTNkNDA1NzRhOGY3MThlZjA3 OTg0OGZiM2MyIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xNSw2 ICsxNSwxNyBAQAogCiAyMDE1LTA0LTA5ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9A aWdhbGlhLmNvbT4KIAorICAgICAgICBbQ01ha2VdIFByaW50IHNvcnRlZCBmZWF0dXJlIGxpc3Qg YXQgdGhlIHZlcnkgZW5kIG9mIHRoZSBjb25maWd1cmUgcHJvY2VzcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzNTk2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDogQ2FsbCBQ UklOVF9XRUJLSVRfT1BUSU9OUyBhdCB0aGUgYm90dG9tIG9mIHRoZSBmaWxlLgorICAgICAgICAq IFNvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFrZTogU3BsaXQgb3B0aW9uIHByaW50aW5n IGludG8gUFJJTlRfV0VCS0lUX09QVElPTlMgbWFjcm8sCisgICAgICAgIGFuZCBzb3J0IHRoZSBv cHRpb25zIGJlZm9yZSBwcmludGluZy4KKworMjAxNS0wNC0wOSAgTWljaGFlbCBDYXRhbnphcm8g IDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CisKICAgICAgICAgW0NNYWtlXSBTb21lIGludGVybmFs IHZhcmlhYmxlcyBhcmUgbm90IG1hcmtlZCBhcyBhZHZhbmNlZAogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzNTk1CiAK 250582 2015-04-11 13:20:25 -0700 2015-04-11 14:29:33 -0700 [CMake] Print sorted feature list at the very end bug-143596-20150411151931.patch text/plain 3392 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyNjM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0RmVhdHVyZXMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKaW5k ZXggYzE4ZjgxYmE2NTQ2ZTY0OWNmODU4YmZlNWJhZWJmOWVjN2ZlOTJiMS4uNmVhODI3MjdjZTNm NzNhMWE4YTM2ODQ4MTdkMzYzMzY3ZjY2NmIxZSAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dl YktpdEZlYXR1cmVzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFr ZQpAQCAtMTY4LDEzICsxNjgsNyBAQCBtYWNybyhXRUJLSVRfT1BUSU9OX0JFR0lOKQogZW5kbWFj cm8oKQogCiBtYWNybyhXRUJLSVRfT1BUSU9OX0VORCkKLSAgICBmb3JlYWNoIChfbmFtZSAke19X RUJLSVRfQVZBSUxBQkxFX09QVElPTlN9KQotICAgICAgICBvcHRpb24oJHtfbmFtZX0gIiR7X1dF QktJVF9BVkFJTEFCTEVfT1BUSU9OU19ERVNDUklQVElPTl8ke19uYW1lfX0iICR7X1dFQktJVF9B VkFJTEFCTEVfT1BUSU9OU19JTklUSUFMVkFMVUVfJHtfbmFtZX19KQotICAgICAgICBpZiAoTk9U IF9XRUJLSVRfQVZBSUxBQkxFX09QVElPTlNfSVNQVUJMSUNfJHtfbmFtZX0pCi0gICAgICAgICAg ICBtYXJrX2FzX2FkdmFuY2VkKEZPUkNFICR7X25hbWV9KQotICAgICAgICBlbmRpZiAoKQotICAg IGVuZGZvcmVhY2ggKCkKLQorICAgIGxpc3QoU09SVCBfV0VCS0lUX0FWQUlMQUJMRV9PUFRJT05T KQogICAgIHNldChfTUFYX0ZFQVRVUkVfTEVOR1RIIDApCiAgICAgZm9yZWFjaCAoX25hbWUgJHtf V0VCS0lUX0FWQUlMQUJMRV9PUFRJT05TfSkKICAgICAgICAgc3RyaW5nKExFTkdUSCAke19uYW1l fSBfTkFNRV9MRU5HVEgpCkBAIC0xODgsOCArMTgyLDIwIEBAIG1hY3JvKFdFQktJVF9PUFRJT05f RU5EKQogICAgICAgICAgICAgICAgIHNldCgke19uYW1lfSBPRkYpCiAgICAgICAgICAgICBlbmRp ZiAoKQogICAgICAgICBlbmRpZiAoKQorCisgICAgICAgIG9wdGlvbigke19uYW1lfSAiJHtfV0VC S0lUX0FWQUlMQUJMRV9PUFRJT05TX0RFU0NSSVBUSU9OXyR7X25hbWV9fSIgJHtfV0VCS0lUX0FW QUlMQUJMRV9PUFRJT05TX0lOSVRJQUxWQUxVRV8ke19uYW1lfX0pCisgICAgICAgIGlmIChOT1Qg X1dFQktJVF9BVkFJTEFCTEVfT1BUSU9OU19JU1BVQkxJQ18ke19uYW1lfSkKKyAgICAgICAgICAg IG1hcmtfYXNfYWR2YW5jZWQoRk9SQ0UgJHtfbmFtZX0pCisgICAgICAgIGVuZGlmICgpCisKKyAg ICAgICAgaWYgKCR7X25hbWV9KQorICAgICAgICAgICAgbGlzdChBUFBFTkQgRkVBVFVSRV9ERUZJ TkVTICR7X25hbWV9KQorICAgICAgICAgICAgc2V0KEZFQVRVUkVfREVGSU5FU19XSVRIX1NQQUNF X1NFUEFSQVRPUiAiJHtGRUFUVVJFX0RFRklORVNfV0lUSF9TUEFDRV9TRVBBUkFUT1J9ICR7X25h bWV9IikKKyAgICAgICAgZW5kaWYgKCkKICAgICBlbmRmb3JlYWNoICgpCitlbmRtYWNybygpCiAK K21hY3JvKFBSSU5UX1dFQktJVF9PUFRJT05TKQogICAgIG1lc3NhZ2UoU1RBVFVTICJFbmFibGVk IGZlYXR1cmVzOiIpCiAKICAgICBzZXQoX1NIT1VMRF9QUklOVF9QT0lOVFMgT0ZGKQpAQCAtMjEw LDExICsyMTYsNiBAQCBtYWNybyhXRUJLSVRfT1BUSU9OX0VORCkKICAgICAgICAgICAgIHNldChf U0hPVUxEX1BSSU5UX1BPSU5UUyBPTikKICAgICAgICAgZW5kaWYgKCkKIAotICAgICAgICBpZiAo JHtfbmFtZX0pCi0gICAgICAgICAgICBsaXN0KEFQUEVORCBGRUFUVVJFX0RFRklORVMgJHtfbmFt ZX0pCi0gICAgICAgICAgICBzZXQoRkVBVFVSRV9ERUZJTkVTX1dJVEhfU1BBQ0VfU0VQQVJBVE9S ICIke0ZFQVRVUkVfREVGSU5FU19XSVRIX1NQQUNFX1NFUEFSQVRPUn0gJHtfbmFtZX0iKQotICAg ICAgICBlbmRpZiAoKQotCiAgICAgICAgIHNldChfTUVTU0FHRSAiJHtfTUVTU0FHRX0gJHske19u YW1lfX0iKQogCiAgICAgICAgIGlmIChfV0VCS0lUX0FWQUlMQUJMRV9PUFRJT05TX0lTUFVCTElD XyR7X25hbWV9KQpkaWZmIC0tZ2l0IGEvQ01ha2VMaXN0cy50eHQgYi9DTWFrZUxpc3RzLnR4dApp bmRleCBlMjJkNmQ3NjkwMmJlOTM0NDgzMzU1NDE2NmE2ZWFlMGNhNGUyYzk1Li4zMjc3ZjYxYzZh MGY4MmRkYWUwOGU0ODBiOTdkMWI3MjM1NmI2MjNhIDEwMDY0NAotLS0gYS9DTWFrZUxpc3RzLnR4 dAorKysgYi9DTWFrZUxpc3RzLnR4dApAQCAtMTc4LDMgKzE3OCw4IEBAIGFkZF9zdWJkaXJlY3Rv cnkoU291cmNlKQogaWYgKEVOQUJMRV9UT09MUykKICAgICBhZGRfc3ViZGlyZWN0b3J5KFRvb2xz KQogZW5kaWYgKCkKKworIyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQorIyBQcmludCB0aGUgZmVhdHVy ZXMgbGlzdCBsYXN0LCBmb3IgbWF4aW11bSB2aXNpYmlsaXR5LgorIyAtLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLQorUFJJTlRfV0VCS0lUX09QVElPTlMoKQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hh bmdlTG9nCmluZGV4IDVkMzdiZTljYzcxNjFkNWI5YTE5NWY4YjllNDMyYzQyNTk3NTVkNjYuLjg1 MTM4YzBjMmZkMmE2MGEwMmQ1NzYzMzEyM2Y3YzU1MzMxOTg5NDkgMTAwNjQ0Ci0tLSBhL0NoYW5n ZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNS0wNC0wOSAgTWljaGFl bCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0NNYWtlXSBQ cmludCBzb3J0ZWQgZmVhdHVyZSBsaXN0IGF0IHRoZSB2ZXJ5IGVuZCBvZiB0aGUgY29uZmlndXJl IHByb2Nlc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE0MzU5NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogQ01ha2VMaXN0cy50eHQ6IENhbGwgUFJJTlRfV0VCS0lUX09QVElPTlMgYXQgdGhlIGJvdHRv bSBvZiB0aGUgZmlsZS4KKyAgICAgICAgKiBTb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21h a2U6IFNwbGl0IG9wdGlvbiBwcmludGluZyBpbnRvIFBSSU5UX1dFQktJVF9PUFRJT05TIG1hY3Jv LAorICAgICAgICBhbmQgc29ydCB0aGUgb3B0aW9ucyBiZWZvcmUgcHJpbnRpbmcuIFJlb3JkZXIg c29tZSBjb2RlIHNvIHRoYXQgZmVhdHVyZXMgc3RpbGwgZ2V0CisgICAgICAgIHByb3BhZ2F0ZWQg dG8gdGhlIGJpbmRpbmdzIGdlbmVyYXRvcnMuCisKIDIwMTUtMDQtMTAgIEd5dXlvdW5nIEtpbSAg PGd5dXlvdW5nLmtpbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtDTWFrZV0gUmVtb3ZlIHVubmVj ZXNzYXJ5IEVOQUJMRV9XRUJDT1JFIHN3aXRjaAo=