143595 2015-04-09 20:58:43 -0700 [CMake] Some internal variables are not marked as advanced 2015-04-23 13:31:38 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro cgarcia commit-queue mcatanzaro mrobinson oldest_to_newest 1084184 0 mcatanzaro 2015-04-09 20:58:43 -0700 The FindFreetype2 module uses find_path and find_library without marking the result as advanced, like all the other find* modules do. Also, FindHarfBuzz was updated to look for harfbuzz-icu without marking HARFBUZZ_ICU_LIBRARIES as advanced. 1084185 1 250499 mcatanzaro 2015-04-09 21:00:12 -0700 Created attachment 250499 [CMake] Some internal variables are not marked as advanced 1087967 2 250499 commit-queue 2015-04-23 13:31:34 -0700 Comment on attachment 250499 [CMake] Some internal variables are not marked as advanced Clearing flags on attachment: 250499 Committed r183206: <http://trac.webkit.org/changeset/183206> 1087968 3 commit-queue 2015-04-23 13:31:38 -0700 All reviewed patches have been landed. Closing bug. 250499 2015-04-09 21:00:12 -0700 2015-04-23 13:31:34 -0700 [CMake] Some internal variables are not marked as advanced bug-143595-20150409225920.patch text/plain 1831 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyNTY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu ZEZyZWV0eXBlMi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9GaW5kRnJlZXR5cGUyLmNtYWtlCmluZGV4 IGZkY2MyYzkyODBmNjUxOGM3MWVkMzY0MWY4MDc4NTVlM2FmZDUyYTQuLjE0ZThiMTZkMWRiNWEw ODEzNWNjMDg3MzVlMGI5NzljZjcyZmU5NzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9GaW5k RnJlZXR5cGUyLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9GaW5kRnJlZXR5cGUyLmNtYWtlCkBA IC04NiwzICs4Niw5IEBAIGlmIChGUkVFVFlQRTJfVkVSU0lPTl9TVFJJTkcpCiBlbmRpZiAoKQog CiBGSU5EX1BBQ0tBR0VfSEFORExFX1NUQU5EQVJEX0FSR1MoRnJlZXR5cGUyIERFRkFVTFRfTVNH IEZSRUVUWVBFMl9JTkNMVURFX0RJUlMgRlJFRVRZUEUyX0xJQlJBUklFUyBWRVJTSU9OX09LKQor CittYXJrX2FzX2FkdmFuY2VkKAorICAgIEZSRUVUWVBFMl9IRUFERVJfRElSCisgICAgRlJFRVRZ UEUyX0xJQlJBUklFUworICAgIEZSRUVUWVBFMl9ST09UX0lOQ0xVREVfRElSCispCmRpZmYgLS1n aXQgYS9Tb3VyY2UvY21ha2UvRmluZEhhcmZCdXp6LmNtYWtlIGIvU291cmNlL2NtYWtlL0ZpbmRI YXJmQnV6ei5jbWFrZQppbmRleCBiYzcwMmM0ZWI3MWYyOTE2Yjc0MzU0ZWM1YmMzYzZlY2Q5ZTVh YThjLi44NDQwYzdiMmI2ODAxYTg1MjgwYjljMjUyODM3ZDY3ZDkyOGRkOTgxIDEwMDY0NAotLS0g YS9Tb3VyY2UvY21ha2UvRmluZEhhcmZCdXp6LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9GaW5k SGFyZkJ1enouY21ha2UKQEAgLTU1LDYgKzU1LDcgQEAgaW5jbHVkZShGaW5kUGFja2FnZUhhbmRs ZVN0YW5kYXJkQXJncykKIEZJTkRfUEFDS0FHRV9IQU5ETEVfU1RBTkRBUkRfQVJHUyhIYXJmQnV6 eiBERUZBVUxUX01TRyBIQVJGQlVaWl9JTkNMVURFX0RJUlMgSEFSRkJVWlpfTElCUkFSSUVTKQog CiBtYXJrX2FzX2FkdmFuY2VkKAorICAgIEhBUkZCVVpaX0lDVV9MSUJSQVJJRVMKICAgICBIQVJG QlVaWl9JTkNMVURFX0RJUlMKICAgICBIQVJGQlVaWl9MSUJSQVJJRVMKICkKZGlmZiAtLWdpdCBh L0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAyMTZmMGMxYjZkODA0YTQ2NmUzNzdkODQ3ODQ2 NmNhOWE1ZTMzYTdkLi4wZmU3NzRmMDM2YWRkZDQxM2E5NDU1ZGEwMmU2YzUxOWMzY2Q2NWI1IDEw MDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUgQEAKIDIw MTUtMDQtMDkgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgogCisg ICAgICAgIFtDTWFrZV0gU29tZSBpbnRlcm5hbCB2YXJpYWJsZXMgYXJlIG5vdCBtYXJrZWQgYXMg YWR2YW5jZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE0MzU5NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogU291cmNlL2NtYWtlL0ZpbmRGcmVldHlwZTIuY21ha2U6IE1hcmsgaW50ZXJuYWwgb3B0aW9u cyBhcyBhZHZhbmNlZC4KKyAgICAgICAgKiBTb3VyY2UvY21ha2UvRmluZEhhcmZCdXp6LmNtYWtl OiBNYXJrIEhBUkZCVVpaX0lDVV9MSUJSQVJJRVMgYXMgYWR2YW5jZWQuCisKKzIwMTUtMDQtMDkg IE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCiAgICAgICAgIFtH VEtdIE1hcmsgYXMgYWR2YW5jZWQgdGhlIGJ1aWxkIG9wdGlvbnMgd2UgZG9uJ3Qgd2FudCB0byBl eHBvc2UKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0 MzU1OAogCg==