143587 2015-04-09 16:09:58 -0700 Web Inspector: ObjectTree Property Path tooltip has a few issues 2015-04-09 17:22:14 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1084104 0 joepeck 2015-04-09 16:09:58 -0700 * SUMMARY ObjectTree Property Path tooltip has a few issues. All trivial to fix. - $n broken after refactoring - broken for Map values after class conversion - broken for Symbol properties (treats them like strings) 1084105 1 webkit-bug-importer 2015-04-09 16:10:29 -0700 <rdar://problem/20490990> 1084109 2 250483 joepeck 2015-04-09 16:11:57 -0700 Created attachment 250483 [PATCH] Proposed Fix 1084146 3 250483 commit-queue 2015-04-09 17:22:09 -0700 Comment on attachment 250483 [PATCH] Proposed Fix Clearing flags on attachment: 250483 Committed r182616: <http://trac.webkit.org/changeset/182616> 1084147 4 commit-queue 2015-04-09 17:22:14 -0700 All reviewed patches have been landed. Closing bug. 250483 2015-04-09 16:11:57 -0700 2015-04-09 17:22:09 -0700 [PATCH] Proposed Fix quick-fixes.patch text/plain 5248 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDFjNzg3N2YuLmMyZjlkOTUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI5IEBACiAyMDE1LTA0LTA5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogT2JqZWN0 VHJlZSBQcm9wZXJ0eSBQYXRoIHRvb2x0aXAgaGFzIGEgZmV3IGlzc3VlcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzNTg3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL01vZGVs cy9Qcm9wZXJ0eVBhdGguanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUHJvcGVydHlQYXRoLnBy b3RvdHlwZS5hcHBlbmRTeW1ib2xQcm9wZXJ0eSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUHJv cGVydHlQYXRoLnByb3RvdHlwZS5hcHBlbmRQcm9wZXJ0eURlc2NyaXB0b3IpOgorICAgICAgICBI YW5kbGUgU3ltYm9sIHByb3BlcnRpZXMuIFRoZXkgYXJlIHRyZWF0ZWQgYXMgYW4gaW1wb3NzaWJs ZSBwYXRoCisgICAgICAgIGJlY2F1c2Ugd2UgY2Fubm90IGd1YXJlbnRlZSBhIHJlZmVyZW5jZSB0 byB0aGUgU3ltYm9sIHJpZ2h0IG5vdy4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3Mv Q29uc29sZU1lc3NhZ2VWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvbnNvbGVNZXNz YWdlVmlldy5wcm90b3R5cGUuX3Jvb3RQcm9wZXJ0eVBhdGhGb3JPYmplY3QpOgorICAgICAgICBU aGUgc2F2ZWRSZXN1bHRJbmRleCBpcyBvbiBtZXNzYWdlLgorCisgICAgICAgICogVXNlckludGVy ZmFjZS9WaWV3cy9PYmplY3RUcmVlTWFwRW50cnlUcmVlRWxlbWVudC5qczoKKyAgICAgICAgKFdl Ykluc3BlY3Rvci5PYmplY3RUcmVlTWFwRW50cnlUcmVlRWxlbWVudCk6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuT2JqZWN0VHJlZU1hcEtleVRyZWVFbGVtZW50KToKKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5PYmplY3RUcmVlTWFwVmFsdWVUcmVlRWxlbWVudCk6CisgICAgICAgIEluIG9yZGVyIGZv ciAia2V5IiB0byBiZSBhdmFpbGFibGUgc2V0dXAgdGhlIG1haW5UaXRsZSBhZnRlcgorICAgICAg ICB0aGUgY2FsbCB0byB0aGUgYmFzZSdzIGNvbnN0cnVjdG9yLgorCisyMDE1LTA0LTA5ICBKb3Nl cGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3Rv cjogVW5jYXVnaHQgZXhjZXB0aW9uIHVzaW5nIGNvbnNvbGUudGFibGUgd2l0aCBmaWx0ZXIgYXJn dW1lbnQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0 MzU3OQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9N b2RlbHMvUHJvcGVydHlQYXRoLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvTW9kZWxzL1Byb3BlcnR5UGF0aC5qcwppbmRleCBlNjY1NzUzLi5mOWRkYWFlIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvUHJvcGVydHlQ YXRoLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9Q cm9wZXJ0eVBhdGguanMKQEAgLTIzMSwxMCArMjMxLDIwIEBAIFdlYkluc3BlY3Rvci5Qcm9wZXJ0 eVBhdGggPSBjbGFzcyBQcm9wZXJ0eVBhdGggZXh0ZW5kcyBXZWJJbnNwZWN0b3IuT2JqZWN0CiAg ICAgICAgIHJldHVybiBuZXcgV2ViSW5zcGVjdG9yLlByb3BlcnR5UGF0aChvYmplY3QsIGNvbXBv bmVudCwgdGhpcyk7CiAgICAgfQogCisgICAgYXBwZW5kU3ltYm9sUHJvcGVydHkob2JqZWN0KQor ICAgIHsKKyAgICAgICAgdmFyIGNvbXBvbmVudCA9IFdlYkluc3BlY3Rvci5Qcm9wZXJ0eVBhdGgu U3BlY2lhbFBhdGhDb21wb25lbnQuU3ltYm9sUHJvcGVydHlOYW1lOworICAgICAgICByZXR1cm4g bmV3IFdlYkluc3BlY3Rvci5Qcm9wZXJ0eVBhdGgob2JqZWN0LCBjb21wb25lbnQsIHRoaXMpOwor ICAgIH0KKwogICAgIGFwcGVuZFByb3BlcnR5RGVzY3JpcHRvcihvYmplY3QsIGRlc2NyaXB0b3Is IHR5cGUpCiAgICAgeworICAgICAgICBjb25zb2xlLmFzc2VydChkZXNjcmlwdG9yIGluc3RhbmNl b2YgV2ViSW5zcGVjdG9yLlByb3BlcnR5RGVzY3JpcHRvcik7CisKICAgICAgICAgaWYgKGRlc2Ny aXB0b3IuaXNJbnRlcm5hbFByb3BlcnR5KQogICAgICAgICAgICAgcmV0dXJuIHRoaXMuYXBwZW5k SW50ZXJuYWxQcm9wZXJ0eU5hbWUob2JqZWN0LCBkZXNjcmlwdG9yLm5hbWUpOworICAgICAgICBp ZiAoZGVzY3JpcHRvci5zeW1ib2wpCisgICAgICAgICAgICByZXR1cm4gdGhpcy5hcHBlbmRTeW1i b2xQcm9wZXJ0eShvYmplY3QpOwogCiAgICAgICAgIGlmICh0eXBlID09PSBXZWJJbnNwZWN0b3Iu UHJvcGVydHlQYXRoLlR5cGUuR2V0dGVyKQogICAgICAgICAgICAgcmV0dXJuIHRoaXMuYXBwZW5k R2V0dGVyUHJvcGVydHlOYW1lKG9iamVjdCwgZGVzY3JpcHRvci5uYW1lKTsKQEAgLTI0Myw4ICsy NTMsNiBAQCBXZWJJbnNwZWN0b3IuUHJvcGVydHlQYXRoID0gY2xhc3MgUHJvcGVydHlQYXRoIGV4 dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVjdAogCiAgICAgICAgIGNvbnNvbGUuYXNzZXJ0KHR5cGUg PT09IFdlYkluc3BlY3Rvci5Qcm9wZXJ0eVBhdGguVHlwZS5WYWx1ZSk7CiAKLSAgICAgICAgLy8g RklYTUU6IFdlIGRvbid0IHlldCBoYXZlIFN5bWJvbCBkZXNjcmlwdG9ycy4KLQogICAgICAgICBp ZiAodGhpcy5fb2JqZWN0LnN1YnR5cGUgPT09ICJhcnJheSIgJiYgIWlzTmFOKHBhcnNlSW50KGRl c2NyaXB0b3IubmFtZSkpKQogICAgICAgICAgICAgcmV0dXJuIHRoaXMuYXBwZW5kQXJyYXlJbmRl eChvYmplY3QsIGRlc2NyaXB0b3IubmFtZSk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnNvbGVNZXNzYWdlVmlldy5qcyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnNvbGVNZXNzYWdlVmlldy5q cwppbmRleCAyZmRiMjk0Li4yMzJmOWUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9Db25zb2xlTWVzc2FnZVZpZXcuanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29uc29sZU1lc3NhZ2VWaWV3Lmpz CkBAIC0zODcsNyArMzg3LDcgQEAgV2ViSW5zcGVjdG9yLkNvbnNvbGVNZXNzYWdlVmlldyA9IGNs YXNzIENvbnNvbGVNZXNzYWdlVmlldyBleHRlbmRzIFdlYkluc3BlY3Rvci4KICAgICAgICAgaWYg KCF0aGlzLl9tZXNzYWdlLnNhdmVkUmVzdWx0SW5kZXgpCiAgICAgICAgICAgICByZXR1cm4gbnVs bDsKIAotICAgICAgICByZXR1cm4gbmV3IFdlYkluc3BlY3Rvci5Qcm9wZXJ0eVBhdGgob2JqZWN0 LCAiJCIgKyB0aGlzLnNhdmVkUmVzdWx0SW5kZXgpOworICAgICAgICByZXR1cm4gbmV3IFdlYklu c3BlY3Rvci5Qcm9wZXJ0eVBhdGgob2JqZWN0LCAiJCIgKyB0aGlzLl9tZXNzYWdlLnNhdmVkUmVz dWx0SW5kZXgpOwogICAgIH0KIAogICAgIF9mb3JtYXRXaXRoU3Vic3RpdHV0aW9uU3RyaW5nKHBh cmFtZXRlcnMsIGZvcm1hdHRlZFJlc3VsdCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL09iamVjdFRyZWVNYXBFbnRyeVRyZWVFbGVtZW50Lmpz IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT2JqZWN0VHJlZU1h cEVudHJ5VHJlZUVsZW1lbnQuanMKaW5kZXggMjcxZjQ0Ny4uOTk5ZTI2MCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT2JqZWN0VHJlZU1hcEVu dHJ5VHJlZUVsZW1lbnQuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvT2JqZWN0VHJlZU1hcEVudHJ5VHJlZUVsZW1lbnQuanMKQEAgLTM0LDcgKzM0LDYg QEAgV2ViSW5zcGVjdG9yLk9iamVjdFRyZWVNYXBFbnRyeVRyZWVFbGVtZW50ID0gY2xhc3MgT2Jq ZWN0VHJlZU1hcEVudHJ5VHJlZUVsZW1lbnQKIAogICAgICAgICB0aGlzLl9vYmplY3QgPSBvYmpl Y3Q7CiAKLSAgICAgICAgdGhpcy5tYWluVGl0bGUgPSB0aGlzLl90aXRsZUZyYWdtZW50KCk7CiAg ICAgICAgIHRoaXMuYWRkQ2xhc3NOYW1lKCJvYmplY3QtdHJlZS1hcnJheS1pbmRleCIpOwogICAg ICAgICB0aGlzLmFkZENsYXNzTmFtZSgib2JqZWN0LXRyZWUtbWFwLWVudHJ5Iik7CiAgICAgfQpA QCAtNTgsOSArNTcsNyBAQCBXZWJJbnNwZWN0b3IuT2JqZWN0VHJlZU1hcEVudHJ5VHJlZUVsZW1l bnQgPSBjbGFzcyBPYmplY3RUcmVlTWFwRW50cnlUcmVlRWxlbWVudAogICAgICAgICByZXR1cm4g V2ViSW5zcGVjdG9yLlByb3BlcnR5UGF0aC5UeXBlLlZhbHVlOwogICAgIH0KIAotICAgIC8vIFBy aXZhdGUKLQotICAgIF90aXRsZUZyYWdtZW50KCkKKyAgICB0aXRsZUZyYWdtZW50KCkKICAgICB7 CiAgICAgICAgIHZhciBjb250YWluZXIgPSBkb2N1bWVudC5jcmVhdGVEb2N1bWVudEZyYWdtZW50 KCk7CiAKQEAgLTg3LDYgKzg0LDggQEAgV2ViSW5zcGVjdG9yLk9iamVjdFRyZWVNYXBLZXlUcmVl RWxlbWVudCA9IGNsYXNzIE9iamVjdFRyZWVNYXBLZXlUcmVlRWxlbWVudCBleHQKICAgICB7CiAg ICAgICAgIHN1cGVyKG9iamVjdCwgcHJvcGVydHlQYXRoKTsKIAorICAgICAgICB0aGlzLm1haW5U aXRsZSA9IHRoaXMudGl0bGVGcmFnbWVudCgpOworCiAgICAgICAgIHRoaXMuYWRkQ2xhc3NOYW1l KCJrZXkiKTsKICAgICB9CiAKQEAgLTExMCw2ICsxMDksOCBAQCBXZWJJbnNwZWN0b3IuT2JqZWN0 VHJlZU1hcFZhbHVlVHJlZUVsZW1lbnQgPSBjbGFzcyBPYmplY3RUcmVlTWFwVmFsdWVUcmVlRWxl bWVudAogICAgICAgICBzdXBlcihvYmplY3QsIHByb3BlcnR5UGF0aCk7CiAKICAgICAgICAgdGhp cy5fa2V5ID0ga2V5OworICAgICAgICAKKyAgICAgICAgdGhpcy5tYWluVGl0bGUgPSB0aGlzLnRp dGxlRnJhZ21lbnQoKTsKIAogICAgICAgICB0aGlzLmFkZENsYXNzTmFtZSgidmFsdWUiKTsKICAg ICB9Cg==