143575 2015-04-09 13:40:49 -0700 [WK2] Regression(r182194): The NetworkProcess is calling the wrong memory pressure handler before suspending 2015-04-09 15:20:35 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez commit-queue ddkilzer kling oldest_to_newest 1084038 0 cdumez 2015-04-09 13:40:49 -0700 After r182194, the NetworkProcess is calling the memory pressure handler before getting suspended to free-up as much memory as possible at this point. However, we are calling the default memory pressure handling code instead of the custom handler registered by the NetworkProcess. Radar: <rdar://problem/20484338> 1084044 1 250463 cdumez 2015-04-09 13:46:06 -0700 Created attachment 250463 Patch 1084072 2 250463 commit-queue 2015-04-09 15:20:30 -0700 Comment on attachment 250463 Patch Clearing flags on attachment: 250463 Committed r182608: <http://trac.webkit.org/changeset/182608> 1084073 3 commit-queue 2015-04-09 15:20:35 -0700 All reviewed patches have been landed. Closing bug. 250463 2015-04-09 13:46:06 -0700 2015-04-09 15:20:30 -0700 Patch bug-143575-20150409134515.patch text/plain 3400 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyNjA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjg2ZDE1ZDBhMmM1ZDY5 MDk3Mzk3OWJkMDA0MWQzMTM2MjJiYTRkOS4uNGU0OGRhNzIxNDEwNWJkY2UxOGRhYTNkZTc5N2Vh MjAxN2U4NDc5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI3IEBACiAyMDE1LTA0LTA5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgW1dLMl0gUmVncmVzc2lvbihy MTgyMTk0KTogVGhlIE5ldHdvcmtQcm9jZXNzIGlzIGNhbGxpbmcgdGhlIHdyb25nIG1lbW9yeSBw cmVzc3VyZSBoYW5kbGVyIGJlZm9yZSBzdXNwZW5kaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDM1NzUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzIwNDg0MzM4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEFmdGVyIHIxODIxOTQsIHRoZSBOZXR3b3JrUHJvY2VzcyBpcyBjYWxsaW5nIHRoZSBtZW1v cnkgcHJlc3N1cmUKKyAgICAgICAgaGFuZGxlciBiZWZvcmUgZ2V0dGluZyBzdXNwZW5kZWQgdG8g ZnJlZS11cCBhcyBtdWNoIG1lbW9yeSBhcyBwb3NzaWJsZQorICAgICAgICBhdCB0aGlzIHBvaW50 LgorCisgICAgICAgIEhvd2V2ZXIsIHdlIHdlcmUgY2FsbGluZyB0aGUgZGVmYXVsdCBtZW1vcnkg cHJlc3N1cmUgaGFuZGxpbmcgY29kZQorICAgICAgICBpbnN0ZWFkIG9mIHRoZSBjdXN0b20gaGFu ZGxlciByZWdpc3RlcmVkIGJ5IHRoZSBOZXR3b3JrUHJvY2Vzcy4gVGhpcworICAgICAgICBwYXRj aCBmaXhlcyB0aGUgcHJvYmxlbS4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL05ldHdvcmtQ cm9jZXNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya1Byb2Nlc3M6Omxvd01lbW9yeUhh bmRsZXIpOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrUHJvY2Vzczo6aW5pdGlhbGl6ZU5ldHdv cmtQcm9jZXNzKToKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya1Byb2Nlc3M6OnByb2Nlc3NXaWxs U3VzcGVuZCk6CisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Byb2Nlc3MuaDoKKwor MjAxNS0wNC0wOSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCiAgICAgICAgIFtX SzJdW2lPU10gZWRpdG9yU3RhdGUoKSBzaG91bGQgbm90IGNhdXNlIGEgc3luY2hyb25vdXMgbGF5 b3V0CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDI1 MzYKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzIwMDQxNTA2PgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Byb2Nlc3MuY3BwIGIvU291cmNlL1dlYktp dDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Byb2Nlc3MuY3BwCmluZGV4IDMwYThlNjA3Y2Y4ZjBi ZmFkYTNmMDE5MzE1Y2JiOWNmMDExZTljZTkuLjQwZjU0NTE5ZDNkMzU5ZWI4NTg5NGE1NTJiMDBk ZTk3OGE2MzBlODkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05l dHdvcmtQcm9jZXNzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3 b3JrUHJvY2Vzcy5jcHAKQEAgLTE2Niw2ICsxNjYsMTIgQEAgQXV0aGVudGljYXRpb25NYW5hZ2Vy JiBOZXR3b3JrUHJvY2Vzczo6ZG93bmxvYWRzQXV0aGVudGljYXRpb25NYW5hZ2VyKCkKICAgICBy ZXR1cm4gYXV0aGVudGljYXRpb25NYW5hZ2VyKCk7CiB9CiAKK3ZvaWQgTmV0d29ya1Byb2Nlc3M6 Omxvd01lbW9yeUhhbmRsZXIoYm9vbCBjcml0aWNhbCkKK3sKKyAgICBwbGF0Zm9ybUxvd01lbW9y eUhhbmRsZXIoY3JpdGljYWwpOworICAgIFdURjo6cmVsZWFzZUZhc3RNYWxsb2NGcmVlTWVtb3J5 KCk7Cit9CisKIHZvaWQgTmV0d29ya1Byb2Nlc3M6OmluaXRpYWxpemVOZXR3b3JrUHJvY2Vzcyhj b25zdCBOZXR3b3JrUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVycyYgcGFyYW1ldGVycykKIHsKICAg ICBwbGF0Zm9ybUluaXRpYWxpemVOZXR3b3JrUHJvY2VzcyhwYXJhbWV0ZXJzKTsKQEAgLTE3NCw4 ICsxODAsNyBAQCB2b2lkIE5ldHdvcmtQcm9jZXNzOjppbml0aWFsaXplTmV0d29ya1Byb2Nlc3Mo Y29uc3QgTmV0d29ya1Byb2Nlc3NDcmVhdGlvblBhcmFtZQogCiAgICAgYXV0byYgbWVtb3J5UHJl c3N1cmVIYW5kbGVyID0gTWVtb3J5UHJlc3N1cmVIYW5kbGVyOjpzaW5nbGV0b24oKTsKICAgICBt ZW1vcnlQcmVzc3VyZUhhbmRsZXIuc2V0TG93TWVtb3J5SGFuZGxlcihbdGhpc10gKGJvb2wgY3Jp dGljYWwpIHsKLSAgICAgICAgcGxhdGZvcm1Mb3dNZW1vcnlIYW5kbGVyKGNyaXRpY2FsKTsKLSAg ICAgICAgV1RGOjpyZWxlYXNlRmFzdE1hbGxvY0ZyZWVNZW1vcnkoKTsKKyAgICAgICAgbG93TWVt b3J5SGFuZGxlcihjcml0aWNhbCk7CiAgICAgfSk7CiAgICAgbWVtb3J5UHJlc3N1cmVIYW5kbGVy Lmluc3RhbGwoKTsKIApAQCAtNTA2LDcgKzUxMSw3IEBAIHZvaWQgTmV0d29ya1Byb2Nlc3M6OnRl cm1pbmF0ZSgpCiAKIHZvaWQgTmV0d29ya1Byb2Nlc3M6OnByb2Nlc3NXaWxsU3VzcGVuZCgpCiB7 Ci0gICAgTWVtb3J5UHJlc3N1cmVIYW5kbGVyOjpzaW5nbGV0b24oKS5yZWxlYXNlTWVtb3J5KHRy dWUpOworICAgIGxvd01lbW9yeUhhbmRsZXIodHJ1ZSk7CiAgICAgcGFyZW50UHJvY2Vzc0Nvbm5l Y3Rpb24oKS0+c2VuZChNZXNzYWdlczo6TmV0d29ya1Byb2Nlc3NQcm94eTo6UHJvY2Vzc1JlYWR5 VG9TdXNwZW5kKCksIDApOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3Jr UHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5oIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3Mv TmV0d29ya1Byb2Nlc3MuaAppbmRleCA1MTY2NDk4YjlkN2FmMjY3Y2ZkOWU2NmEzMmJhYTFkNDQ5 NGIyOTE5Li5kMTFmMzIwZTgyOWM3YjkxMDEwMGQzYzI4NmM5MDRiY2VmYWNiMGU5IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5oCisrKyBi L1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmgKQEAgLTk5LDYg Kzk5LDcgQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIHZvaWQgdGVybWluYXRlKCkgb3ZlcnJpZGU7 CiAgICAgdm9pZCBwbGF0Zm9ybVRlcm1pbmF0ZSgpOwogCisgICAgdm9pZCBsb3dNZW1vcnlIYW5k bGVyKGJvb2wgY3JpdGljYWwpOwogICAgIHZvaWQgcGxhdGZvcm1Mb3dNZW1vcnlIYW5kbGVyKGJv b2wgY3JpdGljYWwpOwogCiAgICAgLy8gQ2hpbGRQcm9jZXNzCg==