143572 2015-04-09 13:26:19 -0700 [CMake] Options should be marked as advanced by default 2015-04-11 11:15:42 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Enhancement --- 143558 1 mcatanzaro mcatanzaro achristensen cgarcia commit-queue gyuyoung.kim mcatanzaro mrobinson oldest_to_newest 1084030 0 mcatanzaro 2015-04-09 13:26:19 -0700 Options defined with WEBKIT_OPTION_DEFINE should be marked as advanced so that they don't show up in CMake GUIs or with cmake -L. We also shouldn't print them when running cmake. This prevents ports from unexpectedly getting new public options. The idea is that you only make an option public if you're really willing to support building both with and without it. If WEBKIT_OPTION_DEFINE_PORT_VALUE is called, then the option should become public. WEBKIT_OPTION_PRIVATE_PORT_VALUE is provided to change the default value for a port without making it public. WEBKIT_OPTION_DEFINE_PUBLIC is provided to create a new port-specific option and mark it public without needing to use both WEBKIT_OPTION_DEFINE and WEBKIT_OPTION_DEFINE_PORT_VALUE. Note that there is no enforcement: users can still set all of these options if they really want to, as before, e.g. 'cmake -DSOME_UNSUPPORTED_OPTION=ON', but probably only developers will do this. 1084033 1 mcatanzaro 2015-04-09 13:32:54 -0700 Warning: if your port doesn't use WEBKIT_OPTION_DEFINE_PORT_VALUE for an option, then this patch will cause that option to disappear! This seemed like the best way to make it easy to hide options, and make sure new options don't unexpectedly appear for particular ports, without making all the Mac and EFL options disappear. 1084035 2 achristensen 2015-04-09 13:35:16 -0700 That should not be a problem for the Mac and Windows ports' CMake files right now. They are experimental and under construction right now anyways. 1084046 3 250464 mcatanzaro 2015-04-09 13:47:08 -0700 Created attachment 250464 Patch 1084168 4 250464 mcatanzaro 2015-04-09 19:35:25 -0700 Comment on attachment 250464 Patch I'll need to try again. WEBKIT_OPTION_DEFINE_PUBLIC doesn't work. 1084171 5 250496 mcatanzaro 2015-04-09 19:50:41 -0700 Created attachment 250496 Patch 1084172 6 250496 gyuyoung.kim 2015-04-09 20:10:23 -0700 Comment on attachment 250496 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250496&action=review I think _PUBLIC and _PRIVATE macros look like better method to define options. Basically I agree to use it. However someone else might want to take a look this patch before landing. > Source/cmake/WebKitFeatures.cmake:11 > + set(_WEBKIT_AVAILABLE_OPTIONS_ISPUBLIC_${_name} TRUE) Isn't "_IS_PUBLIC" looks more clear than "_ISPUBLIC" ? 1084181 7 mcatanzaro 2015-04-09 20:41:56 -0700 (In reply to comment #6) > Isn't "_IS_PUBLIC" looks more clear than "_ISPUBLIC" ? I almost did that, but went with ISPUBLIC to match _WEBKIT_AVAILABLE_OPTIONS_INITIALVALUE. Probably IS_PUBLIC would be better, indeed. 1084540 8 250496 commit-queue 2015-04-11 11:15:31 -0700 Comment on attachment 250496 Patch Clearing flags on attachment: 250496 Committed r182658: <http://trac.webkit.org/changeset/182658> 1084541 9 commit-queue 2015-04-11 11:15:42 -0700 All reviewed patches have been landed. Closing bug. 250464 2015-04-09 13:47:08 -0700 2015-04-09 19:35:25 -0700 Patch bug-143572-20150409154616.patch text/plain 2706 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyNTY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0RmVhdHVyZXMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKaW5k ZXggMzJjMjM1ZDk4YjVhNDIwZWJlMzM0ODM0YzdiNmE0MTgyYjIyMjIwYS4uNzcwNDkyZDQzNzE4 YjI1OWUwZTgwYzliZmI5YTQwYTY2YWEyNDcwYyAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dl YktpdEZlYXR1cmVzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFr ZQpAQCAtNiw4ICs2LDE4IEBAIG1hY3JvKFdFQktJVF9PUFRJT05fREVGSU5FIF9uYW1lIF9kZXNj cmlwdGlvbiBfaW5pdGlhbHZhbHVlKQogICAgIGxpc3QoQVBQRU5EIF9XRUJLSVRfQVZBSUxBQkxF X09QVElPTlMgJHtfbmFtZX0pCiBlbmRtYWNybygpCiAKK21hY3JvKFdFQktJVF9PUFRJT05fREVG SU5FX1BVQkxJQyBfbmFtZSBfZGVzY3JpcHRpb24gX2luaXRpYWx2YWx1ZSkKKyAgICBXRUJLSVRf T1BUSU9OX0RFRklORSgke19uYW1lfSwgJHtfZGVzY3JpcHRpb259LCAke19pbml0aWFsdmFsdWV9 KQorICAgIHNldChfV0VCS0lUX0FWQUlMQUJMRV9PUFRJT05TX0lTUFVCTElDXyR7X25hbWV9IFRS VUUpCitlbmRtYWNybygpCisKIG1hY3JvKFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVF IF9uYW1lIF92YWx1ZSkKICAgICBzZXQoX1dFQktJVF9BVkFJTEFCTEVfT1BUSU9OU19JTklUSUFM VkFMVUVfJHtfbmFtZX0gJHtfdmFsdWV9KQorICAgIHNldChfV0VCS0lUX0FWQUlMQUJMRV9PUFRJ T05TX0lTUFVCTElDXyR7X25hbWV9IFRSVUUpCitlbmRtYWNybygpCisKK21hY3JvKFdFQktJVF9P UFRJT05fUFJJVkFURV9QT1JUX1ZBTFVFIF9uYW1lIF92YWx1ZSkKKyAgICBzZXQoX1dFQktJVF9B VkFJTEFCTEVfT1BUSU9OU19JTklUSUFMVkFMVUVfJHtfbmFtZX0gJHtfdmFsdWV9KQogZW5kbWFj cm8oKQogCiBtYWNybyhXRUJLSVRfT1BUSU9OX0RFUEVORCBfbmFtZSBfZGVwZW5kKQpAQCAtMTYw LDYgKzE3MCw5IEBAIGVuZG1hY3JvKCkKIG1hY3JvKFdFQktJVF9PUFRJT05fRU5EKQogICAgIGZv cmVhY2ggKF9uYW1lICR7X1dFQktJVF9BVkFJTEFCTEVfT1BUSU9OU30pCiAgICAgICAgIG9wdGlv bigke19uYW1lfSAiJHtfV0VCS0lUX0FWQUlMQUJMRV9PUFRJT05TX0RFU0NSSVBUSU9OXyR7X25h bWV9fSIgJHtfV0VCS0lUX0FWQUlMQUJMRV9PUFRJT05TX0lOSVRJQUxWQUxVRV8ke19uYW1lfX0p CisgICAgICAgIGlmIChOT1QgX1dFQktJVF9BVkFJTEFCTEVfT1BUSU9OU19JU1BVQkxJQ18ke19u YW1lfSkKKyAgICAgICAgICAgIG1hcmtfYXNfYWR2YW5jZWQoRk9SQ0UgJHtfbmFtZX0pCisgICAg ICAgIGVuZGlmICgpCiAgICAgZW5kZm9yZWFjaCAoKQogCiAgICAgc2V0KF9NQVhfRkVBVFVSRV9M RU5HVEggMCkKQEAgLTIwMyw2ICsyMTYsOSBAQCBtYWNybyhXRUJLSVRfT1BUSU9OX0VORCkKICAg ICAgICAgZW5kaWYgKCkKIAogICAgICAgICBzZXQoX01FU1NBR0UgIiR7X01FU1NBR0V9ICR7JHtf bmFtZX19IikKLSAgICAgICAgbWVzc2FnZShTVEFUVVMgIiR7X01FU1NBR0V9IikKKworICAgICAg ICBpZiAoX1dFQktJVF9BVkFJTEFCTEVfT1BUSU9OU19JU1BVQkxJQ18ke19uYW1lfSkKKyAgICAg ICAgICAgIG1lc3NhZ2UoU1RBVFVTICIke19NRVNTQUdFfSIpCisgICAgICAgIGVuZGlmICgpCiAg ICAgZW5kZm9yZWFjaCAoKQogZW5kbWFjcm8oKQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hh bmdlTG9nCmluZGV4IGY4N2NhYWI0MzM0MmU0ZWI4MjdlNTJhMzljZGZmZDllNmM0MThmMTAuLmJm YjA3ZDcwNzdjYTZiNzhiZmUxZTM3NzA1MGJmMzUxZTU5YjA5MTQgMTAwNjQ0Ci0tLSBhL0NoYW5n ZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxNS0wNC0wOSAgTWljaGFl bCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0NNYWtlXSBP cHRpb25zIHNob3VsZCBiZSBtYXJrZWQgYXMgYWR2YW5jZWQgYnkgZGVmYXVsdAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzNTcyCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT3B0aW9ucyBkZWZpbmVkIHdp dGggV0VCS0lUX09QVElPTl9ERUZJTkUgYXJlIG5vdyBhZHZhbmNlZCBzbyB0aGF0IHRoZXkgYXJl IGhpZGRlbiBmcm9tCisgICAgICAgIHVzZXJzIGJ5IGRlZmF1bHQsIHVubGVzcyBXRUJLSVRfT1BU SU9OX0RFRkFVTFRfUE9SVF9WQUxVRSBpcyB1c2VkLiBBZGQgbmV3IG1hY3JvcworICAgICAgICBX RUJLSVRfT1BUSU9OX0RFRklORV9QVUJMSUMgdG8gZGVmaW5lIGFuIG9wdGlvbiB0aGF0J3Mgbm90 IGhpZGRlbiBieSBkZWZhdWx0LCB0byBiZSB1c2VkCisgICAgICAgIGZvciBhZGRpbmcgcG9ydC1z cGVjaWZpYyBvcHRpb25zLCBhbmQgV0VCS0lUX09QVElPTl9QUklWQVRFX1BPUlRfVkFMVUUgdG8g b3ZlcnJpZGUgYW4KKyAgICAgICAgb3B0aW9uIHdpdGhvdXQgbWFraW5nIGl0IHB1YmxpYy4KKwor ICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFrZToKKwogMjAxNS0wNC0w OCAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQs IHJldmVydCBhY2NpZGVudGFsIGNvbW1pdC4K 250496 2015-04-09 19:50:41 -0700 2015-04-11 11:15:31 -0700 Patch patch text/plain 2704 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyNTY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0RmVhdHVyZXMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKaW5k ZXggMzJjMjM1ZDk4YjVhNDIwZWJlMzM0ODM0YzdiNmE0MTgyYjIyMjIwYS4uNzcwNDkyZDQzNzE4 YjI1OWUwZTgwYzliZmI5YTQwYTY2YWEyNDcwYyAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dl YktpdEZlYXR1cmVzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFr ZQpAQCAtNiw4ICs2LDE4IEBAIG1hY3JvKFdFQktJVF9PUFRJT05fREVGSU5FIF9uYW1lIF9kZXNj cmlwdGlvbiBfaW5pdGlhbHZhbHVlKQogICAgIGxpc3QoQVBQRU5EIF9XRUJLSVRfQVZBSUxBQkxF X09QVElPTlMgJHtfbmFtZX0pCiBlbmRtYWNybygpCiAKK21hY3JvKFdFQktJVF9PUFRJT05fREVG SU5FX1BVQkxJQyBfbmFtZSBfZGVzY3JpcHRpb24gX2luaXRpYWx2YWx1ZSkKKyAgICBXRUJLSVRf T1BUSU9OX0RFRklORSgke19uYW1lfSAke19kZXNjcmlwdGlvbn0gJHtfaW5pdGlhbHZhbHVlfSkK KyAgICBzZXQoX1dFQktJVF9BVkFJTEFCTEVfT1BUSU9OU19JU1BVQkxJQ18ke19uYW1lfSBUUlVF KQorZW5kbWFjcm8oKQorCiBtYWNybyhXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRSBf bmFtZSBfdmFsdWUpCiAgICAgc2V0KF9XRUJLSVRfQVZBSUxBQkxFX09QVElPTlNfSU5JVElBTFZB TFVFXyR7X25hbWV9ICR7X3ZhbHVlfSkKKyAgICBzZXQoX1dFQktJVF9BVkFJTEFCTEVfT1BUSU9O U19JU1BVQkxJQ18ke19uYW1lfSBUUlVFKQorZW5kbWFjcm8oKQorCittYWNybyhXRUJLSVRfT1BU SU9OX1BSSVZBVEVfUE9SVF9WQUxVRSBfbmFtZSBfdmFsdWUpCisgICAgc2V0KF9XRUJLSVRfQVZB SUxBQkxFX09QVElPTlNfSU5JVElBTFZBTFVFXyR7X25hbWV9ICR7X3ZhbHVlfSkKIGVuZG1hY3Jv KCkKIAogbWFjcm8oV0VCS0lUX09QVElPTl9ERVBFTkQgX25hbWUgX2RlcGVuZCkKQEAgLTE2MCw2 ICsxNzAsOSBAQCBlbmRtYWNybygpCiBtYWNybyhXRUJLSVRfT1BUSU9OX0VORCkKICAgICBmb3Jl YWNoIChfbmFtZSAke19XRUJLSVRfQVZBSUxBQkxFX09QVElPTlN9KQogICAgICAgICBvcHRpb24o JHtfbmFtZX0gIiR7X1dFQktJVF9BVkFJTEFCTEVfT1BUSU9OU19ERVNDUklQVElPTl8ke19uYW1l fX0iICR7X1dFQktJVF9BVkFJTEFCTEVfT1BUSU9OU19JTklUSUFMVkFMVUVfJHtfbmFtZX19KQor ICAgICAgICBpZiAoTk9UIF9XRUJLSVRfQVZBSUxBQkxFX09QVElPTlNfSVNQVUJMSUNfJHtfbmFt ZX0pCisgICAgICAgICAgICBtYXJrX2FzX2FkdmFuY2VkKEZPUkNFICR7X25hbWV9KQorICAgICAg ICBlbmRpZiAoKQogICAgIGVuZGZvcmVhY2ggKCkKIAogICAgIHNldChfTUFYX0ZFQVRVUkVfTEVO R1RIIDApCkBAIC0yMDMsNiArMjE2LDkgQEAgbWFjcm8oV0VCS0lUX09QVElPTl9FTkQpCiAgICAg ICAgIGVuZGlmICgpCiAKICAgICAgICAgc2V0KF9NRVNTQUdFICIke19NRVNTQUdFfSAkeyR7X25h bWV9fSIpCi0gICAgICAgIG1lc3NhZ2UoU1RBVFVTICIke19NRVNTQUdFfSIpCisKKyAgICAgICAg aWYgKF9XRUJLSVRfQVZBSUxBQkxFX09QVElPTlNfSVNQVUJMSUNfJHtfbmFtZX0pCisgICAgICAg ICAgICBtZXNzYWdlKFNUQVRVUyAiJHtfTUVTU0FHRX0iKQorICAgICAgICBlbmRpZiAoKQogICAg IGVuZGZvcmVhY2ggKCkKIGVuZG1hY3JvKCkKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5n ZUxvZwppbmRleCBmODdjYWFiNDMzNDJlNGViODI3ZTUyYTM5Y2RmZmQ5ZTZjNDE4ZjEwLi5iZmIw N2Q3MDc3Y2E2Yjc4YmZlMWUzNzcwNTBiZjM1MWU1OWIwOTE0IDEwMDY0NAotLS0gYS9DaGFuZ2VM b2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTUtMDQtMDkgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtDTWFrZV0gT3B0 aW9ucyBzaG91bGQgYmUgbWFya2VkIGFzIGFkdmFuY2VkIGJ5IGRlZmF1bHQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MzU3MgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9wdGlvbnMgZGVmaW5lZCB3aXRo IFdFQktJVF9PUFRJT05fREVGSU5FIGFyZSBub3cgYWR2YW5jZWQgc28gdGhhdCB0aGV5IGFyZSBo aWRkZW4gZnJvbQorICAgICAgICB1c2VycyBieSBkZWZhdWx0LCB1bmxlc3MgV0VCS0lUX09QVElP Tl9ERUZBVUxUX1BPUlRfVkFMVUUgaXMgdXNlZC4gQWRkIG5ldyBtYWNyb3MKKyAgICAgICAgV0VC S0lUX09QVElPTl9ERUZJTkVfUFVCTElDIHRvIGRlZmluZSBhbiBvcHRpb24gdGhhdCdzIG5vdCBo aWRkZW4gYnkgZGVmYXVsdCwgdG8gYmUgdXNlZAorICAgICAgICBmb3IgYWRkaW5nIHBvcnQtc3Bl Y2lmaWMgb3B0aW9ucywgYW5kIFdFQktJVF9PUFRJT05fUFJJVkFURV9QT1JUX1ZBTFVFIHRvIG92 ZXJyaWRlIGFuCisgICAgICAgIG9wdGlvbiB3aXRob3V0IG1ha2luZyBpdCBwdWJsaWMuCisKKyAg ICAgICAgKiBTb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2U6CisKIDIwMTUtMDQtMDgg IEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBy ZXZlcnQgYWNjaWRlbnRhbCBjb21taXQuCg==