143556 2015-04-08 22:27:24 -0700 Exception in console and broken right click after attempting to show context menu in Inspector 2015-04-08 23:35:07 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck beidson bfulgham commit-queue joepeck webkit-bug-importer oldest_to_newest 1083871 0 joepeck 2015-04-08 22:27:24 -0700 * SUMMARY When I run Safari and right click it produces an exception and right click stops working. * STEPS TO REPRODUCE 1. Run Safari 2. Inspect a web page 3. Right click blank space in the navigation sidebar in the inspector => EXCEPTION in system console Apr 8 21:37:35 pecoraro.apple.com Safari[81152] <Warning>: *** -[__NSArrayM insertObject:atIndex:]: object cannot be nil Apr 8 21:37:35 pecoraro.apple.com Safari[81152] <Warning>: ( 0 CoreFoundation __exceptionPreprocess + 172 1 libobjc.A.dylib objc_exception_throw + 43 2 CoreFoundation -[__NSArrayM insertObject:atIndex:] + 1033 3 AppKit -[NSMenu insertItem:atIndex:] + 487 4 WebKit _ZN6WebKitL14populateNSMenuEP6NSMenuRKN3WTF6VectorINS2_9RetainPtrI10NSMenuItemEELm0ENS2_15CrashOnOverflowEEE + 94 5 WebKit _ZN6WebKit22WebContextMenuProxyMac8populateERKN3WTF6VectorINS1_6RefPtrINS_18WebContextMenuItemEEELm0ENS1_15CrashOnOverflowEEERKNS_22ContextMenuContextDataE + 465 ... * NOTES - Seems to be a nil ContextMenu item, we should gracefully handle a null ContextMenuItem::shareMenuItem 1083872 1 joepeck 2015-04-08 22:27:50 -0700 <rdar://problem/20478205> 1083873 2 250417 joepeck 2015-04-08 22:29:22 -0700 Created attachment 250417 [PATCH] Proposed Fix 1083874 3 joepeck 2015-04-08 22:31:58 -0700 Not sure how to write a test for this. Point me in the right direction and I'll give it a shot! 1083886 4 250417 commit-queue 2015-04-08 23:35:03 -0700 Comment on attachment 250417 [PATCH] Proposed Fix Clearing flags on attachment: 250417 Committed r182590: <http://trac.webkit.org/changeset/182590> 1083887 5 commit-queue 2015-04-08 23:35:07 -0700 All reviewed patches have been landed. Closing bug. 250417 2015-04-08 22:29:22 -0700 2015-04-08 23:35:03 -0700 [PATCH] Proposed Fix context-menu.patch text/plain 2175 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBhMDYzODY3Li4zNDIyYWU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAg QEAKIDIwMTUtMDQtMDggIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAor ICAgICAgICBFeGNlcHRpb24gaW4gY29uc29sZSBhbmQgYnJva2VuIHJpZ2h0IGNsaWNrIGFmdGVy IGF0dGVtcHRpbmcgdG8gc2hvdyBjb250ZXh0IG1lbnUgaW4gSW5zcGVjdG9yCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDM1NTYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNoYXJlZC9tYWMvTmF0aXZl Q29udGV4dE1lbnVJdGVtLm1tOgorICAgICAgICAoV2ViS2l0OjpOYXRpdmVDb250ZXh0TWVudUl0 ZW06Ok5hdGl2ZUNvbnRleHRNZW51SXRlbSk6CisgICAgICAgIEFkZCBhbiBBU1NFUlQgdG8gaW1t ZWRpYXRlbHkgY2F0Y2ggYSBtZW51IGl0ZW0gY3JlYXRlZCB3aXRoIGEgbmlsIG5hdGl2ZSBtZW51 IGl0ZW0uCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAg KFdlYktpdDo6V2ViUGFnZVByb3h5OjppbnRlcm5hbFNob3dDb250ZXh0TWVudSk6CisgICAgICAg IEdyYWNlZnVsbHkgaGFuZGxlIGEgbnVsbCBzaGFyZSBjb250ZXh0IG1lbnUgaXRlbS4KKworMjAx NS0wNC0wOCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAg IENsZWFudXAgc29tZSBTdHJpbmdCdWlsZGVyIHVzZQogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzNTUwCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1NoYXJlZC9tYWMvTmF0aXZlQ29udGV4dE1lbnVJdGVtLm1tIGIvU291cmNlL1dlYktpdDIv U2hhcmVkL21hYy9OYXRpdmVDb250ZXh0TWVudUl0ZW0ubW0KaW5kZXggZDM3ODk0MC4uOTAzYmQz NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2hhcmVkL21hYy9OYXRpdmVDb250ZXh0TWVu dUl0ZW0ubW0KKysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL21hYy9OYXRpdmVDb250ZXh0TWVu dUl0ZW0ubW0KQEAgLTM3LDYgKzM3LDcgQEAgbmFtZXNwYWNlIFdlYktpdCB7CiBOYXRpdmVDb250 ZXh0TWVudUl0ZW06Ok5hdGl2ZUNvbnRleHRNZW51SXRlbShjb25zdCBDb250ZXh0TWVudUl0ZW0m IGNvcmVJdGVtKQogICAgIDogbV9uc01lbnVJdGVtKGNvcmVJdGVtLnBsYXRmb3JtRGVzY3JpcHRp b24oKSkKIHsKKyAgICBBU1NFUlQobV9uc01lbnVJdGVtKTsKIH0KIAogfSAvLyBuYW1lc3BhY2Ug V2ViS2l0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5 LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCmluZGV4IDA2 ZjBlOTIuLmZiODgwYzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQ YWdlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHku Y3BwCkBAIC00MDYwLDcgKzQwNjAsOCBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6aW50ZXJuYWxTaG93 Q29udGV4dE1lbnUoY29uc3QgSW50UG9pbnQmIG1lbnVMb2NhdGlvbiwgY29uc3QgQwogICAgICAg ICB9CiAKICAgICAgICAgQ29udGV4dE1lbnVJdGVtIGNvcmVJdGVtID0gQ29udGV4dE1lbnVJdGVt OjpzaGFyZU1lbnVJdGVtKGFic29sdXRlTGlua1VSTCwgZG93bmxvYWRhYmxlTWVkaWFVUkwsIGlt YWdlLmdldCgpLCBjb250ZXh0TWVudUNvbnRleHREYXRhLnNlbGVjdGVkVGV4dCgpKTsKLSAgICAg ICAgcHJvcG9zZWRBUElJdGVtcy5hcHBlbmQoV2ViQ29udGV4dE1lbnVJdGVtOjpjcmVhdGUoY29y ZUl0ZW0pKTsKKyAgICAgICAgaWYgKCFjb3JlSXRlbS5pc051bGwoKSkKKyAgICAgICAgICAgIHBy b3Bvc2VkQVBJSXRlbXMuYXBwZW5kKFdlYkNvbnRleHRNZW51SXRlbTo6Y3JlYXRlKGNvcmVJdGVt KSk7CiAgICAgfQogCiAgICAgVmVjdG9yPFJlZlB0cjxXZWJDb250ZXh0TWVudUl0ZW0+PiBjbGll bnRJdGVtczsK