143551 2015-04-08 20:25:31 -0700 Web Inspector: Simplify Legacy Tips support 2015-04-08 23:58:32 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1083827 0 joepeck 2015-04-08 20:25:31 -0700 * SUMMARY Simplify Legacy Tips support. iOS 6 supported "Tips". We now treat it like Logs. Do this very early on in the Observer to avoid needing to handle "tips" later on. 1083828 1 250405 joepeck 2015-04-08 20:26:31 -0700 Created attachment 250405 [PATCH] Proposed Fix 1083896 2 250405 commit-queue 2015-04-08 23:58:29 -0700 Comment on attachment 250405 [PATCH] Proposed Fix Clearing flags on attachment: 250405 Committed r182592: <http://trac.webkit.org/changeset/182592> 1083897 3 commit-queue 2015-04-08 23:58:32 -0700 All reviewed patches have been landed. Closing bug. 250405 2015-04-08 20:26:31 -0700 2015-04-08 23:58:29 -0700 [PATCH] Proposed Fix simplify-tips.patch text/plain 4288 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDI0ZWJlNjMuLjFjZGVhYzIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE1LTA0LTA4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogU2ltcGxp ZnkgTGVnYWN5IFRpcHMgc3VwcG9ydAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTQzNTUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL01vZGVscy9Db25zb2xlTWVzc2FnZS5qczoK KyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1Byb3RvY29sL0NvbnNvbGVPYnNlcnZlci5qczoKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5Db25zb2xlT2JzZXJ2ZXIucHJvdG90eXBlLm1lc3NhZ2VBZGRl ZCk6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9Db25zb2xlTWVzc2FnZVZpZXcuanM6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ29uc29sZU1lc3NhZ2VWaWV3KToKKyAgICAgICAgKFdl Ykluc3BlY3Rvci5Db25zb2xlTWVzc2FnZVZpZXcucHJvdG90eXBlLl9sZXZlbFN0cmluZyk6Cisg ICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9Mb2dDb250ZW50Vmlldy5qczoKKyAgICAgICAg KFdlYkluc3BlY3Rvci5Mb2dDb250ZW50Vmlldy5wcm90b3R5cGUuX2ZpbHRlck1lc3NhZ2VFbGVt ZW50cyk6CisKKzIwMTUtMDQtMDggIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNv bT4KKwogICAgICAgICBVbnJldmlld2VkIFRlc3QgRml4IGFmdGVyIHIxODI1NzkuIEFkZCBtaXNz aW5nIGluY2x1ZGUuCiAKICAgICAgICAgKiBVc2VySW50ZXJmYWNlL1Rlc3QuaHRtbDoKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9Db25zb2xl TWVzc2FnZS5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9D b25zb2xlTWVzc2FnZS5qcwppbmRleCBhYWFmMTRhLi5kYjgzMWZjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQ29uc29sZU1lc3NhZ2UuanMK KysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0NvbnNvbGVN ZXNzYWdlLmpzCkBAIC0xMzcsNyArMTM3LDYgQEAgV2ViSW5zcGVjdG9yLkNvbnNvbGVNZXNzYWdl Lk1lc3NhZ2VUeXBlID0gewogfTsKIAogV2ViSW5zcGVjdG9yLkNvbnNvbGVNZXNzYWdlLk1lc3Nh Z2VMZXZlbCA9IHsKLSAgICBUaXA6ICJ0aXAiLCAvLyBDT01QQVRJQklMSVRZIChpT1MgNikKICAg ICBMb2c6ICJsb2ciLAogICAgIFdhcm5pbmc6ICJ3YXJuaW5nIiwKICAgICBFcnJvcjogImVycm9y IiwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Byb3Rv Y29sL0NvbnNvbGVPYnNlcnZlci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1Byb3RvY29sL0NvbnNvbGVPYnNlcnZlci5qcwppbmRleCBiNjFmNzIxLi42OGQ5ZTdiIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Qcm90b2NvbC9D b25zb2xlT2JzZXJ2ZXIuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvUHJvdG9jb2wvQ29uc29sZU9ic2VydmVyLmpzCkBAIC0yOSw3ICsyOSw5IEBAIFdlYkluc3Bl Y3Rvci5Db25zb2xlT2JzZXJ2ZXIgPSBjbGFzcyBDb25zb2xlT2JzZXJ2ZXIKIAogICAgIG1lc3Nh Z2VBZGRlZChtZXNzYWdlKQogICAgIHsKLSAgICAgICAgLy8gRklYTUU6IFdlIHNob3VsZCBjb252 ZXJ0ICJUaXAiIHRvICJMb2ciIGhlcmUgaW1tZWRpYXRlbHkuCisgICAgICAgIC8vIENPTVBBVElC SUxJVFkgKGlPUyA2KTogVHJlYXQgVGlwcyBsaWtlIExvZ3MuCisgICAgICAgIGlmIChtZXNzYWdl LnR5cGUgPT09ICJ0aXAiKQorICAgICAgICAgICAgbWVzc2FnZS50eXBlID0gImxvZyI7CiAKICAg ICAgICAgaWYgKG1lc3NhZ2UudHlwZSA9PT0gImFzc2VydCIgJiYgIW1lc3NhZ2UudGV4dCkKICAg ICAgICAgICAgIG1lc3NhZ2UudGV4dCA9IFdlYkluc3BlY3Rvci5VSVN0cmluZygiQXNzZXJ0aW9u Iik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9Db25zb2xlTWVzc2FnZVZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9Db25zb2xlTWVzc2FnZVZpZXcuanMKaW5kZXggOTA2YTgwMy4uMzY1Mjk0MSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29u c29sZU1lc3NhZ2VWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL0NvbnNvbGVNZXNzYWdlVmlldy5qcwpAQCAtNDYsNyArNDYsNiBAQCBXZWJJbnNw ZWN0b3IuQ29uc29sZU1lc3NhZ2VWaWV3ID0gY2xhc3MgQ29uc29sZU1lc3NhZ2VWaWV3IGV4dGVu ZHMgV2ViSW5zcGVjdG9yLgogICAgICAgICB0aGlzLl9lbGVtZW50Ll9fbWVzc2FnZVZpZXcgPSB0 aGlzOwogCiAgICAgICAgIHN3aXRjaCAodGhpcy5fbWVzc2FnZS5sZXZlbCkgewotICAgICAgICBj YXNlIFdlYkluc3BlY3Rvci5Db25zb2xlTWVzc2FnZS5NZXNzYWdlTGV2ZWwuVGlwOiAvLyBDT01Q QVRJQklMSVRZIChpT1MgNikuCiAgICAgICAgIGNhc2UgV2ViSW5zcGVjdG9yLkNvbnNvbGVNZXNz YWdlLk1lc3NhZ2VMZXZlbC5Mb2c6CiAgICAgICAgICAgICB0aGlzLl9lbGVtZW50LmNsYXNzTGlz dC5hZGQoImNvbnNvbGUtbG9nLWxldmVsIik7CiAgICAgICAgICAgICB0aGlzLl9lbGVtZW50LnNl dEF0dHJpYnV0ZSgiZGF0YS1sYWJlbHByZWZpeCIsIFdlYkluc3BlY3Rvci5VSVN0cmluZygiTG9n OiAiKSk7CkBAIC02NDcsOCArNjQ2LDYgQEAgV2ViSW5zcGVjdG9yLkNvbnNvbGVNZXNzYWdlVmll dyA9IGNsYXNzIENvbnNvbGVNZXNzYWdlVmlldyBleHRlbmRzIFdlYkluc3BlY3Rvci4KICAgICBf bGV2ZWxTdHJpbmcoKQogICAgIHsKICAgICAgICAgc3dpdGNoICh0aGlzLl9tZXNzYWdlLmxldmVs KSB7Ci0gICAgICAgIGNhc2UgV2ViSW5zcGVjdG9yLkNvbnNvbGVNZXNzYWdlLk1lc3NhZ2VMZXZl bC5UaXA6Ci0gICAgICAgICAgICByZXR1cm4gIlRpcCI7CiAgICAgICAgIGNhc2UgV2ViSW5zcGVj dG9yLkNvbnNvbGVNZXNzYWdlLk1lc3NhZ2VMZXZlbC5Mb2c6CiAgICAgICAgICAgICByZXR1cm4g IkxvZyI7CiAgICAgICAgIGNhc2UgV2ViSW5zcGVjdG9yLkNvbnNvbGVNZXNzYWdlLk1lc3NhZ2VM ZXZlbC5XYXJuaW5nOgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvTG9nQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9Mb2dDb250ZW50Vmlldy5qcwppbmRleCA5ZDY1YTA2Li5iOGNiY2Zj IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9M b2dDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9Mb2dDb250ZW50Vmlldy5qcwpAQCAtNjgzLDcgKzY4Myw2IEBAIFdlYkluc3BlY3Rv ci5Mb2dDb250ZW50Vmlldy5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICAgICAgY2FzZSBXZWJJ bnNwZWN0b3IuQ29uc29sZU1lc3NhZ2UuTWVzc2FnZUxldmVsLkVycm9yOgogICAgICAgICAgICAg ICAgICAgICB2aXNpYmxlID0gc2hvd3NFcnJvcnM7CiAgICAgICAgICAgICAgICAgICAgIGJyZWFr OwotICAgICAgICAgICAgICAgIGNhc2UgV2ViSW5zcGVjdG9yLkNvbnNvbGVNZXNzYWdlLk1lc3Nh Z2VMZXZlbC5UaXA6IC8vIENPTVBBVElCSUxJVFkgKGlPUyA2KTogVHJlYXQgVGlwcyBsaWtlIExv Z3MuCiAgICAgICAgICAgICAgICAgY2FzZSBXZWJJbnNwZWN0b3IuQ29uc29sZU1lc3NhZ2UuTWVz c2FnZUxldmVsLkxvZzoKICAgICAgICAgICAgICAgICBjYXNlIFdlYkluc3BlY3Rvci5Db25zb2xl TWVzc2FnZS5NZXNzYWdlTGV2ZWwuRGVidWc6CiAgICAgICAgICAgICAgICAgICAgIHZpc2libGUg PSBzaG93c0xvZ3M7Cg==