143541 2015-04-08 17:06:37 -0700 Fix -Wformat in AnimationBase.cpp 2015-04-08 19:16:37 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Minor --- 1 mcatanzaro mcatanzaro andersca commit-queue dino dstockwell mcatanzaro simon.fraser oldest_to_newest 1083775 0 mcatanzaro 2015-04-08 17:06:37 -0700 Since r170070: ../../Source/WebCore/page/animation/AnimationBase.cpp:321:259: warning: format ‘%d’ expects argument of type ‘int’, but argument 5 has type ‘WebCore::AnimationBase::AnimationStateInput’ [-Wformat=] This only occurs in debug builds. We can either static_cast it to an int, or print it as a string. 1083800 1 250399 mcatanzaro 2015-04-08 18:15:16 -0700 Created attachment 250399 Patch 1083812 2 250399 commit-queue 2015-04-08 19:16:32 -0700 Comment on attachment 250399 Patch Clearing flags on attachment: 250399 Committed r182580: <http://trac.webkit.org/changeset/182580> 1083813 3 commit-queue 2015-04-08 19:16:37 -0700 All reviewed patches have been landed. Closing bug. 250399 2015-04-08 18:15:16 -0700 2015-04-08 19:16:32 -0700 Patch bug-143541-20150408201425.patch text/plain 3417 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyNTY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzAwMDk5ZTU2YjliMjNl MjIwMzViZjc4MGE1Y2UwY2U1ODc2MGYxNS4uOTc3YzNhNWZlZTVjODZjMmFlNjlkOGNmZjVhNGRj ZjZjM2Q4NTU0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA0LTA4ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBGaXggLVdm b3JtYXQgaW4gQW5pbWF0aW9uQmFzZS5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0MzU0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogcGFnZS9hbmltYXRpb24vQW5pbWF0aW9uQmFzZS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpuYW1lRm9yU3RhdGVJbnB1dCk6IEFkZGVkLiBDb252ZXJ0cyBhbiBB bmltYXRpb25CYXNlOjpBbmltYXRpb25TdGF0ZUlucHV0IHRvIGEKKyAgICAgICAgc3RyaW5nLgor ICAgICAgICAoV2ViQ29yZTo6QW5pbWF0aW9uQmFzZTo6dXBkYXRlU3RhdGVNYWNoaW5lKTogUHJp bnQgQW5pbWF0aW9uQmFzZTo6QW5pbWF0aW9uU3RhdGVJbnB1dCBhcyBhCisgICAgICAgIHN0cmlu ZywgaW5zdGVhZCBvZiBwYXNzaW5nIGl0IHRvICVkIGFuZCBhc3N1bWluZyB0aGF0IHdvcmtzLCB0 byBzaWxlbmNlIEdDQydzIC1XZm9ybWF0LgorCiAyMDE1LTA0LTA4ICBBbmRlcnMgQ2FybHNzb24g IDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgRGVsZXRlIEFwcGxpY2F0aW9uQ2FjaGUg c3RhdGljIG1lbWJlciBmdW5jdGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv YW5pbWF0aW9uL0FuaW1hdGlvbkJhc2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9hbmltYXRp b24vQW5pbWF0aW9uQmFzZS5jcHAKaW5kZXggODhkNjJhNTdkZjRiY2E3MmQyN2I3NDIzM2ExMzJm OTYzOGY0MjU4MS4uNzljOTc1NGYzNjBmYjE1MWMzMmRmZjY1MjJhZTU4OTU0YjczZDgzMSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9hbmltYXRpb24vQW5pbWF0aW9uQmFzZS5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9hbmltYXRpb24vQW5pbWF0aW9uQmFzZS5jcHAKQEAg LTEzMSw2ICsxMzEsMjYgQEAgc3RhdGljIGNvbnN0IGNoYXIqIG5hbWVGb3JTdGF0ZShBbmltYXRp b25CYXNlOjpBbmltYXRpb25TdGF0ZSBzdGF0ZSkKICAgICB9CiAgICAgcmV0dXJuICIiOwogfQor CitzdGF0aWMgY29uc3QgY2hhciogbmFtZUZvclN0YXRlSW5wdXQoQW5pbWF0aW9uQmFzZTo6QW5p bWF0aW9uU3RhdGVJbnB1dCBpbnB1dCkKK3sKKyAgICBzd2l0Y2ggKGlucHV0KSB7CisgICAgY2Fz ZSBBbmltYXRpb25CYXNlOjpBbmltYXRpb25TdGF0ZUlucHV0OjpNYWtlTmV3OiByZXR1cm4gIk1h a2VOZXciOworICAgIGNhc2UgQW5pbWF0aW9uQmFzZTo6QW5pbWF0aW9uU3RhdGVJbnB1dDo6U3Rh cnRBbmltYXRpb246IHJldHVybiAiU3RhcnRBbmltYXRpb24iOworICAgIGNhc2UgQW5pbWF0aW9u QmFzZTo6QW5pbWF0aW9uU3RhdGVJbnB1dDo6UmVzdGFydEFuaW1hdGlvbjogcmV0dXJuICJSZXN0 YXJ0QW5pbWF0aW9uIjsKKyAgICBjYXNlIEFuaW1hdGlvbkJhc2U6OkFuaW1hdGlvblN0YXRlSW5w dXQ6OlN0YXJ0VGltZXJGaXJlZDogcmV0dXJuICJTdGFydFRpbWVyRmlyZWQiOworICAgIGNhc2Ug QW5pbWF0aW9uQmFzZTo6QW5pbWF0aW9uU3RhdGVJbnB1dDo6U3R5bGVBdmFpbGFibGU6IHJldHVy biAiU3R5bGVBdmFpbGFibGUiOworICAgIGNhc2UgQW5pbWF0aW9uQmFzZTo6QW5pbWF0aW9uU3Rh dGVJbnB1dDo6U3RhcnRUaW1lU2V0OiByZXR1cm4gIlN0YXJ0VGltZVNldCI7CisgICAgY2FzZSBB bmltYXRpb25CYXNlOjpBbmltYXRpb25TdGF0ZUlucHV0OjpMb29wVGltZXJGaXJlZDogcmV0dXJu ICJMb29wVGltZXJGaXJlZCI7CisgICAgY2FzZSBBbmltYXRpb25CYXNlOjpBbmltYXRpb25TdGF0 ZUlucHV0OjpFbmRUaW1lckZpcmVkOiByZXR1cm4gIkVuZFRpbWVyRmlyZWQiOworICAgIGNhc2Ug QW5pbWF0aW9uQmFzZTo6QW5pbWF0aW9uU3RhdGVJbnB1dDo6UGF1c2VPdmVycmlkZTogcmV0dXJu ICJQYXVzZU92ZXJyaWRlIjsKKyAgICBjYXNlIEFuaW1hdGlvbkJhc2U6OkFuaW1hdGlvblN0YXRl SW5wdXQ6OlJlc3VtZU92ZXJyaWRlOiByZXR1cm4gIlJlc3VtZU92ZXJyaWRlIjsKKyAgICBjYXNl IEFuaW1hdGlvbkJhc2U6OkFuaW1hdGlvblN0YXRlSW5wdXQ6OlBsYXlTdGF0ZVJ1bm5pbmc6IHJl dHVybiAiUGxheVN0YXRlUnVubmluZyI7CisgICAgY2FzZSBBbmltYXRpb25CYXNlOjpBbmltYXRp b25TdGF0ZUlucHV0OjpQbGF5U3RhdGVQYXVzZWQ6IHJldHVybiAiUGxheVN0YXRlUGF1c2VkIjsK KyAgICBjYXNlIEFuaW1hdGlvbkJhc2U6OkFuaW1hdGlvblN0YXRlSW5wdXQ6OkVuZEFuaW1hdGlv bjogcmV0dXJuICJFbmRBbmltYXRpb24iOworICAgIH0KKyAgICByZXR1cm4gIiI7Cit9CiAjZW5k aWYKIAogdm9pZCBBbmltYXRpb25CYXNlOjp1cGRhdGVTdGF0ZU1hY2hpbmUoQW5pbWF0aW9uU3Rh dGVJbnB1dCBpbnB1dCwgZG91YmxlIHBhcmFtKQpAQCAtMzE4LDcgKzMzOCw3IEBAIHZvaWQgQW5p bWF0aW9uQmFzZTo6dXBkYXRlU3RhdGVNYWNoaW5lKEFuaW1hdGlvblN0YXRlSW5wdXQgaW5wdXQs IGRvdWJsZSBwYXJhbSkKICAgICAgICAgY2FzZSBBbmltYXRpb25TdGF0ZTo6RW5kaW5nOgogI2lm ICFMT0dfRElTQUJMRUQKICAgICAgICAgICAgIGlmIChpbnB1dCAhPSBBbmltYXRpb25TdGF0ZUlu cHV0OjpFbmRUaW1lckZpcmVkICYmIGlucHV0ICE9IEFuaW1hdGlvblN0YXRlSW5wdXQ6OlBsYXlT dGF0ZVBhdXNlZCkKLSAgICAgICAgICAgICAgICBMT0dfRVJST1IoIlN0YXRlIGlzIEFuaW1hdGlv blN0YXRlOjpFbmRpbmcsIGJ1dCBpbnB1dCBpcyBub3QgQW5pbWF0aW9uU3RhdGVJbnB1dDo6RW5k VGltZXJGaXJlZCBvciBBbmltYXRpb25TdGF0ZUlucHV0OjpQbGF5U3RhdGVQYXVzZWQuIEl0IGlz ICVkLiIsIGlucHV0KTsKKyAgICAgICAgICAgICAgICBMT0dfRVJST1IoIlN0YXRlIGlzIEFuaW1h dGlvblN0YXRlOjpFbmRpbmcsIGJ1dCBpbnB1dCBpcyBub3QgQW5pbWF0aW9uU3RhdGVJbnB1dDo6 RW5kVGltZXJGaXJlZCBvciBBbmltYXRpb25TdGF0ZUlucHV0OjpQbGF5U3RhdGVQYXVzZWQuIEl0 IGlzICVzLiIsIG5hbWVGb3JTdGF0ZUlucHV0KGlucHV0KSk7CiAjZW5kaWYKICAgICAgICAgICAg IGlmIChpbnB1dCA9PSBBbmltYXRpb25TdGF0ZUlucHV0OjpFbmRUaW1lckZpcmVkKSB7CiAK