143516 2015-04-07 23:38:15 -0700 [Win] Allow running tests without Cygwin 2016-02-14 13:34:31 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 mmaxfield mmaxfield bfulgham commit-queue glenn oldest_to_newest 1083562 0 mmaxfield 2015-04-07 23:38:15 -0700 [Win] Allow running tests without Cygwin 1083564 1 250338 mmaxfield 2015-04-07 23:43:47 -0700 Created attachment 250338 Patch 1083565 2 commit-queue 2015-04-07 23:45:16 -0700 Attachment 250338 did not pass style-queue: ERROR: Tools/Scripts/webkitpy/port/win.py:259: [WinPort.setup_test_run] Undefined variable 'WindowsError' [pylint/E0602] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1083703 3 250338 bfulgham 2015-04-08 12:48:10 -0700 Comment on attachment 250338 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250338&action=review This looks very good, but I think it will break Cygwin support. We need to check for running Windows (as opposed to Cygwin) and use the proper PID in each case. If you grep through the webkitpy stuff, you should find some examples of 'Cygwin'-specific (as opposed to Windows-specific) routines. > Tools/Scripts/webkitpy/port/win.py:94 > + env = os.environ I'm not sure about this. We are supposed to be setting things like WEBKIT_TEST_FONTS and so forth. Are these getting set properly? > Tools/Scripts/webkitpy/port/win.py:-330 > - return system_pid We can't remove this until we are off Cygwin entirely. I think we have a distinction between Cygwin and Windows. This code should be executed for Cygwin, but not for oure Windows. 1164626 4 mmaxfield 2016-02-14 13:34:31 -0800 Looks like this has since been fixed. 250338 2015-04-07 23:43:47 -0700 2015-04-08 12:48:10 -0700 Patch bug-143516-20150407234257.patch text/plain 5946 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyNTE3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTRmZTIwN2MzYWNiZGNhNjgwYTZkZTk5YTgyMGQ5Zjkw ODlhZDhhZS4uMWFkYTEyZTQ3ZGVjOGYxNDZjMGFlOTQxYzJkZjhhNzNlMTBkYjdjYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4 IEBACisyMDE1LTA0LTA3ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+ CisKKyAgICAgICAgW1dpbl0gQWxsb3cgcnVubmluZyB0ZXN0cyB3aXRob3V0IEN5Z3dpbgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzNTE2CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2VlIGZpbGUtc3Bl Y2lmaWMgY29tbWVudHMgYmVsb3cuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQv YmFzZS5weToKKyAgICAgICAgKFBvcnQuZHJpdmVyX25hbWUpOiBUaGUgIi5leGUiIG11c3QgYmUg c3BlY2lmaWVkIHdoZW4gcmVmZXJyaW5nIHRvIGFuCisgICAgICAgIGV4ZWN1dGFibGUuCisgICAg ICAgIChQb3J0Ll9idWlsZF9wYXRoKTogRW52aXJvbm1lbnQgdmFyaWFibGVzIGNvbiBvbmx5IGhv bGQgb2JqZWN0cyBvZiB0eXBlCisgICAgICAgIFN0cmluZywgbm90IFVuaWNvZGUuCisgICAgICAg IChQb3J0LmZpbmRfc3lzdGVtX3BpZCk6IERlbGV0ZWQuIEl0cyByZXN1bHRzIHdlcmUgYmVpbmcg dGhyb3duIGF3YXkuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L3NlcnZlcl9wcm9j ZXNzLnB5OgorICAgICAgICAoU2VydmVyUHJvY2Vzcy5fc3RhcnQpOiBEb24ndCBjYWxsIGZpbmRf c3lzdGVtX3BpZC4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvd2luLnB5OgorICAg ICAgICAoV2luUG9ydC5zZXR1cF9lbnZpcm9uX2Zvcl9zZXJ2ZXIpOiBEdW1wUmVuZGVyVHJlZSBj cmFzaGVzIHdoZW4gaXRzCisgICAgICAgIGVudmlyb25tZW50IGlzIGVtcHR5CisgICAgICAgIChX aW5Qb3J0LnNldHVwX3Rlc3RfcnVuKTogVHJ5aW5nIHRvIGVkaXQgcmVnaXN0cnkgdmFsdWVzIG1h eSBmYWlsLgorICAgICAgICBIb3dldmVyLCB0aGUgbW9kaWZpZWQgcmVnaXN0cnkgZW50cmllcyBh cmUgbm90IHN0cmljdGx5IHJlcXVpcmVkLgorICAgICAgICAoV2luUG9ydCk6IERlbGV0ZWQuCisg ICAgICAgIChXaW5Qb3J0LmZpbmRfc3lzdGVtX3BpZCk6IERlbGV0ZWQuCisKIDIwMTUtMDQtMDcg IEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgUGFnZVZpc2li aWxpdHlTdGF0ZVdpdGhXaW5kb3dDaGFuZ2VzIHNob3VsZCBvbmx5IGJlIGVuYWJsZWQgb24gWW9z ZW1pdGUKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9iYXNlLnB5IGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2Jhc2UucHkKaW5kZXggMmNhYzUxNTBlMzA3MTI0 ZDBhNjgwMjMwZmQ3NTYyYWI4NGIzN2JiNy4uODY4OTAyYzY3MzM1ZTdlMDk4ZDUyMTEyNTg2OWNl YWQzM2Y0ODFlNyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2Jhc2Uu cHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2Jhc2UucHkKQEAgLTM0Nyw3ICsz NDcsNyBAQCBjbGFzcyBQb3J0KG9iamVjdCk6CiAgICAgICAgICAgICByZXR1cm4gc2VsZi5nZXRf b3B0aW9uKCdkcml2ZXJfbmFtZScpCiAgICAgICAgIGlmIHNlbGYuZ2V0X29wdGlvbignd2Via2l0 X3Rlc3RfcnVubmVyJyk6CiAgICAgICAgICAgICByZXR1cm4gJ1dlYktpdFRlc3RSdW5uZXInCi0g ICAgICAgIHJldHVybiAnRHVtcFJlbmRlclRyZWUnCisgICAgICAgIHJldHVybiAnRHVtcFJlbmRl clRyZWUuZXhlJwogCiAgICAgZGVmIGV4cGVjdGVkX2Jhc2VsaW5lc19ieV9leHRlbnNpb24oc2Vs ZiwgdGVzdF9uYW1lKToKICAgICAgICAgIiIiUmV0dXJucyBhIGRpY3QgbWFwcGluZyBiYXNlbGlu ZSBzdWZmaXggdG8gcmVsYXRpdmUgcGF0aCBmb3IgZWFjaCBiYXNlbGluZSBpbgpAQCAtMTEzNCw3 ICsxMTM0LDcgQEAgY2xhc3MgUG9ydChvYmplY3QpOgogICAgICAgICAgICAgIyBGSVhNRTogVGhp cyBpcyBsaWtlIEBtZW1vaXplZCwgYnV0IG1vcmUgYW5ub3lpbmcgYW5kIGZyYWdpbGU7IHRoZXJl IHNob3VsZCBiZSBhbm90aGVyCiAgICAgICAgICAgICAjIHdheSB0byBwcm9wYWdhdGUgdmFsdWVz IHdpdGhvdXQgbXV0YXRpbmcgdGhlIG9wdGlvbnMgbGlzdC4KICAgICAgICAgICAgIHNlbGYuc2V0 X29wdGlvbl9kZWZhdWx0KCdyb290Jywgcm9vdF9kaXJlY3RvcnkpCi0gICAgICAgIHJldHVybiBz ZWxmLl9maWxlc3lzdGVtLmpvaW4oc2VsZi5fZmlsZXN5c3RlbS5hYnNwYXRoKHJvb3RfZGlyZWN0 b3J5KSwgKmNvbXBzKQorICAgICAgICByZXR1cm4gc2VsZi5fZmlsZXN5c3RlbS5qb2luKHNlbGYu X2ZpbGVzeXN0ZW0uYWJzcGF0aChyb290X2RpcmVjdG9yeSksICpjb21wcykuZW5jb2RlKCJhc2Np aSIsICJpZ25vcmUiKQogCiAgICAgZGVmIF9wYXRoX3RvX2RyaXZlcihzZWxmLCBjb25maWd1cmF0 aW9uPU5vbmUpOgogICAgICAgICAiIiJSZXR1cm5zIHRoZSBmdWxsIHBhdGggdG8gdGhlIHRlc3Qg ZHJpdmVyIChEdW1wUmVuZGVyVHJlZSkuIiIiCkBAIC0xMjE1LDEwICsxMjE1LDYgQEAgY2xhc3Mg UG9ydChvYmplY3QpOgogICAgIGRlZiBzYW1wbGVfcHJvY2VzcyhzZWxmLCBuYW1lLCBwaWQpOgog ICAgICAgICBwYXNzCiAKLSAgICBkZWYgZmluZF9zeXN0ZW1fcGlkKHNlbGYsIG5hbWUsIHBpZCk6 Ci0gICAgICAgICMgVGhpcyBpcyBvbmx5IG92ZXJyaWRkZW4gb24gV2luZG93cwotICAgICAgICBy ZXR1cm4gcGlkCi0KICAgICBkZWYgc2hvdWxkX3J1bl9hc19waXhlbF90ZXN0KHNlbGYsIHRlc3Rf aW5wdXQpOgogICAgICAgICBpZiBub3Qgc2VsZi5fb3B0aW9ucy5waXhlbF90ZXN0czoKICAgICAg ICAgICAgIHJldHVybiBGYWxzZQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9w b3J0L3NlcnZlcl9wcm9jZXNzLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L3NlcnZl cl9wcm9jZXNzLnB5CmluZGV4IDU2ZjlmZDhkMTczMmMxYTAwMmFjNDg3NDNjNmI3ZWQ4M2E0NzU0 ZjYuLjZmOTQxMTY5NGUwNGY5MmE4MjRlZmNkZWJjMzJhMTQ4OTYwYjVkYTIgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9zZXJ2ZXJfcHJvY2Vzcy5weQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvc2VydmVyX3Byb2Nlc3MucHkKQEAgLTExNiw3ICsxMTYs NiBAQCBjbGFzcyBTZXJ2ZXJQcm9jZXNzKG9iamVjdCk6CiAgICAgICAgICAgICBlbnY9c2VsZi5f ZW52LAogICAgICAgICAgICAgdW5pdmVyc2FsX25ld2xpbmVzPXNlbGYuX3VuaXZlcnNhbF9uZXds aW5lcykKICAgICAgICAgc2VsZi5fcGlkID0gc2VsZi5fcHJvYy5waWQKLSAgICAgICAgc2VsZi5f cG9ydC5maW5kX3N5c3RlbV9waWQoc2VsZi5uYW1lKCksIHNlbGYuX3BpZCkKICAgICAgICAgZmQg PSBzZWxmLl9wcm9jLnN0ZG91dC5maWxlbm8oKQogICAgICAgICBpZiBub3Qgc2VsZi5fdXNlX3dp bjMyX2FwaXM6CiAgICAgICAgICAgICBmbCA9IGZjbnRsLmZjbnRsKGZkLCBmY250bC5GX0dFVEZM KQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L3dpbi5weSBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvcG9ydC93aW4ucHkKaW5kZXggM2EzZjMxYzkwOTJmOWMwNmI1N2Ew NzIwNzFlMDY2YmY2ZmUwMzc3Zi4uOGZjMGQ0N2JlOWFjN2U4ODYyODY2NjQ4YTJlOWM1Mjk0M2Jm MDI4OCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L3dpbi5weQorKysg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvd2luLnB5CkBAIC05MSw3ICs5MSw3IEBAIGNs YXNzIFdpblBvcnQoQXBwbGVQb3J0KToKICAgICAgICAgcmV0dXJuIG1hcChzZWxmLl93ZWJraXRf YmFzZWxpbmVfcGF0aCwgZmFsbGJhY2tfbmFtZXMpCiAKICAgICBkZWYgc2V0dXBfZW52aXJvbl9m b3Jfc2VydmVyKHNlbGYsIHNlcnZlcl9uYW1lPU5vbmUpOgotICAgICAgICBlbnYgPSBzdXBlcihX aW5Qb3J0LCBzZWxmKS5zZXR1cF9lbnZpcm9uX2Zvcl9zZXJ2ZXIoc2VydmVyX25hbWUpCisgICAg ICAgIGVudiA9IG9zLmVudmlyb24KICAgICAgICAgZW52WydYTUxfQ0FUQUxPR19GSUxFUyddID0g JycgICMgd29yayBhcm91bmQgbWlzc2luZyAvZXRjL2NhdGFsb2cgPHJkYXI6Ly9wcm9ibGVtLzQy OTI5OTU+CiAgICAgICAgIHJldHVybiBlbnYKIApAQCAtMjU0LDcgKzI1NCwxMCBAQCBjbGFzcyBX aW5Qb3J0KEFwcGxlUG9ydCk6CiAgICAgZGVmIHNldHVwX3Rlc3RfcnVuKHNlbGYpOgogICAgICAg ICBhdGV4aXQucmVnaXN0ZXIoc2VsZi5yZXN0b3JlX2NyYXNoX2xvZ19zYXZpbmcpCiAgICAgICAg IHNlbGYuc2V0dXBfY3Jhc2hfbG9nX3NhdmluZygpCi0gICAgICAgIHNlbGYucHJldmVudF9lcnJv cl9kaWFsb2dzKCkKKyAgICAgICAgdHJ5OgorICAgICAgICAgICAgc2VsZi5wcmV2ZW50X2Vycm9y X2RpYWxvZ3MoKQorICAgICAgICBleGNlcHQgV2luZG93c0Vycm9yOgorICAgICAgICAgICAgX2xv Zy53YXJuKCJDb3VsZCBub3QgcHJldmVudCBlcnJvciBkaWFsb2dzLiBOb3RlIHRoYXQgdGhpcyBy ZWxpZXMgb24gZWRpdGluZyByZWdpc3RyeSBlbnRyaWVzLiIpCiAgICAgICAgIHNlbGYuZGVsZXRl X3NlbV9sb2NrcygpCiAgICAgICAgIHN1cGVyKFdpblBvcnQsIHNlbGYpLnNldHVwX3Rlc3RfcnVu KCkKIApAQCAtMzA4LDIzICszMTEsMyBAQCBjbGFzcyBXaW5Qb3J0KEFwcGxlUG9ydCk6CiAgICAg ICAgICAgICBpZiBjcmFzaF9sb2c6CiAgICAgICAgICAgICAgICAgY3Jhc2hfbG9nc1t0ZXN0X25h bWVdID0gY3Jhc2hfbG9nCiAgICAgICAgIHJldHVybiBjcmFzaF9sb2dzCi0KLSAgICBkZWYgZmlu ZF9zeXN0ZW1fcGlkKHNlbGYsIG5hbWUsIHBpZCk6Ci0gICAgICAgIHN5c3RlbV9waWQgPSBpbnQo cGlkKQotICAgICAgICAjIFdpbmRvd3MgYW5kIEN5Z3dpbiBQSURzIGFyZSBub3QgdGhlIHNhbWUu ICBXZSBuZWVkIHRvIGZpbmQgdGhlIFdpbmRvd3MKLSAgICAgICAgIyBQSUQgZm9yIG91ciBDeWd3 aW4gcHJvY2VzcyBzbyB3ZSBjYW4gbWF0Y2ggaXQgbGF0ZXIgdG8gYW55IGNyYXNoCi0gICAgICAg ICMgZmlsZXMgd2UgZW5kIHVwIGNyZWF0aW5nICh3aGljaCB3aWxsIGJlIHRhZ2dlZCB3aXRoIHRo ZSBXaW5kb3dzIFBJRCkKLSAgICAgICAgcHNfcHJvY2VzcyA9IHNlbGYuX2V4ZWN1dGl2ZS5ydW5f Y29tbWFuZChbJ3BzJywgJy1lJ10sIGVycm9yX2hhbmRsZXI9RXhlY3V0aXZlLmlnbm9yZV9lcnJv cikKLSAgICAgICAgZm9yIGxpbmUgaW4gcHNfcHJvY2Vzcy5zcGxpdGxpbmVzKCk6Ci0gICAgICAg ICAgICB0b2tlbnMgPSBsaW5lLnN0cmlwKCkuc3BsaXQoKQotICAgICAgICAgICAgdHJ5OgotICAg ICAgICAgICAgICAgIGNwaWQsIHBwaWQsIHBnaWQsIHdpbnBpZCwgdHR5LCB1aWQsIHN0aW1lLCBw cm9jZXNzX25hbWUgPSB0b2tlbnMKLSAgICAgICAgICAgICAgICBpZiBwcm9jZXNzX25hbWUuZW5k c3dpdGgobmFtZSk6Ci0gICAgICAgICAgICAgICAgICAgIHNlbGYuX2V4ZWN1dGl2ZS5waWRfdG9f c3lzdGVtX3BpZFtpbnQoY3BpZCldID0gaW50KHdpbnBpZCkKLSAgICAgICAgICAgICAgICAgICAg aWYgaW50KHBpZCkgPT0gaW50KGNwaWQpOgotICAgICAgICAgICAgICAgICAgICAgICAgc3lzdGVt X3BpZCA9IGludCh3aW5waWQpCi0gICAgICAgICAgICAgICAgICAgIGJyZWFrCi0gICAgICAgICAg ICBleGNlcHQgVmFsdWVFcnJvciwgZToKLSAgICAgICAgICAgICAgICBwYXNzCi0KLSAgICAgICAg cmV0dXJuIHN5c3RlbV9waWQK