143514 2015-04-07 22:49:24 -0700 [EFL] Create PageUIClientEfl after sending CreateWebPage message 2015-04-08 22:23:49 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ljaehun.lim ljaehun.lim commit-queue gyuyoung.kim lucas.de.marchi oldest_to_newest 1083553 0 ljaehun.lim 2015-04-07 22:49:24 -0700 UIProcess sends some messages to WebPage before WebPage is created. It makes some error logs on debug build. Error Log: ERROR: Unhandled web process message 'WebPage:SetCanRunBeforeUnloadConfirmPanel' ../../Source/WebKit2/WebProcess/WebProcess.cpp(643) : virtual void WebKit::WebProcess::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&) ERROR: Unhandled web process message 'WebPage:SetCanRunModal' ../../Source/WebKit2/WebProcess/WebProcess.cpp(643) : virtual void WebKit::WebProcess::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&) So this patch moves the initialization of m_pageUIClient after calling WKViewInitialize(). 1083554 1 250335 ljaehun.lim 2015-04-07 22:53:49 -0700 Created attachment 250335 Patch 1083852 2 250335 gyuyoung.kim 2015-04-08 21:16:46 -0700 Comment on attachment 250335 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250335&action=review Thanks, LGTM. > Source/WebKit2/ChangeLog:11 > + Error Log: BTW, it looks this error log is not necessary in ChangeLog. 1083854 3 250414 ljaehun.lim 2015-04-08 21:21:01 -0700 Created attachment 250414 Patch 1083855 4 250335 ljaehun.lim 2015-04-08 21:22:25 -0700 Comment on attachment 250335 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250335&action=review >> Source/WebKit2/ChangeLog:11 >> + Error Log: > > BTW, it looks this error log is not necessary in ChangeLog. Thanks. I removed. 1083868 5 commit-queue 2015-04-08 22:22:17 -0700 The commit-queue encountered the following flaky tests while processing attachment 250414: transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com) fast/events/media-focus-in-standalone-media-document.html bug 143555 The commit-queue is continuing to process your patch. 1083869 6 250414 commit-queue 2015-04-08 22:23:45 -0700 Comment on attachment 250414 Patch Clearing flags on attachment: 250414 Committed r182588: <http://trac.webkit.org/changeset/182588> 1083870 7 commit-queue 2015-04-08 22:23:49 -0700 All reviewed patches have been landed. Closing bug. 250335 2015-04-07 22:53:49 -0700 2015-04-08 21:20:55 -0700 Patch bug-143514-20150408145258.patch text/plain 2634 ljaehun.lim U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyNTE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODU2ODU2NTJmZTcyZmNj MGVjMTFkNzdmOTg0NTExMmY2M2Q0YzI1ZC4uNWZlY2I0NDcxMGM5NDhhNGU2MDY0NGNkMTY0MmM5 NzMzYzMzZDBmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE1LTA0LTA3ICBKYWVo dW4gTGltICA8bGphZWh1bi5saW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gQ3JlYXRl IFBhZ2VVSUNsaWVudEVmbCBhZnRlciBzZW5kaW5nIENyZWF0ZVdlYlBhZ2UgbWVzc2FnZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzNTE0CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVUlQcm9jZXNzIHNl bmRzIHNvbWUgbWVzc2FnZXMgdG8gV2ViUGFnZSBiZWZvcmUgV2ViUGFnZSBpcyBjcmVhdGVkLiBJ dCBtYWtlcyBzb21lIGVycm9yIGxvZ3Mgb24gZGVidWcgYnVpbGQuCisgICAgICAgIFNvIHRoaXMg cGF0Y2ggbW92ZXMgdGhlIGluaXRpYWxpemF0aW9uIG9mIG1fcGFnZVVJQ2xpZW50IGFmdGVyIGNh bGxpbmcgV0tWaWV3SW5pdGlhbGl6ZSgpLgorCisgICAgICAgIEVycm9yIExvZzoKKyAgICAgICAg RVJST1I6IFVuaGFuZGxlZCB3ZWIgcHJvY2VzcyBtZXNzYWdlICdXZWJQYWdlOlNldENhblJ1bkJl Zm9yZVVubG9hZENvbmZpcm1QYW5lbCcKKyAgICAgICAgLi4vLi4vU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9XZWJQcm9jZXNzLmNwcCg2NDMpIDogdmlydHVhbCB2b2lkIFdlYktpdDo6V2ViUHJv Y2Vzczo6ZGlkUmVjZWl2ZU1lc3NhZ2UoSVBDOjpDb25uZWN0aW9uJiwgSVBDOjpNZXNzYWdlRGVj b2RlciYpCisgICAgICAgIEVSUk9SOiBVbmhhbmRsZWQgd2ViIHByb2Nlc3MgbWVzc2FnZSAnV2Vi UGFnZTpTZXRDYW5SdW5Nb2RhbCcKKyAgICAgICAgLi4vLi4vU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9XZWJQcm9jZXNzLmNwcCg2NDMpIDogdmlydHVhbCB2b2lkIFdlYktpdDo6V2ViUHJvY2Vz czo6ZGlkUmVjZWl2ZU1lc3NhZ2UoSVBDOjpDb25uZWN0aW9uJiwgSVBDOjpNZXNzYWdlRGVjb2Rl ciYpCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3LmNwcDoKKyAgICAgICAg KEV3a1ZpZXc6OkV3a1ZpZXcpOgorCiAyMDE1LTA0LTA3ICBUaW0gSG9ydG9uICA8dGltb3RoeV9o b3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCB0aGUgYnVpbGQuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3LmNwcCBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcuY3BwCmluZGV4IGVlNTAzYTc0YTI1ZDY3YjFl MmEyMGU0YTQ5MzA4ZmFhNjcyNmMxMDAuLmE0MWEzYjllMTUwMWI3MDBlOWE4ZjVkNGU5ZDczMjU0 YTA2MzQzN2IgMTAwNzU1Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3 a1ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcu Y3BwCkBAIC0yODAsNyArMjgwLDYgQEAgRXdrVmlldzo6RXdrVmlldyhXS1ZpZXdSZWYgdmlldywg RXZhc19PYmplY3QqIGV2YXNPYmplY3QpCiAgICAgLCBtX3BhZ2VHcm91cChFd2tQYWdlR3JvdXA6 OmZpbmRPckNyZWF0ZVdyYXBwZXIoV0tQYWdlR2V0UGFnZUdyb3VwKHdrUGFnZSgpKSkpCiAgICAg LCBtX3BhZ2VMb2FkQ2xpZW50KHN0ZDo6bWFrZV91bmlxdWU8UGFnZUxvYWRDbGllbnRFZmw+KHRo aXMpKQogICAgICwgbV9wYWdlUG9saWN5Q2xpZW50KHN0ZDo6bWFrZV91bmlxdWU8UGFnZVBvbGlj eUNsaWVudEVmbD4odGhpcykpCi0gICAgLCBtX3BhZ2VVSUNsaWVudChzdGQ6Om1ha2VfdW5pcXVl PFBhZ2VVSUNsaWVudEVmbD4odGhpcykpCiAgICAgLCBtX2NvbnRleHRNZW51Q2xpZW50KHN0ZDo6 bWFrZV91bmlxdWU8Q29udGV4dE1lbnVDbGllbnRFZmw+KHRoaXMpKQogICAgICwgbV9maW5kQ2xp ZW50KHN0ZDo6bWFrZV91bmlxdWU8RmluZENsaWVudEVmbD4odGhpcykpCiAgICAgLCBtX2Zvcm1D bGllbnQoc3RkOjptYWtlX3VuaXF1ZTxGb3JtQ2xpZW50RWZsPih0aGlzKSkKQEAgLTMyOCw2ICsz MjcsOCBAQCBFd2tWaWV3OjpFd2tWaWV3KFdLVmlld1JlZiB2aWV3LCBFdmFzX09iamVjdCogZXZh c09iamVjdCkKICAgICBtX3BlbmRpbmdTdXJmYWNlUmVzaXplID0gbV9pc0FjY2VsZXJhdGVkOwog ICAgIFdLVmlld0luaXRpYWxpemUod2tWaWV3KCkpOwogCisgICAgbV9wYWdlVUlDbGllbnQgPSBz dGQ6Om1ha2VfdW5pcXVlPFBhZ2VVSUNsaWVudEVmbD4odGhpcyk7CisKICAgICBXS1BhZ2VHcm91 cFJlZiB3a1BhZ2VHcm91cCA9IFdLUGFnZUdldFBhZ2VHcm91cCh3a1BhZ2UoKSk7CiAgICAgV0tQ cmVmZXJlbmNlc1JlZiB3a1ByZWZlcmVuY2VzID0gV0tQYWdlR3JvdXBHZXRQcmVmZXJlbmNlcyh3 a1BhZ2VHcm91cCk7CiAgICAgV0tQcmVmZXJlbmNlc1NldFdlYkdMRW5hYmxlZCh3a1ByZWZlcmVu Y2VzLCB0cnVlKTsK 250414 2015-04-08 21:21:01 -0700 2015-04-08 22:23:45 -0700 Patch bug-143514-20150409132010.patch text/plain 2197 ljaehun.lim U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyNTg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjQ2MGU1MmE5N2MzZmY3 NjJkMzIxYmVjMTNhNDEzYmJkNjY1ZjdiMS4uMjE4M2E0YzNlM2QwYWM1YmM0NGI1MjljZjcwYzc5 YmFjZjE4YjI1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA0LTA4ICBKYWVo dW4gTGltICA8bGphZWh1bi5saW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gQ3JlYXRl IFBhZ2VVSUNsaWVudEVmbCBhZnRlciBzZW5kaW5nIENyZWF0ZVdlYlBhZ2UgbWVzc2FnZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzNTE0CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgR3l1eW91bmcgS2ltLgorCisgICAgICAgIFVJUHJvY2VzcyBzZW5k cyBzb21lIG1lc3NhZ2VzIHRvIFdlYlBhZ2UgYmVmb3JlIFdlYlBhZ2UgaXMgY3JlYXRlZC4gSXQg bWFrZXMgc29tZSBlcnJvciBsb2dzIG9uIGRlYnVnIGJ1aWxkLgorICAgICAgICBTbyB0aGlzIHBh dGNoIG1vdmVzIHRoZSBpbml0aWFsaXphdGlvbiBvZiBtX3BhZ2VVSUNsaWVudCBhZnRlciBjYWxs aW5nIFdLVmlld0luaXRpYWxpemUoKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL0V3 a1ZpZXcuY3BwOgorICAgICAgICAoRXdrVmlldzo6RXdrVmlldyk6CisKIDIwMTUtMDQtMDggIEJy ZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgW01hY10gV2ViS2l0 IGlzIG5vdCBob25vcmluZyBPUyBwcmVmZXJlbmNlcyBmb3Igc2Vjb25kYXJ5IGNsaWNrIGJlaGF2 aW9ycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmll dy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3LmNwcAppbmRl eCBlZTUwM2E3NGEyNWQ2N2IxZTJhMjBlNGE0OTMwOGZhYTY3MjZjMTAwLi5hNDFhM2I5ZTE1MDFi NzAwZTlhOGY1ZDRlOWQ3MzI1NGEwNjM0MzdiIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2VmbC9Fd2tWaWV3LmNwcApAQCAtMjgwLDcgKzI4MCw2IEBAIEV3a1ZpZXc6OkV3a1Zp ZXcoV0tWaWV3UmVmIHZpZXcsIEV2YXNfT2JqZWN0KiBldmFzT2JqZWN0KQogICAgICwgbV9wYWdl R3JvdXAoRXdrUGFnZUdyb3VwOjpmaW5kT3JDcmVhdGVXcmFwcGVyKFdLUGFnZUdldFBhZ2VHcm91 cCh3a1BhZ2UoKSkpKQogICAgICwgbV9wYWdlTG9hZENsaWVudChzdGQ6Om1ha2VfdW5pcXVlPFBh Z2VMb2FkQ2xpZW50RWZsPih0aGlzKSkKICAgICAsIG1fcGFnZVBvbGljeUNsaWVudChzdGQ6Om1h a2VfdW5pcXVlPFBhZ2VQb2xpY3lDbGllbnRFZmw+KHRoaXMpKQotICAgICwgbV9wYWdlVUlDbGll bnQoc3RkOjptYWtlX3VuaXF1ZTxQYWdlVUlDbGllbnRFZmw+KHRoaXMpKQogICAgICwgbV9jb250 ZXh0TWVudUNsaWVudChzdGQ6Om1ha2VfdW5pcXVlPENvbnRleHRNZW51Q2xpZW50RWZsPih0aGlz KSkKICAgICAsIG1fZmluZENsaWVudChzdGQ6Om1ha2VfdW5pcXVlPEZpbmRDbGllbnRFZmw+KHRo aXMpKQogICAgICwgbV9mb3JtQ2xpZW50KHN0ZDo6bWFrZV91bmlxdWU8Rm9ybUNsaWVudEVmbD4o dGhpcykpCkBAIC0zMjgsNiArMzI3LDggQEAgRXdrVmlldzo6RXdrVmlldyhXS1ZpZXdSZWYgdmll dywgRXZhc19PYmplY3QqIGV2YXNPYmplY3QpCiAgICAgbV9wZW5kaW5nU3VyZmFjZVJlc2l6ZSA9 IG1faXNBY2NlbGVyYXRlZDsKICAgICBXS1ZpZXdJbml0aWFsaXplKHdrVmlldygpKTsKIAorICAg IG1fcGFnZVVJQ2xpZW50ID0gc3RkOjptYWtlX3VuaXF1ZTxQYWdlVUlDbGllbnRFZmw+KHRoaXMp OworCiAgICAgV0tQYWdlR3JvdXBSZWYgd2tQYWdlR3JvdXAgPSBXS1BhZ2VHZXRQYWdlR3JvdXAo d2tQYWdlKCkpOwogICAgIFdLUHJlZmVyZW5jZXNSZWYgd2tQcmVmZXJlbmNlcyA9IFdLUGFnZUdy b3VwR2V0UHJlZmVyZW5jZXMod2tQYWdlR3JvdXApOwogICAgIFdLUHJlZmVyZW5jZXNTZXRXZWJH TEVuYWJsZWQod2tQcmVmZXJlbmNlcywgdHJ1ZSk7Cg==