143488 2015-04-07 11:20:59 -0700 [Gtk] Animation is not stopped when animation class is removed 2017-03-11 11:03:36 -0800 1 1 1 Unclassified WebKit Animations 528+ (Nightly build) Unspecified Linux NEW P2 Normal --- 1 ed_dvd webkit-unassigned bugs-noreply dino ed_dvd oldest_to_newest 1083355 0 250278 ed_dvd 2015-04-07 11:20:59 -0700 Created attachment 250278 HTML file showing the problem The problem is found with GTK port when accelerated Compositing is used. The attached test application is doing the following steps: 1. Apply translateZ(0) to <p> element 2. Apply CSS class called .delayedScrollingLabelA.animate to perform animation using -webkit-animation property. 3. Remove .delayedScrollingLabelA.animate class. At step (3), it is expected that animation should stop, however it continues. The problem does not happen if step (1) is omitted. 1083364 1 ed_dvd 2015-04-07 11:31:02 -0700 The problem seems to be in GraphicsLayerTextureMapper class. Specifically, when animation is added, the GraphicsLayerTextureMapper::addAnimation() is called which does 2 things: 1. add new animation to m_animations set 2. calls notifyChange(AnimationChange) to notify m_layer that its own internal set of animations has been modified. However, when animation is removed via GraphicsLayerTextureMapper::removeAnimation(), the code only removes the animation from the m_animations set, but does not notify the m_layer. The proposed patch would be to add notifyChange(AnimationChange) call to both removeAnimation() and pauseAnimation() as following: void GraphicsLayerTextureMapper::pauseAnimation(const String& animationName, double timeOffset) { m_animations.pause(animationName, timeOffset); notifyChange(AnimationChange); } void GraphicsLayerTextureMapper::removeAnimation(const String& animationName) { m_animations.remove(animationName); notifyChange(AnimationChange); } 1084010 2 ed_dvd 2015-04-09 11:48:35 -0700 Hi Alexei, do you think this bug is GTK-only? The GraphicsLayerTextureMapper class seems to be common code for all ports since it resides under webcore/platform/graphics/texmap folder? (sorry if I misunderstand something, I am new to webkit development community) 250278 2015-04-07 11:20:59 -0700 2015-04-07 11:20:59 -0700 HTML file showing the problem animation_class_remove.html text/html 1870 ed_dvd PGh0bWw+DQo8aGVhZD4NCjxzdHlsZT4NCi5kZWxheWVkU2Nyb2xsaW5nTGFiZWxBIHsNCgl3aGl0 ZS1zcGFjZTogcHJlOw0KCXBvc2l0aW9uOiByZWxhdGl2ZTsNCglkaXNwbGF5OiBpbmxpbmUtYmxv Y2s7DQoNCi8qRUQ6IGlmIGNvbW1lbnQgb3V0IGJlbG93IHRyYW5zbGF0ZVosIHRoZSBpc3N1ZSBk b2VzIG5vdCBoYXBwZW4hISovDQoJLXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0ZVooMCk7DQov KiANCgl0cmFuc2Zvcm06IHRyYW5zbGF0ZVooMCk7DQoqLw0KCX0NCg0KLmRlbGF5ZWRTY3JvbGxp bmdMYWJlbEEuYW5pbWF0ZSB7DQoJei1pbmRleDogMTsNCgktd2Via2l0LWFuaW1hdGlvbjogZGVs YXllZFNjcm9sbGluZ0xhYmVsQW5pbWF0aW9uIDEwcyBsaW5lYXIgaW5maW5pdGU7DQogICAgIGFu aW1hdGlvbjogZGVsYXllZFNjcm9sbGluZ0xhYmVsQW5pbWF0aW9uIDEwcyBsaW5lYXIgaW5maW5p dGU7DQp9DQoNCg0KQGtleWZyYW1lcyBkZWxheWVkU2Nyb2xsaW5nTGFiZWxBbmltYXRpb24gew0K CTAlIHsgdHJhbnNmb3JtOiB0cmFuc2xhdGUzZCgwLCAwLCAwcHgpOyB9DQoJMjAlIHsgdHJhbnNm b3JtOiB0cmFuc2xhdGUzZCgwLCAwLCAwcHgpOyB9DQoJMTAwJSB7IHRyYW5zZm9ybTogdHJhbnNs YXRlM2QoLTUwJSwgMCwgMHB4KTsgfQ0KfQ0KDQpALXdlYmtpdC1rZXlmcmFtZXMgZGVsYXllZFNj cm9sbGluZ0xhYmVsQW5pbWF0aW9uIHsNCgkwJSB7DQoJCS13ZWJraXQtdHJhbnNmb3JtOiB0cmFu c2xhdGUzZCgtMTAlLCAwLCAwcHgpOw0KCQl0cmFuc2Zvcm06IHRyYW5zbGF0ZTNkKC0xMCUsIDAs IDBweCk7DQoJfQ0KCTIwJSB7DQoJCS13ZWJraXQtdHJhbnNmb3JtOiB0cmFuc2xhdGUzZCgtMjAl LCAwLCAwcHgpOw0KCQl0cmFuc2Zvcm06IHRyYW5zbGF0ZTNkKC0yMCUsIDAsIDBweCk7DQoJfQ0K CTEwMCUgew0KCQktd2Via2l0LXRyYW5zZm9ybTogdHJhbnNsYXRlM2QoLTUwJSwgMCwgMHB4KTsN CgkJdHJhbnNmb3JtOiB0cmFuc2xhdGUzZCgtNTAlLCAwLCAwcHgpOw0KCX0NCn0NCg0KPC9zdHls ZT4NCjwvaGVhZD4NCjxib2R5Pg0KPGRpdiBpZD0iZGl2MSIgc3R5bGU9InBhZGRpbmc6IDBweDsg cG9zaXRpb246IGFic29sdXRlOyBvdmVyZmxvdzogaGlkZGVuOyBsZWZ0OiAxNjBweDsgdG9wOiAx MDBweDsgd2lkdGg6IDM2NHB4OyI+PHAgaWQ9InRlc3RjYXNlMSIgY2xhc3M9ImFnb3JhRXZlbnRO YW1lIGRlbGF5ZWRTY3JvbGxpbmdMYWJlbEEiPlNob3VsZCBiZSBOT1QgTU9WSU5HPC9wPjwvZGl2 Pg0KPHNjcmlwdD4NCg0KICAgIHNldFRpbWVvdXQoZnVuY3Rpb24oKSB7DQogICAgICAgIGNvbnNv bGUubG9nKCJTdGFydCBhbmltYXRpb24iKTsNCiAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoInRlc3RjYXNlMSIpLmNsYXNzTGlzdC50b2dnbGUoImFuaW1hdGUiKTsNCgkJZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoInRlc3RjYXNlMSIpLmlubmVySFRNTCA9ICJTaG91bGQgYmUgTU9WSU5H IE5PVy4uLiBTaG91bGQgYmUgTU9WSU5HIE5PVy4uLiBTaG91bGQgYmUgTU9WSU5HIE5PVy4uLiI7 DQoJIH0sIDEwMDApOw0KDQogICAgc2V0VGltZW91dChmdW5jdGlvbigpIHsNCiAgICAgICAgY29u c29sZS5sb2coIlN0b3AgYW5pbWF0aW9uIik7DQogICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCJ0ZXN0Y2FzZTEiKS5jbGFzc0xpc3QudG9nZ2xlKCJhbmltYXRlIik7DQoJCWRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCJ0ZXN0Y2FzZTEiKS5pbm5lckhUTUwgPSAiU2hvdWxkIGJlIE5PVCBN T1ZJTkcuLi4gU2hvdWxkIGJlIE5PVCBNT1ZJTkcuLi4gU2hvdWxkIGJlIE5PVCBNT1ZJTkcuLi4i OwkNCiAgICB9LCA1MDAwKTsNCjwvc2NyaXB0Pg0KPC9ib2R5Pg0KPC9odG1sPg==