143484 2015-04-07 10:16:51 -0700 [Win] Bots complain about missing /etc/catalog 2016-02-01 15:43:52 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Windows 7 RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=143463 https://bugs.webkit.org/show_bug.cgi?id=153683 InRadar P2 Normal --- 1 cdumez bfulgham ap bfulgham cdumez commit-queue glenn oldest_to_newest 1083333 0 cdumez 2015-04-07 10:16:51 -0700 Bots complain about missing /etc/catalog: 476 2928 worker/0 http/tests/security/xss-DENIED-xsl-external-entity-redirect.xml passed 18:00:06.538 2928 worker/0 http/tests/security/xss-DENIED-xsl-external-entity.xml output stderr lines: 18:00:06.538 2928 ERROR: Failed to create path /tmp/DumpRenderTree-1sDSaK\Databases 18:00:06.538 2928 ..\platform\win\FileSystemWin.cpp(212) : WebCore::makeAllDirectories 18:00:06.538 2928 ERROR: Failed to create path /tmp/DumpRenderTree-1sDSaK\Databases 18:00:06.538 2928 ..\platform\win\FileSystemWin.cpp(212) : WebCore::makeAllDirectories 18:00:06.538 2928 LEAK: 3 CachedPage 18:00:06.538 2928 LEAK: 218 CachedResource 18:00:06.538 2928 LEAK: 4 CachedFrame 18:00:06.538 2928 LEAK: 7 Frame 18:00:06.538 2928 LEAK: 242 WebCoreNode 18:00:06.538 2928 LEAK: 46 RenderObject 18:00:06.538 2928 LEAK: 6 Page 18:00:06.538 2928 file:///C:/Program%20Files%20(x86)/Common%20Files/Apple/Apple%20Application%20Support/../etc/catalog:1: parser error : Document is empty 18:00:06.538 2928 18:00:06.538 2928 ^ 18:00:06.538 2928 file:///C:/Program%20Files%20(x86)/Common%20Files/Apple/Apple%20Application%20Support/../etc/catalog:1: parser error : Start tag expected, '<' not found 18:00:06.538 2928 18:00:06.538 2928 ^ 18:00:06.538 2928 compilation error: file http://127.0.0.1:8000/security/xss-DENIED-xsl-document-securityOrigin.xml line 2 element stylesheet 18:00:06.538 2928 xsl:version: only 1.0 features are supported 18:00:06.538 2928 compilation error: file http://127.0.0.1:8000/security/xss-DENIED-xsl-document-securityOrigin.xml line 2 element stylesheet 18:00:06.538 2928 xsl:version: only 1.0 features are supported 18:00:06.538 2928 compilation error: file http://127.0.0.1:8000/security/xss-DENIED-xsl-document-securityOrigin.xml line 2 element stylesheet 18:00:06.538 2928 xsl:version: only 1.0 features are supported 18:00:06.538 2928 worker/0 http/tests/security/xss-DENIED-xsl-external-entity.xml passed It can apparently cause tests to fail sometimes: http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=http%2Ftests%2Fsecurity%2Fxss-DENIED-xsl-external-entity-redirect.xml Radar: <rdar://problem/4292995> 1083348 1 250276 bfulgham 2015-04-07 10:53:50 -0700 Created attachment 250276 Patch 1083350 2 250276 cdumez 2015-04-07 10:55:00 -0700 Comment on attachment 250276 Patch r=me. 1083353 3 bfulgham 2015-04-07 11:07:46 -0700 Committed r182481: <http://trac.webkit.org/changeset/182481> 1083400 4 cdumez 2015-04-07 13:25:47 -0700 Did you confirm it worked locally? It looks like it is still happening on the bots: 11:32:17.829 2580 file:///C:/Program%20Files%20(x86)/Common%20Files/Apple/Apple%20Application%20Support/../etc/catalog:1: parser error : Document is empty 11:32:17.829 2580 11:32:17.829 2580 ^ 11:32:17.829 2580 file:///C:/Program%20Files%20(x86)/Common%20Files/Apple/Apple%20Application%20Support/../etc/catalog:1: parser error : Start tag expected, '<' not found 11:32:17.829 2580 11:32:17.829 2580 ^ see: https://build.webkit.org/builders/Apple%20Win%207%20Debug%20%28Tests%29/builds/65586/steps/layout-test/logs/stdio 1083442 5 bfulgham 2015-04-07 14:38:57 -0700 Because the httpd servers on the Windows bots run as a user, and are not launched directly from the command line, I think their environment doesn't pick up these updated settings. I'm trying an experiment where I set this environment variable in the web server user's environment. 1083451 6 bfulgham 2015-04-07 15:04:58 -0700 (In reply to comment #5) > Because the httpd servers on the Windows bots run as a user, and are not > launched directly from the command line, I think their environment doesn't > pick up these updated settings. > > I'm trying an experiment where I set this environment variable in the web > server user's environment. This didn't work, either. I can now see in the log file that the environment variable is being set properly, but this doesn't seem to be having the desired effect. 1083639 7 bfulgham 2015-04-08 09:55:04 -0700 (In reply to comment #6) > (In reply to comment #5) > > Because the httpd servers on the Windows bots run as a user, and are not > > launched directly from the command line, I think their environment doesn't > > pick up these updated settings. > > > > I'm trying an experiment where I set this environment variable in the web > > server user's environment. > > This didn't work, either. I can now see in the log file that the environment > variable is being set properly, but this doesn't seem to be having the > desired effect. This actually makes sense. If the XML_CATALOG_FILES is not set, it attempts to find the file at a relative path from libxml2.dll (../etc/catalog). I just tried setting XML_CATALOG_FILES to point at the Cygwin version of this file. If that works, we can look at adding the catalog file to our WebKitAuxLibraries bundle. 250276 2015-04-07 10:53:50 -0700 2015-04-07 10:55:00 -0700 Patch bug-143484-20150407110315.patch text/plain 2050 bfulgham SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4MjQ3OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIyIEBACisyMDE1LTA0LTA3ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29t PgorCisgICAgICAgIFtXaW5dIEJvdHMgY29tcGxhaW4gYWJvdXQgbWlzc2luZyAvZXRjL2NhdGFs b2cKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MzQ4 NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBs aWJ4bWwyIGJ1aWxkIG9uIE1hYywgaU9TLCBhbmQgV2luZG93cyBkb2VzIG5vdCBwcm92aWRlIHRo ZSBzZXQKKyAgICAgICAgb2YgZGVmYXVsdCBjYXRhbG9nIGZpbGVzLiBXZSBkbyBub3QgYWN0dWFs bHkgbmVlZCB0aGVzZSBmb3Igb3VyCisgICAgICAgIHB1cnBvc2VzLCBidXQgd2UgZ2V0IHdhcm5p bmdzIGFuZCBzb21lIGJvdCBmbGFraW5lc3MgYmVjYXVzZSB0aGV5CisgICAgICAgIGFyZSBub3Qg cHJlc2VudC4KKworICAgICAgICBXZSBjYW4gYXZvaWQgYm90aCBwcm9ibGVtcyB0aGUgc2FtZSB3 YXkgdGhlIE1hYyBhbmQgaU9TIHBvcnRzIGRvLAorICAgICAgICBieSBzZXR0aW5nIHRoZSBYTUxf Q0FUQUxPR19GSUxFUyBlbnZpcm9ubWVudCB2YXJpYWJsZSB0byAnZW1wdHkgc3RyaW5nJywKKyAg ICAgICAgd2hpY2ggYXZvaWQgdGhlIHdhcm5pbmdzIGFuZCBib3QgcHJvYmxlbXMuCisKKyAgICAg ICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvd2luLnB5OgorICAgICAgICAoV2luUG9ydC5zZXR1 cF9lbnZpcm9uX2Zvcl9zZXJ2ZXIpOiBBZGRlZC4KKwogMjAxNS0wNC0wNiAgU2FtIFdlaW5pZyAg PHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVzZSBjb250ZW50IGV4dGVuc2lvbnMgaW4gTWlu aUJyb3dzZXIuCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvd2luLnB5Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC93aW4ucHkJKHJldmlzaW9uIDE4 MjQ3NykKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC93aW4ucHkJKHdvcmtpbmcgY29w eSkKQEAgLTEsNSArMSw1IEBACiAjIENvcHlyaWdodCAoQykgMjAxMCBHb29nbGUgSW5jLiBBbGwg cmlnaHRzIHJlc2VydmVkLgotIyBDb3B5cmlnaHQgKEMpIDIwMTMgQXBwbGUgSW5jLiBBbGwgcmln aHRzIHJlc2VydmVkLgorIyBDb3B5cmlnaHQgKEMpIDIwMTMsIDIwMTUgQXBwbGUgSW5jLiBBbGwg cmlnaHRzIHJlc2VydmVkLgogIwogIyBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBh bmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICMgbW9kaWZpY2F0aW9uLCBhcmUgcGVy bWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zIGFyZQpAQCAtOTAs NiArOTAsMTEgQEAgY2xhc3MgV2luUG9ydChBcHBsZVBvcnQpOgogICAgICAgICBmYWxsYmFja19u YW1lcy5hcHBlbmQoJ21hYycpCiAgICAgICAgIHJldHVybiBtYXAoc2VsZi5fd2Via2l0X2Jhc2Vs aW5lX3BhdGgsIGZhbGxiYWNrX25hbWVzKQogCisgICAgZGVmIHNldHVwX2Vudmlyb25fZm9yX3Nl cnZlcihzZWxmLCBzZXJ2ZXJfbmFtZT1Ob25lKToKKyAgICAgICAgZW52ID0gc3VwZXIoV2luUG9y dCwgc2VsZikuc2V0dXBfZW52aXJvbl9mb3Jfc2VydmVyKHNlcnZlcl9uYW1lKQorICAgICAgICBl bnZbJ1hNTF9DQVRBTE9HX0ZJTEVTJ10gPSAnJyAgIyB3b3JrIGFyb3VuZCBtaXNzaW5nIC9ldGMv Y2F0YWxvZyA8cmRhcjovL3Byb2JsZW0vNDI5Mjk5NT4KKyAgICAgICAgcmV0dXJuIGVudgorCiAg ICAgZGVmIG9wZXJhdGluZ19zeXN0ZW0oc2VsZik6CiAgICAgICAgIHJldHVybiAnd2luJwogCg==