143465 2015-04-06 22:05:33 -0700 [Win] Build errors in LocalizedStrings.cpp (newline in constant) 2015-07-08 17:48:54 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows 8 RESOLVED INVALID P2 Trivial --- 1 sungmann.cho webkit-unassigned achristensen benjamin gyuyoung.kim oldest_to_newest 1083252 0 sungmann.cho 2015-04-06 22:05:33 -0700 On Windows, ToT currently breaks at: ..\platform\LocalizedStrings.cpp(250): error C2001: newline in constant ..\platform\LocalizedStrings.cpp(252): error C2001: newline in constant ..\platform\LocalizedStrings.cpp(250): fatal error C1057: unexpected end of file in macro expansion In fact, this issue has already been reported in the past: https://lists.webkit.org/pipermail/webkit-help/2014-January/003705.html 1083255 1 250257 sungmann.cho 2015-04-06 22:40:46 -0700 Created attachment 250257 Patch 1084211 2 sungmann.cho 2015-04-09 23:03:10 -0700 +benjamin@webkit.org for review. @Benjamin: I followed your advice described in https://lists.webkit.org/pipermail/webkit-help/2014-January/003705.html. Would you please take a look? Thanks. 1087338 3 250257 gyuyoung.kim 2015-04-22 01:01:16 -0700 Comment on attachment 250257 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250257&action=review It seems this patch looks fine for me. However this patch should be reviewed by Mac or Win port reviewer. Benjamin and Alex, could you take a look ? > Source/WebKit/mac/ChangeLog:3 > + [Win] Fix build errors in LocalizedStrings.cpp (newline in constant). It looks this file modifies mac port file. So I wonder if [Win] prefix is correct. Isn't it [Mac] ? 1087356 4 250257 achristensen 2015-04-22 06:35:44 -0700 Comment on attachment 250257 Patch I don't think we should just remove those quotation marks. If we change this, it should probably be to "Look Up \"%@\"" and similar changes elsewhere. 250257 2015-04-06 22:40:46 -0700 2015-04-22 06:35:44 -0700 Patch bug-143465-20150407143956.patch text/plain 5251 sungmann.cho U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyNDQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjg2ODBhYzViYmM0YzBl MWQ3MDhjM2U2MTljMWFhMzg0ZGEyYjEyMS4uNzI4YzY1MWI2ZGRhZDIzN2I5ODQ4NmEzYjRmZGVh NmI2ZWY4NDE0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE1LTA0LTA2ICBTdW5n bWFubiBDaG8gIDxzdW5nbWFubi5jaG9AbmF2ZXJjb3JwLmNvbT4KKworICAgICAgICBbV2luXSBG aXggYnVpbGQgZXJyb3JzIGluIExvY2FsaXplZFN0cmluZ3MuY3BwIChuZXdsaW5lIGluIGNvbnN0 YW50KS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0 MzQ2NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo ZSBwcm9ibGVtIGlzIGNhdXNlZCBieSB0aGUgZG91YmxlLWJ5dGUgZG91YmxlIHF1b3RhdGlvbiBt YXJrcyBhcm91bmQKKyAgICAgICAgJUAgYW5kIDxzZWxlY3Rpb24+IGluIHRoZSBrZXkgc3RyaW5n cy4gVGhlIHNpbXBsZXN0IHNvbHV0aW9uIGlzIHRvCisgICAgICAgIHJlbW92ZSB0aGUgcHJvYmxl bWF0aWMgY2hhcmFjdGVycyBmcm9tIHRoYXQga2V5IHN0cmluZ3Mgd2hpbGUgbGVhdmluZyB0aGUK KyAgICAgICAgY291bnRlcnBhcnRzIGluIHRoZSB0cmFuc2xhdGlvbiBmaWxlIGFsb25lLgorCisg ICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogRW5n bGlzaC5scHJvai9Mb2NhbGl6YWJsZS5zdHJpbmdzOgorICAgICAgICAqIHBsYXRmb3JtL0xvY2Fs aXplZFN0cmluZ3MuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y29udGV4dE1lbnVJdGVtVGFnTG9v a1VwSW5EaWN0aW9uYXJ5KToKKwogMjAxNS0wNC0wNiAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFw cGxlLmNvbT4KIAogICAgICAgICBTeW5jaHJvbml6ZSBmdWxsc2NyZWVuIGFuaW1hdGlvbiBiZXR3 ZWVuIHByb2Nlc3Nlcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZyBi L1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwppbmRleCBjZjMzYjVhMzYzZGVjOGYwYWE4M2Zi NWU4MzRhZWM3MGE5ZDFiZDk3Li45MDQxZmVmMjU1M2ZiZGI1NjMwNDQ4ZjU4NGFmMmFiNTE5MTkw ZWI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYktpdC9tYWMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTUtMDQtMDYgIFN1bmdt YW5uIENobyAgPHN1bmdtYW5uLmNob0BuYXZlcmNvcnAuY29tPgorCisgICAgICAgIFtXaW5dIEZp eCBidWlsZCBlcnJvcnMgaW4gTG9jYWxpemVkU3RyaW5ncy5jcHAgKG5ld2xpbmUgaW4gY29uc3Rh bnQpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQz NDY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhl IHByb2JsZW0gaXMgY2F1c2VkIGJ5IHRoZSBkb3VibGUtYnl0ZSBkb3VibGUgcXVvdGF0aW9uIG1h cmtzIGFyb3VuZAorICAgICAgICAlQCBhbmQgPHNlbGVjdGlvbj4gaW4gdGhlIGtleSBzdHJpbmdz LiBUaGUgc2ltcGxlc3Qgc29sdXRpb24gaXMgdG8KKyAgICAgICAgcmVtb3ZlIHRoZSBwcm9ibGVt YXRpYyBjaGFyYWN0ZXJzIGZyb20gdGhhdCBrZXkgc3RyaW5ncyB3aGlsZSBsZWF2aW5nIHRoZQor ICAgICAgICBjb3VudGVycGFydHMgaW4gdGhlIHRyYW5zbGF0aW9uIGZpbGUgYWxvbmUuCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBEZWZh dWx0RGVsZWdhdGVzL1dlYkRlZmF1bHRDb250ZXh0TWVudURlbGVnYXRlLm1tOgorICAgICAgICAo LVtXZWJEZWZhdWx0VUlEZWxlZ2F0ZSB3ZWJWaWV3OmNvbnRleHRNZW51SXRlbXNGb3JFbGVtZW50 OmRlZmF1bHRNZW51SXRlbXM6XSk6CisKIDIwMTUtMDQtMDUgIFNpbW9uIEZyYXNlciAgPHNpbW9u LmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlICJnbyBhaGVhZCBhbmQiIGZyb20g Y29tbWVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0VuZ2xpc2gubHByb2ovTG9jYWxp emFibGUuc3RyaW5ncyBiL1NvdXJjZS9XZWJDb3JlL0VuZ2xpc2gubHByb2ovTG9jYWxpemFibGUu c3RyaW5ncwppbmRleCA3NDc0ZGMzMjlkNzYzNTJhNjIxMWY0OTgwNTUxYzdiZmU2YmFkMjg2Li42 MDJiZDExNGMzYWQzOWJlYzkwYmYxMzc5MzU3OWQzZGFjY2Q3ZTUzIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9FbmdsaXNoLmxwcm9qL0xvY2FsaXphYmxlLnN0cmluZ3MKKysrIGIvU291cmNl L1dlYkNvcmUvRW5nbGlzaC5scHJvai9Mb2NhbGl6YWJsZS5zdHJpbmdzCkBAIC0zMjMsMTAgKzMy MywxMCBAQAogIkxvb2sgVXAgaW4gRGljdGlvbmFyeSIgPSAiTG9vayBVcCBpbiBEaWN0aW9uYXJ5 IjsKIAogLyogTG9vayBVcCBjb250ZXh0IG1lbnUgaXRlbSB3aXRoIHNlbGVjdGVkIHdvcmQgKi8K LSJMb29rIFVwIOKAnCVA4oCdIiA9ICJMb29rIFVwIOKAnCVA4oCdIjsKKyJMb29rIFVwICVAIiA9 ICJMb29rIFVwIOKAnCVA4oCdIjsKIAogLyogTG9vayBVcCBjb250ZXh0IG1lbnUgaXRlbSB3aXRo IHNlbGVjdGVkIHdvcmQgKi8KLSJMb29rIFVwIOKAnDxzZWxlY3Rpb24+4oCdIiA9ICJMb29rIFVw IOKAnDxzZWxlY3Rpb24+4oCdIjsKKyJMb29rIFVwIDxzZWxlY3Rpb24+IiA9ICJMb29rIFVwIOKA nDxzZWxlY3Rpb24+4oCdIjsKIAogLyogTWVkaWEgTG9vcCBjb250ZXh0IG1lbnUgaXRlbSAqLwog Ikxvb3AiID0gIkxvb3AiOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTG9j YWxpemVkU3RyaW5ncy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2NhbGl6ZWRTdHJp bmdzLmNwcAppbmRleCA5M2QyZTkwNTMyMDMwMzEwNjg2MDljYTNjM2I1YmM3ZjVjYTE5MmJlLi5l MDlkOWFiNjIxZWFkYTY4MDUxYzg1ODE3NjRmZDcxZmRmNDQ1NzY2IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2NhbGl6ZWRTdHJpbmdzLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9Mb2NhbGl6ZWRTdHJpbmdzLmNwcApAQCAtMjQ3LDkgKzI0Nyw5IEBAIFN0 cmluZyBjb250ZXh0TWVudUl0ZW1UYWdMb29rVXBJbkRpY3Rpb25hcnkoY29uc3QgU3RyaW5nJiBz ZWxlY3RlZFN0cmluZykKIHsKICNpZiBVU0UoQ0YpCiAgICAgUmV0YWluUHRyPENGU3RyaW5nUmVm PiBzZWxlY3RlZENGU3RyaW5nID0gdHJ1bmNhdGVkU3RyaW5nRm9yTG9va3VwTWVudUl0ZW0oc2Vs ZWN0ZWRTdHJpbmcpLmNyZWF0ZUNGU3RyaW5nKCk7Ci0gICAgcmV0dXJuIGZvcm1hdExvY2FsaXpl ZFN0cmluZyhXRUJfVUlfU1RSSU5HKCJMb29rIFVwIOKAnCVA4oCdIiwgIkxvb2sgVXAgY29udGV4 dCBtZW51IGl0ZW0gd2l0aCBzZWxlY3RlZCB3b3JkIiksIHNlbGVjdGVkQ0ZTdHJpbmcuZ2V0KCkp OworICAgIHJldHVybiBmb3JtYXRMb2NhbGl6ZWRTdHJpbmcoV0VCX1VJX1NUUklORygiTG9vayBV cCAlQCIsICJMb29rIFVwIGNvbnRleHQgbWVudSBpdGVtIHdpdGggc2VsZWN0ZWQgd29yZCIpLCBz ZWxlY3RlZENGU3RyaW5nLmdldCgpKTsKICNlbHNlCi0gICAgcmV0dXJuIFdFQl9VSV9TVFJJTkco Ikxvb2sgVXAg4oCcPHNlbGVjdGlvbj7igJ0iLCAiTG9vayBVcCBjb250ZXh0IG1lbnUgaXRlbSB3 aXRoIHNlbGVjdGVkIHdvcmQiKS5yZXBsYWNlKCI8c2VsZWN0aW9uPiIsIHRydW5jYXRlZFN0cmlu Z0Zvckxvb2t1cE1lbnVJdGVtKHNlbGVjdGVkU3RyaW5nKSk7CisgICAgcmV0dXJuIFdFQl9VSV9T VFJJTkcoIkxvb2sgVXAgPHNlbGVjdGlvbj4iLCAiTG9vayBVcCBjb250ZXh0IG1lbnUgaXRlbSB3 aXRoIHNlbGVjdGVkIHdvcmQiKS5yZXBsYWNlKCI8c2VsZWN0aW9uPiIsIHRydW5jYXRlZFN0cmlu Z0Zvckxvb2t1cE1lbnVJdGVtKHNlbGVjdGVkU3RyaW5nKSk7CiAjZW5kaWYKIH0KIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9tYWMvRGVmYXVsdERlbGVnYXRlcy9XZWJEZWZhdWx0Q29udGV4 dE1lbnVEZWxlZ2F0ZS5tbSBiL1NvdXJjZS9XZWJLaXQvbWFjL0RlZmF1bHREZWxlZ2F0ZXMvV2Vi RGVmYXVsdENvbnRleHRNZW51RGVsZWdhdGUubW0KaW5kZXggMDI2NWJmMGM1MWE5ZjE4NzE1OTY1 NTVkNjkwN2Y5MDIzNzBlNzk1Ny4uZjg1ZDQwNzk4MmYxZjM0MzgwMzdiYjk2YmQ0OTFjOGUyODZi NDlhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvRGVmYXVsdERlbGVnYXRlcy9XZWJE ZWZhdWx0Q29udGV4dE1lbnVEZWxlZ2F0ZS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9EZWZh dWx0RGVsZWdhdGVzL1dlYkRlZmF1bHRDb250ZXh0TWVudURlbGVnYXRlLm1tCkBAIC0xNTUsNyAr MTU1LDcgQEAKIAogICAgICAgICBOU01lbnVJdGVtICpsb29rdXBNZW51SXRlbSA9IFtzZWxmIG1l bnVJdGVtV2l0aFRhZzpXZWJNZW51SXRlbVRhZ0xvb2tVcEluRGljdGlvbmFyeSB0YXJnZXQ6bmls IHJlcHJlc2VudGVkT2JqZWN0OmVsZW1lbnRdOwogICAgICAgICBOU1N0cmluZyAqc2VsZWN0ZWRT dHJpbmcgPSBbKGlkIDxXZWJEb2N1bWVudFRleHQ+KVtbd2ViRnJhbWUgZnJhbWVWaWV3XSBkb2N1 bWVudFZpZXddIHNlbGVjdGVkU3RyaW5nXTsKLSAgICAgICAgW2xvb2t1cE1lbnVJdGVtIHNldFRp dGxlOltOU1N0cmluZyBzdHJpbmdXaXRoRm9ybWF0OlVJX1NUUklOR19JTlRFUk5BTCgiTG9vayBV cCDigJwlQOKAnSIsICJMb29rIFVwIGNvbnRleHQgbWVudSBpdGVtIHdpdGggc2VsZWN0ZWQgd29y ZCIpLCBzZWxlY3RlZFN0cmluZ11dOworICAgICAgICBbbG9va3VwTWVudUl0ZW0gc2V0VGl0bGU6 W05TU3RyaW5nIHN0cmluZ1dpdGhGb3JtYXQ6VUlfU1RSSU5HX0lOVEVSTkFMKCJMb29rIFVwICVA IiwgIkxvb2sgVXAgY29udGV4dCBtZW51IGl0ZW0gd2l0aCBzZWxlY3RlZCB3b3JkIiksIHNlbGVj dGVkU3RyaW5nXV07CiAgICAgICAgIFttZW51SXRlbXMgYWRkT2JqZWN0Omxvb2t1cE1lbnVJdGVt XTsKIAogICAgICAgICBbbWVudUl0ZW1zIGFkZE9iamVjdDpbc2VsZiBtZW51SXRlbVdpdGhUYWc6 V2ViTWVudUl0ZW1UYWdTZWFyY2hXZWIgdGFyZ2V0Om5pbCByZXByZXNlbnRlZE9iamVjdDplbGVt ZW50XV07Cg==