143456 2015-04-06 15:15:40 -0700 Create the web inspector process pool lazily 2015-04-06 18:18:10 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 1083177 0 andersca 2015-04-06 15:15:40 -0700 Create the web inspector process pool lazily 1083178 1 250231 andersca 2015-04-06 15:16:58 -0700 Created attachment 250231 Patch 1083195 2 250231 mark.lam 2015-04-06 16:17:45 -0700 Comment on attachment 250231 Patch r=me 1083204 3 250231 mark.lam 2015-04-06 16:29:56 -0700 Comment on attachment 250231 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250231&action=review > Source/WebKit2/UIProcess/WebInspectorProxy.cpp:310 > - static WebProcessPool* processPool = []{ > + if (!s_processPool) { > auto configuration = API::ProcessPoolConfiguration::createWithLegacyOptions(); > configuration->setProcessModel(ProcessModelMultipleSecondaryProcesses); > - return &WebProcessPool::create(configuration.get()).leakRef(); > - }(); > + s_processPool = &WebProcessPool::create(configuration.get()).leakRef(); > + }; One question: does this require initialize once semantics? 1083212 4 andersca 2015-04-06 16:44:23 -0700 (In reply to comment #3) > > One question: does this require initialize once semantics? No, it doesn't require thread safe initialization. 1083219 5 andersca 2015-04-06 17:06:21 -0700 Committed r182447: <http://trac.webkit.org/changeset/182447> 1083235 6 250231 darin 2015-04-06 18:18:10 -0700 Comment on attachment 250231 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250231&action=review > Source/WebKit2/UIProcess/WebInspectorProxy.cpp:318 > + if (!s_processPool) > + return false; I don’t think this code is needed. A null pointer would never be equal to the address of a reference. 250231 2015-04-06 15:16:58 -0700 2015-04-06 16:17:45 -0700 Patch bug-143456-20150406151609.patch text/plain 4269 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyNDMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzUzOWNhYzNiYjNkNDg4 ZDg4ZTc4MTZjZDBmYzJlNjZjZGI2NzAyYS4uMjJkY2MxY2IxM2U5ZGU4OTRhMGUyODliNjBlMTEx MjUyZTJhNWQwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE1LTA0LTA2ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgQ3JlYXRlIHRoZSB3 ZWIgaW5zcGVjdG9yIHByb2Nlc3MgcG9vbCBsYXppbHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MzQ1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhbmQgaW1wbGVtZW50IFdlYkluc3BlY3RvclBy b3h5Ojppc0luc3BlY3RvclByb2Nlc3NQb29sIGluc3RlYWQgb2YgYWx3YXlzIGNyZWF0aW5nIHRo ZSBpbnNwZWN0b3IgcHJvY2VzcyBwb29sCisgICAgICAgIHdoZW4gdHJ5aW5nIHRvIGRldGVybWlu ZSBpZiBhIGdpdmVuIHByb2Nlc3MgcG9vbCBpcyB0aGUgaW5zcGVjdG9yIHByb2Nlc3MgcG9vbC4K KyAgICAgICAgCisgICAgICAgIFRoaXMgc2hvdWxkIHNwZWVkIHVwIGluaXRpYWxpemF0aW9uIHNv bWV3aGF0IGFuZCBhdm9pZCBjcmVhdGluZyBhIHN0b3JhZ2UgbWFuYWdlciBmb3IgZXhhbXBsZS4K KworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94eS5jcHA6CisgICAgICAgIChX ZWJLaXQ6OldlYkluc3BlY3RvclByb3h5OjppbnNwZWN0b3JQcm9jZXNzUG9vbCk6CisgICAgICAg IChXZWJLaXQ6OldlYkluc3BlY3RvclByb3h5Ojppc0luc3BlY3RvclByb2Nlc3NQb29sKToKKyAg ICAgICAgKiBVSVByb2Nlc3MvV2ViSW5zcGVjdG9yUHJveHkuaDoKKyAgICAgICAgKiBVSVByb2Nl c3MvV2ViUHJvY2Vzc1Byb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzc1Byb3h5 OjpnZXRMYXVuY2hPcHRpb25zKToKKwogMjAxNS0wNC0wNiAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0 LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjE4 MjI5Ni4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQ cm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViSW5zcGVjdG9yUHJveHkuY3Bw CmluZGV4IGZjM2QwMjk3MWI4MTlhOGYxN2ZlNDc3MjFkZjM5NzNmMzE1Y2U0OGEuLjliMWViMjFm MjJjMjZkM2Y5ZWVkYTRiYTU5Yjk5MTZiMmQyMjQxNDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1dlYkluc3BlY3RvclByb3h5LmNwcApAQCAtMjk3LDE3ICsyOTcsMjcgQEAgdm9p ZCBXZWJJbnNwZWN0b3JQcm94eTo6dG9nZ2xlUGFnZVByb2ZpbGluZygpCiAgICAgbV9pc1Byb2Zp bGluZ1BhZ2UgPSAhbV9pc1Byb2ZpbGluZ1BhZ2U7CiB9CiAKK3N0YXRpYyBXZWJQcm9jZXNzUG9v bCogc19wcm9jZXNzUG9vbDsKKwogV2ViUHJvY2Vzc1Bvb2wmIFdlYkluc3BlY3RvclByb3h5Ojpp bnNwZWN0b3JQcm9jZXNzUG9vbCgpCiB7CiAgICAgLy8gSGF2aW5nIG91ciBvd24gcHJvY2VzcyBw b29sIHJlbW92ZXMgdXMgZnJvbSB0aGUgbWFpbiBwcm9jZXNzIHBvb2wgYW5kCiAgICAgLy8gZ3Vh cmFudGVlcyBubyBwcm9jZXNzIHNoYXJpbmcgZm9yIG91ciB1c2VyIGludGVyZmFjZS4KLSAgICBz dGF0aWMgV2ViUHJvY2Vzc1Bvb2wqIHByb2Nlc3NQb29sID0gW117CisgICAgaWYgKCFzX3Byb2Nl c3NQb29sKSB7CiAgICAgICAgIGF1dG8gY29uZmlndXJhdGlvbiA9IEFQSTo6UHJvY2Vzc1Bvb2xD b25maWd1cmF0aW9uOjpjcmVhdGVXaXRoTGVnYWN5T3B0aW9ucygpOwogICAgICAgICBjb25maWd1 cmF0aW9uLT5zZXRQcm9jZXNzTW9kZWwoUHJvY2Vzc01vZGVsTXVsdGlwbGVTZWNvbmRhcnlQcm9j ZXNzZXMpOwotICAgICAgICByZXR1cm4gJldlYlByb2Nlc3NQb29sOjpjcmVhdGUoY29uZmlndXJh dGlvbi5nZXQoKSkubGVha1JlZigpOwotICAgIH0oKTsKKyAgICAgICAgc19wcm9jZXNzUG9vbCA9 ICZXZWJQcm9jZXNzUG9vbDo6Y3JlYXRlKGNvbmZpZ3VyYXRpb24uZ2V0KCkpLmxlYWtSZWYoKTsK KyAgICB9OworCisgICAgcmV0dXJuICpzX3Byb2Nlc3NQb29sOworfQorCitib29sIFdlYkluc3Bl Y3RvclByb3h5Ojppc0luc3BlY3RvclByb2Nlc3NQb29sKFdlYlByb2Nlc3NQb29sJiBwcm9jZXNz UG9vbCkKK3sKKyAgICBpZiAoIXNfcHJvY2Vzc1Bvb2wpCisgICAgICAgIHJldHVybiBmYWxzZTsK IAotICAgIHJldHVybiAqcHJvY2Vzc1Bvb2w7CisgICAgcmV0dXJuIHNfcHJvY2Vzc1Bvb2wgPT0g JnByb2Nlc3NQb29sOwogfQogCiBib29sIFdlYkluc3BlY3RvclByb3h5Ojppc0luc3BlY3RvclBh Z2UoV2ViUGFnZVByb3h5JiB3ZWJQYWdlKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL1dlYkluc3BlY3RvclByb3h5LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2Vi SW5zcGVjdG9yUHJveHkuaAppbmRleCA1MGE2OWQzNGNkZWNkMjBmOGE5N2U2YTdmZDM3YjRmNTli MDc5NTQ2Li4wYzFlZTFkODJiZDNhN2I1OTk2ODRkNzY5YjM1OGFiOWYxMGZlZmYxIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViSW5zcGVjdG9yUHJveHkuaAorKysgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViSW5zcGVjdG9yUHJveHkuaApAQCAtMTM0LDcgKzEz NCw3IEBAIHB1YmxpYzoKICAgICBib29sIGlzUHJvZmlsaW5nUGFnZSgpIGNvbnN0IHsgcmV0dXJu IG1faXNQcm9maWxpbmdQYWdlOyB9CiAgICAgdm9pZCB0b2dnbGVQYWdlUHJvZmlsaW5nKCk7CiAK LSAgICBzdGF0aWMgV2ViUHJvY2Vzc1Bvb2wmIGluc3BlY3RvclByb2Nlc3NQb29sKCk7CisgICAg c3RhdGljIGJvb2wgaXNJbnNwZWN0b3JQcm9jZXNzUG9vbChXZWJQcm9jZXNzUG9vbCYpOwogICAg IHN0YXRpYyBib29sIGlzSW5zcGVjdG9yUGFnZShXZWJQYWdlUHJveHkmKTsKIAogICAgIC8vIFBy b3ZpZGVkIGJ5IHBsYXRmb3JtIFdlYkluc3BlY3RvclByb3h5IGltcGxlbWVudGF0aW9ucy4KQEAg LTE1Myw2ICsxNTMsOCBAQCBwdWJsaWM6CiBwcml2YXRlOgogICAgIGV4cGxpY2l0IFdlYkluc3Bl Y3RvclByb3h5KFdlYlBhZ2VQcm94eSopOwogCisgICAgc3RhdGljIFdlYlByb2Nlc3NQb29sJiBp bnNwZWN0b3JQcm9jZXNzUG9vbCgpOworCiAgICAgdm9pZCBlYWdlcmx5Q3JlYXRlSW5zcGVjdG9y UGFnZSgpOwogCiAgICAgLy8gSVBDOjpNZXNzYWdlUmVjZWl2ZXIKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94eS5jcHAKaW5kZXggYjVmMDg2OTQwYWE2ODZmNGU0NzM4 MzM2NzgzNjEyMjZiZWVlZTBiZS4uNGJiNTU4NTJhMzc4NGIzOGUzOGUzOWZkMmFiYzEzMjczNDli MmIyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94 eS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94eS5jcHAK QEAgLTEyOCw3ICsxMjgsNyBAQCBXZWJQcm9jZXNzUHJveHk6On5XZWJQcm9jZXNzUHJveHkoKQog dm9pZCBXZWJQcm9jZXNzUHJveHk6OmdldExhdW5jaE9wdGlvbnMoUHJvY2Vzc0xhdW5jaGVyOjpM YXVuY2hPcHRpb25zJiBsYXVuY2hPcHRpb25zKQogewogICAgIGxhdW5jaE9wdGlvbnMucHJvY2Vz c1R5cGUgPSBQcm9jZXNzTGF1bmNoZXI6OldlYlByb2Nlc3M7Ci0gICAgaWYgKCZtX3Byb2Nlc3NQ b29sLmdldCgpID09ICZXZWJJbnNwZWN0b3JQcm94eTo6aW5zcGVjdG9yUHJvY2Vzc1Bvb2woKSkK KyAgICBpZiAoV2ViSW5zcGVjdG9yUHJveHk6OmlzSW5zcGVjdG9yUHJvY2Vzc1Bvb2wobV9wcm9j ZXNzUG9vbCkpCiAgICAgICAgIGxhdW5jaE9wdGlvbnMuZXh0cmFJbml0aWFsaXphdGlvbkRhdGEu YWRkKEFTQ0lJTGl0ZXJhbCgiaW5zcGVjdG9yLXByb2Nlc3MiKSwgQVNDSUlMaXRlcmFsKCIxIikp OwogICAgIHBsYXRmb3JtR2V0TGF1bmNoT3B0aW9ucyhsYXVuY2hPcHRpb25zKTsKIH0K